CC: kbuild-...@lists.01.org In-Reply-To: <20210404083047.71048-1-o-taka...@sakamocchi.jp> References: <20210404083047.71048-1-o-taka...@sakamocchi.jp> TO: Takashi Sakamoto <o-taka...@sakamocchi.jp> TO: ti...@suse.de TO: pe...@perex.cz CC: alsa-de...@alsa-project.org
Hi Takashi, I love your patch! Perhaps something to improve: [auto build test WARNING on sound/for-next] [also build test WARNING on next-20210401] [cannot apply to v5.12-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Takashi-Sakamoto/ALSA-control_led-use-helper-macro-to-declare-device-attributes-with-specific-permission/20210404-163324 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next :::::: branch date: 2 days ago :::::: commit date: 2 days ago config: i386-randconfig-m021-20210406 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> smatch warnings: sound/core/control_led.c:385 mode_show() error: uninitialized symbol 'str'. vim +/str +385 sound/core/control_led.c 22d8de62f11b28 Jaroslav Kysela 2021-03-17 369 cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 370 /* cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 371 * sysfs cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 372 */ cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 373 013389f5522b33 Takashi Sakamoto 2021-04-04 374 static ssize_t mode_show(struct device *dev, struct device_attribute *attr, char *buf) cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 375 { cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 376 struct snd_ctl_led *led = container_of(dev, struct snd_ctl_led, dev); cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 377 const char *str; cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 378 cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 379 switch (led->mode) { cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 380 case MODE_FOLLOW_MUTE: str = "follow-mute"; break; cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 381 case MODE_FOLLOW_ROUTE: str = "follow-route"; break; cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 382 case MODE_ON: str = "on"; break; cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 383 case MODE_OFF: str = "off"; break; cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 384 } cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 @385 return sprintf(buf, "%s\n", str); cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 386 } cb17fe0045aaa7 Jaroslav Kysela 2021-03-17 387 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
