[kbuild] drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() error: we previously assumed 'ring' could be null (see line 5673)

2022-03-15 Thread kernel test robot
CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: linux-ker...@vger.kernel.org
TO: Maciej Fijalkowski 
CC: Tony Nguyen 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   09688c0166e76ce2fb85e86b9d99be8b0084cdf9
commit: e72bba21355dbb67512a0d666fec9f4b56dbfc2f ice: split ice_ring onto Tx/Rx 
separate structs
date:   5 months ago
:: branch date: 2 days ago
:: commit date: 5 months ago
config: riscv-randconfig-m031-20220313 
(https://download.01.org/0day-ci/archive/20220315/202203151711.sjqusxnj-...@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() 
error: we previously assumed 'ring' could be null (see line 5673)

vim +/ring +5677 drivers/net/ethernet/intel/ice/ice_main.c

fcea6f3da546b93 Anirudh Venkataramanan 2018-03-20  5654  
49d358e0e746dc2 Marta Plantykow2020-05-15  5655  /**
49d358e0e746dc2 Marta Plantykow2020-05-15  5656   * 
ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters
49d358e0e746dc2 Marta Plantykow2020-05-15  5657   * @vsi: the VSI to be 
updated
49d358e0e746dc2 Marta Plantykow2020-05-15  5658   * @rings: rings to 
work on
49d358e0e746dc2 Marta Plantykow2020-05-15  5659   * @count: number of 
rings
49d358e0e746dc2 Marta Plantykow2020-05-15  5660   */
49d358e0e746dc2 Marta Plantykow2020-05-15  5661  static void
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5662  
ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings,
49d358e0e746dc2 Marta Plantykow2020-05-15  5663 
 u16 count)
49d358e0e746dc2 Marta Plantykow2020-05-15  5664  {
49d358e0e746dc2 Marta Plantykow2020-05-15  5665 struct 
rtnl_link_stats64 *vsi_stats = >net_stats;
49d358e0e746dc2 Marta Plantykow2020-05-15  5666 u16 i;
49d358e0e746dc2 Marta Plantykow2020-05-15  5667  
49d358e0e746dc2 Marta Plantykow2020-05-15  5668 for (i = 0; i < 
count; i++) {
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5669 struct 
ice_tx_ring *ring;
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5670 u64 
pkts = 0, bytes = 0;
49d358e0e746dc2 Marta Plantykow2020-05-15  5671  
49d358e0e746dc2 Marta Plantykow2020-05-15  5672 ring = 
READ_ONCE(rings[i]);
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19 @5673 if 
(ring)
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5674 
ice_fetch_u64_stats_per_ring(>syncp, ring->stats, , );
49d358e0e746dc2 Marta Plantykow2020-05-15  5675 
vsi_stats->tx_packets += pkts;
49d358e0e746dc2 Marta Plantykow2020-05-15  5676 
vsi_stats->tx_bytes += bytes;
49d358e0e746dc2 Marta Plantykow2020-05-15 @5677 
vsi->tx_restart += ring->tx_stats.restart_q;
49d358e0e746dc2 Marta Plantykow2020-05-15  5678 
vsi->tx_busy += ring->tx_stats.tx_busy;
49d358e0e746dc2 Marta Plantykow2020-05-15  5679 
vsi->tx_linearize += ring->tx_stats.tx_linearize;
49d358e0e746dc2 Marta Plantykow2020-05-15  5680 }
49d358e0e746dc2 Marta Plantykow2020-05-15  5681  }
49d358e0e746dc2 Marta Plantykow2020-05-15  5682  

:: The code at line 5677 was first introduced by commit
:: 49d358e0e746dc24bfb1b1cf98c17064e5177424 ice: Add XDP Tx to VSI ring 
stats

:: TO: Marta Plantykow 
:: CC: Jeff Kirsher 

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org


[kbuild] drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() error: we previously assumed 'ring' could be null (see line 5673)

2022-02-26 Thread kernel test robot
CC: kbuild-...@lists.01.org
BCC: l...@intel.com
CC: linux-ker...@vger.kernel.org
TO: Maciej Fijalkowski 
CC: Tony Nguyen 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   9137eda53752ef73148e42b0d7640a00f1bc96b1
commit: e72bba21355dbb67512a0d666fec9f4b56dbfc2f ice: split ice_ring onto Tx/Rx 
separate structs
date:   4 months ago
:: branch date: 16 hours ago
:: commit date: 4 months ago
config: ia64-randconfig-m031-20220220 
(https://download.01.org/0day-ci/archive/20220226/202202262103.fe80qtsb-...@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() 
error: we previously assumed 'ring' could be null (see line 5673)

vim +/ring +5677 drivers/net/ethernet/intel/ice/ice_main.c

fcea6f3da546b93 Anirudh Venkataramanan 2018-03-20  5654  
49d358e0e746dc2 Marta Plantykow2020-05-15  5655  /**
49d358e0e746dc2 Marta Plantykow2020-05-15  5656   * 
ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters
49d358e0e746dc2 Marta Plantykow2020-05-15  5657   * @vsi: the VSI to be 
updated
49d358e0e746dc2 Marta Plantykow2020-05-15  5658   * @rings: rings to 
work on
49d358e0e746dc2 Marta Plantykow2020-05-15  5659   * @count: number of 
rings
49d358e0e746dc2 Marta Plantykow2020-05-15  5660   */
49d358e0e746dc2 Marta Plantykow2020-05-15  5661  static void
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5662  
ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings,
49d358e0e746dc2 Marta Plantykow2020-05-15  5663 
 u16 count)
49d358e0e746dc2 Marta Plantykow2020-05-15  5664  {
49d358e0e746dc2 Marta Plantykow2020-05-15  5665 struct 
rtnl_link_stats64 *vsi_stats = >net_stats;
49d358e0e746dc2 Marta Plantykow2020-05-15  5666 u16 i;
49d358e0e746dc2 Marta Plantykow2020-05-15  5667  
49d358e0e746dc2 Marta Plantykow2020-05-15  5668 for (i = 0; i < 
count; i++) {
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5669 struct 
ice_tx_ring *ring;
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5670 u64 
pkts = 0, bytes = 0;
49d358e0e746dc2 Marta Plantykow2020-05-15  5671  
49d358e0e746dc2 Marta Plantykow2020-05-15  5672 ring = 
READ_ONCE(rings[i]);
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19 @5673 if 
(ring)
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5674 
ice_fetch_u64_stats_per_ring(>syncp, ring->stats, , );
49d358e0e746dc2 Marta Plantykow2020-05-15  5675 
vsi_stats->tx_packets += pkts;
49d358e0e746dc2 Marta Plantykow2020-05-15  5676 
vsi_stats->tx_bytes += bytes;
49d358e0e746dc2 Marta Plantykow2020-05-15 @5677 
vsi->tx_restart += ring->tx_stats.restart_q;
49d358e0e746dc2 Marta Plantykow2020-05-15  5678 
vsi->tx_busy += ring->tx_stats.tx_busy;
49d358e0e746dc2 Marta Plantykow2020-05-15  5679 
vsi->tx_linearize += ring->tx_stats.tx_linearize;
49d358e0e746dc2 Marta Plantykow2020-05-15  5680 }
49d358e0e746dc2 Marta Plantykow2020-05-15  5681  }
49d358e0e746dc2 Marta Plantykow2020-05-15  5682  

:: The code at line 5677 was first introduced by commit
:: 49d358e0e746dc24bfb1b1cf98c17064e5177424 ice: Add XDP Tx to VSI ring 
stats

:: TO: Marta Plantykow 
:: CC: Jeff Kirsher 

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org


[kbuild] drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() error: we previously assumed 'ring' could be null (see line 5673)

2022-02-22 Thread kernel test robot
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Maciej Fijalkowski 
CC: Tony Nguyen 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   5c1ee569660d4a205dced9cb4d0306b907fb7599
commit: e72bba21355dbb67512a0d666fec9f4b56dbfc2f ice: split ice_ring onto Tx/Rx 
separate structs
date:   4 months ago
:: branch date: 4 hours ago
:: commit date: 4 months ago
config: ia64-randconfig-m031-20220220 
(https://download.01.org/0day-ci/archive/20220223/202202231218.gebe64ar-...@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() 
error: we previously assumed 'ring' could be null (see line 5673)

vim +/ring +5677 drivers/net/ethernet/intel/ice/ice_main.c

fcea6f3da546b93 Anirudh Venkataramanan 2018-03-20  5654  
49d358e0e746dc2 Marta Plantykow2020-05-15  5655  /**
49d358e0e746dc2 Marta Plantykow2020-05-15  5656   * 
ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters
49d358e0e746dc2 Marta Plantykow2020-05-15  5657   * @vsi: the VSI to be 
updated
49d358e0e746dc2 Marta Plantykow2020-05-15  5658   * @rings: rings to 
work on
49d358e0e746dc2 Marta Plantykow2020-05-15  5659   * @count: number of 
rings
49d358e0e746dc2 Marta Plantykow2020-05-15  5660   */
49d358e0e746dc2 Marta Plantykow2020-05-15  5661  static void
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5662  
ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings,
49d358e0e746dc2 Marta Plantykow2020-05-15  5663 
 u16 count)
49d358e0e746dc2 Marta Plantykow2020-05-15  5664  {
49d358e0e746dc2 Marta Plantykow2020-05-15  5665 struct 
rtnl_link_stats64 *vsi_stats = >net_stats;
49d358e0e746dc2 Marta Plantykow2020-05-15  5666 u16 i;
49d358e0e746dc2 Marta Plantykow2020-05-15  5667  
49d358e0e746dc2 Marta Plantykow2020-05-15  5668 for (i = 0; i < 
count; i++) {
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5669 struct 
ice_tx_ring *ring;
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5670 u64 
pkts = 0, bytes = 0;
49d358e0e746dc2 Marta Plantykow2020-05-15  5671  
49d358e0e746dc2 Marta Plantykow2020-05-15  5672 ring = 
READ_ONCE(rings[i]);
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19 @5673 if 
(ring)
e72bba21355dbb6 Maciej Fijalkowski 2021-08-19  5674 
ice_fetch_u64_stats_per_ring(>syncp, ring->stats, , );
49d358e0e746dc2 Marta Plantykow2020-05-15  5675 
vsi_stats->tx_packets += pkts;
49d358e0e746dc2 Marta Plantykow2020-05-15  5676 
vsi_stats->tx_bytes += bytes;
49d358e0e746dc2 Marta Plantykow2020-05-15 @5677 
vsi->tx_restart += ring->tx_stats.restart_q;
49d358e0e746dc2 Marta Plantykow2020-05-15  5678 
vsi->tx_busy += ring->tx_stats.tx_busy;
49d358e0e746dc2 Marta Plantykow2020-05-15  5679 
vsi->tx_linearize += ring->tx_stats.tx_linearize;
49d358e0e746dc2 Marta Plantykow2020-05-15  5680 }
49d358e0e746dc2 Marta Plantykow2020-05-15  5681  }
49d358e0e746dc2 Marta Plantykow2020-05-15  5682  

:: The code at line 5677 was first introduced by commit
:: 49d358e0e746dc24bfb1b1cf98c17064e5177424 ice: Add XDP Tx to VSI ring 
stats

:: TO: Marta Plantykow 
:: CC: Jeff Kirsher 

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org


[kbuild] drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() error: we previously assumed 'ring' could be null (see line 5673)

2022-02-20 Thread kernel test robot
CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Maciej Fijalkowski 
CC: Tony Nguyen 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   cfb92440ee71adcc2105b0890bb01ac3cddb8507
commit: e72bba21355dbb67512a0d666fec9f4b56dbfc2f ice: split ice_ring onto Tx/Rx 
separate structs
date:   4 months ago
:: branch date: 7 hours ago
:: commit date: 4 months ago
config: ia64-randconfig-m031-20220220 
(https://download.01.org/0day-ci/archive/20220221/202202211208.rslrugsa-...@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() 
error: we previously assumed 'ring' could be null (see line 5673)

vim +/ring +5677 drivers/net/ethernet/intel/ice/ice_main.c

fcea6f3da546b9 Anirudh Venkataramanan 2018-03-20  5654  
49d358e0e746dc Marta Plantykow2020-05-15  5655  /**
49d358e0e746dc Marta Plantykow2020-05-15  5656   * 
ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters
49d358e0e746dc Marta Plantykow2020-05-15  5657   * @vsi: the VSI to be 
updated
49d358e0e746dc Marta Plantykow2020-05-15  5658   * @rings: rings to 
work on
49d358e0e746dc Marta Plantykow2020-05-15  5659   * @count: number of 
rings
49d358e0e746dc Marta Plantykow2020-05-15  5660   */
49d358e0e746dc Marta Plantykow2020-05-15  5661  static void
e72bba21355dbb Maciej Fijalkowski 2021-08-19  5662  
ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings,
49d358e0e746dc Marta Plantykow2020-05-15  5663  
 u16 count)
49d358e0e746dc Marta Plantykow2020-05-15  5664  {
49d358e0e746dc Marta Plantykow2020-05-15  5665  struct 
rtnl_link_stats64 *vsi_stats = >net_stats;
49d358e0e746dc Marta Plantykow2020-05-15  5666  u16 i;
49d358e0e746dc Marta Plantykow2020-05-15  5667  
49d358e0e746dc Marta Plantykow2020-05-15  5668  for (i = 0; i < 
count; i++) {
e72bba21355dbb Maciej Fijalkowski 2021-08-19  5669  struct 
ice_tx_ring *ring;
e72bba21355dbb Maciej Fijalkowski 2021-08-19  5670  u64 
pkts = 0, bytes = 0;
49d358e0e746dc Marta Plantykow2020-05-15  5671  
49d358e0e746dc Marta Plantykow2020-05-15  5672  ring = 
READ_ONCE(rings[i]);
e72bba21355dbb Maciej Fijalkowski 2021-08-19 @5673  if 
(ring)
e72bba21355dbb Maciej Fijalkowski 2021-08-19  5674  
ice_fetch_u64_stats_per_ring(>syncp, ring->stats, , );
49d358e0e746dc Marta Plantykow2020-05-15  5675  
vsi_stats->tx_packets += pkts;
49d358e0e746dc Marta Plantykow2020-05-15  5676  
vsi_stats->tx_bytes += bytes;
49d358e0e746dc Marta Plantykow2020-05-15 @5677  
vsi->tx_restart += ring->tx_stats.restart_q;
49d358e0e746dc Marta Plantykow2020-05-15  5678  
vsi->tx_busy += ring->tx_stats.tx_busy;
49d358e0e746dc Marta Plantykow2020-05-15  5679  
vsi->tx_linearize += ring->tx_stats.tx_linearize;
49d358e0e746dc Marta Plantykow2020-05-15  5680  }
49d358e0e746dc Marta Plantykow2020-05-15  5681  }
49d358e0e746dc Marta Plantykow2020-05-15  5682  

:: The code at line 5677 was first introduced by commit
:: 49d358e0e746dc24bfb1b1cf98c17064e5177424 ice: Add XDP Tx to VSI ring 
stats

:: TO: Marta Plantykow 
:: CC: Jeff Kirsher 

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org