subject:"\[kbuild\] drivers\/platform\/surface\/surface_hotplug.c\:163 shps_setup_irq\(\) warn\: should '\(\(\(1\)\)\) << dsm' be a 64 bit type\?"

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

2022-01-07 Thread kernel test robot

CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Maximilian Luz 
CC: Hans de Goede 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   ddec8ed2d4905d0967ce2ec432e440e582aa52c6
commit: bd69bcce4aa089435e289136b1cb20395bec platform/surface: Add Surface 
Hot-Plug driver
date:   11 months ago
:: branch date: 18 hours ago
:: commit date: 11 months ago
config: i386-randconfig-m021-20220107 
(https://download.01.org/0day-ci/archive/20220108/202201080424.tothmkun-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should 
'(((1))) << dsm' be a 64 bit type?

vim +163 drivers/platform/surface/surface_hotplug.c

bd69bcce4aa089 Maximilian Luz 2021-02-05  147  
bd69bcce4aa089 Maximilian Luz 2021-02-05  148  static int shps_setup_irq(struct 
platform_device *pdev, enum shps_irq_type type)
bd69bcce4aa089 Maximilian Luz 2021-02-05  149  {
bd69bcce4aa089 Maximilian Luz 2021-02-05  150   unsigned long flags = 
IRQF_ONESHOT | IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING;
bd69bcce4aa089 Maximilian Luz 2021-02-05  151   struct shps_device *sdev = 
platform_get_drvdata(pdev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  152   struct gpio_desc *gpiod;
bd69bcce4aa089 Maximilian Luz 2021-02-05  153   acpi_handle handle = 
ACPI_HANDLE(>dev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  154   const char *irq_name;
bd69bcce4aa089 Maximilian Luz 2021-02-05  155   const int dsm = 
shps_dsm_fn_for_irq(type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  156   int status, irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  157  
bd69bcce4aa089 Maximilian Luz 2021-02-05  158   /*
bd69bcce4aa089 Maximilian Luz 2021-02-05  159* Only set up interrupts that 
we actually need: The Surface Book 3
bd69bcce4aa089 Maximilian Luz 2021-02-05  160* does not have a DSM for base 
presence, so don't set up an interrupt
bd69bcce4aa089 Maximilian Luz 2021-02-05  161* for that.
bd69bcce4aa089 Maximilian Luz 2021-02-05  162*/
bd69bcce4aa089 Maximilian Luz 2021-02-05 @163   if (!acpi_check_dsm(handle, 
_dsm_guid, SHPS_DSM_REVISION, BIT(dsm))) {
bd69bcce4aa089 Maximilian Luz 2021-02-05  164   dev_dbg(>dev, 
"IRQ notification via DSM not present (irq=%d)\n", type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  165   return 0;
bd69bcce4aa089 Maximilian Luz 2021-02-05  166   }
bd69bcce4aa089 Maximilian Luz 2021-02-05  167  
bd69bcce4aa089 Maximilian Luz 2021-02-05  168   gpiod = 
devm_gpiod_get(>dev, shps_gpio_names[type], GPIOD_ASIS);
bd69bcce4aa089 Maximilian Luz 2021-02-05  169   if (IS_ERR(gpiod))
bd69bcce4aa089 Maximilian Luz 2021-02-05  170   return PTR_ERR(gpiod);
bd69bcce4aa089 Maximilian Luz 2021-02-05  171  
bd69bcce4aa089 Maximilian Luz 2021-02-05  172   irq = gpiod_to_irq(gpiod);
bd69bcce4aa089 Maximilian Luz 2021-02-05  173   if (irq < 0)
bd69bcce4aa089 Maximilian Luz 2021-02-05  174   return irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  175  
bd69bcce4aa089 Maximilian Luz 2021-02-05  176   irq_name = 
devm_kasprintf(>dev, GFP_KERNEL, "shps-irq-%d", type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  177   if (!irq_name)
bd69bcce4aa089 Maximilian Luz 2021-02-05  178   return -ENOMEM;
bd69bcce4aa089 Maximilian Luz 2021-02-05  179  
bd69bcce4aa089 Maximilian Luz 2021-02-05  180   status = 
devm_request_threaded_irq(>dev, irq, NULL, shps_handle_irq,
bd69bcce4aa089 Maximilian Luz 2021-02-05  181   
   flags, irq_name, pdev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  182   if (status)
bd69bcce4aa089 Maximilian Luz 2021-02-05  183   return status;
bd69bcce4aa089 Maximilian Luz 2021-02-05  184  
bd69bcce4aa089 Maximilian Luz 2021-02-05  185   dev_dbg(>dev, "set up irq 
%d as type %d\n", irq, type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  186  
bd69bcce4aa089 Maximilian Luz 2021-02-05  187   sdev->gpio[type] = gpiod;
bd69bcce4aa089 Maximilian Luz 2021-02-05  188   sdev->irq[type] = irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  189  
bd69bcce4aa089 Maximilian Luz 2021-02-05  190   return 0;
bd69bcce4aa089 Maximilian Luz 2021-02-05  191  }
bd69bcce4aa089 Maximilian Luz 2021-02-05  192  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

2021-11-27 Thread kernel test robot

CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Maximilian Luz 
CC: Hans de Goede 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5
commit: bd69bcce4aa089435e289136b1cb20395bec platform/surface: Add Surface 
Hot-Plug driver
date:   10 months ago
:: branch date: 14 hours ago
:: commit date: 10 months ago
config: i386-randconfig-m021-2026 
(https://download.01.org/0day-ci/archive/20211127/202111271850.jw1o8rta-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should 
'(((1))) << dsm' be a 64 bit type?

vim +163 drivers/platform/surface/surface_hotplug.c

bd69bcce4aa089 Maximilian Luz 2021-02-05  147  
bd69bcce4aa089 Maximilian Luz 2021-02-05  148  static int shps_setup_irq(struct 
platform_device *pdev, enum shps_irq_type type)
bd69bcce4aa089 Maximilian Luz 2021-02-05  149  {
bd69bcce4aa089 Maximilian Luz 2021-02-05  150   unsigned long flags = 
IRQF_ONESHOT | IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING;
bd69bcce4aa089 Maximilian Luz 2021-02-05  151   struct shps_device *sdev = 
platform_get_drvdata(pdev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  152   struct gpio_desc *gpiod;
bd69bcce4aa089 Maximilian Luz 2021-02-05  153   acpi_handle handle = 
ACPI_HANDLE(>dev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  154   const char *irq_name;
bd69bcce4aa089 Maximilian Luz 2021-02-05  155   const int dsm = 
shps_dsm_fn_for_irq(type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  156   int status, irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  157  
bd69bcce4aa089 Maximilian Luz 2021-02-05  158   /*
bd69bcce4aa089 Maximilian Luz 2021-02-05  159* Only set up interrupts that 
we actually need: The Surface Book 3
bd69bcce4aa089 Maximilian Luz 2021-02-05  160* does not have a DSM for base 
presence, so don't set up an interrupt
bd69bcce4aa089 Maximilian Luz 2021-02-05  161* for that.
bd69bcce4aa089 Maximilian Luz 2021-02-05  162*/
bd69bcce4aa089 Maximilian Luz 2021-02-05 @163   if (!acpi_check_dsm(handle, 
_dsm_guid, SHPS_DSM_REVISION, BIT(dsm))) {
bd69bcce4aa089 Maximilian Luz 2021-02-05  164   dev_dbg(>dev, 
"IRQ notification via DSM not present (irq=%d)\n", type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  165   return 0;
bd69bcce4aa089 Maximilian Luz 2021-02-05  166   }
bd69bcce4aa089 Maximilian Luz 2021-02-05  167  
bd69bcce4aa089 Maximilian Luz 2021-02-05  168   gpiod = 
devm_gpiod_get(>dev, shps_gpio_names[type], GPIOD_ASIS);
bd69bcce4aa089 Maximilian Luz 2021-02-05  169   if (IS_ERR(gpiod))
bd69bcce4aa089 Maximilian Luz 2021-02-05  170   return PTR_ERR(gpiod);
bd69bcce4aa089 Maximilian Luz 2021-02-05  171  
bd69bcce4aa089 Maximilian Luz 2021-02-05  172   irq = gpiod_to_irq(gpiod);
bd69bcce4aa089 Maximilian Luz 2021-02-05  173   if (irq < 0)
bd69bcce4aa089 Maximilian Luz 2021-02-05  174   return irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  175  
bd69bcce4aa089 Maximilian Luz 2021-02-05  176   irq_name = 
devm_kasprintf(>dev, GFP_KERNEL, "shps-irq-%d", type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  177   if (!irq_name)
bd69bcce4aa089 Maximilian Luz 2021-02-05  178   return -ENOMEM;
bd69bcce4aa089 Maximilian Luz 2021-02-05  179  
bd69bcce4aa089 Maximilian Luz 2021-02-05  180   status = 
devm_request_threaded_irq(>dev, irq, NULL, shps_handle_irq,
bd69bcce4aa089 Maximilian Luz 2021-02-05  181   
   flags, irq_name, pdev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  182   if (status)
bd69bcce4aa089 Maximilian Luz 2021-02-05  183   return status;
bd69bcce4aa089 Maximilian Luz 2021-02-05  184  
bd69bcce4aa089 Maximilian Luz 2021-02-05  185   dev_dbg(>dev, "set up irq 
%d as type %d\n", irq, type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  186  
bd69bcce4aa089 Maximilian Luz 2021-02-05  187   sdev->gpio[type] = gpiod;
bd69bcce4aa089 Maximilian Luz 2021-02-05  188   sdev->irq[type] = irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  189  
bd69bcce4aa089 Maximilian Luz 2021-02-05  190   return 0;
bd69bcce4aa089 Maximilian Luz 2021-02-05  191  }
bd69bcce4aa089 Maximilian Luz 2021-02-05  192  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

2021-11-25 Thread kernel test robot

CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Maximilian Luz 
CC: Hans de Goede 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   5f53fa508db098c9d372423a6dac31c8a5679cdf
commit: bd69bcce4aa089435e289136b1cb20395bec platform/surface: Add Surface 
Hot-Plug driver
date:   10 months ago
:: branch date: 25 hours ago
:: commit date: 10 months ago
config: i386-randconfig-m021-2026 
(https://download.01.org/0day-ci/archive/20211126/202111260207.alyuxipy-...@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should 
'(((1))) << dsm' be a 64 bit type?

vim +163 drivers/platform/surface/surface_hotplug.c

bd69bcce4aa0894 Maximilian Luz 2021-02-05  147  
bd69bcce4aa0894 Maximilian Luz 2021-02-05  148  static int 
shps_setup_irq(struct platform_device *pdev, enum shps_irq_type type)
bd69bcce4aa0894 Maximilian Luz 2021-02-05  149  {
bd69bcce4aa0894 Maximilian Luz 2021-02-05  150  unsigned long flags = 
IRQF_ONESHOT | IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  151  struct shps_device 
*sdev = platform_get_drvdata(pdev);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  152  struct gpio_desc *gpiod;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  153  acpi_handle handle = 
ACPI_HANDLE(>dev);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  154  const char *irq_name;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  155  const int dsm = 
shps_dsm_fn_for_irq(type);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  156  int status, irq;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  157  
bd69bcce4aa0894 Maximilian Luz 2021-02-05  158  /*
bd69bcce4aa0894 Maximilian Luz 2021-02-05  159   * Only set up 
interrupts that we actually need: The Surface Book 3
bd69bcce4aa0894 Maximilian Luz 2021-02-05  160   * does not have a DSM 
for base presence, so don't set up an interrupt
bd69bcce4aa0894 Maximilian Luz 2021-02-05  161   * for that.
bd69bcce4aa0894 Maximilian Luz 2021-02-05  162   */
bd69bcce4aa0894 Maximilian Luz 2021-02-05 @163  if 
(!acpi_check_dsm(handle, _dsm_guid, SHPS_DSM_REVISION, BIT(dsm))) {
bd69bcce4aa0894 Maximilian Luz 2021-02-05  164  
dev_dbg(>dev, "IRQ notification via DSM not present (irq=%d)\n", type);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  165  return 0;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  166  }
bd69bcce4aa0894 Maximilian Luz 2021-02-05  167  
bd69bcce4aa0894 Maximilian Luz 2021-02-05  168  gpiod = 
devm_gpiod_get(>dev, shps_gpio_names[type], GPIOD_ASIS);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  169  if (IS_ERR(gpiod))
bd69bcce4aa0894 Maximilian Luz 2021-02-05  170  return 
PTR_ERR(gpiod);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  171  
bd69bcce4aa0894 Maximilian Luz 2021-02-05  172  irq = 
gpiod_to_irq(gpiod);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  173  if (irq < 0)
bd69bcce4aa0894 Maximilian Luz 2021-02-05  174  return irq;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  175  
bd69bcce4aa0894 Maximilian Luz 2021-02-05  176  irq_name = 
devm_kasprintf(>dev, GFP_KERNEL, "shps-irq-%d", type);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  177  if (!irq_name)
bd69bcce4aa0894 Maximilian Luz 2021-02-05  178  return -ENOMEM;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  179  
bd69bcce4aa0894 Maximilian Luz 2021-02-05  180  status = 
devm_request_threaded_irq(>dev, irq, NULL, shps_handle_irq,
bd69bcce4aa0894 Maximilian Luz 2021-02-05  181  
   flags, irq_name, pdev);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  182  if (status)
bd69bcce4aa0894 Maximilian Luz 2021-02-05  183  return status;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  184  
bd69bcce4aa0894 Maximilian Luz 2021-02-05  185  dev_dbg(>dev, 
"set up irq %d as type %d\n", irq, type);
bd69bcce4aa0894 Maximilian Luz 2021-02-05  186  
bd69bcce4aa0894 Maximilian Luz 2021-02-05  187  sdev->gpio[type] = 
gpiod;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  188  sdev->irq[type] = irq;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  189  
bd69bcce4aa0894 Maximilian Luz 2021-02-05  190  return 0;
bd69bcce4aa0894 Maximilian Luz 2021-02-05  191  }
bd69bcce4aa0894 Maximilian Luz 2021-02-05  192  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

2021-08-13 Thread kernel test robot

CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Maximilian Luz 
CC: Hans de Goede 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   f8e6dfc64f6135d1b6c5215c14cd30b9b60a0008
commit: bd69bcce4aa089435e289136b1cb20395bec platform/surface: Add Surface 
Hot-Plug driver
date:   6 months ago
:: branch date: 5 hours ago
:: commit date: 6 months ago
config: i386-randconfig-m021-20210813 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should 
'(((1))) << dsm' be a 64 bit type?

vim +163 drivers/platform/surface/surface_hotplug.c

bd69bcce4aa089 Maximilian Luz 2021-02-05  147  
bd69bcce4aa089 Maximilian Luz 2021-02-05  148  static int shps_setup_irq(struct 
platform_device *pdev, enum shps_irq_type type)
bd69bcce4aa089 Maximilian Luz 2021-02-05  149  {
bd69bcce4aa089 Maximilian Luz 2021-02-05  150   unsigned long flags = 
IRQF_ONESHOT | IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING;
bd69bcce4aa089 Maximilian Luz 2021-02-05  151   struct shps_device *sdev = 
platform_get_drvdata(pdev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  152   struct gpio_desc *gpiod;
bd69bcce4aa089 Maximilian Luz 2021-02-05  153   acpi_handle handle = 
ACPI_HANDLE(>dev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  154   const char *irq_name;
bd69bcce4aa089 Maximilian Luz 2021-02-05  155   const int dsm = 
shps_dsm_fn_for_irq(type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  156   int status, irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  157  
bd69bcce4aa089 Maximilian Luz 2021-02-05  158   /*
bd69bcce4aa089 Maximilian Luz 2021-02-05  159* Only set up interrupts that 
we actually need: The Surface Book 3
bd69bcce4aa089 Maximilian Luz 2021-02-05  160* does not have a DSM for base 
presence, so don't set up an interrupt
bd69bcce4aa089 Maximilian Luz 2021-02-05  161* for that.
bd69bcce4aa089 Maximilian Luz 2021-02-05  162*/
bd69bcce4aa089 Maximilian Luz 2021-02-05 @163   if (!acpi_check_dsm(handle, 
_dsm_guid, SHPS_DSM_REVISION, BIT(dsm))) {
bd69bcce4aa089 Maximilian Luz 2021-02-05  164   dev_dbg(>dev, 
"IRQ notification via DSM not present (irq=%d)\n", type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  165   return 0;
bd69bcce4aa089 Maximilian Luz 2021-02-05  166   }
bd69bcce4aa089 Maximilian Luz 2021-02-05  167  
bd69bcce4aa089 Maximilian Luz 2021-02-05  168   gpiod = 
devm_gpiod_get(>dev, shps_gpio_names[type], GPIOD_ASIS);
bd69bcce4aa089 Maximilian Luz 2021-02-05  169   if (IS_ERR(gpiod))
bd69bcce4aa089 Maximilian Luz 2021-02-05  170   return PTR_ERR(gpiod);
bd69bcce4aa089 Maximilian Luz 2021-02-05  171  
bd69bcce4aa089 Maximilian Luz 2021-02-05  172   irq = gpiod_to_irq(gpiod);
bd69bcce4aa089 Maximilian Luz 2021-02-05  173   if (irq < 0)
bd69bcce4aa089 Maximilian Luz 2021-02-05  174   return irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  175  
bd69bcce4aa089 Maximilian Luz 2021-02-05  176   irq_name = 
devm_kasprintf(>dev, GFP_KERNEL, "shps-irq-%d", type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  177   if (!irq_name)
bd69bcce4aa089 Maximilian Luz 2021-02-05  178   return -ENOMEM;
bd69bcce4aa089 Maximilian Luz 2021-02-05  179  
bd69bcce4aa089 Maximilian Luz 2021-02-05  180   status = 
devm_request_threaded_irq(>dev, irq, NULL, shps_handle_irq,
bd69bcce4aa089 Maximilian Luz 2021-02-05  181   
   flags, irq_name, pdev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  182   if (status)
bd69bcce4aa089 Maximilian Luz 2021-02-05  183   return status;
bd69bcce4aa089 Maximilian Luz 2021-02-05  184  
bd69bcce4aa089 Maximilian Luz 2021-02-05  185   dev_dbg(>dev, "set up irq 
%d as type %d\n", irq, type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  186  
bd69bcce4aa089 Maximilian Luz 2021-02-05  187   sdev->gpio[type] = gpiod;
bd69bcce4aa089 Maximilian Luz 2021-02-05  188   sdev->irq[type] = irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  189  
bd69bcce4aa089 Maximilian Luz 2021-02-05  190   return 0;
bd69bcce4aa089 Maximilian Luz 2021-02-05  191  }
bd69bcce4aa089 Maximilian Luz 2021-02-05  192  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org


.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

2021-04-25 Thread kernel test robot

CC: kbuild-...@lists.01.org
CC: linux-ker...@vger.kernel.org
TO: Maximilian Luz 
CC: Hans de Goede 

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   9f4ad9e425a1d3b6a34617b8ea226d56a119a717
commit: bd69bcce4aa089435e289136b1cb20395bec platform/surface: Add Surface 
Hot-Plug driver
date:   3 months ago
:: branch date: 4 hours ago
:: commit date: 3 months ago
config: i386-randconfig-m021-20210426 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 
Reported-by: Dan Carpenter 

smatch warnings:
drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should 
'(((1))) << dsm' be a 64 bit type?

vim +163 drivers/platform/surface/surface_hotplug.c

bd69bcce4aa089 Maximilian Luz 2021-02-05  147  
bd69bcce4aa089 Maximilian Luz 2021-02-05  148  static int shps_setup_irq(struct 
platform_device *pdev, enum shps_irq_type type)
bd69bcce4aa089 Maximilian Luz 2021-02-05  149  {
bd69bcce4aa089 Maximilian Luz 2021-02-05  150   unsigned long flags = 
IRQF_ONESHOT | IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING;
bd69bcce4aa089 Maximilian Luz 2021-02-05  151   struct shps_device *sdev = 
platform_get_drvdata(pdev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  152   struct gpio_desc *gpiod;
bd69bcce4aa089 Maximilian Luz 2021-02-05  153   acpi_handle handle = 
ACPI_HANDLE(>dev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  154   const char *irq_name;
bd69bcce4aa089 Maximilian Luz 2021-02-05  155   const int dsm = 
shps_dsm_fn_for_irq(type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  156   int status, irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  157  
bd69bcce4aa089 Maximilian Luz 2021-02-05  158   /*
bd69bcce4aa089 Maximilian Luz 2021-02-05  159* Only set up interrupts that 
we actually need: The Surface Book 3
bd69bcce4aa089 Maximilian Luz 2021-02-05  160* does not have a DSM for base 
presence, so don't set up an interrupt
bd69bcce4aa089 Maximilian Luz 2021-02-05  161* for that.
bd69bcce4aa089 Maximilian Luz 2021-02-05  162*/
bd69bcce4aa089 Maximilian Luz 2021-02-05 @163   if (!acpi_check_dsm(handle, 
_dsm_guid, SHPS_DSM_REVISION, BIT(dsm))) {
bd69bcce4aa089 Maximilian Luz 2021-02-05  164   dev_dbg(>dev, 
"IRQ notification via DSM not present (irq=%d)\n", type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  165   return 0;
bd69bcce4aa089 Maximilian Luz 2021-02-05  166   }
bd69bcce4aa089 Maximilian Luz 2021-02-05  167  
bd69bcce4aa089 Maximilian Luz 2021-02-05  168   gpiod = 
devm_gpiod_get(>dev, shps_gpio_names[type], GPIOD_ASIS);
bd69bcce4aa089 Maximilian Luz 2021-02-05  169   if (IS_ERR(gpiod))
bd69bcce4aa089 Maximilian Luz 2021-02-05  170   return PTR_ERR(gpiod);
bd69bcce4aa089 Maximilian Luz 2021-02-05  171  
bd69bcce4aa089 Maximilian Luz 2021-02-05  172   irq = gpiod_to_irq(gpiod);
bd69bcce4aa089 Maximilian Luz 2021-02-05  173   if (irq < 0)
bd69bcce4aa089 Maximilian Luz 2021-02-05  174   return irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  175  
bd69bcce4aa089 Maximilian Luz 2021-02-05  176   irq_name = 
devm_kasprintf(>dev, GFP_KERNEL, "shps-irq-%d", type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  177   if (!irq_name)
bd69bcce4aa089 Maximilian Luz 2021-02-05  178   return -ENOMEM;
bd69bcce4aa089 Maximilian Luz 2021-02-05  179  
bd69bcce4aa089 Maximilian Luz 2021-02-05  180   status = 
devm_request_threaded_irq(>dev, irq, NULL, shps_handle_irq,
bd69bcce4aa089 Maximilian Luz 2021-02-05  181   
   flags, irq_name, pdev);
bd69bcce4aa089 Maximilian Luz 2021-02-05  182   if (status)
bd69bcce4aa089 Maximilian Luz 2021-02-05  183   return status;
bd69bcce4aa089 Maximilian Luz 2021-02-05  184  
bd69bcce4aa089 Maximilian Luz 2021-02-05  185   dev_dbg(>dev, "set up irq 
%d as type %d\n", irq, type);
bd69bcce4aa089 Maximilian Luz 2021-02-05  186  
bd69bcce4aa089 Maximilian Luz 2021-02-05  187   sdev->gpio[type] = gpiod;
bd69bcce4aa089 Maximilian Luz 2021-02-05  188   sdev->irq[type] = irq;
bd69bcce4aa089 Maximilian Luz 2021-02-05  189  
bd69bcce4aa089 Maximilian Luz 2021-02-05  190   return 0;
bd69bcce4aa089 Maximilian Luz 2021-02-05  191  }
bd69bcce4aa089 Maximilian Luz 2021-02-05  192  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org


.config.gz
Description: application/gzip
___
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-le...@lists.01.org

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

[kbuild] drivers/platform/surface/surface_hotplug.c:163 shps_setup_irq() warn: should '(((1))) << dsm' be a 64 bit type?

5 matches

Site Navigation

Mail list logo

Footer information