Re: [kbuild-devel] Re: Forgotten driver
On Fri, 30 Nov 2001 09:32:24 +0100, Giacomo Catenazzi <[EMAIL PROTECTED]> wrote: >in drivers/pcmcia/Makefile.in: > >objlink(sa1100_cs.o sa1100_generic.o) >objlink(CONFIG_SA1100_ASSABET sa1100_cs.o a1100_assabet.o) >objlink(CONFIG_ASSABET_NEPONSET sa1100_cs.o a1100_neponset.o) > >You should subst. [[:blank:]]a1100 into sa1100 (as in old Makefile) %s/\https://lists.sourceforge.net/lists/listinfo/kbuild-devel
Re: [kbuild-devel] Re: Forgotten driver
Keith Owens wrote: > > I have no idea what you mean by that. Which filenames are missing the > leading 's' and which file is missing it? > in drivers/pcmcia/Makefile.in: objlink(sa1100_cs.o sa1100_generic.o) objlink(CONFIG_SA1100_ASSABET sa1100_cs.o a1100_assabet.o) objlink(CONFIG_ASSABET_NEPONSET sa1100_cs.o a1100_neponset.o) objlink(CONFIG_SA1100_H3600 sa1100_cs.o a1100_h3600.o) objlink(CONFIG_SA1100_CERF sa1100_cs.o a1100_cerf.o) objlink(CONFIG_SA1100_GRAPHICSCLIENTsa1100_cs.o a1100_graphicsclient.o) objlink(CONFIG_SA1100_XP860 sa1100_cs.o a1100_xp860.o) objlink(CONFIG_SA1100_PANGOLIN sa1100_cs.o a1100_pangolin.o) objlink(CONFIG_SA1100_YOPY sa1100_cs.o a1100_yopy.o) objlink(CONFIG_SA1100_FREEBIRD sa1100_cs.o a1100_freebird.o) objlink(CONFIG_SA1100_PFS168sa1100_cs.o a1100_pfs168.o) objlink(CONFIG_SA1100_JORNADA720sa1100_cs.o a1100_jornada720.o) objlink(CONFIG_SA1100_FLEXANET sa1100_cs.o a1100_flexanet.o) objlink(CONFIG_SA1100_SIMPADsa1100_cs.o a1100_simpad.o) objlink(CONFIG_SA1100_GRAPHICSMASTERsa1100_cs.o a1100_graphicsmaster.o) objlink(CONFIG_SA1100_ADSBITSY sa1100_cs.o a1100_adsbitsy.o) objlink(CONFIG_SA1100_STORK sa1100_cs.o a1100_stork.o) You should subst. [[:blank:]]a1100 into sa1100 (as in old Makefile) giacomo PS: Sorry for my bad bug report. ___ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel
Re: [kbuild-devel] Re: Forgotten driver
On Thu, Nov 29, 2001 at 04:28:00PM +0100, Giacomo Catenazzi wrote: > >drivers/usb/serial/keyspan_pda.S > > drivers/usb/serial/Makefile, line 13 -- obj-$(CONFIG_USB_SERIAL_KEYSPAN_PDA) += >keyspan_pda.o > drivers/usb/serial/Makefile, line 14 -- obj-$(CONFIG_USB_SERIAL_XIRCOM) += >keyspan_pda.o No, this is a firwmare 8051 file, it does not generage the .o file. That's what keyspan_pda.c is for. These will be moved to a separate external package sometime during 2.5. > >drivers/usb/serial/xircom_pgs.S > > NR Same as above. thanks, greg k-h ___ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel
[kbuild-devel] Re: Forgotten driver
On Thu, 29 Nov 2001 16:28:00 +0100, Giacomo Catenazzi <[EMAIL PROTECTED]> wrote: >Keith Owens wrote: >> This is my list from 2.4.16. A lot are false positives, but some are >> definitely orphaned. If you spot any errors in the Makefile.in rules >> compared to Makefile, let me know. > >I have check the list (but with 2.4.14, latest version in LXR [lxr.linux.no]) >Your rules seems ok, but lines 4265-4280: you forgot the 's' at the >beginning of the file names. I have no idea what you mean by that. Which filenames are missing the leading 's' and which file is missing it? ___ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel
Re: [kbuild-devel] Re: Forgotten driver
Keith Owens wrote: > > This is my list from 2.4.16. A lot are false positives, but some are > definitely orphaned. If you spot any errors in the Makefile.in rules > compared to Makefile, let me know. > I have check the list (but with 2.4.14, latest version in LXR [lxr.linux.no]) Your rules seems ok, but lines 4265-4280: you forgot the 's' at the beginning of the file names. Below is you list with the references I found (NR: no references). Next I will check the NR (some are userspace utilities), and I will contact the maintainers. giacomo > drivers/acorn/char/keyb_arc.c drivers/acorn/char/Makefile, line 24 -- obj-arc := keyb_arc.o > drivers/acorn/char/keyb_ps2.c drivers/acorn/char/Makefile, line 25 -- obj-rpc := keyb_ps2.o > drivers/acorn/char/mouse_ps2.c NR > drivers/acorn/char/serial-card.c drivers/acorn/char/serial-dualsp.c, line 24 -- #include "serial-card.c" > drivers/atm/fore200e_sba_fw.c drivers/atm/Makefile, line 42 -- FORE200E_FW_OBJS += fore200e_sba_fw.o > drivers/atm/nicstarmac.c drivers/atm/nicstar.c, line 71 -- #include "nicstarmac.c" > drivers/block/paride/ppc6lnx.c drivers/block/paride/bpck6.c, line 38 -- #include "ppc6lnx.c" > drivers/char/amikeyb.c amikeyb > drivers/char/decserial.c drivers/char/Makefile, line 106 -- SERIAL = decserial.o > drivers/char/dn_keyb.c NR > drivers/char/ec3104_keyb.c drivers/char/Makefile, line 93 -- KEYBD = ec3104_keyb.o > drivers/char/hp600_keyb.c drivers/char/Makefile, line 81 -- KEYBD = scan_keyb.o hp600_keyb.o > drivers/char/hp_keyb.c NR > drivers/char/hp_psaux.c NR > drivers/char/ite_gpio.c NR > drivers/char/q40_keyb.c NR > drivers/char/qtronix.c drivers/char/Makefile, line 123 -- KEYBD = qtronix.o > drivers/char/qtronixmap.c drivers/char/Makefile, line 124 -- KEYMAP = qtronixmap.o > drivers/char/scan_keyb.c drivers/char/Makefile, line 81 -- KEYBD = scan_keyb.o hp600_keyb.o > drivers/char/w83877f_wdt.c NR > drivers/char/ip2/i2cmd.c > drivers/char/ip2/i2ellis.c > drivers/char/ip2/i2lib.c > drivers/char/ip2/ip2mkdev.c > drivers/char/ip2/ip2stat.c > drivers/char/ip2/ip2trace.c utilities.. > drivers/ieee1394/ieee1394_syms.c NR > drivers/isdn/hisax/amd7930.c drivers/sbus/audio/Makefile, line 10 -- export-objs := audio.o amd7930.o dbri.o > drivers/isdn/hisax/elsa_ser.c drivers/isdn/hisax/elsa.c, line 141 -- #include "elsa_ser.c" > drivers/isdn/hisax/hscx_irq.c drivers/isdn/hisax/avm_a1.c, line 102 -- #include "hscx_irq.c" > drivers/isdn/hisax/jade_irq.c drivers/isdn/hisax/bkm_a4t.c, line 136 -- #include "jade_irq.c" > drivers/isdn/hisax/rawhdlc.c NR > drivers/isdn/hysdn/hysdn_procfs.c NR > drivers/media/video/zoran_procfs.c drivers/media/video/zr36067.c, line 4604 -- #include "zoran_procfs.c" > drivers/message/fusion/ascq_tbl.c drivers/message/fusion/isense.c, line 79 -- #include "ascq_tbl.c" > drivers/message/fusion/scsiops.c drivers/message/fusion/isense.c, line 80 -- #include "scsiops.c" > drivers/net/aironet4500_rid.c drivers/net/aironet4500_proc.c, line 47 -- #include "aironet4500_rid.c" > drivers/net/dgrs_firmware.c drivers/net/dgrs.c, line 137 -- #include "dgrs_firmware.c" > drivers/net/isa-skeleton.c skeleton > drivers/net/pci-skeleton.c skeleton > drivers/net/ptifddi.c NR > drivers/net/sonic.c drivers/net/macsonic.c, line 621 -- #include "sonic.c" > drivers/net/zlib.c drivers/net/ppp_deflate.c, line 42 -- #include "zlib.c" > drivers/net/fc/iph5526_novram.c drivers/net/fc/iph5526.c, line 67 -- #include "iph5526_novram.c" > drivers/net/pcmcia/ibmtr_cs_inc.c NR > drivers/net/skfp/can.c 'can' is not a string to search in all kernel > drivers/net/wan/hd6457x.c drivers/net/wan/n2.c, line 156 -- #include "hd6457x.c" > drivers/parport/parport_arc.c #ifdef CONFIG_PARPORT_ARC it should link to this file. > drivers/pcmcia/sa1100_adsbitsy.c > drivers/pcmcia/sa1100_assabet.c > drivers/pcmcia/sa1100_cerf.c > drivers/pcmcia/sa1100_flexanet.c > drivers/pcmcia/sa1100_freebird.c > drivers/pcmcia/sa1100_graphicsclient.c > drivers/pcmcia/sa1100_graphicsmaster.c > drivers/pcmcia/sa1100_h3600.c > drivers/pcmcia/sa1100_jornada720.c > drivers/pcmcia/sa1100_neponset.c > drivers/pcmcia/sa1100_pangolin.c drivers/pcmcia/Makefile, line 71 -- sa1100_cs-objs-$(CONFIG_SA1100_PANGOLIN) += sa1100_pangolin.o > drivers/pcmcia/sa1100_pfs168.c drivers/pcmcia/Makefile, line 74 -- sa1100_cs-objs-$(CONFIG_SA1100_PFS168) += sa1100_pfs168.o > drivers/pcmcia/sa1100_simpad.c drivers/pcmcia/Makefile, line 77 -- sa1100_cs-objs-$(CONFIG_SA1100_SIMPAD) += sa1100_simpad.o > drivers/pcmcia/sa1100_stork.c drivers/pcmcia/Makefile, line 80 -- sa1100_cs-objs-$(CONFIG_SA1100_STORK) += sa1100_stork.o > drivers/pcmcia/sa1100_xp860.c drivers/pcmcia/Makefile, line 70 -- sa1100_cs-objs-$(CONFIG_SA1100_XP860) += sa1100_xp860.o > drivers/pcmcia/sa1100_yopy.c drivers/pcmcia/Makefile, line 72 -- sa1100_cs-objs-$(CONFIG_SA1100_YOPY) += sa1100_yo
[kbuild-devel] Re: Forgotten driver
On Thu, 29 Nov 2001 12:54:03 +0100, Giacomo Catenazzi <[EMAIL PROTECTED]> wrote: >The main point is: Could we find easily all >'orphaned file' with the new kbuild-2.5? make -f $KBUILD_SRCTREE_000/Makefile-2.5 allyes $KBUILD_OBJTREE/.tmp_global_makefile grep '\.[coS] ' $KBUILD_OBJTREE/.tmp_database_debug | \ egrep -v '\.tmp|Documentation|arch/|scripts/| - |\.c?d ' | \ awk 'src != "" {if (obj != $1) {print src}; src="";} $1 ~ /.*\.[cS]$/ {src=$1; obj=src; sub(/.$/, "o", obj); }' It has some false positives: .[cS] files that are only included by other files, like nicstarmac.c. No way to find them without doing a full compile and even that is not guaranteed. Objects that are indirectly selected via make variables _and_ the select() statement is not true. drivers/acorn/char/keyb_arc.c is indirectly selected via make variable obj-arc but obj_$(MACHINE) is not true on my build. make allyes picks up most, but not all, indirect selections. This is my list from 2.4.16. A lot are false positives, but some are definitely orphaned. If you spot any errors in the Makefile.in rules compared to Makefile, let me know. drivers/acorn/char/keyb_arc.c drivers/acorn/char/keyb_ps2.c drivers/acorn/char/mouse_ps2.c drivers/acorn/char/serial-card.c drivers/atm/fore200e_sba_fw.c drivers/atm/nicstarmac.c drivers/block/paride/ppc6lnx.c drivers/char/amikeyb.c drivers/char/decserial.c drivers/char/dn_keyb.c drivers/char/ec3104_keyb.c drivers/char/hp600_keyb.c drivers/char/hp_keyb.c drivers/char/hp_psaux.c drivers/char/ite_gpio.c drivers/char/q40_keyb.c drivers/char/qtronix.c drivers/char/qtronixmap.c drivers/char/scan_keyb.c drivers/char/w83877f_wdt.c drivers/char/ip2/i2cmd.c drivers/char/ip2/i2ellis.c drivers/char/ip2/i2lib.c drivers/char/ip2/ip2mkdev.c drivers/char/ip2/ip2stat.c drivers/char/ip2/ip2trace.c drivers/ieee1394/ieee1394_syms.c drivers/isdn/hisax/amd7930.c drivers/isdn/hisax/elsa_ser.c drivers/isdn/hisax/hscx_irq.c drivers/isdn/hisax/jade_irq.c drivers/isdn/hisax/rawhdlc.c drivers/isdn/hysdn/hysdn_procfs.c drivers/media/video/zoran_procfs.c drivers/message/fusion/ascq_tbl.c drivers/message/fusion/scsiops.c drivers/net/aironet4500_rid.c drivers/net/dgrs_firmware.c drivers/net/isa-skeleton.c drivers/net/pci-skeleton.c drivers/net/ptifddi.c drivers/net/sonic.c drivers/net/zlib.c drivers/net/fc/iph5526_novram.c drivers/net/pcmcia/ibmtr_cs_inc.c drivers/net/skfp/can.c drivers/net/wan/hd6457x.c drivers/parport/parport_arc.c drivers/pcmcia/sa1100_adsbitsy.c drivers/pcmcia/sa1100_assabet.c drivers/pcmcia/sa1100_cerf.c drivers/pcmcia/sa1100_flexanet.c drivers/pcmcia/sa1100_freebird.c drivers/pcmcia/sa1100_graphicsclient.c drivers/pcmcia/sa1100_graphicsmaster.c drivers/pcmcia/sa1100_h3600.c drivers/pcmcia/sa1100_jornada720.c drivers/pcmcia/sa1100_neponset.c drivers/pcmcia/sa1100_pangolin.c drivers/pcmcia/sa1100_pfs168.c drivers/pcmcia/sa1100_simpad.c drivers/pcmcia/sa1100_stork.c drivers/pcmcia/sa1100_xp860.c drivers/pcmcia/sa1100_yopy.c drivers/s390/ebcdic.c drivers/s390/char/tape3590.c drivers/sbus/char/sunkeymap.c drivers/scsi/FlashPoint.c drivers/scsi/NCR5380.c drivers/scsi/atari_NCR5380.c drivers/scsi/atari_dma_emul.c drivers/scsi/cpqioctl.c drivers/scsi/eata_dma_proc.c drivers/scsi/eata_pio_proc.c drivers/scsi/gdth_proc.c drivers/scsi/mac_NCR5380.c drivers/scsi/qlogicfc_asm.c drivers/scsi/qlogicisp_asm.c drivers/scsi/qlogicpti_asm.c drivers/scsi/scsi_module.c drivers/scsi/scsiiom.c drivers/scsi/sun3_NCR5380.c drivers/scsi/aic7xxx_old/aic7xxx_proc.c drivers/scsi/aic7xxx_old/aic7xxx_seq.c drivers/scsi/pcmcia/nsp_debug.c drivers/scsi/pcmcia/nsp_message.c drivers/sound/ite8172.c drivers/sound/msndinit.c drivers/sound/msndperm.c drivers/sound/pndsperm.c drivers/sound/pndspini.c drivers/sound/skeleton.c drivers/sound/cs4281/cs4281_wrapper-24.c drivers/sound/cs4281/cs4281pm-24.c drivers/usb/usb-skeleton.c drivers/usb/serial/keyspan_pda.S drivers/usb/serial/xircom_pgs.S drivers/video/dn_cfb4.c drivers/video/dn_cfb8.c drivers/video/skeletonfb.c fs/intermezzo/ext_attr.c fs/intermezzo/kml.c fs/intermezzo/kml_decode.c fs/intermezzo/kml_reint.c fs/intermezzo/kml_setup.c fs/intermezzo/kml_utils.c fs/jffs2/comprtest.c fs/minix/itree_common.c lib/inflate.c net/ipv4/netfilter/ipt_ttl.c net/ipv6/ip6_fw.c net/sunrpc/svcauth_des.c net/wanrouter/af_wanpipe.c ___ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel