[plasmashell] [Bug 420315] Leave actions do nothing (cannot log out or shutdown from plasma)

2020-04-19 Thread Francis T
https://bugs.kde.org/show_bug.cgi?id=420315

Francis T  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |FIXED

--- Comment #2 from Francis T  ---
I'm running my development version from ~/kde/..., using the
install-sessions.sh script as described here:
https://community.kde.org/Get_Involved/development

dbus is 1.12.16-5. I'm not sure how recently it was pushed to manjaro
repositories, unfortunately.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 420315] New: Leave actions do nothing (cannot log out or shutdown from plasma)

2020-04-19 Thread Francis T
https://bugs.kde.org/show_bug.cgi?id=420315

Bug ID: 420315
   Summary: Leave actions do nothing (cannot log out or shutdown
from plasma)
   Product: plasmashell
   Version: master
  Platform: Compiled Sources
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: k...@davidedmundson.co.uk
  Reporter: frther...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: 1.0

SUMMARY

When selecting a leave action from the plasma Application Launcher, nothing
happens. The only way I've found to logout is via loginctl terminate-user.
"Sleep" and "Lock" seem to work

STEPS TO REPRODUCE
1. Application Launcher > Leave
2. Select Log Out, Shut Down, or Restart

OBSERVED RESULT

Nothing happens.

EXPECTED RESULT
Logout or shutdown procedure should start.

SOFTWARE/OS VERSIONS
Windows: -
macOS: -
Linux/KDE Plasma: Linux 5.4.33-1-MANJARO #1 SMP PREEMPT Fri Apr 17 18:16:26 UTC
2020 x86_64 GNU/Linux
(available in About System)
KDE Plasma Version: Noticed while building plasma-workspace from master (see
below for bisected commit)
KDE Frameworks Version: I believe it was also built from master
Qt Version: 5.14.2-1

ADDITIONAL INFORMATION

My distro had plasma-workspace 5.18.4.1, which does not have the issue. I
checked out the commit tagged "v5.18.4.1" in plasma-workspace and built it, no
issue also. I ran git bisect between that commit and master, and the result is
that commit 3c34dfa in plasma-workspace (https://phabricator.kde.org/D27629)
seems to be the first commit with the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 420085] User autostart scripts sourced after system-level scripts

2020-04-18 Thread Francis T
https://bugs.kde.org/show_bug.cgi?id=420085

--- Comment #6 from Francis T  ---
Patch submmitted here: https://phabricator.kde.org/D28941

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 420085] User autostart scripts sourced after system-level scripts

2020-04-14 Thread Francis T
https://bugs.kde.org/show_bug.cgi?id=420085

--- Comment #4 from Francis T  ---
Odd, I thought I had replied previously.

Anyways, I had a look at startplasma.cpp here:
https://phabricator.kde.org/source/plasma-workspace/browse/master/startkde/startplasma.cpp$193

I don't think anything in the function in question sorts the scripts before
sourcing. entryInfoList has an optional argument for sorting (which is not
used, and the default is NoSort), but even if we used it, we'd be sorting each
directory separately, which is not very useful.

Adding a sort call before sourcefiles appears to be a 1-line fix. However, I
personally agree with Nate that user scripts should be sourced after system
scripts.

I can try and put together a patch. However, C++ (and qt) is really not my
forte, so if anyone wants to take a stab, please have at it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 420085] New: User autostart scripts sourced after system-level scripts

2020-04-14 Thread Francis T
https://bugs.kde.org/show_bug.cgi?id=420085

Bug ID: 420085
   Summary: User autostart scripts sourced after system-level
scripts
   Product: plasmashell
   Version: 5.18.4
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: k...@davidedmundson.co.uk
  Reporter: frther...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: 1.0

SUMMARY

I am trying to use a shell script placed in ~/.config/plasma-workspace/env/ to
set my `$EDITOR` variable, as described in the KDE docs here:
https://userbase.kde.org/Session_Environment_Variables

The script is correctly executed during login, and $EDITOR is correctly set at
one point. However, later on it is overwritten by the value specified in
/etc/xdg/plasma-workspace/env/envars.sh. This file is provided by the Manjaro
distribution to provide default values of common environment variables (such as
PATH and EDITOR).

User preferences should prevail over system defaults. I would expect that the
$EDITOR value I set in my user-specific session autostart scripts should be the
final, active value set after session startup is complete.

STEPS TO REPRODUCE

1. Create the user vars file:

echo "export EDITOR=/usr/bin/nvim" >
$HOME/.config/plasma-workspace/env/uservars.sh
echo "export EDITOR2=bar" >> $HOME/.config/plasma-workspace/env/uservars.sh
chmod +x $HOME/.config/plasma-workspace/env/uservars.sh

2. Edit (or create) the system level envars file:

Edit the file /etc/xdg/plasma-workspace/env/envars.sh. Change the line "export
EDITOR=/usr/bin/nano"  to "export EDITOR=FOO".

3. Log out and log back in.

OBSERVED RESULT

The EDITOR2 variable is set, indicating that the user script was executed.
However, the EDITOR variable was overwritten by the system-level script:

$> echo $EDITOR
FOO

$> echo $EDITOR2
bar

FINAL NOTE

I am not sure which script/process executes these files. It seems the order is
wrong. The KDE docs (linked above) say that the "startkde" script runs them,
yet it appears that this script was replaced by a binary named
"startplasma-x11". I searched KDE's phabricator but was not able to find the
source for this file. If someone can point me to the source file, I can grep
through it with my half-understanding of C++/Qt and attempt to find the source
of the bug.

I should also note that according to pacman,
/etc/xdg/plasma-workspace/env/envars.sh belongs to the package
`manjaro-kde-settings-19.0 20200408-2`.

-- 
You are receiving this mail because:
You are watching all bug changes.