[ktorrent] [Bug 388966] Enabling "Search" plugin freezes KTorrent application

2019-11-21 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=388966

Gilbert Assaf  changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #15 from Gilbert Assaf  ---
The error is somehow caused by the default homepage, used by the search plugin.
The homepage is a local html file, which causes webkit to hang, although the
website seems valid. Moving to QWebEngine fixes the problem.
https://phabricator.kde.org/D25314

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 395689] konsole ignores .NET color change methods

2018-08-17 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=395689

Gilbert Assaf  changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #5 from Gilbert Assaf  ---
I compiled the example with Mono 5.10.1.47 and ran it on konsole 17.12.3 and
current master. It did work correctly on both versions.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 334711] EPUB format is not handled correctly (TOC, images, pages not displayed)

2018-08-15 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=334711

Gilbert Assaf  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/oku
   ||lar/fcf148b75b98462b927da60
   ||5ca76ee69ada31fd1
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Gilbert Assaf  ---
Git commit fcf148b75b98462b927da605ca76ee69ada31fd1 by Gilbert Assaf.
Committed on 15/08/2018 at 17:14.
Pushed by gassaf into branch 'master'.

Fixes url whitespaces in epub documents

Summary:
libepub can't handle whitespace url encodings. This is why epub documents
containing whitespaces urls aren't
displayed correctly. Since libepub doesn't seem to be maintained anymore, it
might be better to fix this issue here.

Test Plan: Example epubs are in the ticket.

Reviewers: #okular, aacid

Reviewed By: #okular, aacid

Subscribers: ngraham, aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D14310

M  +10   -0generators/epub/CMakeLists.txt
A  +---generators/epub/autotests/data/test.epub
A  +84   -0generators/epub/autotests/epubgeneratortest.cpp [License:
GPL (v2+)]
M  +5-1generators/epub/converter.cpp

https://commits.kde.org/okular/fcf148b75b98462b927da605ca76ee69ada31fd1

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 288042] Option to reset forms (PDF)

2017-08-30 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=288042

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #4 from Gilbert Assaf <gas...@gmx.de> ---
https://git.reviewboard.kde.org/r/130057/

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 358059] Inline note text not fully visible

2017-07-23 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=358059

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #3 from Gilbert Assaf <gas...@gmx.de> ---
If you hover over such a rectangle with your mouse (Version 1.0.3), you can see
the whole text. 
Otherwise this issue could only be fixed, if a minimum rectangle size,
depending on the containing text is introduced. I bet this will upset some
users.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 377024] Add "expand all" to the Review View

2017-07-23 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=377024

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #1 from Gilbert Assaf <gas...@gmx.de> ---
Well this option kind of already exists. If you press the "Show reviews for
current page only" Button, located at the bottom in the review view, all
annotations from all authors for this particular page are collapsed. But I
agree, this is not very intuitive.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 262265] crashes with chm (text encoding by LCID)

2017-06-02 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=262265

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/oku
   ||lar/e876640c215f27b0d0cd632
   ||d553174bf851e0147
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Gilbert Assaf <gas...@gmx.de> ---
Okular sends a 'qFatal()', if no encoding could be guessed. This will also
create a core dump crashing Okular and all open document in this instance. 
Reviewed at https://git.reviewboard.kde.org/r/130106/

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 236688] Make use of table of contents data to improve page ordering in CHM files

2017-06-02 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=236688

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/oku
   ||lar/786ec885264fda5b1b2e1ce
   ||e22a7d62f5ad90d3f

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 236688] Make use of table of contents data to improve page ordering in CHM files

2017-06-02 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=236688

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||gas...@gmx.de
 Status|CONFIRMED   |RESOLVED

--- Comment #1 from Gilbert Assaf <gas...@gmx.de> ---
All pages in a CHM File are now ordered accordingly to TOC Data. If a page is
not in TOC, it will be added at the end. 
Reviewed at https://git.reviewboard.kde.org/r/130078/

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 164198] CHM: zooming does not change the font size

2017-06-02 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=164198

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||gas...@gmx.de
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/oku
   ||lar/ff1647ce68856022e7c3278
   ||ccb72c4039328b584

--- Comment #1 from Gilbert Assaf <gas...@gmx.de> ---
Transfers zoom handling from KHTML to KHTMLView and QImage. This way the font
now actually increases when you zoom in and zoom handling is more in line with
the other generators. Bugs closed: 164198 Reviewed at
https://git.reviewboard.kde.org/r/130127/

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 377718] Can you kindly improve support for such CHM file like this ?

2017-05-25 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=377718

--- Comment #5 from Gilbert Assaf <gas...@gmx.de> ---
I have downloaded the file! Thank you very much!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 377718] Can you kindly improve support for such CHM file like this ?

2017-05-24 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=377718

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #3 from Gilbert Assaf <gas...@gmx.de> ---
@Albert: Could you provide me with this file? I will look into this and see
what I can do.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 377454] Please add ability to "edit outlines (contents)"

2017-05-08 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=377454

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #3 from Gilbert Assaf <gas...@gmx.de> ---
Hi, I am sorry, but this fix is for bug #190203 only.
It allows you to create bookmarks for outline elements from the Table of
Contents, which are automatically named after that item.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 378464] esc to quit doesn't work

2017-05-08 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=378464

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #1 from Gilbert Assaf <gas...@gmx.de> ---
Works fine for me. Version 16.12.3 (kubuntu 17.04)

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 262265] crashes with chm (text encoding by LCID)

2017-04-25 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=262265

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #3 from Gilbert Assaf <gas...@gmx.de> ---
The attached file has no coding specified. This causes Okular to crash. You can
only open this file, if you force Okular to use utf8 (only possible in code),
but it stills looks broken. And I don't think it is a good idea to assume utf8
if no encoding is provided.

I tried to open this file on Windows, but Microsofts own chm viewer only shows
garbage and doesn't display any content.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370949] PDF bookmarks off by one

2017-04-07 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=370949

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #2 from Gilbert Assaf <gas...@gmx.de> ---
I can reproduce this problem, with current Master. But I think it's a Bug in
poppler. I also tested it with various other pdf readers:

Okular: Bookmarks are off by one
Firefox: Same Problem
Evince: Same Problem
Chromium: Works fine
Adobe Reader: Works fine

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 353302] Txt Backend does not display Arabic text

2017-02-23 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=353302

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #2 from Gilbert Assaf <gas...@gmx.de> ---
KEncodingProber doesn't work correctly with this file. This causes Okular to
not be able to read this file. A similar bug can be found here:
https://bugs.kde.org/show_bug.cgi?id=334733

-- 
You are receiving this mail because:
You are watching all bug changes.

[Active] [Bug 323240] Okular Active does not read TOCs in PDFs

2017-02-23 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=323240

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #1 from Gilbert Assaf <gas...@gmx.de> ---
Can't reproduce. It seems the problem was fixed by now…
Current Master with poppler 0.44.0-3ubuntu2

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 336192] Enable support for pdfium and favor it to poppler

2017-01-12 Thread Gilbert Assaf
https://bugs.kde.org/show_bug.cgi?id=336192

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #5 from Gilbert Assaf <gas...@gmx.de> ---
Is anybody working on this? I would like to help on this issue. I already have
implemented a working proof-of-concept.

-- 
You are receiving this mail because:
You are watching all bug changes.