[plasmashell] [Bug 443215] GDK_SCALE and GDK_DPI_SCALE are hard coded and overwrite user config

2021-10-03 Thread Liu Zhe
https://bugs.kde.org/show_bug.cgi?id=443215

--- Comment #2 from Liu Zhe  ---
(In reply to David Edmundson from comment #1)
> They are hardcoded to fix a bug.
> 
> On wayland scaling is set via the wayland protocol and there is no need for
> this.

Frankly speaking wayland scaling is unusably blur. And for small factor like
125% it's way better to scale font only, which is not supported by wayland
protocol to my knowledge.

I understand the bug it fixes but I believe a properly scaled browser is also a
must-have feature.

Can we make this behavior configurable? Via system settings or... dirty
workaround like PLASMA_GDK_DPI_SCALE.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 443215] New: GDK_SCALE and GDK_DPI_SCALE are hard coded and overwrite user config

2021-10-01 Thread Liu Zhe
https://bugs.kde.org/show_bug.cgi?id=443215

Bug ID: 443215
   Summary: GDK_SCALE and GDK_DPI_SCALE are hard coded and
overwrite user config
   Product: plasmashell
   Version: master
  Platform: Archlinux Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: k...@davidedmundson.co.uk
  Reporter: cruise@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: 1.0

SUMMARY

In plasma wayland, GDK_SCALE and GDK_DPI_SCALE cannot be configured with
".pam_environment", ".profile", ".config/plasma-workspace/env", etc.

The variables are set to 1 in startplasma-wayland, seemingly after loading user
config.

Code is here:

https://invent.kde.org/plasma/plasma-workspace/-/blob/e6cab5d96f7b51a5cf4be3d93a7e2d4fee1cddae/startkde/startplasma-wayland.cpp#L67

STEPS TO REPRODUCE
1. Write `export GDK_SCALE=2` to `.profile` and
`.config/plasma-workspace/env/dpi.sh`.
2. Reboot.
3. Run printenv.

OBSERVED RESULT
`GDK_SCALE` is 1.

EXPECTED RESULT
`GDK_SCALE` is expected to be 2.

SOFTWARE/OS VERSIONS
plasma-workspace 5.22.5, packaged by Arch Linux.

ADDITIONAL INFORMATION
I edited startplasma-wayland bin file, changed string `GDK_SCALE` to
`XXX_SCALE`. Now `GDK_SCALE` can be configured with `.pam_environment` as
expected.

-- 
You are receiving this mail because:
You are watching all bug changes.