[krita] [Bug 347755] Crash when loading file containing layer with warp transform mask

[Maks Naumov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347755

Maks Naumov  changed:

   What|Removed |Added

 CC||maksq...@ukr.net

--- Comment #7 from Maks Naumov  ---
(In reply to Dmitry Kazakov from comment #6)
> Git commit 241ddd4ec56b58172e631596696c4ea369e52a05 by Dmitry Kazakov.
> Committed on 14/04/2016 at 14:47.
> Pushed by dkazakov into branch 'master'.
> 
> Make transform mask return a change rect for the non-affine transoforms as
> well

You have two typos in the patch:
QRect KisCageTransformWorker::approxChangeRect(const QRect &rc)
{
const int margin = 0.30;  // 

return KisAlgebra2D::blowRect(resultRect | rc, margin);
}

and

QRect KisLiquifyTransformWorker::approxChangeRect(const QRect &rc)
{
const int margin = 0.05; // 

return KisAlgebra2D::blowRect(resultRect | rc, margin);
}

In this cases int equals zero. It should be qreal.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 347755] Crash when loading file containing layer with warp transform mask

[Maks Naumov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=347755

Maks Naumov  changed:

   What|Removed |Added

 CC||maksq...@ukr.net

--- Comment #7 from Maks Naumov  ---
(In reply to Dmitry Kazakov from comment #6)
> Git commit 241ddd4ec56b58172e631596696c4ea369e52a05 by Dmitry Kazakov.
> Committed on 14/04/2016 at 14:47.
> Pushed by dkazakov into branch 'master'.
> 
> Make transform mask return a change rect for the non-affine transoforms as
> well

You have two typos in the patch:
QRect KisCageTransformWorker::approxChangeRect(const QRect &rc)
{
const int margin = 0.30;  // 

return KisAlgebra2D::blowRect(resultRect | rc, margin);
}

and

QRect KisLiquifyTransformWorker::approxChangeRect(const QRect &rc)
{
const int margin = 0.05; // 

return KisAlgebra2D::blowRect(resultRect | rc, margin);
}

In this cases int equals zero. It should be qreal.

-- 
You are receiving this mail because:
You are watching all bug changes.