[Spectacle] [Bug 487997] [wayland] Spectacle Rectangular Region Screenshots Saving Larger Resolution and Ringing Artifacts

2024-06-07 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487997

--- Comment #16 from Noah Davis  ---
(In reply to Andrea Ippolito from comment #15)
> By the title of it "scale back" I understand that some back and forth with
> scaling is being performed.
> 
> Is this necessary even when capturing content the falls entirely within one
> screen?
> 
> Isn't it possible to detect that the content falls within the screen
> boundaries, and then just capture according to the characteristics of that
> screen, without the need for further re-scaling?
> 
> (I have no idea about how any of this works, but it just seems strange to me
> having to do some manipulation on the image, when the content the user wants
> to capture has a fully predictable and single scaling/resolution, not a mix
> and match scenario)
> 
> Thanks

Here is how a rectangle screenshot works:
- Capture a screenshot of all screens.
- Have the user select the region they want.

It's basically just a crop of an All Screens screenshot. We *could* have you
select a portion of the screen and *then* capture a snapshot of just that
region, which would allow us to avoid scaling up and down. However, that would
make capturing exactly what you want more difficult. The screen content could
change while you are making your selection and then you'd have to exit
Spectacle and recreate the conditions you were trying to capture. It would also
become impossible to capture menus (Qt Widgets, GTK) in a region screenshot
unless they were drawn inside of a window, like Qt Quick Menus. The way things
currently are, you can take your time deciding which region to select, draw
annotations and even undo/redo the region selection in Spectacle's viewer
window.

If you use the crop tool in the viewer window, you will get exactly the same
result as using the region capture window since they're both doing undoable
crop operations.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487997] [wayland] Spectacle Rectangular Region Screenshots Saving Larger Resolution and Ringing Artifacts

2024-06-07 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487997

--- Comment #14 from Noah Davis  ---
Git commit 64d1a295e6868e5a6762362249dd792bd210162f by Noah Davis.
Committed on 07/06/2024 at 10:25.
Pushed by ndavis into branch 'master'.

ExportManager: Scale back to original scale if possible when writing an image

This way when you have a 1920x1080@1x screen and a 3840x2160@2x screen,
a rectangular screenshot on the 1080p screen gives a 1x scale image instead of
a 2x scale image when the image is finally saved.

M  +30   -2src/ExportManager.cpp

https://invent.kde.org/graphics/spectacle/-/commit/64d1a295e6868e5a6762362249dd792bd210162f

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487997] [wayland] Spectacle Rectangular Region Screenshots Saving Larger Resolution and Ringing Artifacts

2024-06-06 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487997

Noah Davis  changed:

   What|Removed |Added

Summary|[wayland] Spectacle |[wayland] Spectacle
   |Rectangular Region  |Rectangular Region
   |Screenshots Saving Wrong|Screenshots Saving Larger
   |Resolution and Poor Quality |Resolution and Ringing
   ||Artifacts

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487997] [wayland] Spectacle Rectangular Region Screenshots Saving Wrong Resolution and Poor Quality

2024-06-06 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487997

Noah Davis  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |CONFIRMED
 Ever confirmed|0   |1

--- Comment #13 from Noah Davis  ---
(In reply to Eamonn Rea from comment #8)
> Created attachment 170190 [details]
> Region Screenshot - YouTube [Poor Quality]

(In reply to Eamonn Rea from comment #9)
> Created attachment 170191 [details]
> Current Monitor (Cropped) - YouTube [Good Quality]

Besides the obvious image size difference, this example is hard to see
differences with even after downloading. I think I do see some subtle ringing
artifacts around the text.

(In reply to Eamonn Rea from comment #10)
> Created attachment 170192 [details]
> Region Screenshot - Panel [Poor Quality]

(In reply to Eamonn Rea from comment #11)
> Created attachment 170193 [details]
> Current Monitor (Cropped) - Panel [Good Quality]

I can see that the second image is larger and has some ringing artifacts.

The ringing artifacts seem to be from the Lanczos scaling algorithm used when
fractional scaling is used. When screen images are scaled back down to their
original size, that should be pretty much dealt with. I could try a bicubic
(often just called cubic) or bilinear (often just called linear) scaling
algorithm instead.

Lanczos is the fanciest algorithm available in OpenCV, but can cause ringing
artifacts where abrupt color changes occur. Bicubic and Bilinear might be
blurrier than Lanczos. Bilinear might have problems when scaling beyond 2x, but
might be better than bicubic at scales below that.

If you're interested in these kinds of things, check out this gallery:
https://en.wikipedia.org/wiki/Comparison_gallery_of_image_scaling_algorithms
Unfortunately, it doesn't have an example of the Lanczos algorithm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 488028] Screenshot taken at wrong scaling factor when using multi-monitor Wayland with fractional scaling (attachment expires on 11JUN24!)

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=488028

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #6 from Noah Davis  ---
Seems like a duplicate of bug 487997.

*** This bug has been marked as a duplicate of bug 487997 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487997] [wayland] Spectacle Rectangular Region Screenshots Saving Wrong Resolution and Poor Quality

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487997

Noah Davis  changed:

   What|Removed |Added

 CC||andrea.i...@gmail.com

--- Comment #5 from Noah Davis  ---
*** Bug 488028 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487997] [wayland] Spectacle Rectangular Region Screenshots Saving Wrong Resolution and Poor Quality

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487997

--- Comment #4 from Noah Davis  ---
Right now, the expected behavior for All Screens and Rectangular Region
(requires an image of all screens before making a selection) is this:

With one scale factor, combine all screen images into one image with the given
scale factor. Quality an image size should be accurate to what the user sees.
There are a few exceptions, but those shouldn't apply to your case.

With multiple scale factors, the highest scale factor rounded up to the next
integer is used.
This has the following benefits:
- Screen images with integer scale factors remain crisp, event when fractional
scaling is used on some screens.
- Screen images with fractional scales should have decent quality too, but they
can never be perfect.
- Relative screen image positions and sizes match the relative screen positions
and sizes set in the Display Configuration KCM. *Rounding up* the scale factor
is not necessarily required for this. I'm mentioning it because it's important
and it affects what kinds of scaling operations you can make look good.
This has the following downsides:
- A region screenshot entirely within a single screen is unnecessarily large.
This can be improved with
https://invent.kde.org/graphics/spectacle/-/merge_requests/372.
- A region screenshot or all screens screenshot with multiple screens must be a
larger size than the logical size. We have to make tradeoffs and trading file
size for quality seemed acceptable.

In my testing, there were no obvious issues with quality compared to other
methods when using different combinations of fractional scales or integer
scales.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487997] [wayland] Spectacle Rectangular Region Screenshots Saving Wrong Resolution and Poor Quality

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487997

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from Noah Davis  ---
Can you post an image of the "bad" quality screenshots and the screenshot image
files themselves? You can take a screenshot of spectacle using spectacle with
by running `spectacle -i` in the console.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487143] Spectacle doesn't start after plasmashell crashed or restarted

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487143

Noah Davis  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #4 from Noah Davis  ---
Perhaps this is actually a symptom of bug 483137?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 484892] Rectangular selection unusably slow

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=484892

Noah Davis  changed:

   What|Removed |Added

 CC||lomweathe...@gmail.com

--- Comment #9 from Noah Davis  ---
*** Bug 484947 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 484947] Spectacle causes Plasma's taskbar to lag when in background mode with --nonotify.

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=484947

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #5 from Noah Davis  ---
Somehow I missed this report. Looks like a duplicate of bug 484892.

*** This bug has been marked as a duplicate of bug 484892 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 488025] Highlighter tool draws solid color instead of highlighting

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=488025

Noah Davis  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/spectacle/-/commit/dd2 |hics/spectacle/-/commit/0c2
   |231b5b33cc8d124b68eeeacee19 |15c788e38b39b1126af14ab0c6b
   |f20cc009b1  |3187f15711

--- Comment #4 from Noah Davis  ---
Git commit 0c215c788e38b39b1126af14ab0c6b3187f15711 by Noah Davis.
Committed on 05/06/2024 at 18:39.
Pushed by ndavis into branch 'release/24.05'.

AnnotationDocument: Fix highlighter tool not blending with base image

Previously, the graphics were split into a base image and an annotations image.
The change helped to improve CPU performance by not repainting the base image
so much, but it messed up the highlighter effect. The highlighter needs to be
blended with the base image in order to work correctly.

Now the base image is blended into the annotations image in places where the
highlighter is used. This will probably hurt performance somewhat, but it
doesn't seem too bad so far.

(cherry picked from commit dd2231b5b33cc8d124b68eeeacee19f20cc009b1)

Co-authored-by: Noah Davis 

M  +30   -1src/Gui/Annotations/AnnotationDocument.cpp

https://invent.kde.org/graphics/spectacle/-/commit/0c215c788e38b39b1126af14ab0c6b3187f15711

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 488025] Highlighter tool draws solid color instead of highlighting

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=488025

Noah Davis  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/-/commit/dd2
   ||231b5b33cc8d124b68eeeacee19
   ||f20cc009b1
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Noah Davis  ---
Git commit dd2231b5b33cc8d124b68eeeacee19f20cc009b1 by Noah Davis.
Committed on 05/06/2024 at 17:23.
Pushed by ndavis into branch 'master'.

AnnotationDocument: Fix highlighter tool not blending with base image

Previously, the graphics were split into a base image and an annotations image.
The change helped to improve CPU performance by not repainting the base image
so much, but it messed up the highlighter effect. The highlighter needs to be
blended with the base image in order to work correctly.

Now the base image is blended into the annotations image in places where the
highlighter is used. This will probably hurt performance somewhat, but it
doesn't seem too bad so far.

M  +30   -1src/Gui/Annotations/AnnotationDocument.cpp

https://invent.kde.org/graphics/spectacle/-/commit/dd2231b5b33cc8d124b68eeeacee19f20cc009b1

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 488025] Highlighter tool draws solid color instead of highlighting

2024-06-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=488025

Noah Davis  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Noah Davis  ---
Oof, looks like a major optimization that was made months before the release of
24.05 caused this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487802] Spectacle not taking screenshots correctly KDE6

2024-05-31 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487802

Noah Davis  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487802] Spectacle not taking screenshots correctly KDE6

2024-05-30 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487802

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Noah Davis  ---
[a message so I can set NEEDSINFO since I forgot to do that with the previous
message]

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487802] Spectacle not taking screenshots correctly KDE6

2024-05-30 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487802

--- Comment #1 from Noah Davis  ---
Do you happen to have the following file on your system? If you do, does
deleting the file and rebooting fix the problem?
~/.local/share/applications/org.kde.spectacle.desktop

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487740] When making text annotations, after selecting the text, pressing Ctrl+C will copy both the selected text and the whole screenshot to the clipboard

2024-05-30 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487740

Noah Davis  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/-/commit/04c
   ||bb5d6997f912b784d68654301d0
   ||8f1eb24452
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Noah Davis  ---
Git commit 04cbb5d6997f912b784d68654301d08f1eb24452 by Noah Davis.
Committed on 30/05/2024 at 16:58.
Pushed by ndavis into branch 'master'.

Prevent TextTool TextEdit shortcuts from being used by the window while
TextTool is focused

M  +19   -31   src/Gui/CaptureWindow.cpp
M  +0-1src/Gui/CaptureWindow.h
M  +19   -31   src/Gui/ViewerWindow.cpp
M  +0-1src/Gui/ViewerWindow.h

https://invent.kde.org/graphics/spectacle/-/commit/04cbb5d6997f912b784d68654301d08f1eb24452

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 483155] [wayland] Spectacle Rectangle Select has Inaccurate Sizing on Multi-Screen Multi-Scale Configurations

2024-05-29 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=483155

--- Comment #5 from Noah Davis  ---
If you are experiencing a new issue, can you post a new bug report so that we
can track it properly?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482750] [wayland] Spectacle Rectangle Select / Multi-Display screenshots blurry on unscaled displays when scaled display in use

2024-05-29 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=482750

--- Comment #8 from Noah Davis  ---
If you are experiencing a new issue, can you post a new bug report so that we
can track it properly?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 487630] doesn't respect configured default file manager application

2024-05-29 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487630

Noah Davis  changed:

   What|Removed |Added

 CC||noaha...@gmail.com
  Component|URL navigator   |general

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 487630] doesn't respect configured default file manager application

2024-05-29 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487630

Noah Davis  changed:

   What|Removed |Added

Product|Spectacle   |frameworks-kio
  Component|General |URL navigator
 CC||kdelibs-b...@kde.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
   Assignee|noaha...@gmail.com  |kio-bugs-n...@kde.org
Version|24.02.2 |6.2.0

--- Comment #1 from Noah Davis  ---
Can confirm with git master Spectacle (24.07.70) and KIO (6.3.0). Spectacle
uses KIO to do that, so I'm moving this to KIO.

Relevant code:

>void SpectacleWindow::openContainingFolder(const QUrl )
>{
>KIO::highlightInFileManager({url});
>}

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487739] [Feature request] [Regression] Make annotations copy-and-pastable again

2024-05-29 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487739

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487599] Multiple screenshots slow down the system and almost freeze

2024-05-26 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487599

--- Comment #1 from Noah Davis  ---
> When pressing the keyboard shortcut while a screenshot is running, this 
> screenshot should be aborted and a new one created. 

Unfortunately, it already behaves the way you described for me. I cannot
reproduce this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487539] Spectacle makes black screen unless I close it.

2024-05-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487539

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Noah Davis  ---
What is your Spectacle version? Spectacle is not on Plasma's release schedule,
so the version numbers are different.
Are you on X11 or Wayland?
If you are on X11, is KWin your window manager?  If you didn't change your
window manager, the answer is probably yes.
I am currently unable to reproduce this bug with the latest git master version
or the recently released 24.05 version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 484733] Spectable crashes when we record several times a video

2024-05-24 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=484733

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #2 from Noah Davis  ---
Seems like a duplicate of bug 469336.

*** This bug has been marked as a duplicate of bug 469336 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 469336] Crash in ViewerWindow::showInlineMessage() When Trying to Record Screen With Spectacle

2024-05-24 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=469336

Noah Davis  changed:

   What|Removed |Added

 CC||fabrice.salva...@orange.fr

--- Comment #14 from Noah Davis  ---
*** Bug 484733 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487475] Unexpected crash

2024-05-24 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487475

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |BACKTRACE
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Noah Davis  ---
Cannot reproduce, no KDE code is implicated in what I can see from the
backtrace, and the backtrace has no debug symbols for anything that would help.
:(
If this crash is reproducible, could you please install debug symbols,
reproduce the crash, and attach a new symbolicated backtrace? See
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 445084] Subdirectory Placeholder is forgotten if another placeholder comes after it and is empty.

2024-05-23 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=445084

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/-/commit/183
   ||43ecc9d56993312c5bf3e073264
   ||c099b4726c
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Noah Davis  ---
Git commit 18343ecc9d56993312c5bf3e073264c099b4726c by Noah Davis.
Committed on 24/05/2024 at 05:08.
Pushed by ndavis into branch 'master'.

ExportManager: keep dir separators near 

M  +36   -11   src/ExportManager.cpp
M  +9-4tests/FilenameTest.cpp

https://invent.kde.org/graphics/spectacle/-/commit/18343ecc9d56993312c5bf3e073264c099b4726c

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 477292] Request - Create Flatpak of Spectacle, also put on FlatHub

2024-05-20 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=477292

--- Comment #3 from Noah Davis  ---
There is some work toward re-adding flatpak nightly builds for spectacle:
https://invent.kde.org/graphics/spectacle/-/merge_requests/314
Unfortunately, the flatpak version can't actually take screenshots. If someone
with flatpak expertise could help make the flatpak built from the linked MR
usable, that would be helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487297] The "spectacle" program crashes when the time zone is set incorrectly

2024-05-20 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487297

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |BACKTRACE

--- Comment #1 from Noah Davis  ---
Can you please attach a backtrace of the crash using the coredumpctl
command-line program, as detailed in
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports#Retrieving_a_backtrace_using_coredumpctl?
I'm wondering if the issue comes from spectacle itself or a library we use.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487143] Spectacle doesn't start after plasmashell crashed or restarted

2024-05-17 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487143

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Noah Davis  ---
How are you crashing or restarting plasmashell? I cannot reproduce this with
`systemctl --user restart plasma-plasmashell.service` or `plasmashell
--replace`.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486805] Spectacle cannot take screenshots on my secondary monitor

2024-05-17 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486805

Noah Davis  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |DUPLICATE
 Status|NEEDSINFO   |RESOLVED

--- Comment #4 from Noah Davis  ---
seems like a duplicate then

*** This bug has been marked as a duplicate of bug 485352 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 485352] ScreenShot2 CaptureScreen DBus timeout on X11

2024-05-17 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485352

Noah Davis  changed:

   What|Removed |Added

 CC||saraistup...@gmail.com

--- Comment #12 from Noah Davis  ---
*** Bug 486805 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487107] Error message says "Could not take a screenshot" when selecting Rectangular Region.

2024-05-16 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487107

Noah Davis  changed:

   What|Removed |Added

Version|unspecified |21.12.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487107] Error message says "Could not take a screenshot" when selecting Rectangular Region.

2024-05-16 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487107

Noah Davis  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |UNMAINTAINED
 Status|NEEDSINFO   |RESOLVED

--- Comment #3 from Noah Davis  ---
Unfortunately, version 21.12.3 is no longer supported. I'm not sure what the
problem could be caused by. Spectacle actually doesn't work on GNOME with
Wayland, so using KDE Plasma shouldn't be the issue. I'm not aware of a system
tray icon for Spectacle in any version before 24.02 though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487107] Error message says "Could not take a screenshot" when selecting Rectangular Region.

2024-05-16 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487107

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Noah Davis  ---
What version of Spectacle are you using?

What is your system information? Go to System Settings->About this System and
click Copy Details to get the system info.

Can you give me exact steps to reproduce the issue? For instance, in what way
are you taking a rectangular screenshot? Button in the window? Global shortcut?
Command line?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 483320] Empty breaks other placeholders nearby

2024-05-16 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=483320

Noah Davis  changed:

   What|Removed |Added

   Version Fixed In||24.05

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 483320] Empty breaks other placeholders nearby

2024-05-16 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=483320

--- Comment #34 from Noah Davis  ---
(In reply to 0BADC0DE from comment #33)
> Not sure what you are talking about.
> Besides the window title (which was already there) what will we have new to
> `strftime(3)` ?
> Anyway, it's nice it is being fixed:  is not working yet.

The new features are in 24.05. Again, strftime was never used. The syntax only
looked similar.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 485629] [Wayland/Recording] Hangs when trying to finish a recording for a window which has been closed mid record

2024-05-16 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485629

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||24.05

--- Comment #2 from Noah Davis  ---
Fixed in 24.05

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486805] Spectacle cannot take screenshots on my secondary monitor

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486805

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #2 from Noah Davis  ---
Are you on X11?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486805] Spectacle cannot take screenshots on my secondary monitor

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486805

--- Comment #1 from Noah Davis  ---
Possibly a duplicate of bug 485352

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486116] Discover does not respect screenshot delay

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486116

Noah Davis  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |DUPLICATE
 Status|NEEDSINFO   |RESOLVED

--- Comment #3 from Noah Davis  ---


*** This bug has been marked as a duplicate of bug 487067 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487067] Spectacle ignores delay option in main window

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487067

Noah Davis  changed:

   What|Removed |Added

 CC||anditosan1...@gmail.com

--- Comment #2 from Noah Davis  ---
*** Bug 486116 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 487067] Spectacle ignores delay option in main window

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=487067

--- Comment #1 from Noah Davis  ---
Unfortunately, I cannot reproduce this on openSUSE Tumbleweed 240507 with 24.02
or git master. I've seen a few similar reports from other people, including
someone who was on Fedora (bug 486116) and someone who was on Tuxedo OS2 with
Spectacle 23.08.4 (bug 485240).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 483320] Empty breaks other placeholders nearby

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=483320

Noah Davis  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/spectacle/-/commit/8d2 |hics/spectacle/-/commit/cac
   |e0641af5bda4b7684d8d3da176f |40b6fe828fa71dd3182b2f6839d
   |71e8b5c523  |49e9030dd0

--- Comment #32 from Noah Davis  ---
Git commit cac40b6fe828fa71dd3182b2f6839d49e9030dd0 by Noah Davis.
Committed on 15/05/2024 at 20:47.
Pushed by ndavis into branch 'release/24.05'.

Fix empty  placeholders breaking nearby placeholders
(cherry picked from commit 8d2e0641af5bda4b7684d8d3da176f71e8b5c523)

M  +11   -5src/ExportManager.cpp
M  +9-0tests/FilenameTest.cpp

https://invent.kde.org/graphics/spectacle/-/commit/cac40b6fe828fa71dd3182b2f6839d49e9030dd0

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 484211] Spectacle should convert old format string in filename

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=484211

Noah Davis  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/spectacle/-/commit/a80 |hics/spectacle/-/commit/ee7
   |0768c564e2059c5a1fd8fd00dc7 |0c5027f3a4de4c1762c0975ca8a
   |afed0d0dc2  |0461b6f4e3

--- Comment #9 from Noah Davis  ---
Git commit ee70c5027f3a4de4c1762c0975ca8a0461b6f4e3 by Noah Davis.
Committed on 15/05/2024 at 20:47.
Pushed by ndavis into branch 'release/24.05'.

Always convert old placeholder format to new placeholder format when new format
is not used
(cherry picked from commit a800768c564e2059c5a1fd8fd00dc7afed0d0dc2)

M  +3-5kconf_update/spectacle-24.02.0-change_placeholder_format.cpp

https://invent.kde.org/graphics/spectacle/-/commit/ee70c5027f3a4de4c1762c0975ca8a0461b6f4e3

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 484211] Spectacle should convert old format string in filename

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=484211

Noah Davis  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/-/commit/a80
   ||0768c564e2059c5a1fd8fd00dc7
   ||afed0d0dc2

--- Comment #8 from Noah Davis  ---
Git commit a800768c564e2059c5a1fd8fd00dc7afed0d0dc2 by Noah Davis.
Committed on 15/05/2024 at 20:42.
Pushed by ndavis into branch 'master'.

Always convert old placeholder format to new placeholder format when new format
is not used

M  +3-5kconf_update/spectacle-24.02.0-change_placeholder_format.cpp

https://invent.kde.org/graphics/spectacle/-/commit/a800768c564e2059c5a1fd8fd00dc7afed0d0dc2

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 483320] Empty breaks other placeholders nearby

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=483320

--- Comment #31 from Noah Davis  ---
(In reply to 0BADC0DE from comment #30)
> I would revert back to the previous %-based syntax.
> 
> Honestly this move just broke something that was working fine without adding
> any extra feature.

Objectively not true. There are a bunch of new placeholders that couldn't be
added with the old syntax.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 483320] Empty breaks other placeholders nearby

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=483320

Noah Davis  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/-/commit/8d2
   ||e0641af5bda4b7684d8d3da176f
   ||71e8b5c523

--- Comment #29 from Noah Davis  ---
Git commit 8d2e0641af5bda4b7684d8d3da176f71e8b5c523 by Noah Davis.
Committed on 15/05/2024 at 17:22.
Pushed by ndavis into branch 'master'.

Fix empty  placeholders breaking nearby placeholders

M  +11   -5src/ExportManager.cpp
M  +9-0tests/FilenameTest.cpp

https://invent.kde.org/graphics/spectacle/-/commit/8d2e0641af5bda4b7684d8d3da176f71e8b5c523

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 483320] Empty breaks other placeholders nearby

2024-05-15 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=483320

Noah Davis  changed:

   What|Removed |Added

Summary|It doesn't interpret the|Empty  breaks other
   |last placeholder while  |placeholders nearby
   |saving screenshots  |

--- Comment #27 from Noah Davis  ---
It seems like there's no clear way to determine which kinds of characters count
as separators that should be removed and which shouldn't

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486978] en gnome no funciona en kde plasma si lo hace

2024-05-13 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486978

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Noah Davis  ---


*** This bug has been marked as a duplicate of bug 451842 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 451842] Spectacle Won't Work on Fedora - on Gnome

2024-05-13 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=451842

Noah Davis  changed:

   What|Removed |Added

 CC||juram...@gmail.com

--- Comment #7 from Noah Davis  ---
*** Bug 486978 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486165] Only part of the "Save as" and "Annotation" toolbars are visible taking screenshot on dual monitor setup

2024-05-12 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486165

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #6 from Noah Davis  ---
I can confirm this. This may be a duplicate of another report, but I will wait
until I'm sure to mark it as such.

-- 
You are receiving this mail because:
You are watching all bug changes.

[KPipeWire] [Bug 476866] KPipeWire turns on the discrete GPU on a multi-GPU laptop on startup, slowing it down and using extra energy

2024-05-11 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=476866

Noah Davis  changed:

   What|Removed |Added

 CC||noaha...@gmail.com
Summary|Spectacle turns on the  |KPipeWire turns on the
   |discrete GPU on a multi-GPU |discrete GPU on a multi-GPU
   |laptop on startup, slowing  |laptop on startup, slowing
   |it down and using extra |it down and using extra
   |energy  |energy

-- 
You are receiving this mail because:
You are watching all bug changes.

[KPipeWire] [Bug 476866] Spectacle turns on the discrete GPU on a multi-GPU laptop on startup, slowing it down and using extra energy

2024-05-11 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=476866

Noah Davis  changed:

   What|Removed |Added

Version|24.01.75|unspecified
  Component|General |general
 CC||aleix...@kde.org
Product|Spectacle   |KPipeWire
   Assignee|noaha...@gmail.com  |plasma-b...@kde.org

--- Comment #14 from Noah Davis  ---
Let's move it to KPipeWire

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486847] [Wayland] Wrong screenshot resolution when scaling enabled in multi monitor configuration

2024-05-10 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486847

Noah Davis  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INTENTIONAL

--- Comment #3 from Noah Davis  ---
Issues with image blurriness should be improved in version 24.05, but All
Screens and Rectangular Region always require compromises when there are
different scale factors involved. This is because we try to make the layout of
the screen images match the layout of your screens. Otherwise, there is no
clear way to combine the images. In 24.05, we now round the scale factors up to
the next integer scale factor to preserve sharpness. This means your
1920x1080@125% screen would have a 3840x2160 image, unless you used the Current
Screen mode instead. The reason why Current Screen always has the real
resolution is because we don't have to worry about the layout of screens when
taking only one screen.

This unfortunately means that the resolution not matching your real resolution
is intentional when using All Screens and Rectangular Region. Perhaps
Rectangular Region could be improved by scaling the image down to the original
screen scale when the rectangular area is only on one screen, although we don't
have an easy way to do that right now. I'm marking this issue as Resolved
Intentional because it was originally about image resolution vs screen
resolution with All Screens and Rectangular Region.

If you want someone to investigate adding the improvement for Rectangular
Region I mentioned, you could make a new report specifically about that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486847] [Wayland] Wrong screenshot resolution when scaling enabled in multi monitor configuration

2024-05-10 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486847

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Noah Davis  ---
Which mode are you using to capture the screenshot?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 480023] Add a GUI for stopping region recording besides the systray when started from the viewer window

2024-05-09 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=480023

--- Comment #11 from Noah Davis  ---
Git commit da86ecb98673386a154e466dabb751ddf43c31cf by Noah Davis.
Committed on 09/05/2024 at 17:11.
Pushed by ndavis into branch 'master'.

Make system tray icon easier to notice

Switches from QSystemTrayIcon to KStatusNotifierItem.

The icon has a scale animation when it appears that repeats a few times.

A system notification also appears when recording has started that tells you
about the system tray icon.

M  +1-0.kde-ci.yml
M  +1-0CMakeLists.txt
M  +1-0src/CMakeLists.txt
M  +77   -15   src/SpectacleCore.cpp

https://invent.kde.org/graphics/spectacle/-/commit/da86ecb98673386a154e466dabb751ddf43c31cf

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 485096] When default screenshot format is JPEG, screenshots copied to the clipboard cannot be pasted until Spectacle quits

2024-05-08 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485096

--- Comment #5 from Noah Davis  ---
*** Bug 486658 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486658] Spectacle not copying to clipboard

2024-05-08 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486658

Noah Davis  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |DUPLICATE
 Status|NEEDSINFO   |RESOLVED

--- Comment #8 from Noah Davis  ---
(In reply to Kalcifer from comment #7)
> > Just to be clear, you are unable to paste a JPEG even after closing 
> > Spectacle?
> 
> Ah, my bad — I misread the reported issue. So, for clarity, after I close
> spectacle, I am able to paste the image — I am not able to paste an image
> with spectacle open. Given that that is the case, it seems strange that
> using a shortcut to capture a rectangular region to the clipboard doesn't
> count as Spectacle being closed since the spectacle app was never opened to
> begin with.

It was opened, just not the way you normally think of.

Given that the behavior you see is like the behavior in bug 485096 where
pasting only works after spectacle's process ends, I think this is a duplicate
after all.

*** This bug has been marked as a duplicate of bug 485096 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486658] Spectacle not copying to clipboard

2024-05-08 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486658

--- Comment #6 from Noah Davis  ---
(In reply to Kalcifer from comment #5)
> I don't think this is a duplicate of
> https://bugs.kde.org/show_bug.cgi?id=485096 — I can't even reproduce that
> bug. It just seems that some image formats won't copy to the clipboard. I
> have also found this behaviour with WebP; however, PNG is able to copy to
> the clipboard.

Just to be clear, you are unable to paste a JPEG even after closing Spectacle?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486658] Spectacle not copying to clipboard

2024-05-06 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486658

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #4 from Noah Davis  ---
(In reply to Nate Graham from comment #3)
> 
> *** This bug has been marked as a duplicate of bug 485096 ***

Sorry Nate, I should have marked this as NEEDSINFO. We don't know for sure if
it's a duplicate yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486658] Spectacle not copying to clipboard

2024-05-06 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486658

Noah Davis  changed:

   What|Removed |Added

 Status|RESOLVED|REPORTED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486658] Spectacle not copying to clipboard

2024-05-06 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486658

--- Comment #2 from Noah Davis  ---
Is this a duplicate of bug 485096?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482467] Spectacle's "Rectangular Region" overlay isn't initially focused when opening, making it interact badly with "Activate and raise" left click window action

2024-05-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=482467

Noah Davis  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/spectacle/-/commit/d39 |hics/spectacle/-/commit/3e1
   |73de254fe7b0f89c9f320836832 |bd55dfac7defe9870341dfdc17b
   |fa4f0dd7fc  |52b6ae9fd9

--- Comment #3 from Noah Davis  ---
Git commit 3e1bd55dfac7defe9870341dfdc17b52b6ae9fd9 by Noah Davis.
Committed on 05/05/2024 at 21:40.
Pushed by ndavis into branch 'release/24.05'.

Raise and activate capture windows when shown

This code is in QML instead of C++ because you can't get the global mouse pos
from QCursor on wayland. We need to get the mouse pos within the window and QML
was the easiest place to get it.

(cherry picked from commit d3973de254fe7b0f89c9f320836832fa4f0dd7fc)

M  +12   -0src/Gui/ImageCaptureOverlay.qml
M  +12   -0src/Gui/VideoCaptureOverlay.qml

https://invent.kde.org/graphics/spectacle/-/commit/3e1bd55dfac7defe9870341dfdc17b52b6ae9fd9

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482467] Spectacle's "Rectangular Region" overlay isn't initially focused when opening, making it interact badly with "Activate and raise" left click window action

2024-05-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=482467

Noah Davis  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/-/commit/d39
   ||73de254fe7b0f89c9f320836832
   ||fa4f0dd7fc
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Noah Davis  ---
Git commit d3973de254fe7b0f89c9f320836832fa4f0dd7fc by Noah Davis.
Committed on 05/05/2024 at 20:32.
Pushed by ndavis into branch 'master'.

Raise and activate capture windows when shown

This code is in QML instead of C++ because you can't get the global mouse pos
from QCursor on wayland. We need to get the mouse pos within the window and QML
was the easiest place to get it.

M  +12   -0src/Gui/ImageCaptureOverlay.qml
M  +12   -0src/Gui/VideoCaptureOverlay.qml

https://invent.kde.org/graphics/spectacle/-/commit/d3973de254fe7b0f89c9f320836832fa4f0dd7fc

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 481391] When a user has a panel on the top of the screen, rectangular area screencasts are recorded in the wrong location

2024-05-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=481391

Noah Davis  changed:

   What|Removed |Added

 CC||sunan...@riseup.net

--- Comment #9 from Noah Davis  ---
*** Bug 482747 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482747] Screencasting a region with Spectacle: the overlay that shows which part of the screen is being screencast is shifted downward

2024-05-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=482747

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Noah Davis  ---


*** This bug has been marked as a duplicate of bug 481391 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 482174] Window header gets bugged when window resized

2024-05-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=482174

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #2 from Noah Davis  ---
Unfortunately, there's not really anything I can do about this. This happens to
all Qt Quick apps. It's probably a Qt bug, but it could be a KWin bug if you're
on Wayland.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486615] split the "edit screenshot" stuff into a separate package to be reused

2024-05-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486615

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Noah Davis  ---
Yes, during development of the new version of spectacle, turning the new
annotation system into reusable components was brought up as something
desirable. It would probably need more cleaning up in order to turn it into a
library with stable API. Before it is made into a library with stable API, I
think that at least one other app should implement a UI using the components.
Preferably two, but there might not be enough apps that need these components.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 483140] The Default/Custom shortcut for "Capture Active Window" does not work.

2024-05-01 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=483140

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Noah Davis  ---
Unfortunately, I cannot reproduce this. Since you can't reproduce this anymore,
I will mark this as resolved. Feel free to file another report if you encounter
the issue again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 485733] Spectacle fails to save recorded video with error

2024-05-01 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485733

--- Comment #6 from Noah Davis  ---
What are your settings for recording? Where are you saving your recording to?
Is your /tmp folder a local folder?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486116] Discover does not respect screenshot delay

2024-05-01 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486116

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Noah Davis  ---
Wait, Discover? As in the app store?

If you meant to write Spectacle, this is likely a duplicate of bug 485240.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 485733] Spectacle fails to save recorded video with error

2024-05-01 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485733

Noah Davis  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from Noah Davis  ---
.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 485733] Spectacle fails to save recorded video with error

2024-05-01 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485733

--- Comment #3 from Noah Davis  ---
Are you using X11? Spectacle does not currently support recording on X11. I
once saw that error when trying to record on X11 (I was testing things).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 485988] [Feature request] Escape while selecting region doesn't quit, but brings up main window

2024-04-29 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485988

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |INTENTIONAL
 Status|REPORTED|RESOLVED

--- Comment #5 from Noah Davis  ---
No problem

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 479746] Crash when Spectacle plays a screen recording

2024-04-29 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=479746

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Noah Davis  ---
Is this still a problem for you? I cannot reproduce this on git master or the
24.05 branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 476866] Spectacle turns on the discrete GPU on a multi-GPU laptop on startup, slowing it down and using extra energy

2024-04-29 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=476866

--- Comment #12 from Noah Davis  ---
Git commit 445fc422dae9d1e6c702098b74ace66a5e226faf by Noah Davis.
Committed on 29/04/2024 at 15:57.
Pushed by ndavis into branch 'release/24.05'.

VideoPlatformWayland: Get PipeWireRecord asynchronously

Speeds up startup by 60-80ms


(cherry picked from commit b1686ee96cd62f78dc4cf6cf92d6580376b51250)

M  +4-2src/Platforms/VideoPlatform.h
M  +17   -7src/Platforms/VideoPlatformWayland.cpp
M  +2-0src/Platforms/VideoPlatformWayland.h

https://invent.kde.org/graphics/spectacle/-/commit/445fc422dae9d1e6c702098b74ace66a5e226faf

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 484038] Make it clear that screen recording isn't supported on X11

2024-04-29 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=484038

Noah Davis  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/spectacle/-/commit/c88 |hics/spectacle/-/commit/427
   |3008bd685383b55302e1040d491 |45d25d09b23922ff572d6ea41ba
   |51a1e7e61a  |2df3ca66ad

--- Comment #4 from Noah Davis  ---
Git commit 42745d25d09b23922ff572d6ea41ba2df3ca66ad by Noah Davis.
Committed on 29/04/2024 at 15:57.
Pushed by ndavis into branch 'release/24.05'.

Improve feedback when recording is not available

(cherry picked from commit c883008bd685383b55302e1040d49151a1e7e61a)

M  +4-0src/Platforms/PlatformLoader.cpp
M  +8-9src/Platforms/PlatformNull.cpp
M  +3-2src/Platforms/PlatformNull.h
M  +4-0src/Platforms/VideoPlatformWayland.cpp

https://invent.kde.org/graphics/spectacle/-/commit/42745d25d09b23922ff572d6ea41ba2df3ca66ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 485988] [Feature request] Escape while selecting region doesn't quit, but brings up main window

2024-04-28 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485988

--- Comment #3 from Noah Davis  ---
(In reply to John from comment #2)
> I had followed the entry in the .desktop file for 
> RectangularRegionScreenShot, which is just -r (which now I look closer 
> actually does seem to instantly dismiss from the Plasma shortcut, but not 
> from the command line!)

I'm not completely sure why the behavior is different, but I'm pretty sure the
reason why is that spectacle is launched from a DBus service when you activate
those desktop file shortcuts. In that situation, spectacle behaves as if it was
activated via a global shortcut, which is intentional.

If you want to understand how to use spectacle via the command line, it is
better to run `spectacle --help`. It also says that GUI mode is the default
mode there: "  -g, --gui   Start in GUI mode
(default)"

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486225] Spectacle won't launch at all because of Python?

2024-04-27 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486225

--- Comment #3 from Noah Davis  ---
(In reply to Poci from comment #2)
> (In reply to Noah Davis from comment #1)
> > How strange. Spectacle doesn't even use python.
> 
> ... huh. Likely to be packaging issue on Arch's end then? I would go report
> it, but I don't have an account.

I checked pkgs.org and the Arch package doesn't seem to depend on python
either, but I didn't exhaust every possiblity. I'd still report the issue to
Arch though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486225] Spectacle won't launch at all because of Python?

2024-04-27 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486225

--- Comment #1 from Noah Davis  ---
How strange. Spectacle doesn't even use python.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486165] Only part of the "Save as" and "Annotation" toolbars are visible taking screenshot on dual monitor setup

2024-04-27 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486165

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Noah Davis  ---
Can you post your system settings screen layout with resolutions and scale
factors?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 485988] [Feature request] Escape while selecting region doesn't quit, but brings up main window

2024-04-26 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485988

--- Comment #1 from Noah Davis  ---
> But if there's a use case for getting Spectacle appearing after Escape that 
> I'm not sensitive to, it could be a separate config item?

The use case is currently, "opened spectacle window, then decided to do
rectangle capture, then decided not to" and also because the old spectacle
(22.12) used to go back when you pressed escape. Not sure if the current
behavior is exactly the same as the old though.

In most cases, starting in rectangle capture mode and pressing escape already
quits spectacle. There are currently only two cases I can think of where it's
possible to start in rectangle capture mode without completely exiting when you
press escape:

- Launching spectacle from the command line with `spectacle -r`. Note the
absence of the `-b`/`--background` option. Unless you explicitly put a
different start mode, spectacle will use GUI mode.
- Launching spectacle from either an app menu or the Print key with the "Use
last-used capture mode" setting.

It may be possible to tweak the behavior for those cases.
We have the ability to know when `-r` was specified, so we could potentially
make Spectacle exit on pressing Escape when it was started with `-r`.
I'm more hesitant to change the behavior for the "Use last-used capture mode"
setting because that setting makes it a bit more inconvenient to pick other
capture modes when started in rectangle capture mode. There's still the Options
menu for changing capture modes though, so it's not like you'd be stuck in the
rectangle capture mode either way.

I wouldn't want to make the behavior depend on "Quit after manual Save or Copy"
because pressing Escape is not a manual save or copy. Perhaps the setting name
doesn't quite match with the average user's true desires, perhaps it does.

I'm not a fan of adding yet another setting, but I'm not totally against it.
Figuring out a good way to present a setting is important when adding it and
the current organization of keyboard input related settings could be better.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 473879] Preview when using the rectangular region tool is offset to the right.

2024-04-26 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=473879

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #8 from Noah Davis  ---
(In reply to ezh from comment #7)
> Created attachment 168921 [details]
> Screenshot of the problem
> 
> Is my case the same issue? See screenshot.

It's hard to tell what I'm looking at, but it doesn't look like the problem
described by the original reporter.

Marking this as fixed. There's a different report that this one is probably a
duplicate of, but I can't find it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 476866] Spectacle turns on the discrete GPU on a multi-GPU laptop on startup, slowing it down and using extra energy

2024-04-26 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=476866

--- Comment #11 from Noah Davis  ---
Git commit b1686ee96cd62f78dc4cf6cf92d6580376b51250 by Noah Davis.
Committed on 26/04/2024 at 14:18.
Pushed by ndavis into branch 'master'.

VideoPlatformWayland: Get PipeWireRecord asynchronously

Speeds up startup by 60-80ms

M  +4-2src/Platforms/VideoPlatform.h
M  +17   -7src/Platforms/VideoPlatformWayland.cpp
M  +2-0src/Platforms/VideoPlatformWayland.h

https://invent.kde.org/graphics/spectacle/-/commit/b1686ee96cd62f78dc4cf6cf92d6580376b51250

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 484038] Make it clear that screen recording isn't supported on X11

2024-04-26 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=484038

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/-/commit/c88
   ||3008bd685383b55302e1040d491
   ||51a1e7e61a

--- Comment #3 from Noah Davis  ---
Git commit c883008bd685383b55302e1040d49151a1e7e61a by Noah Davis.
Committed on 26/04/2024 at 11:15.
Pushed by ndavis into branch 'master'.

Improve feedback when recording is not available

M  +4-0src/Platforms/PlatformLoader.cpp
M  +8-9src/Platforms/PlatformNull.cpp
M  +3-2src/Platforms/PlatformNull.h
M  +4-0src/Platforms/VideoPlatformWayland.cpp

https://invent.kde.org/graphics/spectacle/-/commit/c883008bd685383b55302e1040d49151a1e7e61a

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486118] Two screens are not close to each other on X11

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486118

Noah Davis  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/spectacle/-/commit/bfb |hics/spectacle/-/commit/d1c
   |ecb0720f18b3d0342670b76bd19 |15faa45ba1459009248555f4180
   |bb5f42cec3  |0a534c6844

--- Comment #7 from Noah Davis  ---
Git commit d1c15faa45ba1459009248555f41800a534c6844 by Noah Davis.
Committed on 26/04/2024 at 02:24.
Pushed by ndavis into branch 'release/24.05'.

ImagePlatformKWin: Use logical positions for images in combinedImage on X11
(cherry picked from commit bfbecb0720f18b3d0342670b76bd19bb5f42cec3)

M  +46   -21   src/Platforms/ImagePlatformKWin.cpp

https://invent.kde.org/graphics/spectacle/-/commit/d1c15faa45ba1459009248555f41800a534c6844

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486118] Two screens are not close to each other on X11

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486118

Noah Davis  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/-/commit/bfb
   ||ecb0720f18b3d0342670b76bd19
   ||bb5f42cec3
 Resolution|--- |FIXED

--- Comment #6 from Noah Davis  ---
Git commit bfbecb0720f18b3d0342670b76bd19bb5f42cec3 by Noah Davis.
Committed on 25/04/2024 at 20:32.
Pushed by ndavis into branch 'master'.

ImagePlatformKWin: Use logical positions for images in combinedImage on X11

M  +46   -21   src/Platforms/ImagePlatformKWin.cpp

https://invent.kde.org/graphics/spectacle/-/commit/bfbecb0720f18b3d0342670b76bd19bb5f42cec3

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 485352] ScreenShot2 CaptureScreen DBus timeout on X11

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485352

Noah Davis  changed:

   What|Removed |Added

 CC||qydwhotm...@gmail.com

--- Comment #11 from Noah Davis  ---
*** Bug 485959 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 485959] Spectacle doesn't open when there are two screens

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485959

Noah Davis  changed:

   What|Removed |Added

 CC||noaha...@gmail.com
 Resolution|FIXED   |DUPLICATE

--- Comment #6 from Noah Davis  ---
Marking as a duplicate of bug 485352 since that one came first

*** This bug has been marked as a duplicate of bug 485352 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 485352] ScreenShot2 CaptureScreen DBus timeout on X11

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485352

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
   Version Fixed In||6.1
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/-/commit/bc29e09d88
   ||2d13a3a099867ba869742cd2fdb
   ||478

--- Comment #10 from Noah Davis  ---
Fixed in KWin 6.1:
https://invent.kde.org/plasma/kwin/-/commit/bc29e09d882d13a3a099867ba869742cd2fdb478
Also cherry-picked to 6.0:
https://invent.kde.org/plasma/kwin/-/commit/5d9a0aa8920b9514061b616f97ae7277a2d619a5

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 485352] ScreenShot2 CaptureScreen DBus timeout on X11

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485352

Noah Davis  changed:

   What|Removed |Added

 CC||noaha...@gmail.com
Summary|DBus timeout on X11 |ScreenShot2 CaptureScreen
   ||DBus timeout on X11

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 431790] Maximized windows switch to 2nd screen after it turns on

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=431790

--- Comment #6 from Noah Davis  ---
Seems to be fixed. When turning on the second screen, windows will redo their
maximize animation twice, but that's a separate issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486118] Two screens are not close to each other on X11

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486118

--- Comment #3 from Noah Davis  ---
never mind the last question

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486118] Two screens are not close to each other on X11

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486118

--- Comment #2 from Noah Davis  ---
Also, X11 or wayland?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 486118] Two screens are not close to each other on X11

2024-04-25 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=486118

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Noah Davis  ---
Can you post a screenshot and your screen arrangement with resolutions and
scale factors?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 485499] Separate option for clipboard file type

2024-04-23 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=485499

--- Comment #2 from Noah Davis  ---
Actually, I might have been a bit hasty marking as a duplicate. Do you
specifically want a setting just like the existing setting for save formats? Is
that just an idea you came up with that fits your needs but not something you
specifically need? The bug I marked this as a duplicate of is "Add the ability
to Copy to clipboard as a specific image format"

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 447831] Add the ability to Copy to clipboard as a specific image format

2024-04-23 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=447831

Noah Davis  changed:

   What|Removed |Added

 CC||jeffreyzhang...@gmail.com

--- Comment #10 from Noah Davis  ---
*** Bug 485499 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   4   5   6   7   8   9   10   >