[frameworks-kirigami] [Bug 469978] New: Kirigami.Icon rendering black on Android

2023-05-19 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=469978

Bug ID: 469978
   Summary: Kirigami.Icon rendering black on Android
Classification: Frameworks and Libraries
   Product: frameworks-kirigami
   Version: 5.106.0
  Platform: Android
OS: Android 13.x
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kdelibs-b...@kde.org
  Reporter: remgg...@gmail.com
CC: notm...@gmail.com
  Target Milestone: Not decided

Created attachment 159094
  --> https://bugs.kde.org/attachment.cgi?id=159094&action=edit
Peruse running on Android 13 with black Thumbnails

SUMMARY
When using Kirigami.Icon on Android are rendered black. When using Qt's Image
Component they are rendered correctly. Related discuss.kde.org Thread:
https://discuss.kde.org/t/question-regarding-kirigami-on-android/1498?u=malrak
The Kirigami.Icon's are loaded via an AsyncImageProvider.

STEPS TO REPRODUCE
1. Build
https://invent.kde.org/graphics/peruse/-/merge_requests/34/diffs?commit_id=1684e5d0494e888711c22b09749cc75cbd7f4236
and install it on Android
2. Enable Peruse to have access to all files if on Android >= 10.0 (Settings ->
Apps -> Special Access -> Access all files -> Enable Peruse). This is needed as
the version is still an early state of Peruse on Android.
3. Add Comics to `/storage/emulated/0/Comics`and open Peruse in Portrait Mode.

OBSERVED RESULT
The thumbnails will be rendered black.

EXPECTED RESULT
The thumbnails will be rendered correctly.

SOFTWARE/OS VERSIONS
KDE Frameworks Version: 5.106.0
Qt Version: 5.15

ADDITIONAL INFORMATION
When using an Image instead of Kirigami.Icon the Thumbnails get rendered
correctly, see
https://invent.kde.org/graphics/peruse/-/merge_requests/34/diffs?commit_id=99cf409fb98e9c7361c5177a243740c3225de1ab
Also, when changing the Columns from 2 Columns to only 1 the images load
correctly with Kirigami.Icon, see:
https://discuss-cdn.kde.org/uploads/default/original/2X/e/ef33405d90bb53417b7784ffdbaee8aa854aee0e.jpeg

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 450850] Two "Go Full Screen" buttons in viewer page

2022-07-18 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=450850

Remko van Wagensveld  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/peruse/commit/f98ad615
   ||de11e6a847379a72c17182c916e
   ||6dde5
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Remko van Wagensveld  ---
Git commit f98ad615de11e6a847379a72c17182c916e6dde5 by Remko van Wagensveld.
Committed on 16/07/2022 at 15:32.
Pushed by ngraham into branch 'master'.

Remove redundant 'Enter Fullscreen' Button

The mobile and desktop Actions already contain an 'Enter Fullscreen' Action.
These need to be kept, as the desktop Action has the functionality for keyboard
shortcuts ('f' and 'Esc') implemented.

M  +0-7src/app/qml/Book.qml

https://invent.kde.org/graphics/peruse/commit/f98ad615de11e6a847379a72c17182c916e6dde5

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 450844] "Group by series" unflattens filesystem hierarchy, making it difficult to find anything

2022-07-16 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=450844

Remko van Wagensveld  changed:

   What|Removed |Added

 CC||remgg...@gmail.com

--- Comment #3 from Remko van Wagensveld  ---
This behavior of series is intended as far as I see. This is for structures
where you have multiple comics of the same series in one folder. E.g.:

$ tree All-New*
All-New\ Hawkeye\ (2015)
|-- All-New_Hawkeye_2015_1.cbz
`-- All-New_Hawkeye_2015_6.cbz
All-New\ Ultimates\ (2014)
|-- All-New_Ultimates_2014_1.cbz
`-- All-New,_All-Different_Avengers_2015_9.cbz

This helps if the Comic Book Archives do not have any metadata embedded
describing the comic.
What you are suggesting would be a folder browser in peruse. In general I would
like a folder browser, but that is a new feature, as the "Group by series"
works as intended.

The code for adding the folder as a series is here:
https://invent.kde.org/graphics/peruse/-/blob/master/src/qtquick/BookListModel.cpp#L244

However, what I think is a problem with this feature is that the folder name
gets added as series even if the comic book has the appropriate series
information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 450850] Two "Go Full Screen" buttons in viewer page

2022-07-02 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=450850

Remko van Wagensveld  changed:

   What|Removed |Added

 CC||remgg...@gmail.com
   Assignee|ad...@leinir.dk |remgg...@gmail.com
 Status|ASSIGNED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 450846] Group by Author, Publisher, and Keyword pages are empty but don't even show placeholder text

2022-06-16 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=450846

Remko van Wagensveld  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/peruse/commit/3d67cf4d
   ||b740cf8ded5900da82c8ed09a62
   ||a7866

--- Comment #3 from Remko van Wagensveld  ---
Git commit 3d67cf4db740cf8ded5900da82c8ed09a62a7866 by Remko van Wagensveld.
Committed on 16/06/2022 at 18:57.
Pushed by ngraham into branch 'master'.

Add placeholder text to empty category pages

This commit adds a PlaceholderMessage to the Bookshelf which is shown if
CategoryEntriesModel.count == 0. This occurs if e.g. there are no comics with
the according metadata in the library.

M  +10   -0src/app/qml/Bookshelf.qml

https://invent.kde.org/graphics/peruse/commit/3d67cf4db740cf8ded5900da82c8ed09a62a7866

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 450846] Group by Author, Publisher, and Keyword pages are empty but don't even show placeholder text

2022-05-29 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=450846

Remko van Wagensveld  changed:

   What|Removed |Added

   Assignee|remgg...@gmail.com  |ad...@leinir.dk

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 450846] Group by Author, Publisher, and Keyword pages are empty but don't even show placeholder text

2022-05-19 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=450846

Remko van Wagensveld  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 450846] Group by Author, Publisher, and Keyword pages are empty but don't even show placeholder text

2022-05-19 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=450846

--- Comment #1 from Remko van Wagensveld  ---
I want to tackle this and understand QML/Qt better by doing this small fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 450846] Group by Author, Publisher, and Keyword pages are empty but don't even show placeholder text

2022-05-19 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=450846

Remko van Wagensveld  changed:

   What|Removed |Added

 CC||remgg...@gmail.com
   Assignee|ad...@leinir.dk |remgg...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 437943] GLib-ERROR **: 22:18:15.792: Creating pipes for GWakeup: Too many open files on large comic collections

2022-05-15 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=437943

Remko van Wagensveld  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/peruse/commit/7b0050ab
   ||86d98cfd5a973c45029c8358b1f
   ||79bfa

--- Comment #3 from Remko van Wagensveld  ---
Git commit 7b0050ab86d98cfd5a973c45029c8358b1f79bfa by Remko van Wagensveld.
Committed on 15/05/2022 at 09:12.
Pushed by carlschwan into branch 'master'.

Fix filedescriptor leak when indexing books

When calling ArchiveBookModel::setFilename with a valid filename of a comic
book
the archive is opened but never closed again.

M  +1-1src/qtquick/ArchiveBookModel.cpp

https://invent.kde.org/graphics/peruse/commit/7b0050ab86d98cfd5a973c45029c8358b1f79bfa

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 437943] GLib-ERROR **: 22:18:15.792: Creating pipes for GWakeup: Too many open files on large comic collections

2022-05-06 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=437943

--- Comment #2 from Remko van Wagensveld  ---
Added merge request !28 fixing the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 437943] GLib-ERROR **: 22:18:15.792: Creating pipes for GWakeup: Too many open files on large comic collections

2022-05-06 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=437943

Remko van Wagensveld  changed:

   What|Removed |Added

   Assignee|remgg...@gmail.com  |ad...@leinir.dk

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 437943] GLib-ERROR **: 22:18:15.792: Creating pipes for GWakeup: Too many open files on large comic collections

2022-05-06 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=437943

Remko van Wagensveld  changed:

   What|Removed |Added

   Assignee|ad...@leinir.dk |remgg...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[peruse] [Bug 437943] GLib-ERROR **: 22:18:15.792: Creating pipes for GWakeup: Too many open files on large comic collections

2022-04-28 Thread Remko van Wagensveld
https://bugs.kde.org/show_bug.cgi?id=437943

Remko van Wagensveld  changed:

   What|Removed |Added

 CC||remgg...@gmail.com
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Remko van Wagensveld  ---
I can confirm this behaviour and am currently looking into it.

With lsof I see that the opened fds are piling up.

-- 
You are receiving this mail because:
You are watching all bug changes.