[clazy] [Bug 485968] Clazy doesn't build against Clang 18+

2024-06-16 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=485968

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 485968] Clazy doesn't build against Clang 18+

2024-06-16 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=485968

Sergio Martins  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #2 from Sergio Martins  ---
I've reproduced specifically with llvm18 from ubuntu-24.04, will investigate
further.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Heaptrack] [Bug 473695] New: Heaptrack fails with dart executable

2023-08-23 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=473695

Bug ID: 473695
   Summary: Heaptrack fails with dart executable
Classification: Applications
   Product: Heaptrack
   Version: 1.4.0
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: m...@milianw.de
  Reporter: smart...@kde.org
  Target Milestone: ---

When running dart under heaptrack, or even just a dart compiled executable,
heaptrack bails out with:

> starting application, this might take some time...
> terminate called after throwing an instance of '(anonymous 
> namespace)::HeapTrack::LockCheckFailed'
> terminate called recursively

To reproduce:

1. Have a main.dart with minimal contents such as:

void main(List args) { print("Hello"); }

2. Download flutter from:
https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.10.3-stable.tar.xz

3. Unpack somewhere

4. Just to make sure dart works, let's run:
~/flutter-3.13/bin/cache/dart-sdk/bin/dart main.dart

5. Run under heaptrack:
heaptrack ~/flutter-3.13/bin/cache/dart-sdk/bin/dart main.dart

optionally, you can get a main.exe executable with:
$ flutter-3.13/bin/cache/dart-sdk/bin/dart compile exe main.dart
$ heaptrack main.exe

Which results in the same crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 448813] Release build system fixes to enable distros to build clazy from source

2022-01-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=448813

Sergio Martins  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Sergio Martins  ---
v1.11 has been tagged
Source packages will appear in mirrors soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 448813] Release build system fixes to enable distros to build clazy from source

2022-01-20 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=448813

--- Comment #1 from Sergio Martins  ---
Git commit 1acae0b38f42ecea014fc03dd25f377bd5c80ff5 by Sergio Martins.
Committed on 20/01/2022 at 11:08.
Pushed by smartins into branch '1.11'.

Bump version to 1.11

Release is tomorrow if tests pass.

M  +1-1Changelog
M  +1-3README.md
M  +1-1src/ClazyStandaloneMain.cpp

https://invent.kde.org/sdk/clazy/commit/1acae0b38f42ecea014fc03dd25f377bd5c80ff5

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 448813] Release build system fixes to enable distros to build clazy from source

2022-01-20 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=448813

Sergio Martins  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 448813] Release build system fixes to enable distros to build clazy from source

2022-01-20 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=448813

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |smart...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 444964] clazy couldnt compile on llvm13 systems

2021-11-05 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=444964

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #2 from Sergio Martins  ---
it now uses contains_insensitive if llvm13

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 443343] clazy-rule-of-two-soft ignores "= default"

2021-10-26 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=443343

Sergio Martins  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/854f3408dfc9d2
   ||d96d2a9bda46660e2074315d6c
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #3 from Sergio Martins  ---
Git commit 854f3408dfc9d2d96d2a9bda46660e2074315d6c by Sergio Martins.
Committed on 26/10/2021 at 19:44.
Pushed by smartins into branch 'master'.

rule-of-two-soft: Honour explicitly defaulted copy-ctor/operator

The user signaled he knows what he's doing and there's even valid
use cases

M  +5-2src/checks/level1/rule-of-two-soft.cpp
A  +30   -0tests/rule-of-two-soft/bug443343.cpp  *
A  +1-0tests/rule-of-two-soft/bug443343.cpp.expected
M  +3-0tests/rule-of-two-soft/config.json

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/sdk/clazy/commit/854f3408dfc9d2d96d2a9bda46660e2074315d6c

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 443343] clazy-rule-of-two-soft ignores "= default"

2021-10-25 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=443343

Sergio Martins  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |INTENTIONAL

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 443343] clazy-rule-of-two-soft ignores "= default"

2021-10-17 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=443343

--- Comment #1 from Sergio Martins  ---
Counting instances is a very special edge case.

The more common cases are your ctor allocating a resource, and the dtor freeing
it. The default assign-op would be very bad in such case, example:

struct A {};

struct Test {

Test() { m_a = new A(); }

~Test() { delete m_a; }

Test& operator=(const Test&) = default;

A *m_a;
};


Would lead to double-delete.

I understand your point, but I think it's better to have a false-positive than
having more false-negatives which cause crashes

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 443343] clazy-rule-of-two-soft ignores "= default"

2021-10-17 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=443343

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |smart...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 443399] clazy-inefficient-qlist makes no sense anymore with Qt 6

2021-10-13 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=443399

Sergio Martins  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/d86b9dc6b5ae57
   ||e204f6715d2f6113cc196d2d98
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #2 from Sergio Martins  ---
Git commit d86b9dc6b5ae57e204f6715d2f6113cc196d2d98 by Sergio Martins.
Committed on 13/10/2021 at 22:22.
Pushed by smartins into branch 'master'.

Remove inefficient-qlist check, the issue has been fixed in Qt6

Newer project can use Qt6.
Old Qt5 projects shouldn't be doing such invasive changes.

If this check was about uncovering bugs instead of reducing
performance pessimisation then we could keep it for Qt5 code in
production, that's not the case however.

M  +1-0Changelog
M  +0-2CheckSources.cmake
M  +0-1ClazySources.cmake
M  +0-2ClazyTests.cmake
M  +0-2README.md
M  +0-12   checks.json
D  +0-7docs/checks/README-inefficient-qlist-soft.md
D  +0-5docs/checks/README-inefficient-qlist.md
M  +0-2readmes.cmake
M  +0-4src/Checks.h
D  +0-117  src/checks/inefficientqlistbase.cpp
D  +0-63   src/checks/inefficientqlistbase.h
D  +0-34   src/checks/level1/inefficient-qlist-soft.cpp
D  +0-47   src/checks/level1/inefficient-qlist-soft.h
D  +0-35   src/checks/manuallevel/inefficient-qlist.cpp
D  +0-46   src/checks/manuallevel/inefficient-qlist.h
D  +0-7tests/inefficient-qlist-soft/config.json
D  +0-91   tests/inefficient-qlist-soft/main.cpp
D  +0-3tests/inefficient-qlist-soft/main.cpp.expected
D  +0-8tests/inefficient-qlist/config.json
D  +0-55   tests/inefficient-qlist/main.cpp
D  +0-4tests/inefficient-qlist/main.cpp.expected
D  +0-4tests/inefficient-qlist/main.cpp.expected.x86

https://invent.kde.org/sdk/clazy/commit/d86b9dc6b5ae57e204f6715d2f6113cc196d2d98

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 443399] clazy-inefficient-qlist makes no sense anymore with Qt 6

2021-10-13 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=443399

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |smart...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 443399] clazy-inefficient-qlist makes no sense anymore with Qt 6

2021-10-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=443399

--- Comment #1 from Sergio Martins  ---
yeah, I'll disable it for Qt6

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 442769] qt6-qlatin1stringchar-to-u creates invalid code

2021-09-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=442769

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |joerg.bornem...@qt.io

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 389055] suggest simplification: `$smartpointer.data()->` to `$smartpointer->`

2021-07-23 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=389055

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/74686cc8c884db
   ||cfabb12ea7a926e0eec486846d
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Sergio Martins  ---
Git commit 74686cc8c884dbcfabb12ea7a926e0eec486846d by Sergio Martins, on
behalf of Waqar Ahmed.
Committed on 23/07/2021 at 19:33.
Pushed by smartins into branch 'master'.

Add use-arrow-operator

Suggest to use arrow operator with qt smart pointers instead of
.data()->someFunc()

print parent class name in warning

Signed-off-by: Waqar Ahmed 

M  +1-0CheckSources.cmake
M  +1-0ClazyTests.cmake
M  +7-0checks.json
M  +2-0src/Checks.h
A  +90   -0src/checks/manuallevel/use-arrow-operator.cpp [License: LGPL
(v2+)]
A  +39   -0src/checks/manuallevel/use-arrow-operator.h [License: LGPL
(v2+)]
A  +8-0tests/use-arrow-operator/config.json
A  +20   -0tests/use-arrow-operator/main.cpp  *
A  +3-0tests/use-arrow-operator/main.cpp.expected

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/sdk/clazy/commit/74686cc8c884dbcfabb12ea7a926e0eec486846d

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 439337] clazy-qt6-deprecated-api-fixes creates invalid code

2021-07-19 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=439337

--- Comment #2 from Sergio Martins  ---
Joerg , are you still the contact person for the qt6- checks ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 439338] clazy-qt6-deprecated-api-fixes creates invalid code for QDate::startOfDay

2021-07-19 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=439338

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |joerg.bornem...@qt.io

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 439337] clazy-qt6-deprecated-api-fixes creates invalid code

2021-07-19 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=439337

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |joerg.bornem...@qt.io

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438976] Clazy crashes when parsing Qt 6.1.0 with old-style-connect check enabled

2021-06-30 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438976

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/19f1254224b69c
   ||ffd639b4a343866e7db2a469df

--- Comment #8 from Sergio Martins  ---
Git commit 19f1254224b69cffd639b4a343866e7db2a469df by Sergio Martins.
Committed on 30/06/2021 at 23:17.
Pushed by smartins into branch 'master'.

old-style-connect: Simplify regexp, which also fixes a crash

Simplification done by Jonathan Marten.

I don't understand why it fixes the crash though, but at least
it's not worse.
Related: bug 435615

M  +1-1src/checks/level2/old-style-connect.cpp

https://invent.kde.org/sdk/clazy/commit/19f1254224b69cffd639b4a343866e7db2a469df

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 435615] Reproducible crash within clang when attempting to check Akonadi

2021-06-30 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=435615

Sergio Martins  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/19f1254224b69c
   ||ffd639b4a343866e7db2a469df
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #6 from Sergio Martins  ---
Git commit 19f1254224b69cffd639b4a343866e7db2a469df by Sergio Martins.
Committed on 30/06/2021 at 23:17.
Pushed by smartins into branch 'master'.

old-style-connect: Simplify regexp, which also fixes a crash

Simplification done by Jonathan Marten.

I don't understand why it fixes the crash though, but at least
it's not worse.
Related: bug 438976

M  +1-1src/checks/level2/old-style-connect.cpp

https://invent.kde.org/sdk/clazy/commit/19f1254224b69cffd639b4a343866e7db2a469df

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 435615] Reproducible crash within clang when attempting to check Akonadi

2021-06-30 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=435615

--- Comment #5 from Sergio Martins  ---
I've reproduced

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438976] Clazy crashes when parsing Qt 6.1.0 with old-style-connect check enabled

2021-06-30 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438976

--- Comment #7 from Sergio Martins  ---
I've reproduced on macOS

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438999] QVariant assignment (-Wclazy-qt6-deprecated-api-fixes)

2021-06-30 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438999

Sergio Martins  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/sdk/ |https://invent.kde.org/sdk/
   |clazy/commit/e223fd501c5835 |clazy/commit/83a41301e72cf3
   |eb46048681d84d4db7887221c7  |0a8be1fa9c3eba7173a298c958

--- Comment #5 from Sergio Martins  ---
Git commit 83a41301e72cf30a8be1fa9c3eba7173a298c958 by Sergio Martins, on
behalf of Nicolas Fella.
Committed on 30/06/2021 at 13:07.
Pushed by smartins into branch '1.9'.

Fix container find operation

Make sure we compare with the end of the correct container
(cherry picked from commit e223fd501c5835eb46048681d84d4db7887221c7)

M  +1-1src/checks/manuallevel/qt6-deprecated-api-fixes.cpp

https://invent.kde.org/sdk/clazy/commit/83a41301e72cf30a8be1fa9c3eba7173a298c958

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438999] QVariant assignment (-Wclazy-qt6-deprecated-api-fixes)

2021-06-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438999

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |joerg.bornem...@qt.io

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438999] QVariant assignment (-Wclazy-qt6-deprecated-api-fixes)

2021-06-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438999

--- Comment #1 from Sergio Martins  ---
Maybe also fixed in master

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438998] QProcess::startDetached gives qt6-deprecated-api-fixes warning

2021-06-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438998

Sergio Martins  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438998] QProcess::startDetached gives qt6-deprecated-api-fixes warning

2021-06-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438998

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |joerg.bornem...@qt.io
 Status|RESOLVED|REPORTED
 Resolution|FIXED   |---

--- Comment #2 from Sergio Martins  ---
Joerg might want to cherry-pick it to QtCreator (or even to 1.9 branch)

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438998] QProcess::startDetached gives qt6-deprecated-api-fixes warning

2021-06-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438998

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Sergio Martins  ---
This is fixed in master branch, will be part of 1.10

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438976] Clazy crashes when parsing Qt 6.1.0 with old-style-connect check enabled

2021-06-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438976

--- Comment #1 from Sergio Martins  ---
can't repro on Linux/llvm-12

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 438027] copyable-polymorphic should not issue a warning when the base class copy ctor isn't public

2021-06-03 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=438027

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/9ec85f78a18c03
   ||1e49cdc62517175bfee7ee92ea
 Status|REPORTED|RESOLVED

--- Comment #1 from Sergio Martins  ---
Git commit 9ec85f78a18c031e49cdc62517175bfee7ee92ea by Sergio Martins.
Committed on 03/06/2021 at 21:45.
Pushed by smartins into branch 'master'.

copyable-polymorphic: Don't warn for some final classes

If the class is final and its base classes don't have public
copy-ctor/assign then it's ok
Related: bug 430672

M  +28   -4src/checks/level2/copyable-polymorphic.cpp
M  +23   -0tests/copyable-polymorphic/main.cpp
M  +1-0tests/copyable-polymorphic/main.cpp.expected

https://invent.kde.org/sdk/clazy/commit/9ec85f78a18c031e49cdc62517175bfee7ee92ea

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 430672] Level 2 lint copyable-polymorphic is a false positive for pure virtual classes

2021-06-03 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=430672

Sergio Martins  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/9ec85f78a18c03
   ||1e49cdc62517175bfee7ee92ea
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Sergio Martins  ---
Git commit 9ec85f78a18c031e49cdc62517175bfee7ee92ea by Sergio Martins.
Committed on 03/06/2021 at 21:45.
Pushed by smartins into branch 'master'.

copyable-polymorphic: Don't warn for some final classes

If the class is final and its base classes don't have public
copy-ctor/assign then it's ok
Related: bug 438027

M  +28   -4src/checks/level2/copyable-polymorphic.cpp
M  +23   -0tests/copyable-polymorphic/main.cpp
M  +1-0tests/copyable-polymorphic/main.cpp.expected

https://invent.kde.org/sdk/clazy/commit/9ec85f78a18c031e49cdc62517175bfee7ee92ea

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 407322] suggest to use QRegularExpressionMatch::capturedRef

2021-05-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=407322

Sergio Martins  changed:

   What|Removed |Added

   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 423780] clazy-fully-qualified-moc-types not detecting missing namespace

2021-05-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=423780

Sergio Martins  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/b183b3312edd17
   ||81788cc598d5a89f344d7c8d7f

--- Comment #3 from Sergio Martins  ---
Git commit b183b3312edd1781788cc598d5a89f344d7c8d7f by Sergio Martins.
Committed on 15/05/2021 at 09:48.
Pushed by smartins into branch 'master'.

fully-qualified-moc-types: Explain why Q_PROPERTY warns on moc output only

Q_PROPERTY is a macro that doesn't expand to anything. It won't appear in
the AST. The properties only appear in the moc output.

It will warn that your Q_PROPERTY needs to be fully qualified when you do
a full build with clazy as the compiler, but probably not in QtCreator's
inline warnings.

Working at the Lexer level without a code model would not
only be hardwork but would be flaky with many corner cases and false-positives.

M  +3-0docs/checks/README-fully-qualified-moc-types.md

https://invent.kde.org/sdk/clazy/commit/b183b3312edd1781788cc598d5a89f344d7c8d7f

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 435615] Reproducible crash within clang when attempting to check Akonadi

2021-05-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=435615

--- Comment #4 from Sergio Martins  ---
What would be really valuable would be a reproducible test case, trimming down
your akonadi case and attach here, so I can work on it

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 435615] Reproducible crash within clang when attempting to check Akonadi

2021-05-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=435615

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |smart...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 413315] "clazy-standalone -version" prints LLVM version, but not clazy version

2021-05-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=413315

Sergio Martins  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/0080d8358b253a
   ||a5b7019c054cb57d402a538a85
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #2 from Sergio Martins  ---
Git commit 0080d8358b253aa5b7019c054cb57d402a538a85 by Sergio Martins.
Committed on 15/05/2021 at 09:27.
Pushed by smartins into branch 'master'.

Print clazy's version when --version is passed

M  +7-0src/ClazyStandaloneMain.cpp

https://invent.kde.org/sdk/clazy/commit/0080d8358b253aa5b7019c054cb57d402a538a85

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 413315] "clazy-standalone -version" prints LLVM version, but not clazy version

2021-05-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=413315

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |smart...@kde.org

--- Comment #1 from Sergio Martins  ---
Do you know any

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 435854] Problems building clazy with MinGW

2021-05-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=435854

--- Comment #2 from Sergio Martins  ---
I don't have bandwidth to support MinGW so won't work on it

Can you try if -DLINK_CLAZY_TO_LLVM=OFF helps ?

Windows is very tricky to get right MSVC works very differently than MinGW,
regarding llvm and plugin symbols

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 435854] Problems building clazy with MinGW

2021-05-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=435854

--- Comment #1 from Sergio Martins  ---
Git commit 96de05dd7795d045258db28270b5b27c6ce37021 by Sergio Martins.
Committed on 15/05/2021 at 09:07.
Pushed by smartins into branch 'master'.

README: Mention supported platforms

M  +7-0README.md

https://invent.kde.org/sdk/clazy/commit/96de05dd7795d045258db28270b5b27c6ce37021

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 437092] clazy believes member function template is signal

2021-05-14 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=437092

Sergio Martins  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/sdk/ |https://invent.kde.org/sdk/
   |clazy/commit/def0b3d9620876 |clazy/commit/39adc47e8dcb7d
   |d69456c907ee276e86c880147c  |8a86ff76a17c107c35874d4ec4

--- Comment #3 from Sergio Martins  ---
Git commit 39adc47e8dcb7d8a86ff76a17c107c35874d4ec4 by Sergio Martins.
Committed on 14/05/2021 at 22:38.
Pushed by smartins into branch 'master'.

Merge branch '1.9'

M  +1-2tests/incorrect-emit/config.json

https://invent.kde.org/sdk/clazy/commit/39adc47e8dcb7d8a86ff76a17c107c35874d4ec4

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 437092] clazy believes member function template is signal

2021-05-14 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=437092

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/def0b3d9620876
   ||d69456c907ee276e86c880147c
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Sergio Martins  ---
Git commit def0b3d9620876d69456c907ee276e86c880147c by Sergio Martins.
Committed on 14/05/2021 at 22:37.
Pushed by smartins into branch '1.9'.

incorrect-emit: Don't classify template functions as signals

It was using the loc of the method definition, which is after
"signals". Instead of improving the loc calculation for the
template case, simply bail out early and save some CPU cycles.

signals can't be templated

M  +1-1src/AccessSpecifierManager.cpp

https://invent.kde.org/sdk/clazy/commit/def0b3d9620876d69456c907ee276e86c880147c

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 437092] clazy believes member function template is signal

2021-05-14 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=437092

--- Comment #1 from Sergio Martins  ---
Git commit 38e2a693b4e175713e15ff1715a597860a0c2bc3 by Sergio Martins.
Committed on 14/05/2021 at 22:20.
Pushed by smartins into branch 'master'.

incorrect-emit: Add unit-test for a bug

A  +20   -0tests/incorrect-emit/bug437092.cpp  *
A  +0-0tests/incorrect-emit/bug437092.cpp.expected
M  +4-0tests/incorrect-emit/config.json

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/sdk/clazy/commit/38e2a693b4e175713e15ff1715a597860a0c2bc3

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 437092] clazy believes member function template is signal

2021-05-14 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=437092

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |smart...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 437092] clazy believes member function template is signal

2021-05-14 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=437092

Sergio Martins  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 436606] -std=c++17 mask connect-3arg-lambda check

2021-05-05 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=436606

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/2d3e842961b9d5
   ||2e454c2c6838a30c630ba91492
 Status|REPORTED|RESOLVED

--- Comment #3 from Sergio Martins  ---
Git commit 2d3e842961b9d52e454c2c6838a30c630ba91492 by Sergio Martins.
Committed on 05/05/2021 at 14:07.
Pushed by smartins into branch 'master'.

connect-3arg-lambda: Add a test that it still works with c++17

M  +5-0tests/connect-3arg-lambda/config.json

https://invent.kde.org/sdk/clazy/commit/2d3e842961b9d52e454c2c6838a30c630ba91492

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 436606] -std=c++17 mask connect-3arg-lambda check

2021-05-05 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=436606

--- Comment #2 from Sergio Martins  ---
Git commit bf9c81e8dda41c4a1202c93dbf85c4afef361ec2 by Sergio Martins.
Committed on 05/05/2021 at 13:40.
Pushed by smartins into branch 'master'.

tests: Allow a test to specify that it wants c++17

M  +12   -7tests/run_tests.py

https://invent.kde.org/sdk/clazy/commit/bf9c81e8dda41c4a1202c93dbf85c4afef361ec2

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-02-25 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/876796fb007cd6
   ||245fda37b6035b2504fdb6ad6e
 Status|REOPENED|RESOLVED

--- Comment #29 from Sergio Martins  ---
Git commit 876796fb007cd6245fda37b6035b2504fdb6ad6e by Sergio Martins.
Committed on 25/02/2021 at 20:16.
Pushed by smartins into branch '1.9'.

Fix -Wconnect-non-signal when fixits are enabled on macOS

Partially reverts d6b07989e7a921. The fixit for copyable-polymorphic
is now guarded by an opt-in env variable. I think it's not worth the slow
down anyway, and since it causes regressions for connect-non-signal,
disable it by default

M  +9-2src/AccessSpecifierManager.cpp
M  +1-0src/AccessSpecifierManager.h

https://invent.kde.org/sdk/clazy/commit/876796fb007cd6245fda37b6035b2504fdb6ad6e

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-02-24 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #28 from Sergio Martins  ---
I've finally reproduced without QtCreator. Needs the -export-fixes=foo argument
to reproduce

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-02-24 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #27 from Sergio Martins  ---
thanks, I'll have a try

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-02-24 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #25 from Sergio Martins  ---
can you paste here the commands you use to compile and install clazy ?
If it's done within a QtCreator build, are there instructions I can do the same
?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431870] Proposal: Split range-loop check

2021-02-22 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431870

Sergio Martins  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/83425dc3aada18
   ||a2046b5f33469d41a3a25838cb

--- Comment #5 from Sergio Martins  ---
Git commit 83425dc3aada18a2046b5f33469d41a3a25838cb by Sergio Martins.
Committed on 22/02/2021 at 19:56.
Pushed by smartins into branch 'master'.

README: Add Christian Schärf to list of contributors

M  +1-0README.md

https://invent.kde.org/sdk/clazy/commit/83425dc3aada18a2046b5f33469d41a3a25838cb

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431870] Proposal: Split range-loop check

2021-02-22 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431870

--- Comment #4 from Sergio Martins  ---
thanks, will check it soon!

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-02-07 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #23 from Sergio Martins  ---
Thierry, can you reproduce with clazy master ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431789] False positive with -clazy-inefficient-qlist

2021-02-07 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431789

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |INTENTIONAL
 Status|REPORTED|RESOLVED

--- Comment #1 from Sergio Martins  ---
Calling values QMap::values() just makes it worse, as it allocates a temporary
container, see README-container-anti-pattern.md.

Ofc, people will always find cases where "but here it's useful for me!", for
that reason, inefficient-qlist is disabled by default, and there's
inefficient-qlist-soft.

Anyway, no point on spending our weekend around this since it's already a
non-issue in Qt 6, where this check doesn't make sense anymore. Any effort
spend here will be wasted in the long run.

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431870] Proposal: Split range-loop check

2021-02-07 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431870

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |c.scha...@t-online.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431870] Proposal: Split range-loop check

2021-02-07 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431870

--- Comment #2 from Sergio Martins  ---
can you provide a patch ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431870] Proposal: Split range-loop check

2021-02-07 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431870

--- Comment #1 from Sergio Martins  ---
sounds good

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-02-03 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #22 from Sergio Martins  ---
What do we know so far, is it Windows only ?

Thierry, did you repro on macOS ?
Anyone repro on Linux ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 432078] Crash when building with 'ENABLE_CLAZY'

2021-01-26 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=432078

--- Comment #7 from Sergio Martins  ---
Can you build clazy itself and see if you can repro

cmake -DCMAKE_BUILD_TYPE=Debug .
cmake --build .
the ClazyPlugin.so path to LD_LIBRARY_PATH and rerun the tests
(remove the system package if needed)

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 432078] Crash when building with 'ENABLE_CLAZY'

2021-01-25 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=432078

--- Comment #4 from Sergio Martins  ---
Can't reproduce on Archlinux.

What's the output of:
$ cd clazy/tests 
$ ./run_tests.py --verbose

(git clone g...@invent.kde.org:sdk/clazy.git if needed)

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 432078] Crash when building with 'ENABLE_CLAZY'

2021-01-25 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=432078

--- Comment #2 from Sergio Martins  ---
which distro ?

Ahmad Samir, which distro too ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-01-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #18 from Sergio Martins  ---
Interesting, can you open the compile_commands.json, go to the line of your
translation unit, and start removing compiler flags until you can't repro ?

I think there's some flag which is the culprit.

Another idea is to test clazy from 
https://downloads.kdab.com/clazy/1.8/clazy_v1.8-msvc2019.zip instead of the one
shipped with QtC.

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-01-20 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |DOWNSTREAM
 Status|REPORTED|RESOLVED

--- Comment #16 from Sergio Martins  ---
This is a bug in QtCreator's clazy integration, needs to be reported at
https://bugs.qt.io instead

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431507] qt6-header-fixes fails when Qt5 is build using OpenGL ES

2021-01-12 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431507

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |joerg.bornem...@qt.io

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-01-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #13 from Sergio Martins  ---
thanks, that built fine, but doesn't show the problem

Is this something you're seeing when compiling the project with clazy =
(clang+mingw+clazy plugin) or is this a warning you're seeing in QtCreator code
analysis tools (which underlines the problem) ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-01-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #11 from Sergio Martins  ---
thanks

can you upload a single .zip and make sure it compiles ?

I think something went wrong with your upload, some files say:

#include "Error in " Util.relativeFilePath('C:/Users/jhertz/Dropbox (NU College
of Eng'g)/Files/CPP/Qt/mainwindow.h', 'C:/Users/jhertz/Dropbox (NU College of
Eng'g)/Files/CPP/Qt' + '/' + Util.path('mainwindow.cpp'))": SyntaxError:
Unexpected token `identifier'"
#include "ui_mainwindow.h"

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 430672] Level 2 lint copyable-polymorphic is a false positive for pure virtual classes

2021-01-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=430672

--- Comment #1 from Sergio Martins  ---
If they can't be copied why do they have a copy-ctor in the first place ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 416046] Suggest to check that QDir().exists(...) is used correctly

2021-01-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=416046

Sergio Martins  changed:

   What|Removed |Added

   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 410655] Suggests to use Q_ENUM when you can't use it

2021-01-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=410655

Sergio Martins  changed:

   What|Removed |Added

   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 430138] qt6-qlatin1stringchar-to-u creates duplicates in replacements yaml file

2021-01-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=430138

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |joerg.bornem...@qt.io

--- Comment #1 from Sergio Martins  ---
can you reassign to Lucie ? I'm not finding then name in the assign list

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-01-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #2 from Sergio Martins  ---
Do you have either precompiled headers turned on, or ccache running ?

Can you paste the complete compiler invocation ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-01-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |smart...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431186] QAbstractItemView::entered not recognized as a signal [clazy-connect-non-signal]

2021-01-10 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431186

--- Comment #1 from Sergio Martins  ---
Git commit d3f6b6606b170c7daf8abdd24ac69e562e86b9b8 by Sergio Martins.
Committed on 10/01/2021 at 13:40.
Pushed by smartins into branch 'master'.

connect-non-signal: Add a testcsae for bug 431186

I can't reproduce

A  +9-0tests/connect-non-signal/bug431186.cpp  *
A  +0-0tests/connect-non-signal/bug431186.cpp.expected
M  +3-0tests/connect-non-signal/config.json

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/sdk/clazy/commit/d3f6b6606b170c7daf8abdd24ac69e562e86b9b8

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 430959] Building with clazy is at least 2x slower than without clazy

2021-01-09 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=430959

Sergio Martins  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/acb72c6165c521
   ||3a2d6d2e631d091751faaa43fc
 Resolution|--- |FIXED

--- Comment #7 from Sergio Martins  ---
Git commit acb72c6165c5213a2d6d2e631d091751faaa43fc by Sergio Martins.
Committed on 10/01/2021 at 00:21.
Pushed by smartins into branch 'master'.

Merge branch '1.8'


https://invent.kde.org/sdk/clazy/commit/acb72c6165c5213a2d6d2e631d091751faaa43fc

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 430959] Building with clazy is at least 2x slower than without clazy

2021-01-09 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=430959

--- Comment #6 from Sergio Martins  ---
Git commit 0215389de14f5bc6daa5d6e6e5d3943c0aba9584 by Sergio Martins.
Committed on 10/01/2021 at 00:14.
Pushed by smartins into branch '1.8'.

Revert "Add fixit for copyable-polymorphic"

This reverts commit d6b07989e7a9211b21ecb9b9f8bd4d237bcc453e.
It's causing a 4x slowdown.

The culprit is running AccessSpecifierManager::VisitDeclaration
for all classes, instead of QObject only

Will reapply in master with a possible workaround

M  +2-17   src/AccessSpecifierManager.cpp
M  +0-3src/AccessSpecifierManager.h
M  +1-54   src/checks/level2/copyable-polymorphic.cpp
M  +0-1src/checks/level2/copyable-polymorphic.h
M  +0-5tests/copyable-polymorphic/config.json
M  +0-9tests/copyable-polymorphic/main.cpp
M  +0-1tests/copyable-polymorphic/main.cpp.expected
D  +0-72   tests/copyable-polymorphic/main.cpp.fixed.expected

https://invent.kde.org/sdk/clazy/commit/0215389de14f5bc6daa5d6e6e5d3943c0aba9584

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 430959] Building with clazy is at least 2x slower than without clazy

2021-01-09 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=430959

--- Comment #5 from Sergio Martins  ---
reproduced

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 430959] Building with clazy is at least 2x slower than without clazy

2021-01-09 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=430959

--- Comment #4 from Sergio Martins  ---
Which checks do you have enabled ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 431168] Asserts triggered in qproperty-type-mismatch. DiagnosticMessage shouldn't receive macro location

2021-01-07 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=431168

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #6 from Sergio Martins  ---
thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 430959] Building with clazy is at least 2x slower than without clazy

2020-12-29 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=430959

--- Comment #1 from Sergio Martins  ---
A git bisect would be useful ?

Is it only repro with master, or 1.8 branch too ?
If only master then it's easy to bisect, as only a few commits when in recently

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 425822] 1.7 version does not compile with LLVM/clang-11.x

2020-11-24 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=425822

--- Comment #3 from Sergio Martins  ---
if you copy that compiler invocation line, but replace -std=c++11 with
-std=c++14 , does it work ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 429552] qt6-deprecated-api-fixes & qt6-qlatin1stringchar-to-u fail

2020-11-23 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=429552

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/sdk/
   ||clazy/commit/c1dc6549457422
   ||7646e1dd36675a5bd906660647
 Status|REPORTED|RESOLVED

--- Comment #4 from Sergio Martins  ---
Git commit c1dc65494574227646e1dd36675a5bd906660647 by Sergio Martins.
Committed on 23/11/2020 at 16:31.
Pushed by smartins into branch '1.8'.

qt6-qlatin1stringchar-to-u: Only run tests with clang 11

It's flaky with other versions.
Not disabling the check since it still works, just warns twice for
the same line.

CCMAIL: lucie.ger...@qt.io

M  +2-1tests/qt6-qlatin1stringchar-to-u/config.json

https://invent.kde.org/sdk/clazy/commit/c1dc65494574227646e1dd36675a5bd906660647

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 429552] qt6-deprecated-api-fixes & qt6-qlatin1stringchar-to-u fail

2020-11-23 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=429552

--- Comment #3 from Sergio Martins  ---
Git commit 04d38721ba951a9cafd276d584880d3f72c7794a by Sergio Martins.
Committed on 23/11/2020 at 16:05.
Pushed by smartins into branch '1.8'.

qt6-deprecated-api-fixes: Remove unrelated warnings from the test

There was a stray/unrelated compiler warning in the expected dataset.
Can make the test fail if some other compiler is used and gives a different
message

M  +1-1tests/qt6-deprecated-api-fixes/main.cpp
M  +0-1tests/qt6-deprecated-api-fixes/main.cpp.expected
M  +1-1tests/qt6-deprecated-api-fixes/main.cpp.fixed.expected

https://invent.kde.org/sdk/clazy/commit/04d38721ba951a9cafd276d584880d3f72c7794a

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwayland] [Bug 427749] New: kwin_wayland crash, easily repro when using QDrag

2020-10-15 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=427749

Bug ID: 427749
   Summary: kwin_wayland crash, easily repro when using QDrag
   Product: frameworks-kwayland
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: server
  Assignee: mgraess...@kde.org
  Reporter: smart...@kde.org
CC: kwin-bugs-n...@kde.org
  Target Milestone: ---

Created attachment 132381
  --> https://bugs.kde.org/attachment.cgi?id=132381=edit
test-case

If we hide() our widget inside QWidget::dragEnterEvent(), then the wayland
server will crash. 

See attached main.cpp
$ qmake QT+=widgets
$ make && ./testc

Press the button, without releasing mouse. Move mouse over the other window.
Crashes with the following backtrace

(gdb) bt
#0  0x7fbb0ba2bc94 in KWaylandServer::SurfaceInterface::buffer() () at
/usr/lib/libKWaylandServer.so.5
#1  0x7fbb0bf38172 in  () at /usr/lib/libkwin.so.5
#2  0x7fbb0a7de036 in  () at /usr/lib/libQt5Core.so.5
#3  0x7fbb0a7de036 in  () at /usr/lib/libQt5Core.so.5
#4  0x7fbb0ba16103 in
KWaylandServer::PointerInterface::Private::setCursor(unsigned int,
KWaylandServer::SurfaceInterface*, QPoint const&) () at
/usr/lib/libKWaylandServer.so.5
#5  0x7fbb0ba162bf in
KWaylandServer::PointerInterface::Private::setCursorCallback(wl_client*,
wl_resource*, unsigned int, wl_resource*, int, int) () at
/usr/lib/libKWaylandServer.so.5
#6  0x7fbb0777ca8d in  () at /usr/lib/libffi.so.7
#7  0x7fbb0777c01b in  () at /usr/lib/libffi.so.7
#8  0x7fbb08b64f62 in  () at /usr/lib/libwayland-server.so.0
#9  0x7fbb08b612dc in  () at /usr/lib/libwayland-server.so.0
#10 0x7fbb08b62faa in wl_event_loop_dispatch () at
/usr/lib/libwayland-server.so.0
#11 0x7fbb0b9f4bf0 in KWaylandServer::Display::Private::dispatch() () at
/usr/lib/libKWaylandServer.so.5
#12 0x7fbb0a7de036 in  () at /usr/lib/libQt5Core.so.5
#13 0x7fbb0a7e15a0 in QSocketNotifier::activated(QSocketDescriptor,
QSocketNotifier::Type, QSocketNotifier::QPrivateSignal) () at
/usr/lib/libQt5Core.so.5
#14 0x7fbb0a7e1dad in QSocketNotifier::event(QEvent*) () at
/usr/lib/libQt5Core.so.5
#15 0x7fbb0b26e752 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() at /usr/lib/libQt5Widgets.so.5
#16 0x7fbb0a7a6cda in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() at /usr/lib/libQt5Core.so.5
#17 0x7fbb0a7fcc34 in
QEventDispatcherUNIXPrivate::activateSocketNotifiers() () at
/usr/lib/libQt5Core.so.5
#18 0x7fbb0a7fd0b5 in
QEventDispatcherUNIX::processEvents(QFlags) ()
at /usr/lib/libQt5Core.so.5
#19 0x7fbb0c12e91e in  () at /usr/lib/qt/plugins/platforms/KWinQpaPlugin.so
#20 0x7fbb0a7a565c in
QEventLoop::exec(QFlags) () at
/usr/lib/libQt5Core.so.5
#21 0x7fbb0a7adaf4 in QCoreApplication::exec() () at
/usr/lib/libQt5Core.so.5
#22 0x55be3656884e in  ()
#23 0x7fbb0a01a152 in __libc_start_main () at /usr/lib/libc.so.6
#24 0x55be365690de in _start ()


I don't have a devel env to get debug symbols, but hopefully the test-case is
enough.




Linux/KDE Plasma: Archlinux, plasma 5.20
KDE Plasma Version: 5.20
Qt Version: 5.15.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 425822] 1.7 version does not compile with LLVM/clang-11.x

2020-10-14 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=425822

Sergio Martins  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 425822] 1.7 version does not compile with LLVM/clang-11.x

2020-10-14 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=425822

--- Comment #1 from Sergio Martins  ---
commit 1f2f7f47bc9a5bce6e3eaabbef8743f0617bc015 (HEAD -> master, origin/master)
Author: Sergio Martins 
Date:   Wed Oct 14 15:47:13 2020 +0100

Fix build with llvm-11

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 407258] clazy-standalone/clang-tidy substitution

2020-10-04 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=407258

--- Comment #3 from Sergio Martins  ---
There's no plans for merging them, and that would take a lot of work.
Our best bet would be clang-tidy supporting plugins. There's been some talk
about this in the llvm mailing lists, not sure what's the status there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 423728] inefficient-qlist fails on 32bit architectures

2020-07-01 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=423728

Sergio Martins  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 423728] inefficient-qlist fails on 32bit architectures

2020-07-01 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=423728

--- Comment #3 from Sergio Martins  ---
Git commit dbde38f1a67c2968c951629a5f5629c9847078bd by Sergio Martins.
Committed on 01/07/2020 at 17:57.
Pushed by smartins into branch '1.7'.

inefficient-qlist: Disable flaky test on arm 32bit

This check will be disabled in master, so no point wasting time.
People are already (re-)porting QVector->QList due to Qt6 changes,
so let's not confuse people more.

M  +2-1tests/inefficient-qlist/config.json
M  +12   -1tests/run_tests.py

https://invent.kde.org/sdk/clazy/commit/dbde38f1a67c2968c951629a5f5629c9847078bd

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 423728] inefficient-qlist fails on 32bit architectures

2020-07-01 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=423728

--- Comment #4 from Sergio Martins  ---
please check if it works now

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 413169] inefficient-qlist fails on Linux x86 (32bit)

2020-07-01 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=413169

--- Comment #2 from Sergio Martins  ---
Git commit dbde38f1a67c2968c951629a5f5629c9847078bd by Sergio Martins.
Committed on 01/07/2020 at 17:57.
Pushed by smartins into branch '1.7'.

inefficient-qlist: Disable flaky test on arm 32bit

This check will be disabled in master, so no point wasting time.
People are already (re-)porting QVector->QList due to Qt6 changes,
so let's not confuse people more.

M  +2-1tests/inefficient-qlist/config.json
M  +12   -1tests/run_tests.py

https://invent.kde.org/sdk/clazy/commit/dbde38f1a67c2968c951629a5f5629c9847078bd

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 423728] inefficient-qlist fails on 32bit architectures

2020-07-01 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=423728

--- Comment #1 from Sergio Martins  ---
People are starting to port QVector to QList already, in preparation to Qt 6.

I think this check just adds salt to injury and we should stop confusing users.
Would rather disable it than waste more time on it

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 423640] Wrong diagnostic with multi-lines Q_PROPERTY

2020-06-29 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=423640

Sergio Martins  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Sergio Martins  ---


*** This bug has been marked as a duplicate of bug 404327 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 404327] support multi-line Q_PROPERTY

2020-06-29 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=404327

Sergio Martins  changed:

   What|Removed |Added

 CC||chg...@gmail.com

--- Comment #3 from Sergio Martins  ---
*** Bug 423640 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 423640] Wrong diagnostic with multi-lines Q_PROPERTY

2020-06-29 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=423640

--- Comment #2 from Sergio Martins  ---
fixed in 1.6

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 423316] Implement a check to look for QT_VERSION_CHECK calls below a certain version

2020-06-21 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=423316

--- Comment #1 from Sergio Martins  ---
Sounds overkill in clazy, I would just grep for QT_VERSION_CHECK after bumping
the required Qt version

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 419578] Promote selected Clazy checks to errors

2020-04-03 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=419578

--- Comment #1 from Sergio Martins  ---
If you could look at it it would be great.

Last time I checked (2 or 3 years ago) it was hard to do, as clang didn't
accept custom check names in -Werror=, only the built-in ones, I wonder if this
has changed

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 419578] Promote selected Clazy checks to errors

2020-04-03 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=419578

Sergio Martins  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |c.scha...@t-online.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 419578] Promote selected Clazy checks to errors

2020-04-03 Thread Sergio Martins
https://bugs.kde.org/show_bug.cgi?id=419578

Sergio Martins  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   4   5   6   7   >