[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010
--- Comment #75 from Tanya ---
Julian reported VPTESTMW and VPTESTMB instruction failures - these instructions
read data with incorrect granularity (64 and 32 bits instead of 16 and 8 bits,
respectively). The granularity has been specified in the master file
incorrectly.
Attached an updated master file (also corrects granularity for VPTESTNMW and
VPTESTNMB, and corrects exception types for several instructions) and the
generated files ("Version 4: Part 2 of AVX-512 patch - auto-generated files").
--
You are receiving this mail because:
You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #142995|0 |1 is obsolete|| --- Comment #74 from Tanya --- Created attachment 146573 --> https://bugs.kde.org/attachment.cgi?id=146573=edit Version 4: Part 4 of AVX-512 patch - (optional) Generator of AVX-512 .c files -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #142993|0 |1 is obsolete|| --- Comment #73 from Tanya --- Created attachment 146572 --> https://bugs.kde.org/attachment.cgi?id=146572=edit Version 4: Part 2 of AVX-512 patch - auto-generated files -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #71 from Tanya --- Created attachment 145364 --> https://bugs.kde.org/attachment.cgi?id=145364=edit Update for AVX-512 Valgrind regression tests to spot differences between mask k0 and no mask (In reply to Julian Seward from comment #70) > I worry that there are potentially other places where the IR is generated > using `getKReg(mask)` when really it should be `mask ? getKReg(mask) : > mkU64(0)`, and that testing isn't catching these. Not sure though. Attached a patch to AVX-512 regression tests that catches this kind of errors by writing a random value in k0 before each test. It did not detect any other affected instructions. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #69 from Tanya --- Created attachment 144938 --> https://bugs.kde.org/attachment.cgi?id=144938=edit Fix copyright notices on the new AVX-512 files Patches attached in comment #58, comment #59, comment #60 and comment #61 had incorrect copyright notices. Attached a patch with a fix. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 441609] unhandled instruction bytes: 0x62 0xF1 0x7C 0x48 0x57 0xC0 0xC5 0xFA 0x11 0x80
https://bugs.kde.org/show_bug.cgi?id=441609 Tanya changed: What|Removed |Added CC||tatyana.a.mine...@intel.com Status|REPORTED|RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Tanya --- The faulty instruction is part of the AVX512 instruction set. It is currently being worked on in scope of https://bugs.kde.org/show_bug.cgi?id=383010. *** This bug has been marked as a duplicate of bug 383010 *** -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added CC||mgsext...@gmail.com --- Comment #66 from Tanya --- *** Bug 441609 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #64 from Tanya --- (In reply to Patrick J. LoPresti from comment #63) > Could someone please work on getting these changes into mainline? Or at > least make this a branch in the git repository? (Is there anything I can do > to help?) > > AVX-512 is now a "must have" for us. Hello, If you would make the patch into a new branch - would you be interested in its internal commit history, perhaps for git blame? If yes, preparing it with git-format-patch turned out to be too verbose. If it'd be useful, would it be possible to grant me access to this branch, perhaps temporarily? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #62 from Tanya --- Attached an updated version of the AVX-512 patch for KNL and SkyLake. It does not contain any principal changes comparing to the previous version, just bug fixes. It is based on Valgrind 3.18 (GIT master from Oct 22, commit b77dbefe72e4a5c7bcf1576a02c909010bd56991) For build and test instructions, please refer to comment #51 (https://bugs.kde.org/show_bug.cgi?id=383010#c51) -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #135974|0 |1 is obsolete|| Attachment #140028|0 |1 is obsolete|| --- Comment #61 from Tanya --- Created attachment 142995 --> https://bugs.kde.org/attachment.cgi?id=142995=edit Version 3: Part 4 of AVX-512 patch - (optional) Generator of AVX-512 .c files -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #140027|0 |1 is obsolete|| --- Comment #60 from Tanya --- Created attachment 142994 --> https://bugs.kde.org/attachment.cgi?id=142994=edit Version 3: Part 3 of AVX-512 patch - AVX-512 tests -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #140026|0 |1 is obsolete|| --- Comment #59 from Tanya --- Created attachment 142993 --> https://bugs.kde.org/attachment.cgi?id=142993=edit Version 3: Part 2 of AVX-512 patch - auto-generated files -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #140025|0 |1 is obsolete|| --- Comment #58 from Tanya --- Created attachment 142992 --> https://bugs.kde.org/attachment.cgi?id=142992=edit Version 3: Part 1 of AVX-512 patch - main implementation -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 443314] In the latest GIT version, Valgrind with "--trace-flags" crashes at "al" register
https://bugs.kde.org/show_bug.cgi?id=443314 --- Comment #1 from Tanya --- Created attachment 142149 --> https://bugs.kde.org/attachment.cgi?id=142149=edit Possible fix -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 443314] New: In the latest GIT version, Valgrind with "--trace-flags" crashes at "al" register
https://bugs.kde.org/show_bug.cgi?id=443314 Bug ID: 443314 Summary: In the latest GIT version, Valgrind with "--trace-flags" crashes at "al" register Product: valgrind Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: jsew...@acm.org Reporter: tatyana.a.mine...@intel.com Target Milestone: --- Created attachment 142148 --> https://bugs.kde.org/attachment.cgi?id=142148=edit Reproducer SUMMARY Valgrind trace (debug) crashes at "al" register after GIT commits 22bae4b1 and 61307ee8. STEPS TO REPRODUCE Attached a reproducer (al_test.c). 1. Compile the attached file: > gcc al_test.c 2. Run it under Valgrind with debugging: > valgrind --trace-flags=1000 --trace-notbelow=0 ./a.out > vg_trace OBSERVED RESULT The trace file ends with an error message: vex: priv/guest_amd64_toIR.c:946 (nameIReg): Assertion `reg >= 4 && reg < 8' failed. vex storage: T total 53281728 bytes allocated vex storage: P total 512 bytes allocated valgrind: the 'impossible' happened: LibVEX called failure_exit(). host stacktrace: ==442872==at 0x580285F2: show_sched_status_wrk (m_libcassert.c:406) ==442872==by 0x580286F7: report_and_quit (m_libcassert.c:477) ==442872==by 0x58028935: vgPlain_core_panic_at (m_libcassert.c:553) ==442872==by 0x5802895A: vgPlain_core_panic (m_libcassert.c:563) ==442872==by 0x58040112: failure_exit (m_translate.c:766) ==442872==by 0x580FE9A8: vex_assert_fail (main_util.c:249) ==442872==by 0x5813EF4D: nameIRegRexB (guest_amd64_toIR.c:946) ==442872==by 0x58158F03: dis_ESC_NONE.isra.50 (guest_amd64_toIR.c:21060) ==442872==by 0x581A35C7: disInstr_AMD64_WRK (guest_amd64_toIR.c:32980) EXPECTED RESULT The trace file does not contain error messages SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION The cause is, function "nameIRegRexB" classifies "al" as "irregular", while other functions, like "getIRegRexB", correctly classify it as regular. Attached a fix (al_debug_fix.patch). -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 439326] Valgrind 3.17.0 won't compile with Intel 2021 oneAPI compilers
https://bugs.kde.org/show_bug.cgi?id=439326 --- Comment #2 from Tanya --- (In reply to Jason Jones from comment #0) Hi Jason, Attached the fix I used for this issue. Would you be able to check whether this patch works for you? You'll need to rerun ./autogen.sh after applying this patch. Tanya -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 439326] Valgrind 3.17.0 won't compile with Intel 2021 oneAPI compilers
https://bugs.kde.org/show_bug.cgi?id=439326 Tanya changed: What|Removed |Added CC||tatyana.a.mine...@intel.com --- Comment #1 from Tanya --- Created attachment 140031 --> https://bugs.kde.org/attachment.cgi?id=140031=edit Update config file to allow icc-202x compiler versions Intel oneAPI compiler uses version numbers starting with "202x" instead of "1x". Valgrind config file was discarding this version as unsupported. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #57 from Tanya --- Attached an updated version of the AVX-512 patch for KNL and SkyLake. It is based on Valgrind 3.18 (GIT master from Jul, 13, commit 61307ee83121aa5f0b57a12a80e90fc2f414380a) The major improvements are: - Fixes for runtime crashes - Changed the way masked instructions access memory For build and test instructions, please refer to comment #51 (https://bugs.kde.org/show_bug.cgi?id=383010#c51) -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #56 from Tanya --- Created attachment 140028 --> https://bugs.kde.org/attachment.cgi?id=140028=edit Version 2: Part 4 of AVX-512 patch - (optional) Generator of AVX-512 .c files -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #135973|0 |1 is obsolete|| --- Comment #55 from Tanya --- Created attachment 140027 --> https://bugs.kde.org/attachment.cgi?id=140027=edit Version 2: Part 3 of AVX-512 patch - AVX-512 tests -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #135972|0 |1 is obsolete|| --- Comment #54 from Tanya --- Created attachment 140026 --> https://bugs.kde.org/attachment.cgi?id=140026=edit Version 2: Part 2 of AVX-512 patch - auto-generated files -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #135971|0 |1 is obsolete|| --- Comment #53 from Tanya --- Created attachment 140025 --> https://bugs.kde.org/attachment.cgi?id=140025=edit Version 2: Part 1 of AVX-512 patch - main implementation -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #51 from Tanya --- Hello, Attached updated AVX-512 patch for KNL and SkyLake. It is based on the GIT master from Feb. 20 (commit 1c9a0bf58a47e855e6e5bf78a30bcee0af835804) Attached files ~~ - AVX-512_KNL_SKX_p1_main.patch - Main AVX-512 Valgrind patch - AVX-512_KNL_SKX_p2_data.patch - Files, automatically generated by a script. These files are required for the build - AVX-512_KNL_SKX_p3_test.patch - AVX-512 regression tests - AVX-512_KNL_SKX_p4_filegen.patch - Generator of Valgrind AVX-512 .c files from a file with instruction descriptions. Not required for build or usage; useful for adding new instructions or modifying AVX-512 behaviour Functionality ~ - No known regressions on AVX2 machines - Nulgrind is functional (no known failures of small AVX-512 applications) on KNL and SkyLake - Memcheck does not crash on AVX-512 code; the analysis might still be incorrect Limitations ~~~ - Needs GCC version 8 or newer - Cannot emulate AVX-512 code on AVX-2 or older machine (some AVX-512 instructions are emulated through intrinsics) Build and test ~~ Clone Valgrind master: > git clone https://sourceware.org/git/valgrind.git > cd valgrind Apply the patch: > git apply AVX-512_KNL_SKX_p1_main.patch > git apply AVX-512_KNL_SKX_p2_data.patch > git apply AVX-512_KNL_SKX_p3_test.patch Optional development tool, not required for the build process: > git apply AVX-512_KNL_SKX_p4_filegen.patch Build: Please check that GCC version is 8 or higher. > ./autogen.sh > ./configure --prefix= On AVX-512 machine, verify that AVX-512 version will be built: open config.log and check that "BUILD_AVX512_TESTS_TRUE=''" and "CFLAGS=' -DAVX_512'" lines exist. > make install Quick test: /bin/valgrind ls Invoke a script to generate reference AVX-512 tests results (they are not provided with the patch because file size exceeds limit set by bugtracker): > ./scripts/generate_test_results.sh Run regression tests: > make regtest -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #50 from Tanya --- Created attachment 135974 --> https://bugs.kde.org/attachment.cgi?id=135974=edit Part 4 of AVX-512 patch - (optional) Generator of AVX-512 .c files -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #109005|0 |1 is obsolete|| --- Comment #49 from Tanya --- Created attachment 135973 --> https://bugs.kde.org/attachment.cgi?id=135973=edit Part 3 of AVX-512 patch - AVX-512 tests -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #48 from Tanya --- Created attachment 135972 --> https://bugs.kde.org/attachment.cgi?id=135972=edit Part 2 of AVX-512 patch - auto-generated files -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #128799|0 |1 is obsolete|| Attachment #129652|0 |1 is obsolete|| --- Comment #47 from Tanya --- Created attachment 135971 --> https://bugs.kde.org/attachment.cgi?id=135971=edit Part 1 of AVX-512 patch - main implementation -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #38 from Tanya --- (In reply to Alexandra Hajkova from comment #37) > Created attachment 128856 [details] > patch > > Hello Tanya, > > I slighly modified your patch to make it appliable (removed trailing > whitespaces, etc.) and used git format-patch. Hello Alexandra, Thank you! I will use this format for further patches. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya changed: What|Removed |Added Attachment #111693|0 |1 is obsolete|| Attachment #111694|0 |1 is obsolete|| Attachment #111695|0 |1 is obsolete|| Attachment #111696|0 |1 is obsolete|| Attachment #111697|0 |1 is obsolete|| Attachment #111698|0 |1 is obsolete|| --- Comment #34 from Tanya --- Created attachment 128799 --> https://bugs.kde.org/attachment.cgi?id=128799=edit Refactored implementation for Skylake machines Attached patch "AVX-512_prototype_all_skx_insns.patch". It implements Skylake AVX-512 instruction subsets (AVX-512F, AVX-512CD, AVX-512VL, AVX-512BW, AVX-512 DQ) and refactors AVX-512 functionality in the following way: - AVX-512 functionality is separated from the main code and only available under "AVX_512" define - AVX-512 instruction information is moved to C structures. They can be automatically generated form a master .csv file - Minimal AVX-512 Memcheck enabling The patch is in alpha-stage. It has been tested on AVX-512 NPB benchmarks: some benchmarks pass validation under Nulgrind and Memcheck, but validation failures and crashes still occur, and Memcheck often reports false-positive errors. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407735] Konsole: with Space before Cursos
https://bugs.kde.org/show_bug.cgi?id=407735 Tanya changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #3 from Tanya --- @tcanabrava - You are a genius now I have no issues with Konsole. I never thought to change the font to a monospace. I took for granted the default font has always worked for me. *Cheers -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407735] Konsole: with Space before Cursos
https://bugs.kde.org/show_bug.cgi?id=407735 --- Comment #2 from Tanya --- (In reply to tcanabrava from comment #1) > Created attachment 120186 [details] > attachment-15184-0.html > > What’s the font you are using? > > Em dom, 19 de mai de 2019 às 20:31, Tanya > escreveu: > > > https://bugs.kde.org/show_bug.cgi?id=407735 > > > > Bug ID: 407735 > >Summary: Konsole: with Space before Cursos > >Product: konsole > >Version: 19.04.1 > > Platform: Manjaro > > OS: Linux > > Status: REPORTED > > Severity: normal > > Priority: NOR > > Component: keyboard > > Assignee: konsole-de...@kde.org > > Reporter: debian.frea...@gmail.com > > Target Milestone: --- > > > > Created attachment 120185 [details] > > --> https://bugs.kde.org/attachment.cgi?id=120185=edit > > Konsole with space before cursor > > > > SUMMARY > > When typing with Konsole I have an increasing amount of space before my > > cursor. > > I use a .bashrc and removed it but still the issue persists. I've had this > > since I installed it not long ago. > > > > STEPS TO REPRODUCE > > 1. Open Konsole > > 2. Start typing > > 3. > > > > OBSERVED RESULT > > Space increses between the words and the cursos > > > > EXPECTED RESULT > > expected no spaces and words to flow normally > > > > SOFTWARE/OS VERSIONS > > Windows: > > macOS: > > Linux/KDE Plasma: Manjaro with Deepin Destop > > (available in About System) > > KDE Plasma Version: > > KDE Frameworks Version: > > Qt Version: > > > > ADDITIONAL INFORMATION > > I receive this in the deepin desktop and in the normal manjaro XFCE. > > > > -- > > You are receiving this mail because: > > You are the assignee for the bug. I am using the default - Cantarell size 10pt -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407735] New: Konsole: with Space before Cursos
https://bugs.kde.org/show_bug.cgi?id=407735 Bug ID: 407735 Summary: Konsole: with Space before Cursos Product: konsole Version: 19.04.1 Platform: Manjaro OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: keyboard Assignee: konsole-de...@kde.org Reporter: debian.frea...@gmail.com Target Milestone: --- Created attachment 120185 --> https://bugs.kde.org/attachment.cgi?id=120185=edit Konsole with space before cursor SUMMARY When typing with Konsole I have an increasing amount of space before my cursor. I use a .bashrc and removed it but still the issue persists. I've had this since I installed it not long ago. STEPS TO REPRODUCE 1. Open Konsole 2. Start typing 3. OBSERVED RESULT Space increses between the words and the cursos EXPECTED RESULT expected no spaces and words to flow normally SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: Manjaro with Deepin Destop (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION I receive this in the deepin desktop and in the normal manjaro XFCE. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #27 from Tanya <tatyana.a.mine...@intel.com> --- > Hi, Tanya, > > Thank you so much. > Once I get new patch, I will try it for basic operations in AVX-512 double > precision. > > Best Regards > > Elliot Hello Elliot, Attached a new patch. Sorry for the delay. Thank you, Tanya -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #26 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 111698 --> https://bugs.kde.org/attachment.cgi?id=111698=edit Nulgrind tests for AVX-512 machine, part 5 Files AVX-512_prototype_v4_tests.patch_p1 - AVX-512_prototype_v4_tests.patch_p5 are parts of new Nulgrind tests, split up because of site file size limit. To join them together, please run "cat AVX-512_prototype_v4_tests.patch_p? > AVX-512_prototype_v4_tests.patch" New test files, added by this patch (all in none/tests/amd64/): avx512.vgtest, avx512.c, avx512.stdout.exp, avx512.stderr.exp - test for AVX_512 instructions. VGETEXPPS and VSCALEFPS instruction tests fail on denormal values. avx-1_zmm.vgtest, avx-1_zmm.c, avx-1_zmm.stdout.exp, avx-1_zmm.stderr.exp - test for avx-1 instructions on AVX-512 machine. The only difference from original avx-1 test file is that it check bytes 511:256 of the used registers avx2-1_zmm.vgtest, avx2-1_zmm.c, avx2-1_zmm.stdout.exp avx2-1_zmm.stderr.exp - test for avx-2 instructions on AVX-512 machine. The only difference from the original file is that it check bytes 511:256 of the used registers -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya <tatyana.a.mine...@intel.com> changed: What|Removed |Added Attachment #111696|0 |1 is patch|| -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #25 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 111697 --> https://bugs.kde.org/attachment.cgi?id=111697=edit Nulgrind tests for AVX-512 machine, part 4 -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #24 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 111696 --> https://bugs.kde.org/attachment.cgi?id=111696=edit Nulgrind tests for AVX-512 machine, part 3 -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #23 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 111695 --> https://bugs.kde.org/attachment.cgi?id=111695=edit Nulgrind tests for AVX-512 machine, part 2 -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya <tatyana.a.mine...@intel.com> changed: What|Removed |Added Attachment #109001|0 |1 is obsolete|| Attachment #109002|0 |1 is obsolete|| Attachment #109004|0 |1 is obsolete|| --- Comment #22 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 111694 --> https://bugs.kde.org/attachment.cgi?id=111694=edit Nulgrind tests for AVX-512 machine, part 1 -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya <tatyana.a.mine...@intel.com> changed: What|Removed |Added Attachment #109000|0 |1 is obsolete|| --- Comment #21 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 111693 --> https://bugs.kde.org/attachment.cgi?id=111693=edit Updated AVX-512 implementation prototype with all KNL instructions The patch (AVX-512_prototype_v4_all_knl_insns.patch) implements all instructions from four subsets of AVX-512 (F, ER, CD, PF), available on KNL machines, in Nulgrind and in Memcheck. It also enables AVX-512 registers in vgdb. New source files, added by this patch: - VEX/priv/host_generic_simd512.c - Implementation of AVX-512 instrucitons in C, similar to VEX/priv/host_generic_simd256.c - VEX/priv/host_generic_vrcp14.c - Reference implementations of VRCP14 and VRSQRT14 instructions. - VEX/priv/host_generic_avx512er.c - Reference implementations of AVX-512 ER instruction set (VRCP28, VRSQRT28, and VEXP2 instructions). The latter two files are copied, with minor modifications, from https://software.intel.com/en-us/articles/reference-implementations-for-IA-approximation-instructions-vrcp14-vrsqrt14-vrcp28-vrsqrt28-vexp2 , files RECIP14.c and RECIP28EXP2.c, correspondingly AVX-512 KNL benchmarks that pass result verification under Nulgrind (not tested under Memcheck yet) with the patch: NPB IS, IOR, STREAM, STRIDE, AMG-2013, LAMMPS (both GCC-7.1.0 and Intel Compiler 17.0.4 builds). NPB benchmarks other than IS and the QMCPACK benchmark fail result verification or crash. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #19 from Tanya <tatyana.a.mine...@intel.com> --- (In reply to Hou, Ao-ping from comment #18) > Hello, > I have patched the "AVX-512_prototype_v3" patch. > But I can not use this patch for _mm512_setr_pd(...) > Could you please help me to solve it ? > > I encounter the following ERROR: > ... > > Elliot Hello Elliot, I can not reproduce the issue, but it looks like the application uses AVX-512 "vinsertf64x4" instruciton, which haven't been implemented in the patch. We still have a few AVX-512 instructions missing. I'll attach the updated patch with all AVX-512 instructions next week. Thank you, Tanya -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #17 from Tanya <tatyana.a.mine...@intel.com> --- Hello Julian, Sorry for a late reply. Thank you very much for the comments. We have fixed most of these bugs, and hope to finish adding and debugging KNL AVX-512 instructions in about a month. Regarding the performance on AVX-2 code: >> As a side note -- before this lands, I would want to do some performance >> runs to check that this doesn't impact performance (or correctness) of >> existing IA support. On a few tiny AVX-2 benchmarks, Memcheck overhead is 0-1% bigger than that of a "clean" Valgrind version. We will run and measure it on bigger AVX-2 benchmarks. Do you have any obligatory benchmarks for Valgrind correctness and performance? Regarding the test files: >> Is this intended to replace the existing AVX test? Or is it a new test? >> This is unclear. The attached tests are new tests, usable on AVX-512 machines only. They recheck AVX and AVX-2 instructions on bigger vector registers, similarly to how avx-2.c test rechecks avx-1 instructions on ymm registers. Would it be ok to keep them as three separate tests files for AVX-512, or should they be merged into one avx-512.c test file? Regarding the FMA instructions: >> If I understand this right, that means the existing cases for serial vFMA >> insns are wrong, and also the VEX implementation is wrong. Is that >> correct? If so, shouldn't we just fix both the test case and >> implementation? The issue was, for serial (32- and 64-bit) FMA instructions, Valgrind used to set bits [128:32] or [128:64] of the destination to zero, while they should be left unchanged. We have fixed the implementation and added a new test, because the none/tests/amd64/fma.c test seems to be designed to only verify one float or one double value. Would you prefer us to provide not-AVX-512-related changes as a separate patches? I also have a question on our implementation of translation of EVEX instructions to IR. Currently, we use separate functions for VEX- and EVEX- prefixed instructions (file VEX/priv/guest_amd64_toIR.c, functions, for example, dis_ESC_0F38__VEX and dis_ESC_0F38__EVEX, respectively). However, looking at the next Intel AVX-512 instruction sets, the VL (Vector Length) set allows to run EVEX-prefixed instructions on xmm and ymm registers, so it basically duplicates the VEX code (for example, EVEX-prefixed "vmovpdd xmm1, xmm2" is an equivalent of VEX-prefixed "vmovpdd xmm1, xmm2"). The easiest way to implement it would be to unite the EVEX- and VEX- translator functions into something like "dis_ESC_0F38__VEX_EVEX". On the upside, there would be less duplicated code. On the downside, it means that EVEX-related code would no longer be contained in separate __EVEX functions, so it would probably be more difficult to review. An alternate approach would be to add VL code (basically, copy the __VEX translations) to the __EVEX functions. As a downside, it may be bothersome to maintain the __VEX and the EVEX VL implementations identical. It we were to implement those instructions in the future, what would be a preferable approach? Thank you, Tanya -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #10 from Tanya <tatyana.a.mine...@intel.com> --- Hello, Sorry for the late response. Please find the attachment for the patch AVX-512_prototype_v3.patch. It mainly adds new instructions to Nulgrind; most of these instructions are not added to Memcheck yet. The patch also enables AVX-512 in VGDB. The patch has these updates to the AVX/AVX2 functionality: 1) AVX and AVX-2 instructions now set the unused upper half of destination ZMM vector register to all zeros. 2) Serial FMA instructions are supposed to keep the destination bits [127:32] for 32-bit instructions or [127:64] for the 64-bit unchanged; original Valgrind sets them to zero. Please let us know if this should be a separate patch. The tests for AVX-512, AVX-2, AVX and serial vFMA instructions are attached. The vFMA test must run correctly on the AVX machines, too. Please let me know if you would like us to provide the list of the implemented AVX-512 instructions. Regards, Tanya -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #9 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 109005 --> https://bugs.kde.org/attachment.cgi?id=109005=edit Nulgrind test for the serial vFMA instructions The "AVX-512_prototype_v3" patch changes the behaviour of the serial vFMA instructions. For these instructions, Valgrind sets destination bits [127:64] or [127:32] to zero; according to the ISE, these bits should remain unchanged. The test covers the changed instructions. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #8 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 109004 --> https://bugs.kde.org/attachment.cgi?id=109004=edit Nulgrind test for the AVX-2 instructions on AVX-512 machine AVX-2 regression test based on the existing Nulgrind AVX-2 test, outputs ZMM instead of YMM -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #7 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 109002 --> https://bugs.kde.org/attachment.cgi?id=109002=edit Nulgrind test for the AVX instructions on AVX-512 machine AVX regression test based on the existing Nulgrind AVX test, outputs ZMM registers instead of YMM -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #6 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 109001 --> https://bugs.kde.org/attachment.cgi?id=109001=edit Nulgrind test for the AVX-512 instructions The test is based on the existing Nulgrind AVX and AVX-2 tests -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya <tatyana.a.mine...@intel.com> changed: What|Removed |Added Attachment #107354|0 |1 is obsolete|| --- Comment #5 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 109000 --> https://bugs.kde.org/attachment.cgi?id=109000=edit Updated AVX-512 implementation prototype -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 --- Comment #4 from Tanya <tatyana.a.mine...@intel.com> --- (In reply to Julian Seward from comment #3) > Tanya, any progress on this? Julian, More AVX-512 instructions are added to Nulgrind (at the moment, 168 out of 347 are added), and some AVX-512 functionality (masking and displacement encoding) is updated. I will clean up the code and attach the updated patch in a few days. Regards, Tanya -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya <tatyana.a.mine...@intel.com> changed: What|Removed |Added Attachment #107012|0 |1 is obsolete|| --- Comment #2 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 107354 --> https://bugs.kde.org/attachment.cgi?id=107354=edit Corrected prototype implementation Julian, thank you for the comments! Attached a corrected version. Not fixed yet: - Return our own values from the CPUID - Allocate vregmap2 and vregmap3 only when needed I'm working on these issues. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Tanya <tatyana.a.mine...@intel.com> changed: What|Removed |Added CC||tatyana.a.mine...@intel.com -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 383010] New: Add support for AVX-512 instructions
https://bugs.kde.org/show_bug.cgi?id=383010 Bug ID: 383010 Summary: Add support for AVX-512 instructions Product: valgrind Version: 3.14 SVN Platform: unspecified OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: vex Assignee: jsew...@acm.org Reporter: tatyana.a.mine...@intel.com Target Milestone: --- Created attachment 107012 --> https://bugs.kde.org/attachment.cgi?id=107012=edit Prototype implementation of several AVX-512 instructions Valgrind does not support AVX-512 yet. AVX-512 programming reference and hardware emulator are available at https://software.intel.com/en-us/isa-extensions AVX-512 is supported by GCC 4.9 and later. Attached a prototype implementation of several AVX-512 instructions in Nulgrind. A test for these instructions is located in none/tests/amd64/avx512.c -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #33 from Tanya <tatyana.a.mine...@intel.com> --- (In reply to Julian Seward from comment #32) > (In reply to Tanya from comment #23) > > Attached an updated 32-bit version of the patch. 32-bit part of the previous > > patch sets "temp_sorb" variable incorrectly. > > As far as I understand, the test case should be the same for 32-bit > > architecture. > > Committed, with some tidying, r3385. Thanks for the patch. > > Also for the split tests. Ivo very kindly offered to connect them to > the build system. Ivo, Julian, Thank you very much! -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #30 from Tanya <tatyana.a.mine...@intel.com> --- (In reply to Julian Seward from comment #27) > (In reply to Tanya from comment #26) > > Created attachment 105777 [details] > > test without FS or GS prefixes > > Tanya, is that a tar file? Can you just attach a plain text file? It should be a plain text file, it opens correctly for me. It does nor open for you? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #29 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 105779 --> https://bugs.kde.org/attachment.cgi?id=105779=edit test with FS prefixes -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #27 from Julian Seward <jsew...@acm.org> --- (In reply to Tanya from comment #26) > Created attachment 105777 [details] > test without FS or GS prefixes Tanya, is that a tar file? Can you just attach a plain text file? --- Comment #28 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 105778 --> https://bugs.kde.org/attachment.cgi?id=105778=edit test with GS prefixes -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 Tanya <tatyana.a.mine...@intel.com> changed: What|Removed |Added Attachment #105776|0 |1 is obsolete|| --- Comment #26 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 105777 --> https://bugs.kde.org/attachment.cgi?id=105777=edit test without FS or GS prefixes -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #25 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 105776 --> https://bugs.kde.org/attachment.cgi?id=105776=edit test without FS or GS prefixes -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #23 from Tanya <tatyana.a.mine...@intel.com> --- (In reply to Ivo Raisr from comment #19) > (In reply to Tanya from comment #17) > > (In reply to Julian Seward from comment #9) > > > Committed, r3383, r16415. Thanks for the patches. > > > > Julian, > > Would it be possible to patch the 32-bit instruction parser as well? > > Sure, no problem. Please provide a patch and test cases. Ivo, Julian, Attached an updated 32-bit version of the patch. 32-bit part of the previous patch sets "temp_sorb" variable incorrectly. As far as I understand, the test case should be the same for 32-bit architecture. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #22 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 105753 --> https://bugs.kde.org/attachment.cgi?id=105753=edit Proposed patch for 32-bit architecture -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #17 from Tanya <tatyana.a.mine...@intel.com> --- (In reply to Julian Seward from comment #9) > Committed, r3383, r16415. Thanks for the patches. Julian, Would it be possible to patch the 32-bit instruction parser as well? -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #11 from Tanya <tatyana.a.mine...@intel.com> --- (In reply to Ivo Raisr from comment #10) Ivo, I cannot reproduce the issue on the latest Git sources with the 379525 patch (amd64 linux, gcc 6.2.0). I cannot get the latest SVN sources (firewall blocks the access, and the "socat" redirection did not work for me.) Would it be possible to update the Git repository with VALGRIND_3_13_BRANCH? Thank you, Tanya -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #8 from Tanya <tatyana.a.mine...@intel.com> --- (In reply to Julian Seward from comment #5) > (In reply to Tanya from comment #4) > > Proposed a patch that implements the missing opcodes and allows them to have > > any prefixes or operands. > > Tanya, thanks for the patch. Given that we are very close to freezing > for 3.13 and that this is really our last chance to get decoder fixes in > for the next several months, I'd like to commit this soon -- this week, > if the patch is OK. > > Do you have a test case for this? I think that is important. Julian, Added a C application with different opcode/prefix/ModRM combinations (provided by H.J. Lu). I'm not sure how to properly write Valgrind test cases. Attached a test with all opcode/prefix/ModRM combinations; please let me know if I should only leave a few. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #7 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 105677 --> https://bugs.kde.org/attachment.cgi?id=105677=edit Files for Valgrind test case attempt to make Valgrind test case -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 379525] Support more x86 nop opcodes
https://bugs.kde.org/show_bug.cgi?id=379525 --- Comment #6 from Tanya <tatyana.a.mine...@intel.com> --- Created attachment 105676 --> https://bugs.kde.org/attachment.cgi?id=105676=edit C test with different opcodes C application with NOPs with various opcode, prefix and ModRM combinations -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 373591] New: Offset between Wacom stylus and cursor on canvas.
https://bugs.kde.org/show_bug.cgi?id=373591 Bug ID: 373591 Summary: Offset between Wacom stylus and cursor on canvas. Product: krita Version: 3.0.1.1 Platform: Other OS: MS Windows Status: UNCONFIRMED Severity: normal Priority: NOR Component: krita gemini Assignee: krita-bugs-n...@kde.org Reporter: tanyaz...@gmail.com Target Milestone: --- When stylus is moved over canvas the cursor is tracking way off, but works normally in menus. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 298144] Wacom Cintiq 12wx has big offset on the canvas between the pen and the cursor.
https://bugs.kde.org/show_bug.cgi?id=298144 Tanya Zumstein <tanyaz...@gmail.com> changed: What|Removed |Added CC||tanyaz...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
