[amarok] [Bug 493882] Lyrics don't show the first (or two) sentence of the song

2024-10-05 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=493882

--- Comment #4 from Tuomas Nurmi  ---
Okay, thank you for testing. Can't reproduce right away myself, but I'll try
harder later.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 493882] Lyrics don't show the first (or two) sentence of the song

2024-09-30 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=493882

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for the report!
I'm not immediately able to reproduce with 3.1.1. I edited the lyrics applet
code a bit (ported from QtControls 1 to 2) between 3.1.0 and 3.1.1, so if  you
are encountering this with 3.1.0, I'd be very interested to hear if updating to
3.1.1 (released yesterday) actually fixes this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 493476] [FEATURE] add biases for artist/album that is (not) on playlist

2024-09-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=493476

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #2 from Tuomas Nurmi  ---
Yes, this is a nice idea. Extending meta bias might be one route, but adding a
new bias type altogether might also be something worth considering. Not sure
which one would be better yet.

I think e.g. the EchoNest bias might also contain some similar functionality,
as it can be set to target any artist in current playlist (although I haven't
myself ever used it, and have no idea if it is actually working nowadays), so
it might give some pointers (and meta bias can be used as reference when
working with the database queries required).

I haven't touched the dynamic playlist biases that much, but I think work
required for this would be pretty much contained under src/dynamic/ or even
src/dynamic/biases. Possibly you could e.g. try duplicating EchoNestBias and
creating a minimal/dummy new bias based on it as first step, and then try to
pick the required ideas from TagMatchBias to get some simple first working
prototype.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491354] Missing HOME icon in saved playlist menú

2024-09-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491354

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/acfe
   ||6f7f29e66e35ce1d4713fc1f5da
   ||2bc003561

--- Comment #2 from Tuomas Nurmi  ---
Git commit acfe6f7f29e66e35ce1d4713fc1f5da2bc003561 by Tuomas Nurmi.
Committed on 22/09/2024 at 11:20.
Pushed by nurmi into branch 'master'.

Add minimal delay to breadcrumb update to ensure home gets shown

Init now equivalent to the codepath when the widget gets resized, which was
working
properly all the time.

M  +1-0ChangeLog
M  +1-1src/browsers/BrowserBreadcrumbWidget.cpp

https://invent.kde.org/multimedia/amarok/-/commit/acfe6f7f29e66e35ce1d4713fc1f5da2bc003561

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 492001] Playing cd tracks only works with track 1

2024-09-21 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=492001

--- Comment #2 from Tuomas Nurmi  ---
Funny, I encountered this problem earlier, but now when I try to reproduce, it
seems to work ok. I'll try and see if I still might be able to trigger this
somehow...

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 493320] Yellow star missing

2024-09-18 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=493320

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Probably a duplicate of previous report
https://bugs.kde.org/show_bug.cgi?id=484395
Please try with Amarok 3.0 or later, which should include the fix.

*** This bug has been marked as a duplicate of bug 484395 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 484395] "New"-icon missing

2024-09-18 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=484395

--- Comment #4 from Tuomas Nurmi  ---
*** Bug 493320 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 492629] launching amarok failed remote peer disconnected

2024-09-17 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=492629

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #5 from Tuomas Nurmi  ---
(In reply to Eddie from comment #4)
> Created attachment 173749 [details]
> outcome of gdb backtrace

Okay, thank you very much!
So although some lines are slightly different, this apparently still is a
duplicate of https://bugs.kde.org/show_bug.cgi?id=486468 so marking as such.
There seems to be a potential solution in the latest message of the other bug
report, hopefully it fixes the crash for you, too.

*** This bug has been marked as a duplicate of bug 486468 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Phonon] [Bug 486468] Phonon-vlc with pipewire output crashes when Phonon::AudioOutput::setVolume is called without media

2024-09-17 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486468

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||brownedward...@yahoo.com

--- Comment #13 from Tuomas Nurmi  ---
*** Bug 492629 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 492629] launching amarok failed remote peer disconnected

2024-09-16 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=492629

--- Comment #3 from Tuomas Nurmi  ---
(In reply to Eddie from comment #2)
> Created attachment 173513 [details]
> gbd debug
> 
> Ok ran gbd amarok run | output is 
> Thread 1 "amarok" received signal SIGSEGV, Segmentation fault.
> ___pthread_mutex_lock (mutex=mutex@entry=0x28) at pthread_mutex_lock.c:80
> 80unsigned int type = PTHREAD_MUTEX_TYPE_ELISION (mutex);

Great, thank you!
Interesting, so this is apparently not quite the same issue as the other one.
Could you also try getting a gdb backtrace by running
gdb amarok
run
backtrace

and pasting the out here, please?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491520] Autocomplete on track editing

2024-09-07 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491520

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/de30
   ||00479b18a618915d3d5ee2abea0
   ||ab65d7411
 Resolution|--- |FIXED

--- Comment #2 from Tuomas Nurmi  ---
Git commit de3000479b18a618915d3d5ee2abea0ab65d7411 by Tuomas Nurmi.
Committed on 07/09/2024 at 11:58.
Pushed by nurmi into branch 'master'.

Fix track editor autocompletions

They were almost there all the time in Qt5 port, but the code just needed small
fixes.

M  +1-0ChangeLog
M  +5-5src/dialogs/TagDialog.cpp

https://invent.kde.org/multimedia/amarok/-/commit/de3000479b18a618915d3d5ee2abea0ab65d7411

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491603] Remove pause delay by default

2024-09-07 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491603

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/a13b
   ||dae943d760404d91235832008cf
   ||aa89e60c2

--- Comment #2 from Tuomas Nurmi  ---
Git commit a13bdae943d760404d91235832008cfaa89e60c2 by Tuomas Nurmi.
Committed on 07/09/2024 at 12:05.
Pushed by nurmi into branch 'master'.

Default to no fadeout on pause and stop

Not stopping sound instantly at user interaction can probably be considered as
'destructive' behaviour and shouldn't maybe be on by default.

M  +1-0ChangeLog
M  +2-2src/amarokconfig.kcfg

https://invent.kde.org/multimedia/amarok/-/commit/a13bdae943d760404d91235832008cfaa89e60c2

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 492629] launching amarok failed remote peer disconnected

2024-09-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=492629

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for the report! Looking at output, might be duplicate of
https://bugs.kde.org/show_bug.cgi?id=486468

Can you try running

gdb amarok
run

and checking if the output is similar to linked bug, i.e.

Thread 1 "amarok" received signal SIGSEGV, Segmentation fault.
vlc_pw_lock (ctx=0x800300080005) at modules/audio_output/vlc_pipewire.c:76
76  pw_thread_loop_lock(ctx->loop);

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 492406] Crash on entering text into the collection browser filter

2024-08-30 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=492406

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Yes, thank you for reporting this!
I know there's something like this hiding in there, I've got it on my personal
TODO, I have a hunch how to replicate, and this is the most common crash on
crash-reports.kde.org too. I believe this is related to some problems with Qt5
port of everything ThreadWeaver related, partially explained in
https://mail.kde.org/pipermail/amarok-devel/2015-October/013807.html , and
something I have on my list of "try working on after Qt6 port is done". Should
be possible to fix, but requires some work, and has a risk of breaking more
than fixes, so something I'd figure is more appropriate for 4.0 instead of e.g.
3.1.1.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 492218] Spectrum Analyzer not working

2024-08-28 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=492218

--- Comment #3 from Tuomas Nurmi  ---
(In reply to Walter Kargus from comment #2)
> I understand.  Since, Amarok is now being worked on again, I wanted to point
> this out.  I know Strawberry does it, but it is too small for my liking and
> thought it would be a simple fix.

Yes, it is good to have a bug report on this, thank you for filing! Even though
the bug might look obvious, now it is tracked, and additionally someone else
wondering the same might find this report and get some background information
here. Unfortunately not a simple fix, but definitely something I will spend
some time on after Qt6 port is done.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 492218] Spectrum Analyzer not working

2024-08-26 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=492218

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Unfortunately caused by missing functionality in phonon-vlc backend:
https://bugs.kde.org/show_bug.cgi?id=320215
Would work with phonon-gstreamer; however, phonon-gstreamer backend is in
unmaintained state, so cannot be recommended as an alternative. Also somewhat
related to equalizer problems with phonon-vlc:
https://bugs.kde.org/show_bug.cgi?id=486342

Fixing this (& some other similar bugs) will need either a load of work on
phonon-vlc, (someone taking up maintaining phonon-gstreamer or) changing the
Amarok playback system to use something else than Phonon. Hopefully one of
those will happen at some point not in too distant future.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 492001] Playing cd tracks only works with track 1

2024-08-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=492001

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Tuomas Nurmi  ---
Great, thank you for filing this report! I've noticed some hints about this
kind of problem myself & from other bug reports, but now that there's a
specific report I can refer to, I'll be more probable to inspect & try to fix
this sometime.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491603] Remove pause delay by default

2024-08-18 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491603

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Tuomas Nurmi  ---
I hadn't noticed / had forgotten it is on by default (when available). As
default options should indeed generally be the 'less destructive' ones; I think
it is justified to change this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491594] Amarok 3.x does not play Audio CDs

2024-08-14 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491594

--- Comment #5 from Tuomas Nurmi  ---
Okay, good to know. I think I've heard/seen hints of something like that
happen, but haven't actually done enough CD listening with Amarok to experience
it myself. A separate bug report for that might be good.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491594] Amarok 3.x does not play Audio CDs

2024-08-12 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491594

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #3 from Tuomas Nurmi  ---
Okay, I'm very happy to hear that!
Both KF5 and KF6 kio_audiocd can actually be installed concurrently, but as
kio_audiocd5 is not available from official openSUSE repositories any more,
having it as dependency for Amarok packages isn't probably completely ideal
option either.
But this is something that will get automatically fixed when we get to Qt6/KF6
Amarok.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491322] Playback doesn't start when playing from File browser

2024-08-12 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491322

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #6 from Tuomas Nurmi  ---
Okay, great to hear you managed to get playback  working!

As to why the gstreamer plugins were required; I guess it's a long story:
ffmpeg is indeed a dependency, but it isn't actually used for playback, only
for some song fingerprinting / something like that. For playback, Phonon is
used, the corresponding dependency in PKGBUILD listing being phonon-qt5. There
are multiple possible backends for Phonon, so I guess the package manager just
requires that one of them is installed, and in your case it was
phonon-gstreamer, which uses gstreamer (and its codecs) for playback.
(Phonon-gstreamer has been unmaintained for some years now, but it still works
somewhat ok. Another backend option is phonon-vlc)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491594] Amarok 3.x does not play Audio CDs

2024-08-12 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491594

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
This seems similar to https://bugs.kde.org/show_bug.cgi?id=486517 - can you
verify that you have kio_audiocd5 (=KF5 version of audiocd KIO library)
installed? This should be the correct package on openSUSE:
https://software.opensuse.org/package/kio_audiocd5

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491354] Missing HOME icon in saved playlist menú

2024-08-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491354

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||tuo...@norsumanageri.org
 Ever confirmed|0   |1

--- Comment #1 from Tuomas Nurmi  ---
Thank you for the report! I can reproduce: If the browser panel is too narrow
to fit the whole "Saved playlists" text, the home icon is indeed left out.
Resizing the browser panel immediately makes the icon appear, but if one then
goes back, and opens the "Saved playlists" again, the icon is hidden again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 325317] Feature request: Allow filtering by lack of tag, or empty tag.

2024-08-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=325317

Tuomas Nurmi  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||tuo...@norsumanageri.org

--- Comment #2 from Tuomas Nurmi  ---
Goes also for other tags in collection search, I believe. Would be useful; I'll
try to have a look sometime and see if this would be simple enough to
implement.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491516] Filter for displaying tracks with empty artist doesn't work

2024-08-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491516

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Tuomas Nurmi  ---
This would be useful, but seems that there's actually a similar report from 11
years ago, so closing this one in favour of the previous.

*** This bug has been marked as a duplicate of bug 325317 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 325317] Feature request: Allow filtering by lack of tag, or empty tag.

2024-08-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=325317

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||rob...@capuchin.co.uk

--- Comment #1 from Tuomas Nurmi  ---
*** Bug 491516 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491520] Autocomplete on track editing

2024-08-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491520

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||tuo...@norsumanageri.org
 Ever confirmed|0   |1

--- Comment #1 from Tuomas Nurmi  ---
Ah yes, I had almost forgotten that one. I'll have a look later if this could
be restored.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491322] Playback doesn't start when playing from File browser

2024-08-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491322

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #2 from Tuomas Nurmi  ---
Thank you for this report, too! 
Interesting. I'll be able to try to reproduce only a bit later, but could you
also try running
amarok --debug --debug-audio
and paste the corresponding output (including EngineController::playUrl and
some surrounding lines) here, too; I think it might provide some useful extra
output information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 426807] Out of range changedate prevents importing music folder

2024-08-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=426807

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||momo@protonmail.com

--- Comment #6 from Tuomas Nurmi  ---
*** Bug 491321 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 491321] MySQL error while adding music to collection

2024-08-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=491321

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for the report! Seems that the modification timestamp for the files,
2147483648 is in year 2038, so I believe this one is a duplicate of
https://bugs.kde.org/show_bug.cgi?id=426807 - a previously known bug of files
modified after year 2038 getting rejected during collection scan.

*** This bug has been marked as a duplicate of bug 426807 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 490650] src/musicbrainz/MusicDNSAudioDecoder.cpp fails to build on Ubuntu Jammy with Amarok git

2024-07-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=490650

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/6224
   ||40b76f3c174b41072fd358bd5f7
   ||ffdf6aca5
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #2 from Tuomas Nurmi  ---
Git commit 622440b76f3c174b41072fd358bd5f7ffdf6aca5 by Tuomas Nurmi.
Committed on 22/07/2024 at 23:13.
Pushed by nurmi into branch 'master'.

Fix compilation with ffmpeg < 5

Also drop some code for ffmpeg 0.10 and older, which were released 10+ years
ago.

M  +1-463  src/musicbrainz/MusicDNSAudioDecoder.cpp

https://invent.kde.org/multimedia/amarok/-/commit/622440b76f3c174b41072fd358bd5f7ffdf6aca5

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 490650] src/musicbrainz/MusicDNSAudioDecoder.cpp fails to build on Ubuntu Jammy with Amarok git

2024-07-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=490650

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you again for noticing! That's a sneaky place in code. Maybe I'll clean
up some bits too while I'm at it, as the older codepaths have been bypassed by
various modernization efforts, and still to use NULL etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 490147] crash amarok 3

2024-07-15 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=490147

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/9fe7
   ||35ac03eb8e2adba341a673c19a0
   ||ec1a6c047
 Status|REPORTED|RESOLVED

--- Comment #5 from Tuomas Nurmi  ---
Git commit 9fe735ac03eb8e2adba341a673c19a0ec1a6c047 by Tuomas Nurmi.
Committed on 15/07/2024 at 18:32.
Pushed by nurmi into branch 'master'.

Avoid thread-related crashes in CoverManager

Do all m_statusLabel updating through signals/slots so threads don't get messed
up
when both CoverManager status and network events and CoverView mouseover want
to
change it.

M  +1-0ChangeLog
M  +1-2src/covermanager/CoverManager.cpp
M  +0-1src/covermanager/CoverManager.h

https://invent.kde.org/multimedia/amarok/-/commit/9fe735ac03eb8e2adba341a673c19a0ec1a6c047

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 490147] crash amarok 3

2024-07-15 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=490147

--- Comment #4 from Tuomas Nurmi  ---
Okay, it was a bit more complicated than it first seemed, being actually
related to multiple threads wanting to alter UI items, but I think I got it.
(Was also reproducible by hovering mouse over one of the album items on
background while "Fetch Cover" dialog was open, and then a cover was selected
there and dialog closed.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 490147] crash amarok 3

2024-07-15 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=490147

--- Comment #3 from Tuomas Nurmi  ---
Very good, thank you! I can reproduce with the exact steps:
Have an album with no cover. Open cover manager, click "Fetch missing covers".
Wait for the album to get a cover. After that, click manually "Fetch Cover" for
that album, and try to assign a different cover to that -> crash.

Should be easily fixable, let's see.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 490266] Amarok fails to build with KF < 5.94 due to KStatefulBrush include

2024-07-14 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=490266

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/f614
   ||3b2df0b251f3e5e5665ea7121e4
   ||9b0f45d7e

--- Comment #2 from Tuomas Nurmi  ---
Git commit f6143b2df0b251f3e5e5665ea7121e49b0f45d7e by Tuomas Nurmi.
Committed on 14/07/2024 at 19:33.
Pushed by nurmi into branch 'master'.

Ifdef KStatefulBrush include to only Qt6 builds for now

M  +3-0src/playlist/ProgressiveSearchWidget.cpp

https://invent.kde.org/multimedia/amarok/-/commit/f6143b2df0b251f3e5e5665ea7121e49b0f45d7e

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 490266] Amarok fails to build with KF < 5.94 due to KStatefulBrush include

2024-07-14 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=490266

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for notifying!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 334579] too much useless knotify output when playing audio cd

2024-07-14 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=334579

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #3 from Tuomas Nurmi  ---
Tried with a pretty default system and didn't get the notifications any more.
Not quite sure if fixed due to changes in Amarok, Plasma or kio-audiocd, but
seems to be OK nowadays. (Should anyone still encounter this, please do reopen)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 371192] Export podcasts to OPML option missing in 2.8

2024-07-14 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=371192

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/274a
   ||8cb384f6515ddff7eeed1ec8511
   ||cac0b0f82
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Tuomas Nurmi  ---
Git commit 274a8cb384f6515ddff7eeed1ec8511cac0b0f82 by Tuomas Nurmi.
Committed on 14/07/2024 at 10:36.
Pushed by nurmi into branch 'master'.

Fixes in podcast provider actions

Show actions for non-empty podcast providers, too. Additionally, fix the
podcast
configuration dialog UI.

M  +1-0ChangeLog
M  +5-4src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp
M  +9-2src/core-impl/podcasts/sql/SqlPodcastProvider.cpp

https://invent.kde.org/multimedia/amarok/-/commit/274a8cb384f6515ddff7eeed1ec8511cac0b0f82

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 451738] Amarok crash when clicking on Quit [/src/browsers/BrowserCategoryListModel.cpp:30]

2024-07-13 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=451738

Tuomas Nurmi  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||tuo...@norsumanageri.org
 Status|REPORTED|CONFIRMED

--- Comment #2 from Tuomas Nurmi  ---
I happened to encounter this a couple of times when looking at other things,
but didn't find what are the exact steps to reproduce. I did some navigating in
file browser and checking through the Internet services + enabling/disabling
them when I got the crash.

I'm not completely sure if the bug fixed with
https://invent.kde.org/multimedia/amarok/-/commit/777195d457ce0488f5e03248b9c600fa4b9c9435
might be relevant here (and if this is also fixed with that), but I'll maybe
try reproducing later again to see if this might actually be fixed now, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 216528] saving playlist button should reflect save mode and use last used save mode

2024-07-13 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=216528

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/8b5c
   ||d306c4a58d06ecde08a77e9588c
   ||6f4abeb41
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #2 from Tuomas Nurmi  ---
Git commit 8b5cd306c4a58d06ecde08a77e9588c6f4abeb41 by Tuomas Nurmi.
Committed on 13/07/2024 at 17:37.
Pushed by nurmi into branch 'master'.

Remember the previous destination provider when saving playlist

M  +1-0ChangeLog
M  +23   -3src/playlist/PlaylistDock.cpp

https://invent.kde.org/multimedia/amarok/-/commit/8b5cd306c4a58d06ecde08a77e9588c6f4abeb41

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 254821] no warning when trying to reorder tracks in a sorted playlist

2024-07-13 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=254821

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/5c73
   ||a21b52f926c32c7d66f1deb14a7
   ||a43337f79
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Tuomas Nurmi  ---
Git commit 5c73a21b52f926c32c7d66f1deb14a7a43337f79 by Tuomas Nurmi.
Committed on 13/07/2024 at 17:36.
Pushed by nurmi into branch 'master'.

Don't show false reordering visual hints on a sorted playlist

M  +1-0ChangeLog
M  +15   -11   src/playlist/view/listview/PrettyListView.cpp

https://invent.kde.org/multimedia/amarok/-/commit/5c73a21b52f926c32c7d66f1deb14a7a43337f79

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 347058] Is the search in random on dynamic biassed towards similar tracks?

2024-07-12 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=347058

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |NOT A BUG
 CC||tuo...@norsumanageri.org
 Status|REPORTED|RESOLVED

--- Comment #1 from Tuomas Nurmi  ---
I've skimmed through the dynamic playlist code a bit, but haven't seen anything
like that anywhere.

I guess this is at least partially explained psychological confirmation bias;
additionally, this effect is probably intensified by the fact that long
symphonies are, well, long, so they're being played for longer times even if
they come up as often as shorter tracks. And, albums with longer tracks are
likely to have less tracks on album, so a greater proportion of them match the
tracknumber:1 too, I guess.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 261525] Amarok cuts off top of the text in some fields of Similar Artists applet

2024-07-12 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=261525

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED

--- Comment #15 from Tuomas Nurmi  ---
The old similar artists applet didn't make it to Amarok 3 so closing this
report (a new one without this bug coming soon at
https://invent.kde.org/multimedia/amarok/-/merge_requests/121 )

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 490147] crash amarok 3

2024-07-12 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=490147

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for your report! I didn't manage to reproduce this yet, but I'll try
harder a bit later.

How many albums / missing album covers are you fetching approximately?

If you can reproduce this, it might be useful to get console output from
"amarok --debug" prior to crash, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 327547] Last.fm Invalid session key error not handled: scrobbles silently lost until amarok restarts

2024-07-11 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=327547

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/9c17
   ||c0f5af71c1ebe0150039c4d8c32
   ||04992158d
 Resolution|--- |FIXED

--- Comment #11 from Tuomas Nurmi  ---
Git commit 9c17c0f5af71c1ebe0150039c4d8c3204992158d by Tuomas Nurmi.
Committed on 11/07/2024 at 21:46.
Pushed by nurmi into branch 'master'.

Add general handler for last.fm errors

InvalidSessionKey handled specifically and user is notified, other errors don't
look like having any specific handling for them is necessary.

M  +2-1ChangeLog
M  +20   -0src/App.cpp
M  +9-0src/App.h
M  +4-0src/services/gpodder/CMakeLists.txt
M  +4-0tests/CMakeLists.txt

https://invent.kde.org/multimedia/amarok/-/commit/9c17c0f5af71c1ebe0150039c4d8c3204992158d

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414826] Failed to open KDE Wallet to read Last.fm credentials

2024-07-11 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=414826

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/588d
   ||8cef9d760b86586afebdd58e8ee
   ||32c77c09d

--- Comment #1 from Tuomas Nurmi  ---
Git commit 588d8cef9d760b86586afebdd58e8ee32c77c09d by Tuomas Nurmi.
Committed on 11/07/2024 at 21:46.
Pushed by nurmi into branch 'master'.

Update last.fm login mechanism to use non-deprecated token method

The mobile session seems to be somewhat deprecated, and at least I'm not
totally
confident that it is actually possible to log in new sessions with it any more
in
Amarok.

Token-based method doesn't need password, so no new data is saved to kwallet in
any
case. Tries to use existing session key from config file and username from
config
file or kwallet. If username is saved to kwallet, tries to migrate it from
there.
If this succeeds, everything should be transparent to user. If not, an error
window
is shown and the account can be reconnected in plugin settings.

Thus also avoids any KWallet related bugs

M  +1-0ChangeLog
M  +20   -28   src/services/lastfm/LastFmConfigWidget.ui
M  +9-71   src/services/lastfm/LastFmService.cpp
M  +0-2src/services/lastfm/LastFmService.h
M  +15   -140  src/services/lastfm/LastFmServiceConfig.cpp
M  +2-12   src/services/lastfm/LastFmServiceConfig.h
M  +122  -41   src/services/lastfm/LastFmServiceSettings.cpp
M  +4-1src/services/lastfm/LastFmServiceSettings.h

https://invent.kde.org/multimedia/amarok/-/commit/588d8cef9d760b86586afebdd58e8ee32c77c09d

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 299461] amarok: song starts playing before gain is adjusted

2024-07-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=299461

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/99b5
   ||bd4f38f7311a77ed132dcce869a
   ||2cbbc3382
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #26 from Tuomas Nurmi  ---
Git commit 99b5bd4f38f7311a77ed132dcce869a2cbbc3382 by Tuomas Nurmi.
Committed on 10/07/2024 at 12:19.
Pushed by nurmi into branch 'master'.

Try harder to avoid volume spikes when ReplayGain changes from low to high

Gain was adjusted in slotNewTrackPlaying, which will be called only after
the new track has started playing, causing a volume spike of a second or so.
Try to avoid this by only doing gapless playback when the next track is
from the same album, and by setting gain a bit earlier in playback preparation
if possible.

Shouldn't affect any cases where ReplayGain is not available (= phonon-vlc)
or used.

M  +3-0ChangeLog
M  +51   -37   src/EngineController.cpp
M  +5-0src/EngineController.h

https://invent.kde.org/multimedia/amarok/-/commit/99b5bd4f38f7311a77ed132dcce869a2cbbc3382

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 489856] collection scanner fails/no files displayed

2024-07-07 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=489856

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for report! I'm not that familiar with scanner internals yet, but
let's see if I'll figure it out in process.

Is this a problem with a fresh new installation (I take from the description
that this is the case), or did you have previous Amarok data and the scanner
stopped working? I guess you could try (backupping+)clearing
~/.local/share/amarok and ~/.config/amarokrc.

Can you try running `amarok --debug`, starting a scan and seeing if there seems
to be anything scan problem related in output? (Possibly trying full rescan
from settings -> collection settings)

I think it's also possible to run collection scanner manually, saving the
output to xml file and importing it from collection settings. It could be
interesting to know if that works (or if not, what kind of errors are visible
in debug output)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 333745] Amarok exports unreadable playlists for other players...

2024-07-06 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=333745

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/3a33
   ||67e6aeee5a26c4191821055f656
   ||ce7ce3f4a
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #20 from Tuomas Nurmi  ---
Git commit 3a3367e6aeee5a26c4191821055f656ce7ce3f4a by Tuomas Nurmi.
Committed on 06/07/2024 at 16:24.
Pushed by nurmi into branch 'master'.

Improve encoding when exporting playlist files

Try to avoid excessive escaping local paths when exporting playlist files, and
take
one step more to ensure that remote URLs are encoded sensibly.

I tested exporting to each playlist format and both Amarok and VLC seemed to be
able
to open each of the files and URLs on them (including local files with
non-UTF-8
characters and remote streams with spaces in URL etc). Rhythmbox apparently
doesn't
support streams in playlists, but loaded the local files OK, too. In theory,
e.g.
m3u shouldn't be UTF-8 (m3u8 is a separate file format for that), but at least
all
three tested players successfully loaded tracks with paths saved as UTF-8, so
it's
probably OK.

I'm definitely not confident this is perfect now, but I'm quite sure it is
notably
better than it was before.

M  +10   -3src/core-impl/playlists/types/file/PlaylistFile.cpp

https://invent.kde.org/multimedia/amarok/-/commit/3a3367e6aeee5a26c4191821055f656ce7ce3f4a

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 488763] Progress bar area needs a visual overhaul

2024-07-01 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=488763

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Good comments, thank you. I think this kind of sub-divides into two aspects:
1) Making everything work nicer with dark mode and
2) maybe creating a new progress/toolbar layout to be the default for Qt6/KF6
Amarok (a third option, in addition to default "main" and slim toolbar,
probably; one has to be careful with adding too many options, but maybe 3 is
not too much here.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 329166] Amarok volume is often reset to 100% when changing tracks

2024-06-30 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=329166

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Tuomas Nurmi  ---
Closing as "likely fixed by phonon-vlc 0.9 in 2018".
(Should someone still encounter this with modern Phonon / Amarok versions,
please do reopen)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 435779] Files on the playlist with unusual characters are not recognized again after being temporarily unavailable

2024-06-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=435779

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/1255
   ||e9a6297a6916343a9dc94459e1e
   ||8c3a43e63
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Tuomas Nurmi  ---
Git commit 1255e9a6297a6916343a9dc94459e1e8c3a43e63 by Tuomas Nurmi.
Committed on 29/06/2024 at 17:55.
Pushed by nurmi into branch 'master'.

Load paths from XSPF playlists as UTF-8

The saving code writes them in UTF-8 and the xml header generated states that
the
encoding is UTF-8, so they should be definitely also read as UTF-8.

M  +1-0ChangeLog
M  +1-1src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp

https://invent.kde.org/multimedia/amarok/-/commit/1255e9a6297a6916343a9dc94459e1e8c3a43e63

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 277146] Playlist sorting menu is sorted alphabetically by their English name

2024-06-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=277146

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/06a2
   ||d20fa6547512e99c66023cbe301
   ||63fcc73eb
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from Tuomas Nurmi  ---
Git commit 06a2d20fa6547512e99c66023cbe30163fcc73eb by Tuomas Nurmi.
Committed on 23/06/2024 at 21:59.
Pushed by nurmi into branch 'master'.

Sort playlist sorting breadcrumb menu by localized names

Internally, they are ordered alphabetically by English name, but no reason not
to
do localized sorting when preparing the breadcrumb menu.

M  +1-0ChangeLog
M  +5-0src/playlist/PlaylistBreadcrumbItem.cpp

https://invent.kde.org/multimedia/amarok/-/commit/06a2d20fa6547512e99c66023cbe30163fcc73eb

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 341907] When set larger KDE font size, Amarok collection view cannot display text fully

2024-06-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=341907

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||tuo...@norsumanageri.org
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Tuomas Nurmi  ---
Tried doubling KDE font size with Amarok 3.0.1, everything's really big but I
didn't see any clipped texts in collection view, so perhaps this has been fixed
by Qt5/KF5 port. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 471216] Amarok starts using 100% CPU after a time playing

2024-06-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=471216

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 489063] Invalid for loop syntax in src/services/gpodder/GpodderServiceSettings.cpp

2024-06-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=489063

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/bb7f
   ||6812b29d8497755d1edcedfe74c
   ||7ab15183e

--- Comment #2 from Tuomas Nurmi  ---
Git commit bb7f6812b29d8497755d1edcedfe74c7ab15183e by Tuomas Nurmi.
Committed on 23/06/2024 at 20:43.
Pushed by nurmi into branch 'master'.

Temporarily fix for syntax

... by reverting to previous foreach. Better fix will come later among the
other
remaining foreach ports.

M  +1-1src/services/gpodder/GpodderServiceSettings.cpp

https://invent.kde.org/multimedia/amarok/-/commit/bb7f6812b29d8497755d1edcedfe74c7ab15183e

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 489063] Invalid for loop syntax in src/services/gpodder/GpodderServiceSettings.cpp

2024-06-23 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=489063

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
My apologies, I thought I was building everything on my development system, but
dependencies for gpodder were not installed so I missed this one (and it's also
blind spot for invent.kde.org CI). Thank you for reporting!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 488946] Invalid CMake syntax for !BUILD_WITH_QT6

2024-06-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=488946

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/4562
   ||eae3f1f9fd82dd1a558eb7e9e53
   ||cf6da20f9
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Tuomas Nurmi  ---
Git commit 4562eae3f1f9fd82dd1a558eb7e9e53cf6da20f9 by Tuomas Nurmi.
Committed on 22/06/2024 at 14:30.
Pushed by nurmi into branch 'master'.

Fix CMake syntax

M  +2-2src/CMakeLists.txt
M  +1-1src/core-impl/collections/db/sql/mysqlcollection/CMakeLists.txt
M  +1-1src/core-impl/storage/sql/mysqlestorage/CMakeLists.txt
M  +1-1src/core-impl/storage/sql/mysqlserverstorage/CMakeLists.txt
M  +2-2src/services/ampache/CMakeLists.txt
M  +1-1src/services/lastfm/CMakeLists.txt
M  +1-1src/services/magnatune/CMakeLists.txt

https://invent.kde.org/multimedia/amarok/-/commit/4562eae3f1f9fd82dd1a558eb7e9e53cf6da20f9

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 488946] Invalid CMake syntax for !BUILD_WITH_QT6

2024-06-22 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=488946

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Ah, indeed. Thank you very much for reporting!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 391146] fix crash when some external APIs fail

2024-06-21 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=391146

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/312c
   ||36046bf49dadb2edbb0398989ff
   ||b6230c3e0
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Tuomas Nurmi  ---
Git commit 312c36046bf49dadb2edbb0398989ffb6230c3e0 by Tuomas Nurmi.
Committed on 21/06/2024 at 10:31.
Pushed by nurmi into branch 'master'.

Some theoretical mp3tunes fixes

Fix the regexes so it compiles again. Add fixes to reported bugs, including a
patch
posted by Zhouyang on bugs.kde.org. Fix some issues reported by code quality
scans.

The compilation works now, but no effort was made even to try to test the
functionality,
which probably doesn't. The service as is would need work and everything is
turned off
in CMakeLists. Hard to predict if someone will ever update the mp3tunes to
usable state,
but I guess there's no point in NOT applying the potential fixes (as the
service still
exists, so maybe not everything's not broken enough to justify removing) so the
existing
issues can be happily cleaned up at least.
Related: bug 419132

M  +3-2src/services/mp3tunes/Mp3tunesService.cpp
M  +3-3src/services/mp3tunes/Mp3tunesServiceCollection.cpp
M  +27   -5src/services/mp3tunes/libmp3tunes/locker.c

https://invent.kde.org/multimedia/amarok/-/commit/312c36046bf49dadb2edbb0398989ffb6230c3e0

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 419132] potential memory leakage: forget using libxml2 API 'xmlXPathFreeContext‘ after 'xmlXPathNewContext'

2024-06-21 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=419132

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/312c
   ||36046bf49dadb2edbb0398989ff
   ||b6230c3e0

--- Comment #3 from Tuomas Nurmi  ---
Git commit 312c36046bf49dadb2edbb0398989ffb6230c3e0 by Tuomas Nurmi.
Committed on 21/06/2024 at 10:31.
Pushed by nurmi into branch 'master'.

Some theoretical mp3tunes fixes

Fix the regexes so it compiles again. Add fixes to reported bugs, including a
patch
posted by Zhouyang on bugs.kde.org. Fix some issues reported by code quality
scans.

The compilation works now, but no effort was made even to try to test the
functionality,
which probably doesn't. The service as is would need work and everything is
turned off
in CMakeLists. Hard to predict if someone will ever update the mp3tunes to
usable state,
but I guess there's no point in NOT applying the potential fixes (as the
service still
exists, so maybe not everything's not broken enough to justify removing) so the
existing
issues can be happily cleaned up at least.
Related: bug 391146

M  +3-2src/services/mp3tunes/Mp3tunesService.cpp
M  +3-3src/services/mp3tunes/Mp3tunesServiceCollection.cpp
M  +27   -5src/services/mp3tunes/libmp3tunes/locker.c

https://invent.kde.org/multimedia/amarok/-/commit/312c36046bf49dadb2edbb0398989ffb6230c3e0

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 435779] Files on the playlist with unusual characters are not recognized again after being temporarily unavailable

2024-06-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=435779

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #3 from Tuomas Nurmi  ---
Tested on Amarok 3.0.1, Debian Bullseye (LANG=fi_FI.UTF-8):
Added an album in collection with 3 tracks to playlist: Track01öä.ogg,
Track02.ogg, and Track03.ogg. Visible normally.
Exited Amarok
Moved the directory containing the three tracks.
Started Amarok. The tracks are greyed. Exited Amarok.
Moved the directory back. Started Amarok. The tracks are recognized correctly.

However, if I add Track01öä.ogg to playlist when it does not reside in a
collection path and repeat the steps, it stays greyed out and it's path
contains garbled characters.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 294817] Clicks on a playlist: Please add saved playlist to current playlist on middle-click

2024-06-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=294817

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Tuomas Nurmi  ---
Amarok 3.0.1, apparently double-clicking a saved playlist adds it to current
playlist. I think the behaviour's intuitive & sensible enough now (renaming
available with F2 and right click menu), so maybe I'll just close this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 486457] build of amarok3 crashes on starte

2024-06-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=486457

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |WAITINGFORINFO

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 308032] Plase add "do not show again" checkbox to reload lyrics warning message box

2024-06-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=308032

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Tuomas Nurmi  ---
No reload warning dialogs in 3.0 lyrics applet, so I guess I'll close this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 329166] Amarok volume is often reset to 100% when changing tracks

2024-06-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=329166

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #13 from Tuomas Nurmi  ---
Has anyone encountered this bug since 2018 (phonon-vlc 0.9) or so?

I read through phonon-vlc commit history and this one looks potentially like
something that might have fixed this issue
https://invent.kde.org/libraries/phonon-vlc/-/commit/c42d7a05bbdae2c5d7ad71d1d4a91e81e9247841
but I'm definitely not sure and would love to hear if anyone has any
experiences

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 463946] Amarok equalizer - usability suggestions

2024-06-20 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=463946

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Just a short take on the points:
1. is a bug in unmaintained phonon-gstreamer, related report here:
https://bugs.kde.org/show_bug.cgi?id=350735 - wontfix, unfortunately

2. No opinion here (yet?)

3. Had a quick look through image search results. Seems like there is more
variation within equalizers in computer software, but actual physical hardware
devices indeed very often seem to have a range of +-12.0 dB.
Smaller range would probably make handling slider positions nicer, too; I think
I'll try something before 3.0.2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 316020] track info changes unnecessarily

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=316020

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Tuomas Nurmi  ---
Button to stop automatic Wikipedia page refresh was added in 3.0.0, and
additionally now when testing, the Wikipedia applet back button seems to always
go to the actual page viewed previously, so I believe this one is actually
fixed in current Amarok versions -> Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 300596] Wish: Add Last.FM event radios to the menu

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=300596

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED

--- Comment #1 from Tuomas Nurmi  ---
Closing as last.fm has deprecated/discontinued its radio API since.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 279264] Add a way to filter upcoming events by country or region

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=279264

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Closing as upcoming events applet wasn't ever ported to Qt5, its remnants were
removed from source tree just lately and last.fm dropped the APIs used
somewhere in 2015.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 279267] Upcoming events applet should use OpenStreetMap instead of Google Maps, at least optionally

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=279267

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Closing as upcoming events applet wasn't ever ported to Qt5, its remnants were
removed from source tree just lately and last.fm dropped the APIs used
somewhere in 2015.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 351503] Cannot start a search for venues in the upcoming event applet configuration

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=351503

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||tuo...@norsumanageri.org

--- Comment #8 from Tuomas Nurmi  ---
Closing as upcoming events applet wasn't ever ported to Qt5, its remnants were
removed from source tree just lately and last.fm dropped the APIs used
somewhere in 2015.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 262080] Confusing configuration option "Group venue events:"

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=262080

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Tuomas Nurmi  ---
Closing as upcoming events applet wasn't ever ported to Qt5, its remnants were
removed from source tree just lately and last.fm dropped the APIs used
somewhere in 2015.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 136502] Link to Google Music Search for currently playing artist

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=136502

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org

--- Comment #4 from Tuomas Nurmi  ---
Closing as https://www.google.com/musicsearch/ has been 404 since 2018.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 226055] Various artists sort/group toggle

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=226055

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
I think this was pretty much implemented in mid 2010's (e.g. commit
78415dfb1d44c59a0f53748071ce57b794abd83a in 2013) and works very nicely
nowadays. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 337787] JJ: Make equalizer reflect changes as soon as it's setting is changed

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=337787

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #2 from Tuomas Nurmi  ---
Closing this one as times have changed and
https://bugs.kde.org/show_bug.cgi?id=486342 describes the current behaviour
with different phonon backends better.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 350735] Equalizer should give frequency range for each band

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=350735

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |UNMAINTAINED
 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org

--- Comment #3 from Tuomas Nurmi  ---
Closing as the equalizer frequency range bug happens only with phonon-gstreamer
backend, which was declared unmaintained in 2022 by upstream. (The frequencies
are shown correctly with phonon-vlc.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 406701] Some tracks not marked as played (zero length?) with vlc backend

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=406701

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/e3dd
   ||77951ea229a183b3e246ad29db0
   ||747c76e4a
 Status|REPORTED|RESOLVED

--- Comment #2 from Tuomas Nurmi  ---
Git commit e3dd77951ea229a183b3e246ad29db0747c76e4a by Tuomas Nurmi.
Committed on 19/06/2024 at 12:18.
Pushed by nurmi into branch 'master'.

Use our own progress for track if phonon reported position seems wrong

At least phonon-vlc seems to commonly claim position is 0 when stopping
playback / when backend prepares the next track to be played gapless. This
causes the track progress on stop to be 0, which further causes the track
scrobbling and playcount updates get skipped (at least sometimes), it seems.
Related: bug 337849

M  +2-0ChangeLog
M  +7-1src/EngineController.cpp

https://invent.kde.org/multimedia/amarok/-/commit/e3dd77951ea229a183b3e246ad29db0747c76e4a

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 337849] Last played time not updated on some tracks

2024-06-19 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=337849

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/e3dd
   ||77951ea229a183b3e246ad29db0
   ||747c76e4a
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #20 from Tuomas Nurmi  ---
Git commit e3dd77951ea229a183b3e246ad29db0747c76e4a by Tuomas Nurmi.
Committed on 19/06/2024 at 12:18.
Pushed by nurmi into branch 'master'.

Use our own progress for track if phonon reported position seems wrong

At least phonon-vlc seems to commonly claim position is 0 when stopping
playback / when backend prepares the next track to be played gapless. This
causes the track progress on stop to be 0, which further causes the track
scrobbling and playcount updates get skipped (at least sometimes), it seems.
Related: bug 406701

M  +2-0ChangeLog
M  +7-1src/EngineController.cpp

https://invent.kde.org/multimedia/amarok/-/commit/e3dd77951ea229a183b3e246ad29db0747c76e4a

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 338741] Queue is lost after restart

2024-06-16 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=338741

Tuomas Nurmi  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/42ae
   ||1037138eba73e1856389742862a
   ||59866c7f2
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Tuomas Nurmi  ---
Git commit 42ae1037138eba73e1856389742862a59866c7f2 by Tuomas Nurmi.
Committed on 16/06/2024 at 10:35.
Pushed by nurmi into branch 'master'.

Ensure XSPF playlist file structure exists before trying to save queue

Turns out there was a functionality implemented to save and restore queue on
quit
and restart, but it just needed a tiny fix. Nice!

M  +1-0ChangeLog
M  +2-0src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp

https://invent.kde.org/multimedia/amarok/-/commit/42ae1037138eba73e1856389742862a59866c7f2

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 440869] Mistake in "11 Equalizer gains include pre-amp"

2024-06-15 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=440869

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/d0e9
   ||934e1b4d04c4711bd8226a8e83f
   ||7101d7137
 Resolution|--- |FIXED

--- Comment #2 from Tuomas Nurmi  ---
Git commit d0e9934e1b4d04c4711bd8226a8e83f7101d7137 by Tuomas Nurmi.
Committed on 15/06/2024 at 16:54.
Pushed by nurmi into branch 'master'.

Fix typo in config label

M  +1-1src/amarokconfig.kcfg

https://invent.kde.org/multimedia/amarok/-/commit/d0e9934e1b4d04c4711bd8226a8e83f7101d7137

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 440869] Mistake in "11 Equalizer gains include pre-amp"

2024-06-15 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=440869

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Missed this one earlier when updating some strings for 3.0.1, but I guess no
reason not to fix this now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 337849] Last played time not updated on some tracks

2024-06-11 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=337849

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||martin.bo...@bonuama.de

--- Comment #19 from Tuomas Nurmi  ---
*** Bug 488210 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 488210] Replay Counter / last Replay doesn't write in ogg-files

2024-06-11 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=488210

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Tuomas Nurmi  ---
Thank you for the report. I believe the issue is same as the one described in
https://bugs.kde.org/show_bug.cgi?id=337849 , so marking as such. I'll probably
try to inspect this more in a couple of weeks.

*** This bug has been marked as a duplicate of bug 337849 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487937] Amarok crashes on startup in Debian

2024-06-10 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487937

--- Comment #5 from Tuomas Nurmi  ---
Great to hear you managed to solve the issue! Happy listening!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487937] Amarok crashes on startup in Debian

2024-06-08 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487937

--- Comment #3 from Tuomas Nurmi  ---
Thank you for the additional information!

Sounds somewhat odd. However, the fact that you encounter the crash on multiple
machines, but people using the official Debian packages don't seem to have the
problem in general,  would suggest there might be some common denominator in
your environment. 
I guess one possibility could be something related to your systems' locale (the
"mysql_embedded: Warning: Charset id '83' csname 'utf8' trying to replace
existing csname 'utf8mb3'" doesn't sound like something I recall seeing in
output myself, but I'm not sure); or, seeing the samba libs in backtrace,
something related to your network environment.
I wonder what would happen if you tried temporarily removing/hiding
libsamba-util.so.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487937] Amarok crashes on startup in Debian

2024-06-05 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487937

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
Thank you for your report; looks interesting. The fact that bitmap_copy in
libsamba-util.so.0 is called from libmariadbd.so.19 seems a little suspicious
(I could be wrong, though); at least on my openSUSE system, libmariadbd.so.19
doesn't seem to link against anything samba related.
I'll try to figure out if there's something that could be easily tested (or
possibly I'll try installing a Debian sid system myself later and see if I can
reproduce)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 322107] Amarok creates MP3 invalid files with bitrate above 320 Kbps

2024-06-02 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=322107

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #10 from Tuomas Nurmi  ---
I tried adding
parameters << QStringLiteral("-write_xing") << QStringLiteral("0"); 
to Mp3Format::ffmpegParameters() and although I can observe some differences in
tracks transcoded with and without that parameter, I haven't yet found a way to
measure what is the maximal bitrate. Any hints welcome.

"and the transcode removes the originals"
sounds strange, doesn't happen here when I'm doing the transcoding via "Copy to
Collection"; the original remains in place

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 450500] Amarok boosts audio to the maximum, with manual track changes

2024-06-02 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=450500

--- Comment #10 from Tuomas Nurmi  ---
That's great to hear, thank you! Happy listening!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 450500] Amarok boosts audio to the maximum, with manual track changes

2024-06-01 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=450500

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org

--- Comment #8 from Tuomas Nurmi  ---
I don't think I've ever encountered this (mainly phonon-qt5-gstreamer user).
Could be something that has been fixed since somewhere, although I can't right
away think of any specific change that might have been the solution.
Do you still encounter this with Amarok 3.0.0 and recent KDE/Phonon versions?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 281706] add search/filtering/grouping to covergrid

2024-06-01 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=281706

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org
 Resolution|--- |UNMAINTAINED

--- Comment #2 from Tuomas Nurmi  ---
Closing as covergrid hasn't worked since Qt4/KDE4 versions and the sources were
just removed from git master with
https://invent.kde.org/multimedia/amarok/-/commit/6c5a54284d2366ffe8b025a88b241b39e173f2bc
. Covergrid was neat; hopefully something similar can be implemented after Qt6
port.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 220327] wish: integrate moodbar generator

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=220327

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||theun...@gmail.com

--- Comment #20 from Tuomas Nurmi  ---
*** Bug 328692 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 328692] You should make moodbar as Clementine does...

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=328692

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||tuo...@norsumanageri.org
 Status|REPORTED|RESOLVED

--- Comment #3 from Tuomas Nurmi  ---
Heh, funny, this is actually a duplicate.

*** This bug has been marked as a duplicate of bug 220327 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 199483] Make "Album Artist/Album" collection browser mode the default

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=199483

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
 CC||tuo...@norsumanageri.org

--- Comment #36 from Tuomas Nurmi  ---
This seems to have been fixed with commit
78415dfb1d44c59a0f53748071ce57b794abd83a in June 2013. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 321107] Import OPML file for Podcast not working.

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=321107

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
 CC||tuo...@norsumanageri.org

--- Comment #6 from Tuomas Nurmi  ---
Closing, as this works nowadays and was apparently fixed a couple of years ago.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 420964] Current Track applet layout a mess

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=420964

--- Comment #12 from Tuomas Nurmi  ---
Great to hear, thank you! Happy listening!

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 487730] Crash when typing in search box

2024-05-29 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=487730

Tuomas Nurmi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||tuo...@norsumanageri.org

--- Comment #1 from Tuomas Nurmi  ---
I believe this has been fixed since 2.9.71, please update Amarok to 3.0.0.
(3.0.0 doesn't seem to be available in any official repository for openSUSE
Leap 15.5, but at least home:ecsos and home:plasmaregataos community
repositories seem to provide packages for it)

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 313791] "Remove duplicates" function does not work completely

2024-05-28 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=313791

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/1569
   ||068ddc911e1a8970aa3afe2ae6d
   ||5986d3877
 Resolution|--- |FIXED

--- Comment #22 from Tuomas Nurmi  ---
Git commit 1569068ddc911e1a8970aa3afe2ae6d5986d3877 by Tuomas Nurmi.
Committed on 28/05/2024 at 17:45.
Pushed by nurmi into branch 'master'.

Avoid deleting multiple tracks instead of one

Additionally, testing with a sample track provided on bug report, an earlier
bug
where duplicate removal didn't work for some specific tracks seems to have been
fixed.

M  +1-0ChangeLog
M  +5-5src/playlist/PlaylistController.cpp

https://invent.kde.org/multimedia/amarok/-/commit/1569068ddc911e1a8970aa3afe2ae6d5986d3877

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 290270] Lyrics applet does not use I-Beam cursor

2024-05-28 Thread Tuomas Nurmi
https://bugs.kde.org/show_bug.cgi?id=290270

Tuomas Nurmi  changed:

   What|Removed |Added

 CC||tuo...@norsumanageri.org
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Tuomas Nurmi  ---
I-Beam in 3.0.0. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   4   >