[yakuake] [Bug 411681] Yakuake always shown on second monitor on wayland

2021-09-26 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=411681

--- Comment #14 from Valerii Malov  ---
>From what I gather, spectacle doesn't do anything under Wayland, instead it
makes dbus calls to KWin asking it to take a screenshot with desired parameters

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 411681] Yakuake always shown on second monitor on wayland

2021-07-23 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=411681

Valerii Malov  changed:

   What|Removed |Added

 CC||jazzv...@gmail.com
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #11 from Valerii Malov  ---
I've looked into Yakuake code, if the target screen is not fixed, it checks
global cursor position to determine where to open the console.

This relies on QCursor::pos(), which is explicitly unavailable on Wayland (see
https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Drop_Menus).
It constantly returns (0,0) so yakuake picks top left screen. I cannot find an
alternative API to this, I assume wayland clients are not supposed to have
access to global cursor position :/

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 434921] Removing the 'wacom' kernel module while a wacom tablet is plugged in freezes computer.

2021-03-26 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=434921

--- Comment #3 from Valerii Malov  ---
I would suspect this is a problem with wacom module itself or possibly X11
wacom driver, since if you're loggout out, kded (and wacomtablet kded module)
should not be involved.

You can try reproducing this once again, now with X11 stopped completely,
possibly to rule out X11 driver and leaving only the kernel module.

You can try reporting this issue to: 
https://github.com/linuxwacom/input-wacom/issues (kernel driver)
https://github.com/linuxwacom/xf86-input-wacom/issues (X11 driver, if the
problem disappears with X11 stopped)

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 434921] Removing the 'wacom' kernel module while a wacom tablet is plugged in freezes computer.

2021-03-25 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=434921

--- Comment #1 from Valerii Malov  ---
Can you please check if this is reproducible while your tablet is plugged in,
but you're not logged into KDE?
e.g. have only login manager running on one terminal, plug in the tablet & run
modprobe -r from another tty?

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 428802] Dependency missing?

2020-11-08 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=428802

--- Comment #1 from Valerii Malov  ---
I think the problem is that kglobalaccel5 seems to be crashing (signal 6 is
abort) on startup for some reason
Try running kglobalaccel5 from a terminal and share the output here

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 366223] Wacom tablet doesn't work if mouse in left handed mode

2020-11-08 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=366223

Valerii Malov  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|REPORTED|RESOLVED

--- Comment #2 from Valerii Malov  ---
Can't reproduce the left-handed mode bug either

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 428534] Compile error: pressurecurvewidget.cpp missing include [reported fixed - not]

2020-11-08 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=428534

Valerii Malov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Valerii Malov  ---
This was fixed in master but didn't make it in v3.2.0 tag for some reason, my
mistake probably

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 424971] Wacomtablet Stylus Tracking Relative Mode is now same as Absolute Mode

2020-08-12 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=424971

--- Comment #2 from Valerii Malov  ---
Hi, thanks for reporting, this wasn't intentional. This should be fixed with
last commit in 3.3 branch. I haven't tagged it yet so I guess it's going to be
the 3.3.0 version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 424971] Wacomtablet Stylus Tracking Relative Mode is now same as Absolute Mode

2020-08-12 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=424971

Valerii Malov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/syst
   ||em/wacomtablet/commit/a442f
   ||6f6eb3bdc864264e5b507f16e6c
   ||de64c60e
 Resolution|--- |FIXED

--- Comment #1 from Valerii Malov  ---
Git commit a442f6f6eb3bdc864264e5b507f16e6cde64c60e by Valerii Malov.
Committed on 12/08/2020 at 18:50.
Pushed by valeriymalov into branch '3.3'.

Fix xsetwacom adapter

+disable setting screenspace to desktop, as relative mode seems to work
even without this, and forcing screen space to destkop will override
profile setting

M  +3-3src/kded/tablethandler.cpp
M  +13   -25   src/kded/xsetwacomadaptor.cpp

https://invent.kde.org/system/wacomtablet/commit/a442f6f6eb3bdc864264e5b507f16e6cde64c60e

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 419392] Settings for touch zone are not saved

2020-07-02 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=419392

--- Comment #10 from Valerii Malov  ---
Daniel, indeed I'm not sure if there's a way to determine which screen the
built-in tablet belongs to, although I haven't checked on libwacom API in a
while. I'll try to look into that PR again later.

I've looked into the issue of losing settings, seems like a two-fold problem:
1. Single-screen setups are always mapped to desktop, not specific screen. IIRC
this was done to support relative mapping mode since it only works when the
tablet is mapped to the whole desktop.
2. When a screen goes missing, mapping defaults to desktop and this setting is
saved, which breaks the mapping when the screen is reconnected.

For now as a workaround I've disabled saving the "default" desktop to tablet
profile. This should in theory address 2nd and somewhat 1st issue. If anyone
can build & test current master that would be swell.

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 419392] Settings for touch zone are not saved

2020-07-02 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=419392

--- Comment #9 from Valerii Malov  ---
Git commit 1d0b04478c9eb7df24a664ba7cc5096c5b0ee675 by Valerii Malov.
Committed on 02/07/2020 at 21:14.
Pushed by valeriymalov into branch 'master'.

don't override the screenspace in profile if the screen is missing

M  +12   -12   src/kded/tablethandler.cpp

https://invent.kde.org/system/wacomtablet/commit/1d0b04478c9eb7df24a664ba7cc5096c5b0ee675

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 414468] missing libxcb-xinput-dev in the list of packages to install

2020-07-02 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=414468

Valerii Malov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 423420] kde_wacom_table segfault

2020-07-02 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=423420

Valerii Malov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #1 from Valerii Malov  ---
Should be fixed by
https://invent.kde.org/system/wacomtablet/commit/ee670ec282e81998d2142c1986c963005fc3d264

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 418827] Wacom Intuos Pro M connected via bluetooth

2020-03-15 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=418827

Valerii Malov  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/wac
   ||omtablet/f830e44cd1be0f91ee
   ||e61ca3517866b3399a718b
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Valerii Malov  ---
Git commit f830e44cd1be0f91eee61ca3517866b3399a718b by Valerii Malov.
Committed on 15/03/2020 at 17:17.
Pushed by valeriymalov into branch 'master'.

Wacom Intuos Pro M bluetooth definition

M  +20   -0data/wacom_devicelist

https://commits.kde.org/wacomtablet/f830e44cd1be0f91eee61ca3517866b3399a718b

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 416361] Is the fix for QTBUG-77826 supported?

2020-01-16 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=416361

--- Comment #1 from Valerii Malov  ---
Since it's a bug in Qt, most appropriate fix would be having fixed Qt version
packaged in Kubuntu and Neon. Unfortunately at the moment there seems to be no
fixed version released yet.

Bugfix release 5.14.1 seems to be planned on January 21st (in 4 days):
https://wiki.qt.io/Qt_5.14_Release
This is probably the version rolling Neon can get.

Next 5.12 LTS bugfix release is on January 30. This is probably the version
Kubuntu 19.10 will get.

It might be worth opening a bug in corresponding packaging bugtrackers (neon
packaging section here, kubuntu on launchpad) when those versions arrive to
speed up the process. Judging by https://bugreports.qt.io/browse/QTBUG-77826
there are still some concerns if the fix is safe so maybe the fix shouldn't be
backported by disros yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ktorrent] [Bug 383127] KTorrent crash while closing

2019-09-29 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=383127

--- Comment #44 from Valerii Malov  ---
Git commit b819ef6a35495e12a204cbb241cdb2502c4cd11e by Valerii Malov.
Committed on 29/09/2019 at 20:31.
Pushed by valeriymalov into branch '5.1'.

Cleanup ViewModel a bit and try to fix crash on exit

Summary:
removeTorrent makes changes to torrent list we are currently iterating
on per-item basis, this causees heap-use-after-free in onExit
Just call removeRows which should be functionally the same, but should
delete all items in one batch

Compact ViewModel::Item::update
Fix a few warnings (0 as nullptr, c-style casts)
Remove useless ViewModel::torrentFromIndex variant
Remove unused headers
add CMakeLists.txt.user to gitignore

Test Plan: build with asan, run & exit, see asan stacktrace before changing
onExit

Reviewers: stikonas

Differential Revision: https://phabricator.kde.org/D24149

M  +1-0.gitignore
M  +1-0ktorrent/CMakeLists.txt
M  +51   -146  ktorrent/view/viewmodel.cpp
M  +10   -11   ktorrent/view/viewmodel.h

https://commits.kde.org/ktorrent/b819ef6a35495e12a204cbb241cdb2502c4cd11e

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 411505] Image shows wrong layout for Intuos 3 Express Buttons

2019-09-08 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=411505

Valerii Malov  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Valerii Malov  ---
Thanks for the report, I'll need to check if other tablets using same layout
have same numbering, then I'll fix it on the layout image.

Probably a better solution will be moving away from showing numbers and just
indicating which button has been pressed when configuring them, but this isn't
trivial to implement since once a button has been mapped, it emits they
key/button is has been mapped to.

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 399971] Cintiq Pro 13's Full Tablet Mapping is off

2019-08-09 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=399971

--- Comment #1 from Valerii Malov  ---
Hi,

Version 3.2.0 has been recently released, and it contains a fix for tablets
that don't use entire sensor.
In theory, this fix should address current issue. It doesn't address any other
issues related to screen tablets unfortunately.

If you're still interested, you can test your tablet with new version and
report about results here, that'd be highly appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 397775] Support for CTL-4100WL

2019-06-27 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=397775

Valerii Malov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/wac
   ||omtablet/a431056224a4e610cf
   ||ad763cc9ea92d0dc8aff4a

--- Comment #10 from Valerii Malov  ---
Git commit a431056224a4e610cfad763cc9ea92d0dc8aff4a by Valerii Malov.
Committed on 27/06/2019 at 16:45.
Pushed by valeriymalov into branch 'master'.

Add mapping for Wacom Intuos BT S (bluetooth)

Based on https://github.com/linuxwacom/input-wacom/wiki/Device-IDs wacom 0376
and wacom 0377 are the same device

M  +14   -0data/wacom_devicelist

https://commits.kde.org/wacomtablet/a431056224a4e610cfad763cc9ea92d0dc8aff4a

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 405582] Incorrect hardware button mapping for Express Keys - Wacom Intuos BT S

2019-06-27 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=405582

Valerii Malov  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/wac
   ||omtablet/fcb003a2525e659dd9
   ||f936743ac23d6defa1e729
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #11 from Valerii Malov  ---
Git commit fcb003a2525e659dd9f936743ac23d6defa1e729 by Valerii Malov.
Committed on 27/06/2019 at 16:31.
Pushed by valeriymalov into branch 'master'.

Add mapping for Wacom Intuos BT S

Based on the mappings provided by Stefano Guidoni for larger tablets

M  +14   -0data/wacom_devicelist

https://commits.kde.org/wacomtablet/fcb003a2525e659dd9f936743ac23d6defa1e729

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 405582] Incorrect hardware button mapping for Express Keys - Wacom Intuos BT S

2019-06-18 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=405582

--- Comment #8 from Valerii Malov  ---
Hi, could you please test the following device description

[0376]
model=CTL-4100WL
name=Wacom Intuos BT S
padbuttons=4
wheel=no
touchring=no
touchstripl=no
touchstripr=no
hwbutton1=1
hwbutton2=2
hwbutton3=3
hwbutton4=8

To do so you have put this in a file ~/.config/tabletdblocalrc, e.g. open it
any text editor you use

$ kate ~/.config/tabletdblocalrc

and paste the content above into the file. If you already have a section for
[0376], replace it with the content above. Then restart wacom service it via
System Settings -> Startup and Shutdown -> Background Services -> Wacom Tablet
and click Stop and then Start (or just re-login into Plasma session).

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 407015] wacomtablet FTBFS with gcc9+

2019-05-02 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=407015

Valerii Malov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 407015] wacomtablet FTBFS with gcc9+

2019-04-28 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=407015

Valerii Malov  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #2 from Valerii Malov  ---
Hello, I don't think I can get my hands on gcc9 in the nearest time. Can you
try the following patch?
https://cgit.kde.org/wacomtablet.git/patch/?id=810487c4fa240f6de598b04929bb08de8937feb5

If this fixes the problem, do you need a bugfix release or you'll fine with a
patch until next release?

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 407015] wacomtablet FTBFS with gcc9+

2019-04-28 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=407015

--- Comment #1 from Valerii Malov  ---
Git commit 810487c4fa240f6de598b04929bb08de8937feb5 by Valerii Malov.
Committed on 28/04/2019 at 16:10.
Pushed by valeriymalov into branch 'master'.

(Supposedly) fix building with gcc9

I don't really have access to gcc9 right now to test, but this should
fix "static assertion failed: unique_ptr's deleter must be invocable
with a pointer"

M  +1-1src/common/libwacomwrapper.cpp

https://commits.kde.org/wacomtablet/810487c4fa240f6de598b04929bb08de8937feb5

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 405582] Incorrect hardware button mapping for Express Keys - Wacom Intuos BT S

2019-04-02 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=405582

--- Comment #3 from Valerii Malov  ---
I'm checking libwacom database and according to
https://github.com/linuxwacom/libwacom/commit/e19147988aed8d42de72e980e6d47d4b6f473044

056a:0376 doesn't have unusual button mapping, i.e. buttons *should* be
1/2/3/4, so detecting express key 4 as hw button 8 might be an error on
tabletfinder part (or previous mapping setting interfering with it).

Can you update libwacom to 0.30 or newer via package manager and remove your
~/.config/tabletdblocalrc file? This *should* provide correct mapping out of
the box, without the need for tabletfinder.

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 405582] Incorrect hardware button mapping for Express Keys - Wacom Intuos BT S

2019-03-29 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=405582

--- Comment #1 from Valerii Malov  ---
Hi, could you please share:
* USB ID of your tablet. Run "lsusb | grep Wacom" and share the output.
* Version of libwacom library installed in the system

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 403720] Baloo crashes at KDE session start.

2019-03-13 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=403720

--- Comment #3 from Valerii Malov  ---
Git commit eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d by Valerii Malov.
Committed on 13/03/2019 at 21:50.
Pushed by valeriymalov into branch 'master'.

Baloo engine: treat every non-success code as a failure

Summary:
Treating only MDB_NOTFOUND as an error leads to use of uninitliazed
pointers and handle IDs in other cases (e.g. when get fails with
MDB_BAD_TXN) and wreaks havoc in the application.
Related: bug 361186, bug 390823, bug 372880, bug 395888, bug 367480

Reviewers: #baloo, bruns, poboiko

Reviewed By: #baloo, bruns

Subscribers: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18664

M  +12   -9src/engine/database.cpp
M  +26   -17   src/engine/documentdatadb.cpp
M  +30   -22   src/engine/documentdb.cpp
M  +30   -22   src/engine/documentiddb.cpp
M  +25   -16   src/engine/documenttimedb.cpp
M  +0-1src/engine/documenturldb.cpp
M  +4-3src/engine/documenturldb.h
M  +4-5src/engine/fsutils.cpp
M  +28   -15   src/engine/idfilenamedb.cpp
M  +22   -13   src/engine/idtreedb.cpp
M  +37   -29   src/engine/mtimedb.cpp
M  +0-2src/engine/phraseanditerator.cpp
M  +24   -19   src/engine/positiondb.cpp
M  +31   -27   src/engine/postingdb.cpp
M  +47   -13   src/engine/transaction.cpp
M  +4-4src/engine/transaction.h
M  +3-2src/file/extractorprocess.cpp
M  +5-5src/file/fileindexscheduler.cpp
M  +5-4src/file/indexcleaner.cpp
M  +0-1src/file/main.cpp
M  +1-1src/file/metadatamover.cpp

https://commits.kde.org/baloo/eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 367480] Crash inside Baloo::PostingCodec::decode

2019-03-13 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=367480

--- Comment #136 from Valerii Malov  ---
Git commit eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d by Valerii Malov.
Committed on 13/03/2019 at 21:50.
Pushed by valeriymalov into branch 'master'.

Baloo engine: treat every non-success code as a failure

Summary:
Treating only MDB_NOTFOUND as an error leads to use of uninitliazed
pointers and handle IDs in other cases (e.g. when get fails with
MDB_BAD_TXN) and wreaks havoc in the application.
Related: bug 361186, bug 390823, bug 372880, bug 395888, bug 403720

Reviewers: #baloo, bruns, poboiko

Reviewed By: #baloo, bruns

Subscribers: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18664

M  +12   -9src/engine/database.cpp
M  +26   -17   src/engine/documentdatadb.cpp
M  +30   -22   src/engine/documentdb.cpp
M  +30   -22   src/engine/documentiddb.cpp
M  +25   -16   src/engine/documenttimedb.cpp
M  +0-1src/engine/documenturldb.cpp
M  +4-3src/engine/documenturldb.h
M  +4-5src/engine/fsutils.cpp
M  +28   -15   src/engine/idfilenamedb.cpp
M  +22   -13   src/engine/idtreedb.cpp
M  +37   -29   src/engine/mtimedb.cpp
M  +0-2src/engine/phraseanditerator.cpp
M  +24   -19   src/engine/positiondb.cpp
M  +31   -27   src/engine/postingdb.cpp
M  +47   -13   src/engine/transaction.cpp
M  +4-4src/engine/transaction.h
M  +3-2src/file/extractorprocess.cpp
M  +5-5src/file/fileindexscheduler.cpp
M  +5-4src/file/indexcleaner.cpp
M  +0-1src/file/main.cpp
M  +1-1src/file/metadatamover.cpp

https://commits.kde.org/baloo/eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 372880] baloo_file crashes in Baloo::IdFilenameDB::get()

2019-03-13 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=372880

--- Comment #9 from Valerii Malov  ---
Git commit eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d by Valerii Malov.
Committed on 13/03/2019 at 21:50.
Pushed by valeriymalov into branch 'master'.

Baloo engine: treat every non-success code as a failure

Summary:
Treating only MDB_NOTFOUND as an error leads to use of uninitliazed
pointers and handle IDs in other cases (e.g. when get fails with
MDB_BAD_TXN) and wreaks havoc in the application.
Related: bug 361186, bug 390823, bug 395888, bug 367480, bug 403720

Reviewers: #baloo, bruns, poboiko

Reviewed By: #baloo, bruns

Subscribers: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18664

M  +12   -9src/engine/database.cpp
M  +26   -17   src/engine/documentdatadb.cpp
M  +30   -22   src/engine/documentdb.cpp
M  +30   -22   src/engine/documentiddb.cpp
M  +25   -16   src/engine/documenttimedb.cpp
M  +0-1src/engine/documenturldb.cpp
M  +4-3src/engine/documenturldb.h
M  +4-5src/engine/fsutils.cpp
M  +28   -15   src/engine/idfilenamedb.cpp
M  +22   -13   src/engine/idtreedb.cpp
M  +37   -29   src/engine/mtimedb.cpp
M  +0-2src/engine/phraseanditerator.cpp
M  +24   -19   src/engine/positiondb.cpp
M  +31   -27   src/engine/postingdb.cpp
M  +47   -13   src/engine/transaction.cpp
M  +4-4src/engine/transaction.h
M  +3-2src/file/extractorprocess.cpp
M  +5-5src/file/fileindexscheduler.cpp
M  +5-4src/file/indexcleaner.cpp
M  +0-1src/file/main.cpp
M  +1-1src/file/metadatamover.cpp

https://commits.kde.org/baloo/eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 395888] baloo_file crashes in Baloo::DocTermsCodec::decode()

2019-03-13 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=395888

--- Comment #4 from Valerii Malov  ---
Git commit eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d by Valerii Malov.
Committed on 13/03/2019 at 21:50.
Pushed by valeriymalov into branch 'master'.

Baloo engine: treat every non-success code as a failure

Summary:
Treating only MDB_NOTFOUND as an error leads to use of uninitliazed
pointers and handle IDs in other cases (e.g. when get fails with
MDB_BAD_TXN) and wreaks havoc in the application.
Related: bug 361186, bug 390823, bug 372880, bug 367480, bug 403720

Reviewers: #baloo, bruns, poboiko

Reviewed By: #baloo, bruns

Subscribers: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18664

M  +12   -9src/engine/database.cpp
M  +26   -17   src/engine/documentdatadb.cpp
M  +30   -22   src/engine/documentdb.cpp
M  +30   -22   src/engine/documentiddb.cpp
M  +25   -16   src/engine/documenttimedb.cpp
M  +0-1src/engine/documenturldb.cpp
M  +4-3src/engine/documenturldb.h
M  +4-5src/engine/fsutils.cpp
M  +28   -15   src/engine/idfilenamedb.cpp
M  +22   -13   src/engine/idtreedb.cpp
M  +37   -29   src/engine/mtimedb.cpp
M  +0-2src/engine/phraseanditerator.cpp
M  +24   -19   src/engine/positiondb.cpp
M  +31   -27   src/engine/postingdb.cpp
M  +47   -13   src/engine/transaction.cpp
M  +4-4src/engine/transaction.h
M  +3-2src/file/extractorprocess.cpp
M  +5-5src/file/fileindexscheduler.cpp
M  +5-4src/file/indexcleaner.cpp
M  +0-1src/file/main.cpp
M  +1-1src/file/metadatamover.cpp

https://commits.kde.org/baloo/eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 390823] baloo_file crashes in Baloo::IdTreeDB::get()

2019-03-13 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=390823

--- Comment #1 from Valerii Malov  ---
Git commit eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d by Valerii Malov.
Committed on 13/03/2019 at 21:50.
Pushed by valeriymalov into branch 'master'.

Baloo engine: treat every non-success code as a failure

Summary:
Treating only MDB_NOTFOUND as an error leads to use of uninitliazed
pointers and handle IDs in other cases (e.g. when get fails with
MDB_BAD_TXN) and wreaks havoc in the application.
Related: bug 361186, bug 372880, bug 395888, bug 367480, bug 403720

Reviewers: #baloo, bruns, poboiko

Reviewed By: #baloo, bruns

Subscribers: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18664

M  +12   -9src/engine/database.cpp
M  +26   -17   src/engine/documentdatadb.cpp
M  +30   -22   src/engine/documentdb.cpp
M  +30   -22   src/engine/documentiddb.cpp
M  +25   -16   src/engine/documenttimedb.cpp
M  +0-1src/engine/documenturldb.cpp
M  +4-3src/engine/documenturldb.h
M  +4-5src/engine/fsutils.cpp
M  +28   -15   src/engine/idfilenamedb.cpp
M  +22   -13   src/engine/idtreedb.cpp
M  +37   -29   src/engine/mtimedb.cpp
M  +0-2src/engine/phraseanditerator.cpp
M  +24   -19   src/engine/positiondb.cpp
M  +31   -27   src/engine/postingdb.cpp
M  +47   -13   src/engine/transaction.cpp
M  +4-4src/engine/transaction.h
M  +3-2src/file/extractorprocess.cpp
M  +5-5src/file/fileindexscheduler.cpp
M  +5-4src/file/indexcleaner.cpp
M  +0-1src/file/main.cpp
M  +1-1src/file/metadatamover.cpp

https://commits.kde.org/baloo/eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 361186] baloo_file crashes in Baloo::PositionDB::get()

2019-03-13 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=361186

--- Comment #6 from Valerii Malov  ---
Git commit eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d by Valerii Malov.
Committed on 13/03/2019 at 21:50.
Pushed by valeriymalov into branch 'master'.

Baloo engine: treat every non-success code as a failure

Summary:
Treating only MDB_NOTFOUND as an error leads to use of uninitliazed
pointers and handle IDs in other cases (e.g. when get fails with
MDB_BAD_TXN) and wreaks havoc in the application.
Related: bug 390823, bug 372880, bug 395888, bug 367480, bug 403720

Reviewers: #baloo, bruns, poboiko

Reviewed By: #baloo, bruns

Subscribers: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18664

M  +12   -9src/engine/database.cpp
M  +26   -17   src/engine/documentdatadb.cpp
M  +30   -22   src/engine/documentdb.cpp
M  +30   -22   src/engine/documentiddb.cpp
M  +25   -16   src/engine/documenttimedb.cpp
M  +0-1src/engine/documenturldb.cpp
M  +4-3src/engine/documenturldb.h
M  +4-5src/engine/fsutils.cpp
M  +28   -15   src/engine/idfilenamedb.cpp
M  +22   -13   src/engine/idtreedb.cpp
M  +37   -29   src/engine/mtimedb.cpp
M  +0-2src/engine/phraseanditerator.cpp
M  +24   -19   src/engine/positiondb.cpp
M  +31   -27   src/engine/postingdb.cpp
M  +47   -13   src/engine/transaction.cpp
M  +4-4src/engine/transaction.h
M  +3-2src/file/extractorprocess.cpp
M  +5-5src/file/fileindexscheduler.cpp
M  +5-4src/file/indexcleaner.cpp
M  +0-1src/file/main.cpp
M  +1-1src/file/metadatamover.cpp

https://commits.kde.org/baloo/eb68430ae5f4fc4c4a2e5b1798683ff6a639ad3d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 367480] Crash inside Baloo::PostingCodec::decode

2019-02-02 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=367480

Valerii Malov  changed:

   What|Removed |Added

 CC||jazzv...@gmail.com

--- Comment #128 from Valerii Malov  ---
This seems to be a somewhat multi-layered issue

A lot of crashes seem to be caused by unsafe handling of LMDB calls, namely
mdb_dbi_open, mdb_dbi_create and mdb_dbi_get aren't checked for errors other
than MDB_NOTFOUND, which allows the application to proceed as normal even if
the call erorred out, so the output buffers passed to those functions aren't
filled out. What makes it worse is that those buffers aren't initalized in the
baloo engine either, so we end up with random database handles and random value
pointers. Then those random handles/pointers are passed somewhere else where
they cause a crash.

As a workardound I've added more strict error checks across baloo engine, if
anyone wants to help with the review or testing:
https://phabricator.kde.org/D18664
Posting in the most popular bug to expedite things (^:

Hard to tell exactly which crashes on the bugtracker this addresses due to
nature of crashes. This fixes crashes I've had on my machine, however this
doesn't really address other issues.

First, I have no idea why baloo makes so many calls that fail in the first
place (corrupted database?). In my case after applying the fix on each run it's
spending around 5-10 minutes using 1 core for 100%, spamming logs with a
MDB_BAD_TXN error, and then calms down.  From user point of view this is
probably worse than crashing.

Second, overall I think baloo engine needs some refactoring because it has a
lot of duplicate code. Probably a proper way to fix this would be a safe
wrapper around LMDB api.

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 401870] Localization problem in the plasmoid

2018-12-13 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=401870

Valerii Malov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[wacomtablet] [Bug 398747] Wacom Intuos (2015) button 2 not working

2018-12-09 Thread Valerii Malov
https://bugs.kde.org/show_bug.cgi?id=398747

Valerii Malov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.