[krita] [Bug 414995] Feature request for implementation of 3d mouse support.
https://bugs.kde.org/show_bug.cgi?id=414995 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e CC||victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395000] Crash when adding Filter Mask node using addChildNode() in Python
https://bugs.kde.org/show_bug.cgi?id=395000
--- Comment #3 from Victor Wåhlström ---
The API has been updated and now requires passing in a selection or a node when
calling createFilterMask. Typically that would be the node you intend to parent
the filter mask to.
In your example you would change
fm = d.createFilterMask("SHS[Blacken]", filter)
to
fm = d.createFilterMask("SHS[Blacken]", filter, n)
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 395000] Crash when adding Filter Mask node using addChildNode() in Python
https://bugs.kde.org/show_bug.cgi?id=395000 Victor Wåhlström changed: What|Removed |Added Latest Commit||https://invent.kde.org/kde/ ||krita/commit/a9b68dbb910e20 ||53a3329e6839b6dc8e0bf1e62e Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #2 from Victor Wåhlström --- Git commit a9b68dbb910e2053a3329e6839b6dc8e0bf1e62e by Victor Wåhlström. Committed on 09/05/2019 at 11:31. Pushed by victorw into branch 'master'. Change Document::createFilterMask API to require either a Selection or a Node from which to initialize the selection with. This prevents a crash that would occur when parenting a FilterMask without a selection to a node. M +32 -4libs/libkis/Document.cpp M +12 -1libs/libkis/Document.h M +2-1plugins/extensions/pykrita/sip/krita/Document.sip https://invent.kde.org/kde/krita/commit/a9b68dbb910e2053a3329e6839b6dc8e0bf1e62e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395000] Crash when adding Filter Mask node using addChildNode() in Python
https://bugs.kde.org/show_bug.cgi?id=395000 Victor Wåhlström changed: What|Removed |Added CC||victor.wahlstrom@initiali.s ||e Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 391035] feature request: reload in scripter
https://bugs.kde.org/show_bug.cgi?id=391035 Victor Wåhlström changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC||victor.wahlstrom@initiali.s ||e Resolution|--- |FIXED --- Comment #3 from Victor Wåhlström --- Patch was submitted over a year ago. Closing as fixed. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 403436] channel[].visible() always returns False
https://bugs.kde.org/show_bug.cgi?id=403436 Victor Wåhlström changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/kde/ ||krita/commit/84eb32f2b99892 ||e6afff09936ffc30dd57ca3fb6 --- Comment #5 from Victor Wåhlström --- Git commit 84eb32f2b99892e6afff09936ffc30dd57ca3fb6 by Victor Wåhlström. Committed on 05/05/2019 at 16:07. Pushed by victorw into branch 'master'. Fix crash when checking if a channel is visible Documentation states that if channelFlags is empty, then all channels are considered active. M +4-2libs/libkis/Channel.cpp https://invent.kde.org/kde/krita/commit/84eb32f2b99892e6afff09936ffc30dd57ca3fb6 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 403436] channel[].visible() always returns False
https://bugs.kde.org/show_bug.cgi?id=403436 Victor Wåhlström changed: What|Removed |Added CC||victor.wahlstrom@initiali.s ||e Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 403817] On canvas color selector triggers a taskbar entry in plasma
https://bugs.kde.org/show_bug.cgi?id=403817 Victor Wåhlström changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED Latest Commit||https://invent.kde.org/kde/ ||krita/commit/840a169728efdc ||1fc3c0e99859e469e167c182ca --- Comment #5 from Victor Wåhlström --- Git commit 840a169728efdc1fc3c0e99859e469e167c182ca by Victor Wåhlström. Committed on 05/05/2019 at 09:24. Pushed by victorw into branch 'master'. Prevent additional taskbar entry when invoking the on-canvas color selector M +27 -11 plugins/dockers/advancedcolorselector/kis_color_selector_base.cpp M +2-0plugins/dockers/advancedcolorselector/kis_color_selector_base.h https://invent.kde.org/kde/krita/commit/840a169728efdc1fc3c0e99859e469e167c182ca -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 403817] On canvas color selector triggers a taskbar entry in plasma
https://bugs.kde.org/show_bug.cgi?id=403817 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e CC||victor.wahlstrom@initiali.s ||e Resolution|INTENTIONAL |--- Status|RESOLVED|REOPENED --- Comment #4 from Victor Wåhlström --- While that comment is correct, it is possible to set Qt::BypassWindowManagerHint and then workaround the issues mentioned by the comment. The workaround might have side effects, but nothing we shouldn't be able to test for. I'll provide a patch for review once I've familiarized myself with the new gitlab workflow. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 392251] Krita appimages crash or hang when using touch on a wacom cintiq touch display
https://bugs.kde.org/show_bug.cgi?id=392251 Victor Wåhlström changed: What|Removed |Added CC||victor.wahlstrom@initiali.s ||e --- Comment #23 from Victor Wåhlström --- I can reproduce this issue on a Cintiq Pro 16, but not consistently. I've also had it happen on a Surface Pro 2 (wacom tech) a year or so ago, both using various versions of Kubuntu/KDE, both running appimages. I have so far not managed to get it when running a local build. Since palm rejection in general isn't great I ended up disabling touch entirely when drawing: xsetwacom --set "Wacom Cintiq Pro 16 Touch Finger touch" touch off While not a solution to this problem, it does work around the issue. As to why you have to disable gestures with xsetwacom to get gestures in Krita: xsetwacom gestures is an in-driver legacy feature, intended for systems that don't support multitouch. This means that when driver gestures are on, Krita won't receive touch events. See https://github.com/linuxwacom/xf86-input-wacom/wiki/Multitouch for more information. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395774] Doesn't prompt to save KRA before Saving as PNG
https://bugs.kde.org/show_bug.cgi?id=395774 Victor Wåhlström changed: What|Removed |Added CC||victor.wahlstrom@initiali.s ||e --- Comment #4 from Victor Wåhlström --- While "Export" would avoid this problem entirely, I don't think the original report is without merit. I'm not sure everyone is aware of the difference between "Save As" and "Export", and what they do exactly. Given that "Save As" is pretty consistent across applications and "Export" might not even exist, it's easy to default to the familiar "Save As" even though "Export" is what you want. Since the data in the current session is not immediately lost when you save to a different format, you can simply recover from a "Save As: PNG" situation by using "Save As" again and save to KRA. The real problem is that once you use "Save As", Krita clears the dirty state, allowing for the following scenario: 1. Create a new document 2. Draw something 3. Save as KRA 4. Continue working 5. Save as PNG 6. Close Krita 7. Krita won't warn you about unsaved changes, discarding all work done in step 4. Sure, you still have the PNG file, but that's missing a bunch of data. One way to avoid this scenario is to have Krita keep track of the last time you saved the current session as KRA, separately from the internal dirty state. This way, Krita knows that there are "unsaved" changes when you close the document, despite having just saved it to PNG. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 392208] Request to remove brush from tags fails to perform
https://bugs.kde.org/show_bug.cgi?id=392208 Victor Wåhlström changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||victor.wahlstrom@initiali.s ||e --- Comment #1 from Victor Wåhlström --- Confirmed using the 4.0 appimage and latest master. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 392027] Crash in SVG Text Tool when input is multiline with a single character per line
https://bugs.kde.org/show_bug.cgi?id=392027 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 392027] Crash in SVG Text Tool when input is multiline with a single character per line
https://bugs.kde.org/show_bug.cgi?id=392027 --- Comment #1 from Victor Wåhlström --- Git commit bacc6a476ab5daff64a12343775afc3fba2c3d26 by Victor Wåhlström. Committed on 18/03/2018 at 21:36. Pushed by victorw into branch 'master'. Fix potential crash when the last text input line in the SVG Text Tool is a single character M +3-4libs/flake/text/KoSvgTextShape.cpp https://commits.kde.org/krita/bacc6a476ab5daff64a12343775afc3fba2c3d26 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 392027] New: Crash in SVG Text Tool when input is multiline with a single character per line
https://bugs.kde.org/show_bug.cgi?id=392027 Bug ID: 392027 Summary: Crash in SVG Text Tool when input is multiline with a single character per line Product: krita Version: git master Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: Tool/Text Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- Repro: 1. Create a new document 2. Activate the new SVG Text Tool 3. Input e.g. "h" "i" 4. Click Save 5. Observe crash I can't reproduce this with appimages. It's a 100% out of bounds crash with my local build, and the responsible code is 10 months old. This should theoretically affect the 4.0 build too, but I haven't tested that. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 387403] Unable to open pgm and ppm files with comments
https://bugs.kde.org/show_bug.cgi?id=387403 --- Comment #3 from Victor Wåhlström --- Git commit a0624f31a0cb78f9520dce52428c18b0769e8b06 by Victor Wåhlström. Committed on 28/11/2017 at 21:33. Pushed by victorw into branch 'master'. Fix compile error in KisPPMImport::convert() M +2-2plugins/impex/ppm/kis_ppm_import.cpp https://commits.kde.org/krita/a0624f31a0cb78f9520dce52428c18b0769e8b06 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 385716] Default brush resize shortcuts do not work on layouts where [ and ] requires alt gr modifier keys
https://bugs.kde.org/show_bug.cgi?id=385716 --- Comment #2 from Victor Wåhlström --- Tried this again. It smells like a Qt bug. When I tried 4.0 pre-alpha before I think I built it from source. Now I explicitly tested it with appimages, and the problem exists with both the 3.3.2 and 4.0 version. I cannot repro it when building locally. Both 3.3 and 4.0 works. At least the 3.3.2 appimage was built with Qt 5.6. I use Qt 5.7. I can't easily test with older version of Qt, though I suspect this might get resolved if built against a newer version of Qt. I'd like to leave this open until it has been verified. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 385716] Default brush resize shortcuts do not work on layouts where [ and ] requires alt gr modifier keys
https://bugs.kde.org/show_bug.cgi?id=385716 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 386747] Crash on startup when loading svg files with radial gradients in it
https://bugs.kde.org/show_bug.cgi?id=386747 Victor Wåhlström changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #2 from Victor Wåhlström --- Fixed by 132e0e8a7f32a0eafe7d81d1c9c1f87c2fafb7f2 which was near identical to my local workaround. I figured that just setting the coordinate mode would have side effects, but I have no idea how this code is used so maybe not? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 386747] New: Crash on startup when loading svg files with radial gradients in it
https://bugs.kde.org/show_bug.cgi?id=386747 Bug ID: 386747 Summary: Crash on startup when loading svg files with radial gradients in it Product: krita Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: File formats Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- This is a 100% crash for me, using Ubuntu 17.04 (Qt 5.7.1). The crash occurs when it processes preset_icons.svg. Specifically, it crashes after processing radialGradient tags. When the crash happens it will first assert in the KoGradientBackground constructor: Q_ASSERT(d->gradient->coordinateMode() == QGradient::ObjectBoundingMode); Of the 3 svg files in master, only preset_icons.svg contain radialGradient tags. The crash goes away if g->setCoordinateMode(QGradient::ObjectBoundingMode); is set in the else block for "radialGradient" tags in SvgParser::parseGradient(). Not a solution, but maybe it can help identify the real cause. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 386704] Zoom tool is broken in mirror view
https://bugs.kde.org/show_bug.cgi?id=386704 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 365933] pan tool is broken in mirror view
https://bugs.kde.org/show_bug.cgi?id=365933 Victor Wåhlström changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |FIXED Summary|pan and zoom tools are |pan tool is broken in |broken in mirror view |mirror view --- Comment #8 from Victor Wåhlström --- This is a two-for-one bug, and I only fixed the pan tool version of it. I created bug 386704 to track the zoom tool version of the bug. Unfortunately the same solution cannot be applied to the zoom tool, so it's not as easy. I'll edit the title of this bug so it can be closed. The zoom tool bug should be tracked in bug 386704. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 386704] New: Zoom tool is broken in mirror view
https://bugs.kde.org/show_bug.cgi?id=386704 Bug ID: 386704 Summary: Zoom tool is broken in mirror view Product: krita Version: git master Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: Tools Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- This is a subset of bug 365933. The pan version of that bug was fixed. Since we can't tag bugs as partially fixed I'm creating this one to track the remaining zoom bug. The pan tool was fixed by rewriting it based on screen cursor positioning, as that does not care if the canvas is mirrored or not. The zoom tool is more tied to the canvas and can't use the same solution. Unfortunately the code which does the zooming is unaware of the mirroring feature, so a proper fix will require quite a bit of refactoring. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 384544] No GMIC plugin for Linux
https://bugs.kde.org/show_bug.cgi?id=384544 Victor Wåhlström changed: What|Removed |Added CC||victor.wahlstrom@initiali.s ||e --- Comment #13 from Victor Wåhlström --- I can confirm the brush resize shortcut issue, and that it's not a problem in 4.0 pre-alpha. However, since that is separate from the G'Mic issue, I've created a separate bug report for it: https://bugs.kde.org/show_bug.cgi?id=385716 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 385716] New: Default brush resize shortcuts do not work on layouts where [ and ] requires alt gr modifier keys
https://bugs.kde.org/show_bug.cgi?id=385716 Bug ID: 385716 Summary: Default brush resize shortcuts do not work on layouts where [ and ] requires alt gr modifier keys Product: krita Version: 3.3.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: shortcuts Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- This is not an issue in 4.0 pre-alpha or master. I've only verified it in 3.3.1. I don't know if it's a regression. Steps to repro: 1. Switch to a keyboard layout where [ and ] requires the use of alt gr (e.g. Swedish) 2. Press right alt key and 8 or 9 ([ or ]) 3. Observe that the brush does not resize 4. Switch to US layout, press the [ or ] key (or equivalent position if not using a US keyboard) 5. Observe that it works Tested on Ubuntu 17.04 (KDE) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381810] Krita does not load images with bogus file extensions.
https://bugs.kde.org/show_bug.cgi?id=381810 Victor Wåhlström changed: What|Removed |Added CC||victor.wahlstrom@initiali.s ||e --- Comment #2 from Victor Wåhlström --- Other than accidentally saving as the wrong file extension, there are websites like imgur where you can change the extension in the URL and still get the same image. It's not converted, it just has the wrong extension. One thing that can be done to improve the situation is to parse the header if there is a problem while loading the file, then either: 1. Notify the user of the problem, then attempt to "import" the image rather than opening it: Create a new file and load the data from the "opened" file into it. Since Krita won't have any references to the original file, saving will ask the user where to save the file instead of just overwriting the source file. or: 2. Keep the current behaviour of not opening the file, but improve the error message: "Couldn't load file.jpg: Image format is actually png, not jpeg. Please change the file extension and try again." -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382429] Crash when creating or opening a grayscale image
https://bugs.kde.org/show_bug.cgi?id=382429 Victor Wåhlström changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #2 from Victor Wåhlström --- Looking at the code this should be 100% reproducible, maybe depending on what widget is visible. I looked through the code a bit more than that assert shouldn't really be there, and no code path exists where removing it is a problem. It's also removed on the main branch. I fixed it by removing it from the 3.2 branch in 2c28382d84ccc7de5452326ed672d0fdb699efb1 but forgot to tag this bug. Marking this as resolved. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382429] Crash when creating or opening a grayscale image
https://bugs.kde.org/show_bug.cgi?id=382429 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382354] "Store alpha channel" checked and disabled when saving/exporting an image without alpha as png
https://bugs.kde.org/show_bug.cgi?id=382354 --- Comment #4 from Victor Wåhlström --- Git commit 9c969b60fa290005105883dd048d316bc4e96f29 by Victor Wåhlström. Committed on 17/07/2017 at 13:06. Pushed by victorw into branch 'krita/3.2'. Respect transparencyFillcolor configuration when exporting to jpeg or png without an alpha channel And don't create an alpha channel in png files that has no transparency Related: bug 382376 M +29 -3plugins/impex/jpeg/kis_jpeg_export.cc M +32 -7plugins/impex/png/kis_png_export.cc M +18 -18 plugins/impex/png/kis_wdg_options_png.ui https://commits.kde.org/krita/9c969b60fa290005105883dd048d316bc4e96f29 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382376] Exporting a PNG without transparency does not fill transparency with the selected color
https://bugs.kde.org/show_bug.cgi?id=382376 --- Comment #3 from Victor Wåhlström --- Git commit 9c969b60fa290005105883dd048d316bc4e96f29 by Victor Wåhlström. Committed on 17/07/2017 at 13:06. Pushed by victorw into branch 'krita/3.2'. Respect transparencyFillcolor configuration when exporting to jpeg or png without an alpha channel And don't create an alpha channel in png files that has no transparency Related: bug 382354 M +29 -3plugins/impex/jpeg/kis_jpeg_export.cc M +32 -7plugins/impex/png/kis_png_export.cc M +18 -18 plugins/impex/png/kis_wdg_options_png.ui https://commits.kde.org/krita/9c969b60fa290005105883dd048d316bc4e96f29 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382429] New: Crash when creating or opening a grayscale image
https://bugs.kde.org/show_bug.cgi?id=382429 Bug ID: 382429 Summary: Crash when creating or opening a grayscale image Product: krita Version: 3.2.0-beta.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: File formats Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- There is a Q_ASSERT in KisVisualColorSelector::slotRebuildSelectors() that triggers if you try to load (open or create) a grayscale/alpha image. Q_ASSERT(m_d->widgetlist.size() == 2); Only happens on the 3.2 branch for me. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382376] Exporting a PNG without transparency does not fill transparency with the selected color
https://bugs.kde.org/show_bug.cgi?id=382376 --- Comment #2 from Victor Wåhlström --- Git commit c8ca1c0fd1a15446bb2d99c6f0bb22be9ccf1e2f by Victor Wåhlström. Committed on 15/07/2017 at 13:37. Pushed by victorw into branch 'master'. JPEG Export: Respect transparencyFillcolor configuration M +2-1plugins/impex/jpeg/kis_jpeg_export.cc https://commits.kde.org/krita/c8ca1c0fd1a15446bb2d99c6f0bb22be9ccf1e2f -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382376] Exporting a PNG without transparency does not fill transparency with the selected color
https://bugs.kde.org/show_bug.cgi?id=382376 Victor Wåhlström changed: What|Removed |Added Latest Commit||https://commits.kde.org/kri ||ta/864348016a5f1ea61326e1ea ||9d4a438e0a350175 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Victor Wåhlström --- Git commit 864348016a5f1ea61326e1ea9d4a438e0a350175 by Victor Wåhlström. Committed on 15/07/2017 at 13:06. Pushed by victorw into branch 'master'. PNG Export: Respect transparencyFillcolor configuration when exporting without an alpha channel M +2-1plugins/impex/png/kis_png_export.cc https://commits.kde.org/krita/864348016a5f1ea61326e1ea9d4a438e0a350175 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382376] Exporting a PNG without transparency does not fill transparency with the selected color
https://bugs.kde.org/show_bug.cgi?id=382376 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382354] "Store alpha channel" checked and disabled when saving/exporting an image without alpha as png
https://bugs.kde.org/show_bug.cgi?id=382354 --- Comment #3 from Victor Wåhlström --- (In reply to Victor Wåhlström from comment #1) > There are two ways to solve it: > 1. Ensure the checkbox is never checked if it is also disabled, i.e. when > the image has no transparency > 2. Always enable the checkbox and let the user choose > > I can't think of a reason why Krita should forbid saving PNGs with an alpha > channel when there is no transparency. It might be wasteful, but if the PNG > is going to be used in a program expecting RGBA it can also be required. Went with option 1 for now. Option 2 requires some UX considerations. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382354] "Store alpha channel" checked and disabled when saving/exporting an image without alpha as png
https://bugs.kde.org/show_bug.cgi?id=382354 Victor Wåhlström changed: What|Removed |Added Latest Commit||https://commits.kde.org/kri ||ta/bebbe66cce72cf5ca2f21838 ||1bb6d9ab394e64da Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #2 from Victor Wåhlström --- Git commit bebbe66cce72cf5ca2f218381bb6d9ab394e64da by Victor Wåhlström. Committed on 15/07/2017 at 12:08. Pushed by victorw into branch 'master'. PNG Export: Don't leave the alpha channel checkbox checked if it's disabled, and move the checkbox next to the transparency fill color widget. Leaving it checked would force the creation of a PNG image with an alpha channel, even though the image has no transparency. M +4-4plugins/impex/png/kis_png_export.cc M +18 -18 plugins/impex/png/kis_wdg_options_png.ui https://commits.kde.org/krita/bebbe66cce72cf5ca2f218381bb6d9ab394e64da -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382376] New: Exporting a PNG without transparency does not fill transparency with the selected color
https://bugs.kde.org/show_bug.cgi?id=382376 Bug ID: 382376 Summary: Exporting a PNG without transparency does not fill transparency with the selected color Product: krita Version: git master Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: File formats Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- Transparency appears to always be replaced with black. Steps to reproduce: 1. Create a new image with a solid background color 2. Erase some of it 3. Export as PNG 4. Uncheck alpha channel 5. Select a fill color, e.g. red 6. Export 7. Open resulting image -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382354] "Store alpha channel" checked and disabled when saving/exporting an image without alpha as png
https://bugs.kde.org/show_bug.cgi?id=382354 --- Comment #1 from Victor Wåhlström --- There are two ways to solve it: 1. Ensure the checkbox is never checked if it is also disabled, i.e. when the image has no transparency 2. Always enable the checkbox and let the user choose I can't think of a reason why Krita should forbid saving PNGs with an alpha channel when there is no transparency. It might be wasteful, but if the PNG is going to be used in a program expecting RGBA it can also be required. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382354] "Store alpha channel" checked and disabled when saving/exporting an image without alpha as png
https://bugs.kde.org/show_bug.cgi?id=382354 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382354] New: "Store alpha channel" checked and disabled when saving/exporting an image without alpha as png
https://bugs.kde.org/show_bug.cgi?id=382354 Bug ID: 382354 Summary: "Store alpha channel" checked and disabled when saving/exporting an image without alpha as png Product: krita Version: git master Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: File formats Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- The checkbox is correctly disabled, but it is also checked so it exports the png with an alpha channel despite the image not containing any transparency. This could be because of previously saved values or defaults. Steps to reproduce: 1. Create or open an image without any transparency 2. Export to PNG -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381830] Heightmap import is "transposed"
https://bugs.kde.org/show_bug.cgi?id=381830 Victor Wåhlström changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kri ||ta/b4b9021616edcfb1e6bfd084 ||c5567f69da7668fa --- Comment #1 from Victor Wåhlström --- Git commit b4b9021616edcfb1e6bfd084c5567f69da7668fa by Victor Wåhlström. Committed on 14/07/2017 at 19:27. Pushed by victorw into branch 'master'. Add support for non-square heightmap import/export and various related improvements/bugfixes * Support for non-square heightmap files (.r8, .r16) * New heightmap import/export dialog * Fixed issue where imported heightmap is "transposed" * Fixed issue where saving an r16 heightmap file as r8 or vice versa only changes the extension Related: bug 381774, bug 381866 Differential Revision: https://phabricator.kde.org/D6460 M +10 -0libs/ui/kis_config.cc M +3-0libs/ui/kis_config.h M +4-0plugins/impex/heightmap/CMakeLists.txt M +39 -44 plugins/impex/heightmap/kis_heightmap_export.cpp M +1-17 plugins/impex/heightmap/kis_heightmap_export.h M +50 -35 plugins/impex/heightmap/kis_heightmap_import.cpp M +1-1plugins/impex/heightmap/kis_heightmap_import.h A +230 -0plugins/impex/heightmap/kis_wdg_options_heightmap.cpp [License: LGPL (v2.1+)] A +52 -0plugins/impex/heightmap/kis_wdg_options_heightmap.h [License: LGPL (v2.1+)] M +170 -59 plugins/impex/heightmap/kis_wdg_options_heightmap.ui A +10 -0plugins/impex/heightmap/tests/CMakeLists.txt A +---plugins/impex/heightmap/tests/data/results/test_512x256.r16.png A +---plugins/impex/heightmap/tests/data/results/test_512x256.r8.png A +---plugins/impex/heightmap/tests/data/results/test_512x512.r16.png A +---plugins/impex/heightmap/tests/data/results/test_512x512.r8.png A +---plugins/impex/heightmap/tests/data/sources/test_512x256.r16 A +1-0plugins/impex/heightmap/tests/data/sources/test_512x256.r8 A +---plugins/impex/heightmap/tests/data/sources/test_512x512.r16 A +1-0plugins/impex/heightmap/tests/data/sources/test_512x512.r8 A +36 -0plugins/impex/heightmap/tests/kis_heightmap_test.cpp [License: GPL (v2+)] A +31 -0plugins/impex/heightmap/tests/kis_heightmap_test.h [License: GPL (v2+)] https://commits.kde.org/krita/b4b9021616edcfb1e6bfd084c5567f69da7668fa -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381866] Saving an r16 heightmap file as r8 or vice versa only changes the extension
https://bugs.kde.org/show_bug.cgi?id=381866 Victor Wåhlström changed: What|Removed |Added Latest Commit||https://commits.kde.org/kri ||ta/b4b9021616edcfb1e6bfd084 ||c5567f69da7668fa Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #2 from Victor Wåhlström --- Git commit b4b9021616edcfb1e6bfd084c5567f69da7668fa by Victor Wåhlström. Committed on 14/07/2017 at 19:27. Pushed by victorw into branch 'master'. Add support for non-square heightmap import/export and various related improvements/bugfixes * Support for non-square heightmap files (.r8, .r16) * New heightmap import/export dialog * Fixed issue where imported heightmap is "transposed" * Fixed issue where saving an r16 heightmap file as r8 or vice versa only changes the extension Related: bug 381774, bug 381830 Differential Revision: https://phabricator.kde.org/D6460 M +10 -0libs/ui/kis_config.cc M +3-0libs/ui/kis_config.h M +4-0plugins/impex/heightmap/CMakeLists.txt M +39 -44 plugins/impex/heightmap/kis_heightmap_export.cpp M +1-17 plugins/impex/heightmap/kis_heightmap_export.h M +50 -35 plugins/impex/heightmap/kis_heightmap_import.cpp M +1-1plugins/impex/heightmap/kis_heightmap_import.h A +230 -0plugins/impex/heightmap/kis_wdg_options_heightmap.cpp [License: LGPL (v2.1+)] A +52 -0plugins/impex/heightmap/kis_wdg_options_heightmap.h [License: LGPL (v2.1+)] M +170 -59 plugins/impex/heightmap/kis_wdg_options_heightmap.ui A +10 -0plugins/impex/heightmap/tests/CMakeLists.txt A +---plugins/impex/heightmap/tests/data/results/test_512x256.r16.png A +---plugins/impex/heightmap/tests/data/results/test_512x256.r8.png A +---plugins/impex/heightmap/tests/data/results/test_512x512.r16.png A +---plugins/impex/heightmap/tests/data/results/test_512x512.r8.png A +---plugins/impex/heightmap/tests/data/sources/test_512x256.r16 A +1-0plugins/impex/heightmap/tests/data/sources/test_512x256.r8 A +---plugins/impex/heightmap/tests/data/sources/test_512x512.r16 A +1-0plugins/impex/heightmap/tests/data/sources/test_512x512.r8 A +36 -0plugins/impex/heightmap/tests/kis_heightmap_test.cpp [License: GPL (v2+)] A +31 -0plugins/impex/heightmap/tests/kis_heightmap_test.h [License: GPL (v2+)] https://commits.kde.org/krita/b4b9021616edcfb1e6bfd084c5567f69da7668fa -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381774] r16 heightmap import does not support non-square dimensions
https://bugs.kde.org/show_bug.cgi?id=381774 Victor Wåhlström changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kri ||ta/b4b9021616edcfb1e6bfd084 ||c5567f69da7668fa Resolution|--- |FIXED --- Comment #2 from Victor Wåhlström --- Git commit b4b9021616edcfb1e6bfd084c5567f69da7668fa by Victor Wåhlström. Committed on 14/07/2017 at 19:27. Pushed by victorw into branch 'master'. Add support for non-square heightmap import/export and various related improvements/bugfixes * Support for non-square heightmap files (.r8, .r16) * New heightmap import/export dialog * Fixed issue where imported heightmap is "transposed" * Fixed issue where saving an r16 heightmap file as r8 or vice versa only changes the extension Related: bug 381830, bug 381866 Differential Revision: https://phabricator.kde.org/D6460 M +10 -0libs/ui/kis_config.cc M +3-0libs/ui/kis_config.h M +4-0plugins/impex/heightmap/CMakeLists.txt M +39 -44 plugins/impex/heightmap/kis_heightmap_export.cpp M +1-17 plugins/impex/heightmap/kis_heightmap_export.h M +50 -35 plugins/impex/heightmap/kis_heightmap_import.cpp M +1-1plugins/impex/heightmap/kis_heightmap_import.h A +230 -0plugins/impex/heightmap/kis_wdg_options_heightmap.cpp [License: LGPL (v2.1+)] A +52 -0plugins/impex/heightmap/kis_wdg_options_heightmap.h [License: LGPL (v2.1+)] M +170 -59 plugins/impex/heightmap/kis_wdg_options_heightmap.ui A +10 -0plugins/impex/heightmap/tests/CMakeLists.txt A +---plugins/impex/heightmap/tests/data/results/test_512x256.r16.png A +---plugins/impex/heightmap/tests/data/results/test_512x256.r8.png A +---plugins/impex/heightmap/tests/data/results/test_512x512.r16.png A +---plugins/impex/heightmap/tests/data/results/test_512x512.r8.png A +---plugins/impex/heightmap/tests/data/sources/test_512x256.r16 A +1-0plugins/impex/heightmap/tests/data/sources/test_512x256.r8 A +---plugins/impex/heightmap/tests/data/sources/test_512x512.r16 A +1-0plugins/impex/heightmap/tests/data/sources/test_512x512.r8 A +36 -0plugins/impex/heightmap/tests/kis_heightmap_test.cpp [License: GPL (v2+)] A +31 -0plugins/impex/heightmap/tests/kis_heightmap_test.h [License: GPL (v2+)] https://commits.kde.org/krita/b4b9021616edcfb1e6bfd084c5567f69da7668fa -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382153] Krita crashes when saving or exporting new files
https://bugs.kde.org/show_bug.cgi?id=382153 Victor Wåhlström changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kri ||ta/377027476ca6f945ebe2c953 ||5eed47095e32e374 Status|CONFIRMED |RESOLVED --- Comment #2 from Victor Wåhlström --- Git commit 377027476ca6f945ebe2c9535eed47095e32e374 by Victor Wåhlström. Committed on 09/07/2017 at 15:17. Pushed by victorw into branch 'master'. * Don't crash and default to "All supported files" when passing an empty default to KoFileDialog::setMimeTypeFilters() * Default to .kra when saving newly created files * Added docs to KoFileDialog::setMimeTypeFilters() and renamed parameters to better reflect the expected contents M +2-1libs/ui/KisMainWindow.cpp M +12 -10 libs/widgetutils/KoFileDialog.cpp M +7-2libs/widgetutils/KoFileDialog.h https://commits.kde.org/krita/377027476ca6f945ebe2c9535eed47095e32e374 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 382153] New: Krita crashes when saving or exporting new files
https://bugs.kde.org/show_bug.cgi?id=382153 Bug ID: 382153 Summary: Krita crashes when saving or exporting new files Product: krita Version: git master Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: File formats Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- Likely introduced in 7dcfbbdcb1a2b5fdc5f7c6f237c6c55eca86cc83. Specifically line 114 in KoFileDialog.cpp setMimeTypeFilters allows an empty default mime type to be passed, which triggers a Q_ASSERT in getFilterStringListFromMime -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381866] Saving an r16 heightmap file as r8 or vice versa only changes the extension
https://bugs.kde.org/show_bug.cgi?id=381866 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e --- Comment #1 from Victor Wåhlström --- I have a fix for this locally, along with 381774 and 381830. Just need a bit more testing. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381866] New: Saving an r16 heightmap file as r8 or vice versa only changes the extension
https://bugs.kde.org/show_bug.cgi?id=381866 Bug ID: 381866 Summary: Saving an r16 heightmap file as r8 or vice versa only changes the extension Product: krita Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: File formats Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- No conversion appears to take place and the save goes through, so if you open a file as one format and save as another you end up with identical data but different extensions. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381830] Heightmap import is "transposed"
https://bugs.kde.org/show_bug.cgi?id=381830 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381830] New: Heightmap import is "transposed"
https://bugs.kde.org/show_bug.cgi?id=381830 Bug ID: 381830 Summary: Heightmap import is "transposed" Product: krita Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: File formats Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- When importing a heightmap, the result looks transposed. If the heightmap is symmetrical this is easy to miss. The easiest way to verify this is to create a heightmap in a different tool, then save it as both raw heightmap data (r16) and PNG. You can then load both in Krita and observe the difference. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381774] r16 heightmap import does not support non-square dimensions
https://bugs.kde.org/show_bug.cgi?id=381774 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e --- Comment #1 from Victor Wåhlström --- I tried replacing the heightmap importer with a generic raw data importer two years ago. Conceptually it worked, but because Krita requires importer/exporter code to associate with a given file extension I ended up shelving it. I'll see if I can adapt the code to work with the current r16 import/export code. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 381774] New: r16 heightmap import does not support non-square dimensions
https://bugs.kde.org/show_bug.cgi?id=381774 Bug ID: 381774 Summary: r16 heightmap import does not support non-square dimensions Product: krita Version: git master Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: File formats Assignee: krita-bugs-n...@kde.org Reporter: victor.wahlst...@initiali.se Target Milestone: --- The heightmap importer for .r16 files has a "size" input field. This appears to be width * height, but because they cannot be specified separately the code effectively only supports square heightmaps. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 365933] pan and zoom tools are broken in mirror view
https://bugs.kde.org/show_bug.cgi?id=365933 --- Comment #6 from Victor Wåhlström --- Git commit aaaf1eea993d3dc65bcd3585cabf7751464e9567 by Victor Wåhlström. Committed on 20/06/2017 at 19:43. Pushed by victorw into branch 'master'. Rewrote the Pan tool based on KisTool. Fixes pan issues when mirroring is enabled. Differential Revision: https://phabricator.kde.org/D6245 M +0-2libs/flake/CMakeLists.txt M +24 -0libs/flake/KoCanvasController.h M +20 -0libs/flake/KoCanvasControllerWidget.cpp M +5-0libs/flake/KoCanvasControllerWidget.h M +0-6libs/flake/KoToolManager.cpp M +0-3libs/flake/KoToolRegistry.cpp D +0-121 libs/flake/tools/KoPanTool.cpp D +0-73 libs/flake/tools/KoPanTool.h D +0-40 libs/flake/tools/KoPanToolFactory.cpp D +0-35 libs/flake/tools/KoPanToolFactory.h M +1-0plugins/tools/basictools/CMakeLists.txt M +2-0plugins/tools/basictools/default_tools.cc A +100 -0plugins/tools/basictools/kis_tool_pan.cpp [License: GPL (v2+)] A +54 -0plugins/tools/basictools/kis_tool_pan.h [License: GPL (v2+)] https://commits.kde.org/krita/aaaf1eea993d3dc65bcd3585cabf7751464e9567 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 365933] pan and zoom tools are broken in mirror view
https://bugs.kde.org/show_bug.cgi?id=365933 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e CC||victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 363853] .r16 file open dialogue on Mac OS X
https://bugs.kde.org/show_bug.cgi?id=363853 --- Comment #2 from Victor Wåhlström --- The UI could really use some love, but for now I just removed the limit so the feature at least works. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 363853] .r16 file open dialogue on Mac OS X
https://bugs.kde.org/show_bug.cgi?id=363853 Victor Wåhlström changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||http://commits.kde.org/krit ||a/15662fd7ee89ff086aba1bba2 ||a9abba65ee9b7ea Status|CONFIRMED |RESOLVED --- Comment #1 from Victor Wåhlström --- Git commit 15662fd7ee89ff086aba1bba2a9abba65ee9b7ea by Victor Wåhlström. Committed on 07/07/2016 at 21:16. Pushed by victorw into branch 'master'. Allow user to input size values higher than 99 when opening .r16 files M +5-1plugins/impex/heightmap/kis_wdg_options_heightmap.ui http://commits.kde.org/krita/15662fd7ee89ff086aba1bba2a9abba65ee9b7ea -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 363853] .r16 file open dialogue on Mac OS X
https://bugs.kde.org/show_bug.cgi?id=363853 Victor Wåhlström changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC||victor.wahlstrom@initiali.s ||e Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 353433] Remember the last used filter in export dialogue
https://bugs.kde.org/show_bug.cgi?id=353433 Victor Wåhlström changed: What|Removed |Added Ever confirmed|0 |1 CC||victor.wahlstrom@initiali.s ||e Status|UNCONFIRMED |CONFIRMED --- Comment #3 from Victor Wåhlström --- The first suggestion is a duplicate of bug 346013, which I just submitted a fix for. :) I'm leaving this one open since the second suggestion is still worth implementing. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 346013] File type filter to "All" for export
https://bugs.kde.org/show_bug.cgi?id=346013 Victor Wåhlström changed: What|Removed |Added Latest Commit||http://commits.kde.org/krit ||a/53aa1a84adce984b149e9b137 ||ce6afa135561760 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #7 from Victor Wåhlström --- Git commit 53aa1a84adce984b149e9b137ce6afa135561760 by Victor Wåhlström. Committed on 24/02/2016 at 21:14. Pushed by victorw into branch 'master'. Set default filter when exporting to "All supported formats" M +2-1libs/ui/KisMainWindow.cpp http://commits.kde.org/krita/53aa1a84adce984b149e9b137ce6afa135561760 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 346013] File type filter to "All" for export
https://bugs.kde.org/show_bug.cgi?id=346013 Victor Wåhlström changed: What|Removed |Added CC||victor.wahlstrom@initiali.s ||e Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 359644] Monochrome filter to export binary images.
https://bugs.kde.org/show_bug.cgi?id=359644 Victor Wåhlström changed: What|Removed |Added CC||victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 333169] Bigger thumbnails option for predefined brushes
https://bugs.kde.org/show_bug.cgi?id=333169 Victor Wåhlström changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||http://commits.kde.org/krit ||a/1fb8812ba18b65461d85f02b3 ||2bc14cedc152254 Status|CONFIRMED |RESOLVED --- Comment #3 from Victor Wåhlström --- Git commit 1fb8812ba18b65461d85f02b32bc14cedc152254 by Victor Wåhlström. Committed on 21/02/2016 at 01:20. Pushed by victorw into branch 'master'. Fixed broken zoom function in brush chooser widget M +1-0plugins/paintops/libpaintop/kis_brush_chooser.cpp http://commits.kde.org/krita/1fb8812ba18b65461d85f02b32bc14cedc152254 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 333169] Bigger thumbnails option for predefined brushes
https://bugs.kde.org/show_bug.cgi?id=333169 Victor Wåhlström changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |victor.wahlstrom@initiali.s ||e CC||victor.wahlstrom@initiali.s ||e -- You are receiving this mail because: You are watching all bug changes.
