[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2016-01-30 Thread Wolfgang Bauer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||te...@beam.ltd.uk

--- Comment #21 from Wolfgang Bauer  ---
*** Bug 358555 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2016-01-29 Thread Luc Lalonde via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Luc Lalonde  changed:

   What|Removed |Added

 CC||luc.lalo...@polymtl.ca

--- Comment #20 from Luc Lalonde  ---
This bug (seen on dual-head setup)  reared is solved for me since I upgraded to
Plasma 5.5.4.

Yay!  I can come back from GNOME 3 purgatory and start using KDE again ;-) 
Thank You!

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2016-01-28 Thread Rex Dieter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Rex Dieter  changed:

   What|Removed |Added

 CC||grgo...@yahoo.com

--- Comment #19 from Rex Dieter  ---
*** Bug 357063 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2016-01-25 Thread Mike Grindle via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Mike Grindle  changed:

   What|Removed |Added

 CC||mgfl...@summitxo.com

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2016-01-25 Thread Julien HENRY via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Julien HENRY  changed:

   What|Removed |Added

 CC||henr...@yahoo.fr

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2016-01-25 Thread Thomas Lübking via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Thomas Lübking  changed:

   What|Removed |Added

 CC||slartibar...@gmail.com

--- Comment #18 from Thomas Lübking  ---
*** Bug 357388 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2016-01-21 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

k...@stieler.org changed:

   What|Removed |Added

 CC||k...@stieler.org

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2016-01-11 Thread Hugo Pereira Da Costa via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Hugo Pereira Da Costa  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/bree |http://commits.kde.org/bree
   |ze/c5e48d765ab7ea71b0a4e30f |ze/2cae9359188af85ac884e270
   |e6482ed7e7be026f|9c17592bc67b0e73

--- Comment #17 from Hugo Pereira Da Costa  ---
Git commit 2cae9359188af85ac884e2709c17592bc67b0e73 by Hugo Pereira Da Costa.
Committed on 11/01/2016 at 19:20.
Pushed by hpereiradacosta into branch 'Plasma/5.5'.

- Removed palette helper.
Special background for groupboxes, menus, etc is now handled directly in the
painting routine rather than adjusting
the palette. This was indeed breaking palette inheritance, and requiring hacks
that apparently posed some performance
regressions.
- check documentMode to decide tab background color.
Related: bug 356561

M  +0-1kstyle/CMakeLists.txt
M  +2-37   kstyle/breezehelper.cpp
M  +0-13   kstyle/breezehelper.h
D  +0-188  kstyle/breezepalettehelper.cpp
D  +0-94   kstyle/breezepalettehelper.h
M  +43   -15   kstyle/breezestyle.cpp
M  +0-4kstyle/breezestyle.h

http://commits.kde.org/breeze/2cae9359188af85ac884e2709c17592bc67b0e73

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2016-01-03 Thread Johannes Pfrang via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

--- Comment #16 from Johannes Pfrang  ---
This bug reappeared somehow, but is only reproducible on multi-monitor setups
(for me by starting konsole on the 2nd monitor). Bug 357388 has been filed
about that issue.

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-15 Thread Weng Xuetian via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

--- Comment #15 from Weng Xuetian  ---
I can confirm that this fixes the issue for me, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-15 Thread Hugo Pereira Da Costa via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/bree
   ||ze/c5e48d765ab7ea71b0a4e30f
   ||e6482ed7e7be026f

--- Comment #14 from Hugo Pereira Da Costa  ---
Git commit c5e48d765ab7ea71b0a4e30fe6482ed7e7be026f by Hugo Pereira Da Costa.
Committed on 15/12/2015 at 23:40.
Pushed by hpereiradacosta into branch 'master'.

- Removed palette helper.
Special background for groupboxes, menus, etc is now handled directly in the
painting routine rather than adjusting
the palette. This was indeed breaking palette inheritance, and requiring hacks
that apparently posed some performance
regressions.
- check documentMode to decide tab background color.
Related: bug 356561

M  +0-1kstyle/CMakeLists.txt
M  +2-37   kstyle/breezehelper.cpp
M  +0-13   kstyle/breezehelper.h
D  +0-188  kstyle/breezepalettehelper.cpp
D  +0-94   kstyle/breezepalettehelper.h
M  +43   -15   kstyle/breezestyle.cpp
M  +0-4kstyle/breezestyle.h

http://commits.kde.org/breeze/c5e48d765ab7ea71b0a4e30fe6482ed7e7be026f

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-15 Thread Rex Dieter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-12 Thread Johannes Pfrang via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Johannes Pfrang  changed:

   What|Removed |Added

 CC||johannespfrang+...@gmail.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-08 Thread Weng Xuetian via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

--- Comment #13 from Weng Xuetian  ---
(In reply to Thomas Lübking from comment #12)
> Outmost weird.
> 
> Xuetian, how do you start konsole maximized (by restored size, kwin rule,
> kstart, some konsole key I don't know ... ;-) and does it matter whether you
> flag --notransparency to it?
> 
> Can you also "qDebug() << object;" in the ::adjustPendingPalettes() loop to
> see what widgets there would actually be to fit this breeze code?
> 
> PS: In case Xuetian is actually your surname - sorry ^_^

I start konsole maximized just by closing konsole when it's maximized. It's
easier to reproduce the issue when it's maximized (so nothing covers it or
triggers repainting).

With --notransparency, it seems that there's no problem anymore, even though my
konsole profile doesn't use transparency.

After add qDebug(), only shows some some qmenu
http://paste.ubuntu.com/13836079/ .

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-08 Thread Thomas Lübking via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

--- Comment #12 from Thomas Lübking  ---
Outmost weird.

Xuetian, how do you start konsole maximized (by restored size, kwin rule,
kstart, some konsole key I don't know ... ;-) and does it matter whether you
flag --notransparency to it?

Can you also "qDebug() << object;" in the ::adjustPendingPalettes() loop to see
what widgets there would actually be to fit this breeze code?

PS: In case Xuetian is actually your surname - sorry ^_^

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-08 Thread Hugo Pereira Da Costa via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

--- Comment #11 from Hugo Pereira Da Costa  ---
(In reply to Thomas Lübking from comment #10)
> How could anything in konsole match ::acceptWidget, why would that expose
> content on the window system layer and htf should palette setting mess with
> input???
> 

no clue 

> There needs to be some other bug deeper down, I don't use networkmanager -
> could you reproduce the input breaking with anything else but plasma-nm?
> 
nope

> What I could assume is that ::adjustPalette makes a call to the winId
> though, and then nasty things can happen (which might also explain the
> window-from-below exposure)
> 
not that I know.
> 
> About palette updates:
> changes only impact children until the first child with Qt::WA_SetPalette is
> met in the tree (they don't inherit the parenting palette but start a new
> hierarchy)

Which is the issue: when the style calls setPalette on a given widget it starts
a new hierarchy.
If the application set a custom palette on a parent widget, it will propagate
untill it hits one modified by the style and break there. Not good. 

We react on application palette change (using a trick, because the widgets for
which we changed the palette manually do not get the corresponding change event
anymore), but not on parent widgets palette change. 

Anyway. That's OT.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-08 Thread Thomas Lübking via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

--- Comment #10 from Thomas Lübking  ---
How could anything in konsole match ::acceptWidget, why would that expose
content on the window system layer and htf should palette setting mess with
input???

There needs to be some other bug deeper down, I don't use networkmanager -
could you reproduce the input breaking with anything else but plasma-nm?

What I could assume is that ::adjustPalette makes a call to the winId though,
and then nasty things can happen (which might also explain the
window-from-below exposure)


About palette updates:
changes only impact children until the first child with Qt::WA_SetPalette is
met in the tree (they don't inherit the parenting palette but start a new
hierarchy)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-08 Thread Hugo Pereira Da Costa via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 CC||hugo.pere...@free.fr

--- Comment #9 from Hugo Pereira Da Costa  ---
Hi, 
Thanks for reporting and bisecting.

I was about to say, the change looks pretty orthogonal to the issue at hand.
But then again, the reason why this change was introduced, namely bug #344425
is not very clear either. (apparently, calling setPalette to a widget inside
::polish was breaking input events).

Ultimately I would like to get rid of these palettes manipulation in breeze
because they are broken in other ways (application palette changes of a given
widget not properly propagated to children), but I think this issue is
different and should be fixed regardless.

I'm clueless how, though

Hugo

-- 
You are receiving this mail because:
You are watching all bug changes.


[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-08 Thread Thomas Lübking via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Thomas Lübking  changed:

   What|Removed |Added

 CC||thomas.luebk...@gmail.com

--- Comment #8 from Thomas Lübking  ---
The code seems to perform a (delayed) change of a widgets palette, but that
doesn't explain why the window below paints on top (unless a part of the
konsole window is repainted with full transparency) - or did I get that
description wrong?

Could be some false shape mask is applied? Does it also happen w/o compositing
resp. can you interact with the below window (in the exposed area)?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 356343] Rendering issue after upgrade to kwin 5.5

2015-12-07 Thread Weng Xuetian via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356343

Weng Xuetian  changed:

   What|Removed |Added

  Component|general |QStyle
   Assignee|kwin-bugs-n...@kde.org  |hugo.pere...@free.fr
Product|kwin|Breeze

--- Comment #7 from Weng Xuetian  ---
First bad commit in breeze found by git bisect.

http://commits.kde.org/breeze/6d852f30a1f2c1988359d4e0cdb21e2f1714a6bd

-- 
You are receiving this mail because:
You are watching all bug changes.