[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Nate Graham changed: What|Removed |Added CC||m...@eliasprobst.eu --- Comment #28 from Nate Graham --- *** Bug 367764 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #27 from Pascal d'Hermilly --- Looks good. You can read the text with a white background, right? I'm having trouble imagining the whole thing from the explanation. Den 22. april 2018 16.41.19 CEST, Marco Martin skrev: >https://bugs.kde.org/show_bug.cgi?id=369676 > >Marco Martin changed: > > What|Removed |Added > > Status|CONFIRMED |RESOLVED > Resolution|--- |FIXED > Latest Commit||https://commits.kde.org/pla > ||sma-workspace/448455c3c937c > ||ebc1358dc417b280b0008a4c196 > Version Fixed In||5.13 > >--- Comment #26 from Marco Martin --- >Git commit 448455c3c937cebc1358dc417b280b0008a4c196 by Marco Martin. >Committed on 22/04/2018 at 14:41. >Pushed by mart into branch 'master'. > >fade to blur when the login box appears > >Summary: >for both lockscreen and login screen: > >* display the wallpaper and the clock with a shadow by default >* at the first mouse or keyboard input, make the input fields appear >* the actual controls appear pretty fast >* the wallpaper starts to blur, desaturate and fade to darker >* after 10 seconds make the controls disappear again > >* as soon as anything is written in the password field never fade out >the >controls >* if the virtual keyboard is open, never fade out the controls >* if anything is pushed on the stack, like "switch user", never fade >the >controls >* Esc clears the field and makes controls disappear (closing keyboard >if >needed) > >the fade won't happen if the background is a simple color >Related: bug 388622 >FIXED-IN: 5.13 > >Depends on D12314 > >Recommended D11309 and D11308 to change the default wallpaper to plasma >wallpaper > >Test Plan: tested the behavior of all the above points > >Reviewers: #plasma, #vdg, ngraham > >Reviewed By: #vdg, ngraham > >Subscribers: zzag, abetts, davidedmundson, ngraham, plasma-devel > >Tags: #plasma > >Differential Revision: https://phabricator.kde.org/D11928 > >M +4-2lookandfeel/contents/components/Clock.qml >M +0-1 >lookandfeel/contents/components/SessionManagementScreen.qml >A +182 -0lookandfeel/contents/components/WallpaperFader.qml >[License: >GPL (v2)] >M +81 -13 lookandfeel/contents/lockscreen/LockScreenUi.qml >M +2-0sddm-theme/Login.qml >M +308 -236 sddm-theme/Main.qml > >https://commits.kde.org/plasma-workspace/448455c3c937cebc1358dc417b280b0008a4c196 > >-- >You are receiving this mail because: >You are on the CC list for the bug. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Marco Martin changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/pla ||sma-workspace/448455c3c937c ||ebc1358dc417b280b0008a4c196 Version Fixed In||5.13 --- Comment #26 from Marco Martin --- Git commit 448455c3c937cebc1358dc417b280b0008a4c196 by Marco Martin. Committed on 22/04/2018 at 14:41. Pushed by mart into branch 'master'. fade to blur when the login box appears Summary: for both lockscreen and login screen: * display the wallpaper and the clock with a shadow by default * at the first mouse or keyboard input, make the input fields appear * the actual controls appear pretty fast * the wallpaper starts to blur, desaturate and fade to darker * after 10 seconds make the controls disappear again * as soon as anything is written in the password field never fade out the controls * if the virtual keyboard is open, never fade out the controls * if anything is pushed on the stack, like "switch user", never fade the controls * Esc clears the field and makes controls disappear (closing keyboard if needed) the fade won't happen if the background is a simple color Related: bug 388622 FIXED-IN: 5.13 Depends on D12314 Recommended D11309 and D11308 to change the default wallpaper to plasma wallpaper Test Plan: tested the behavior of all the above points Reviewers: #plasma, #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: zzag, abetts, davidedmundson, ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D11928 M +4-2lookandfeel/contents/components/Clock.qml M +0-1lookandfeel/contents/components/SessionManagementScreen.qml A +182 -0lookandfeel/contents/components/WallpaperFader.qml [License: GPL (v2)] M +81 -13 lookandfeel/contents/lockscreen/LockScreenUi.qml M +2-0sddm-theme/Login.qml M +308 -236 sddm-theme/Main.qml https://commits.kde.org/plasma-workspace/448455c3c937cebc1358dc417b280b0008a4c196 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Rog131 changed: What|Removed |Added CC||s.oosth...@xs4all.nl --- Comment #25 from Rog131 --- *** Bug 392964 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 FabiB changed: What|Removed |Added CC|plusf...@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #24 from Martin Flöser --- I really like the idea presented by Marco to use a slideshow and then transition to our "existing" lock screen. I see this as a clear evolution over the current state without losing why we did the current existing lock screen in the first place. What I would like to be considered is the impact on the environment when doing a slideshow. If a system is locked, it's most likely because nobody is in front of the system. That means we show an animation nobody sees, which of course has a negative impact on the climate. We shouldn't downplay this factor as this change will hopefully affect millions of systems. But I think it's possible to get a compromise here: * stop the animation as soon as the screen goes into power saving (for this we might need a hook from powerdevil) and restart on user interaction * increase the time between every transition (e.g. fibonacci style, so the longer nobody interacting with the system, the longer it takes for an animation to be shown). For those wondering why an animation is a big deal: in the locked case we have KWin (Wayland compositor) pretty much sleeping, the system can go into the lowest power mode. But animations mean that the compositor is woken up and the system needs to go into a higher power state. The transition between wallpapers is animated so our system is at least woken up 60 times per second for the duration of the transition. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Michail Vourlakos changed: What|Removed |Added CC||mvourla...@gmail.com --- Comment #23 from Michail Vourlakos --- (In reply to Marco Martin from comment #19) > another version, with blur > https://www.youtube.com/watch?v=KWCZwrPXfVk Looks very good! I just want to add some ideas in case they will help a bit more with the contrast between the background and the text color used when the background isnt blurred... Latte demonstrated the following: https://www.youtube.com/watch?v=srkKkSnjG-w watch out the top panel how changes its color... The algorithm is the following: 1. For the underlying background is calculated the relative luminas only for the region of the background which is under the panel 2. That luminas value is cached so it isnt calculated again when we switch to that background 3. Based on that luminas value Latte is choosing between backgroundColor and textColor, the one that provides the greater contrast. 4. [based on another Latte part that I had to make similar design decisions] a. When a whitish color is used for the text then enabling shadows looks really good b. but when a darkish color is used for text then it is better to disable totally the shadows -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #22 from Michael D --- Great. In that case I have no complaints (except for the quibble that I still dislike unnecessarily hiding information in the name of aesthetic flair). -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #21 from Nate Graham --- Since this patch is all about poor text visibility on certain backgrounds, you can rest assured that we won't neglect that aspect of the design. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #20 from Michael D --- Just to chime in, I still prefer having everything visible always, with an option for changing the font color. Otherwise we might as well file another bug right now about how the white text is still unreadable on certain backgrounds before input. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #19 from Marco Martin --- another version, with blur https://www.youtube.com/watch?v=KWCZwrPXfVk -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #18 from Nate Graham --- > i'll try also a version which has the dialog appearing in the same way, tough > i think i would prefer the wallpaper fading out either to a color or to a > blur instead +1 for blurring the current background once the window appears. I think that would look really, really good. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Marco Martin changed: What|Removed |Added CC||notm...@gmail.com --- Comment #17 from Marco Martin --- that's another prototype i did https://www.youtube.com/watch?v=BOsclMNpK3M i'll try also a version which has the dialog appearing in the same way, tough i think i would prefer the wallpaper fading out either to a color or to a blur instead (hironically the dialog one was pretty much the first design for the lock screen after vdg cchanged it to the black strip version) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #16 from Nate Graham --- Created attachment 111445 --> https://bugs.kde.org/attachment.cgi?id=111445&action=edit What you usee after any user input And this is what you would see after any user input (moving the mouse, touching a touchscreen, hitting any key, etc): a floating window that contains all the UI elements. This window would inherit your user-chosen style, so for example if you were using Breeze Dark, it would have a dark background and white text. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #15 from Nate Graham --- Also worth mentioning that we haven't decided for sure on what the default background will be. Current contenders are: - Default Plasma wallpaper - Slideshow of all the wallpapers in the wallpaper folder -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #14 from Nate Graham --- Created attachment 111444 --> https://bugs.kde.org/attachment.cgi?id=111444&action=edit What you see right after the screen locks This is what you would see immediately after the screen locks. The date/time text would have a strong shadow behind the text to ensure that it shows up on very light backgrounds. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #13 from Nate Graham --- I am attaching two exceptionally crude mockups of what we discussed in the VDG room this morning: in essence, the lock screen would display some background and the date/time by default. Then once you move the mouse, touch the screen, or show a key, a floating frame would appear showing all the UI controls. Basically this implements the "screen saver" paradigm, and resolved the usability issues brought up here. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #12 from Rog131 --- (In reply to Navid Zamani from comment #11) > (In reply to Rog131 from comment #10) > > The Breeze text color can be set from the KDE system settings > Colors > > > Complementary > Normal text. > > That doesn’t actually work. I just changed that color from white to black, > saved it as a new scheme, closed the dialog, selected my new scheme from the > list, and clicked “Apply”. Then I locked the screen, and … nothing had > changed. > Also, the white text isn’t actually fully white by default either. > > And the actual full path is K → System settings → Colors → Change scheme → > Color selection [tab] → Color set [dropdown] (Generic colors ⇒ > Complementary) → Normal text. > (This is translated from German, so YMMV.) > You need to save the scheme as a new one, because the „Apply“ button inside > the scheme editing dialog does nothing, and your changes will be lost > otherwise. > > Or do I need to restart something or log out once? > > How did you make that screenshot by the way? The dialog is on top of the > lock screen. Photoshop^WGimp, or is there a way to test the lock screen? KDE Forums - KDE Plasma lockscreen colors and testing lock screen: https://forum.kde.org/viewtopic.php?f=14&t=151172 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #11 from Navid Zamani --- (In reply to Rog131 from comment #10) > The Breeze text color can be set from the KDE system settings > Colors > > Complementary > Normal text. That doesn’t actually work. I just changed that color from white to black, saved it as a new scheme, closed the dialog, selected my new scheme from the list, and clicked “Apply”. Then I locked the screen, and … nothing had changed. Also, the white text isn’t actually fully white by default either. And the actual full path is K → System settings → Colors → Change scheme → Color selection [tab] → Color set [dropdown] (Generic colors ⇒ Complementary) → Normal text. (This is translated from German, so YMMV.) You need to save the scheme as a new one, because the „Apply“ button inside the scheme editing dialog does nothing, and your changes will be lost otherwise. Or do I need to restart something or log out once? How did you make that screenshot by the way? The dialog is on top of the lock screen. Photoshop^WGimp, or is there a way to test the lock screen? -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Krzysztof Nowicki changed: What|Removed |Added CC||kri...@op.pl -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #10 from Rog131 --- (In reply to Michael D from comment #9) > Why not have configurable font color, or have the background detected and > automatically select text color based on that (which I imagine is way harder > to implement)? The Breeze plasma lockscreen is using plasma complementary color group. The Breeze text color can be set from the KDE system settings > Colors > Complementary > Normal text. Image - Imgur: https://imgur.com/jrC4bR8 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Michael D changed: What|Removed |Added CC||nortex...@gmail.com --- Comment #9 from Michael D --- Why not have configurable font color, or have the background detected and automatically select text color based on that (which I imagine is way harder to implement)? -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com Keywords||usability -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=388622 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #8 from Navid Zamani --- (In reply to Navid Zamani from comment #7) Oh, and with a black background, the outer glow would just be invisible. :) -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Navid Zamani changed: What|Removed |Added CC||navid.zam...@googlemail.com --- Comment #7 from Navid Zamani --- Since this is still a problem … (In reply to Juri Vitali from comment #3) > change line 32 of > /usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/ > LockScreenUi.qml from > colorGroup: PlasmaCore.Theme.ComplementaryColorGroup > to > colorGroup: PlasmaCore.Theme.ViewColorGroup > or remove the line altogether. I just tried that, and it doesn’t work. I switched my theme to Oxygen, changed the file you mentioned, saved it, switched the theme back to Breeze. Nothing changed. I’m for giving the text a subtle outer glow of the opposite brightness than the text. So as if the white text had a lamp on its back side, that emits light, except the “light” is black. That way, it looks "white on white" but still perfectly readable, and very elegant. The reason it looks so good, is because in the real world, a white raised object put on top of a white table will block some light from reaching the concave corners, and our eyes detect the difference in depth and add even more contrast to the edges. That is the intended look. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Dr. Chapatin changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 FabiB changed: What|Removed |Added CC||plusf...@gmail.com --- Comment #6 from FabiB --- Maybe it would be better to use the Plasma themes background as background for the Textareas/mediaplayer. Because we dont know what picture the user is taking and there are some cases where no white and no black text is good readable. So a background image would be better. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #5 from Rog131 --- Dublicate / same kind of as Bug 374300 - Option to change the font color on the lock screen - https://bugs.kde.org/show_bug.cgi?id=374300 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Rog131 changed: What|Removed |Added CC||samrog...@hotmail.com --- Comment #4 from Rog131 --- The ui can be placed on the top of sliding cover. The ui will be on sight only when it is needed. An example: https://forum.kde.org/viewtopic.php?f=289&t=131783&p=372930#p372930 YouTube: https://youtu.be/7gsJkSYRIw8 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Juri Vitali changed: What|Removed |Added CC||j...@dbzero.it --- Comment #3 from Juri Vitali --- Same here, I noticed that to switch to a black text mode is sufficient to change line 32 of /usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml from colorGroup: PlasmaCore.Theme.ComplementaryColorGroup to colorGroup: PlasmaCore.Theme.ViewColorGroup or remove the line altogether. Now, the only think I think is needed is a logic to choose between white and black (or other color) text depending on the image supplied. This is especially important when the image comes from an image provider (as National Geographic, APOD, etc.), as the picture changes daily and it is not reasonable to manually edit the file each time. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Viorel-Cătălin Răpițeanu changed: What|Removed |Added CC||rapiteanu.cata...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #2 from Pascal d'Hermilly --- Same on Neon 5.8.2. It's written in QML right? Isn't it just adding this? : style: Text.Outline; styleColor: "black" -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 369676] White lockscreen text's readability depends on background
https://bugs.kde.org/show_bug.cgi?id=369676 Christoph Feck changed: What|Removed |Added CC||pas...@dhermilly.dk --- Comment #1 from Christoph Feck --- *** Bug 36 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
