[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=375051

Christoph Feck  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/bre
   ||eze-gtk/01a8660180422292944
   ||1c0c1c8bb0db6d4ee2769
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||5.11.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Artem Grinev]

https://bugs.kde.org/show_bug.cgi?id=375051

--- Comment #11 from Artem Grinev  ---
New scrollbars lack support of Breeze-dark and have some bugs for now but
otherwise I think this issue is solved.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=375051

--- Comment #10 from Christoph Feck  ---
Artem, did your changes solve all issues mentioned in this ticket?

See https://commits.kde.org/breeze-gtk/01a86601804222929441c0c1c8bb0db6d4ee2769

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Artem Grinev]

https://bugs.kde.org/show_bug.cgi?id=375051

--- Comment #9 from Artem Grinev  ---
https://phabricator.kde.org/D6688

Ok, is it right now?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=375051

--- Comment #8 from Christoph Feck  ---
You did not complete the steps. Click "Continue" and fill out the details.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Artem Grinev]

https://bugs.kde.org/show_bug.cgi?id=375051

--- Comment #7 from Artem Grinev  ---
https://phabricator.kde.org/differential/diff/15977/

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=375051

--- Comment #6 from Christoph Feck  ---
Use https://phabricator.kde.org/differential/diff/create/ and set Repository to
'Breeze for Gtk'. Then please add the link for the Diff here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Artem Grinev]

https://bugs.kde.org/show_bug.cgi?id=375051

Artem Grinev  changed:

   What|Removed |Added

 CC||agrine...@gmail.com

--- Comment #5 from Artem Grinev  ---
I spent a couple of mornings to adjust scrollbars so they fit the Qt theme. I
made changes to the assets+gtkrc and also changed the "Scrollbars" section in
gtk-3.20/gtk.css. The only one issue I found is that Firefox doesn't respect
GTK3 css scrollbar:hover selector so hovering over the scrollbar doesn't show
scrollbar trough.
Is there any way to contribute this changes to the project?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=375051

--- Comment #4 from Hugo Pereira Da Costa  ---
(In reply to Felix Miata from comment #3)
> (In reply to Hugo Pereira Da Costa from comment #1)
> > - the default small width is good
> 
> Where can people find the discussion that reached this reduced
> usability/accessibility conclusion and implementation?

See comment #1
Click the phabricator link

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Felix Miata]

https://bugs.kde.org/show_bug.cgi?id=375051

Felix Miata  changed:

   What|Removed |Added

 CC||mrma...@earthlink.net

--- Comment #3 from Felix Miata  ---
(In reply to Hugo Pereira Da Costa from comment #1)
> - the default small width is good

Where can people find the discussion that reached this reduced
usability/accessibility conclusion and implementation?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Heiko Becker]

https://bugs.kde.org/show_bug.cgi?id=375051

Heiko Becker  changed:

   What|Removed |Added

 CC||heire...@exherbo.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Fuchs]

https://bugs.kde.org/show_bug.cgi?id=375051

--- Comment #2 from Fuchs  ---
(In reply to Hugo Pereira Da Costa from comment #1)
> Hi,

Hi! 

> thanks for reporting.

You're welcome.

> Despite of what the commit says (sorry we did not update), and after long
> discussions on phabricator (https://phabricator.kde.org/D3210), it was
> decided not to make the scrollbar visible width configurable. 
> The rationale is that
> - we avoid the added code complexity

understandable.

> - the default small width is good

Heavily disagree, but that's a matter of personal preference, so not really
discussable

> - the hit area is unchanged with respect to the previous design (it is
> larger than the visible width of the handle), so that no usability is lost.

actually making it larger than visible is a massive usability issue. If you
disabled animations and thus it is always visible, grabbing the mouse event
when near but not on the scrollbar is against user expectations and thus a big
UX flaw.  Say I have a file view in dolphin and I want to start selecting
multiple items by drawing a rectangle. If I started close to a scrollbar, it
might activate the scrolling instead, even though the mouse was not over it. 
That would be very bad.



> Now, that this makes the scrollbar inconsistent with gtk should be fixed of
> course.
> Reassigning to the gtk theme (of which I am not the maintainer and for which
> I lack the skills to fix)

I shall patch both to the old width locally, then. 

> Best,
> 
> Hugo

Kind regards, 

Christian

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 375051] New scroll bar width: cofiguration missing and inconsistent with GTK theme

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=375051

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 CC||hugo.pereira.da.costa@gmail
   ||.com
   Assignee|hugo.pereira.da.costa@gmail |scionicspec...@gmail.com
   |.com|
  Component|QStyle  |gtk theme

--- Comment #1 from Hugo Pereira Da Costa  ---
Hi,
thanks for reporting.

Despite of what the commit says (sorry we did not update), and after long
discussions on phabricator (https://phabricator.kde.org/D3210), it was decided
not to make the scrollbar visible width configurable. 
The rationale is that
- we avoid the added code complexity
- the default small width is good
- the hit area is unchanged with respect to the previous design (it is larger
than the visible width of the handle), so that no usability is lost.

Now, that this makes the scrollbar inconsistent with gtk should be fixed of
course.
Reassigning to the gtk theme (of which I am not the maintainer and for which I
lack the skills to fix)

Best,

Hugo

-- 
You are receiving this mail because:
You are watching all bug changes.