[Breeze] [Bug 386076] QToolButton is drawn incorectly when there are extra size constraints

[Michał D .]

https://bugs.kde.org/show_bug.cgi?id=386076

--- Comment #8 from Michał D. (Emdek)  ---
Reported upstream:
https://bugreports.qt.io/browse/QTBUG-64132

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 386076] QToolButton is drawn incorectly when there are extra size constraints

[Michał D .]

https://bugs.kde.org/show_bug.cgi?id=386076

--- Comment #7 from Michał D. (Emdek)  ---
I've got second thoughts on this, I think that I've should report it to BQI
instead, since it's more like inconsistency here:
http://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/widgets/qtoolbutton.cpp#n238

To be exact, I mean the part where text is not elided when width is constrained
(and still bigger than icon size), for example QTabBar elides text on widget
level, but it's missing in QToolButton.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 386076] QToolButton is drawn incorectly when there are extra size constraints

[Michał D .]

https://bugs.kde.org/show_bug.cgi?id=386076

--- Comment #6 from Michał D. (Emdek)  ---
Well, for me it's the closest thing to a reference (it's official fallback
after all, so it's one of the most used styles, especially after this change:
https://0x0.st/F2Y.txt). ;-)

Might be not perfect but it's in pretty good shape, especially when comparing
to platform style for macOS, it's both buggy and partially outdated (tab bar in
document mode doesn't look at all like these used by Finder or Safari)...

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 386076] QToolButton is drawn incorectly when there are extra size constraints

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=386076

--- Comment #5 from Hugo Pereira Da Costa  ---
I disagree.
Say someone wants to trim the margins by just the right amount that both the
text and the icon still apear in the trimmed button, then for fusion he/she
will complain that the icon and text are not centered anymore and that margins
are different between the top and the bottom. 
There is no solution to this problem, because this is not a well-formed
problem. 
And fusion is not a reference implementation. It has bugs that other styles
dont (though I can't remember of one on top of my head right now).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 386076] QToolButton is drawn incorectly when there are extra size constraints

[Michał D .]

https://bugs.kde.org/show_bug.cgi?id=386076

--- Comment #4 from Michał D. (Emdek)  ---
I guess that Fusion should be considered as reference implementation, so
perhaps it's better to be consistent with it and at least align it to the top
and only cut off bottom part, at least it looks "less broken" that way.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 386076] QToolButton is drawn incorectly when there are extra size constraints

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=386076

--- Comment #3 from Hugo Pereira Da Costa  ---
As far as I know there is nothing incorrect about the placement of the text and
icons in the example you sent: icon is cropped at the top, text at the bottom,
and in fact by the same amount. 
The logic behind it is that the text and the icon are placed in a rect that
accomodate their minimum size and some style defined vertical spacing between
the two, then this rect is centered on the actual toolbutton rect. 
This is what leads to the result you see.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 386076] QToolButton is drawn incorectly when there are extra size constraints

[Michał D .]

https://bugs.kde.org/show_bug.cgi?id=386076

--- Comment #2 from Michał D. (Emdek)  ---
Hello
I agree, but logic that aligns icon should be fixed, drawing it outside of
frame, above proper location, is simply weird.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 386076] QToolButton is drawn incorectly when there are extra size constraints

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=386076

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 CC||hugo.pereira.da.costa@gmail
   ||.com
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Hugo Pereira Da Costa  ---
Hi, 
thanks for reporting the issue, but ...

if you apply fixed size to widgets, disregarding the one recommanded by the
style, you're on your own. There is now way the style can work in all cases
when used in an incomplete manner, or overconstrained, or inconsistent. 
If you want overconstrained widgets to work in all cases you'll have to write
the paintEvent yourself too. 

There is most likely a way to make your particular example work with
breeze/oxygen but then it will likely
- break in other places
- not work for other cases of specialization.

Wontfix, sorry

Hugo

-- 
You are receiving this mail because:
You are watching all bug changes.