[Breeze] [Bug 388018] Breeze-GTK+ changes from Dec 16th 2017 cause visual regressions

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388018

--- Comment #6 from scionicspec...@gmail.com ---
Thanks for finding the root of the issue and taking care of it. Lending a hand
like this is always appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 388018] Breeze-GTK+ changes from Dec 16th 2017 cause visual regressions

[Luca Beltrame]

https://bugs.kde.org/show_bug.cgi?id=388018

Luca Beltrame  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #5 from Luca Beltrame  ---
Somehow part of the CC didn't get here...

It's fixed by 4757d48d7f97d354f1ad926bbbc5ae06aa51 in breeze-gtk, which
restores the ability to install themes correctly (which was the case all along
- the wrong theme would get installed).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 388018] Breeze-GTK+ changes from Dec 16th 2017 cause visual regressions

[Luca Beltrame]

https://bugs.kde.org/show_bug.cgi?id=388018

--- Comment #4 from Luca Beltrame  ---
Git commit 50c632cfa9b991c6729bc561405214b98f6c5feb by Luca Beltrame.
Committed on 20/12/2017 at 14:32.
Pushed by lbeltrame into branch 'master'.

Revert "Revert "Remove gtk+-3 build dep, install versioned gtk.css dirs
unconditionally""

This reverts commit 89ebc0b7e167f25af96c72d87f1a416820424e1f.

Same as previous commit, causes theme installation issues.

CCMAIL: bcooks...@kde.org

M  +3-5Breeze-dark-gtk/CMakeLists.txt
M  +3-5Breeze-gtk/CMakeLists.txt
M  +0-3CMakeLists.txt

https://commits.kde.org/breeze-gtk/50c632cfa9b991c6729bc561405214b98f6c5feb

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 388018] Breeze-GTK+ changes from Dec 16th 2017 cause visual regressions

[Luca Beltrame]

https://bugs.kde.org/show_bug.cgi?id=388018

Luca Beltrame  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |UNCONFIRMED

--- Comment #3 from Luca Beltrame  ---
The distribution is openSUSE Tumbleweed, which uses a fairly recent GTK+
version (3.22). The screenshot you saw is the product of an automated test
which always creates user configuration from scratch, so I would exclude the
effect of pre-existing configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 388018] Breeze-GTK+ changes from Dec 16th 2017 cause visual regressions

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388018

scionicspec...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #2 from scionicspec...@gmail.com ---
Thank you for your detailed report. I can't seem to reproduce this issue with
Firefox 57, nor can I see the highlight/form/menu items issue in Firefox or
other GTK applications. This may be related to your GTK version, as GTK
versions prior to 3.18 are no longer supported. Still, that may not be the case
as the November 27th version would've caused more problems as it only supported
GTK 3.20 onward.

However, I am doubtful it's related to the theme generator since those changes
only apply to assets for now and the scrollbars are the only assets that were
different in the update, fixing some visual artifacts as well as improving
maintainability. Changes to highlights and menu items in particular can't be
affected by the raster images, only by the CSS.

Still, I would certainly like to reproduce this issue, so if you could give me
more information about the distribution and version where you encountered the
issue and if you have any non-default repositories enabled, that would be very
helpful in pinning down the cause. If it's related to GTK 3.16 after all, this
distro should continue using the previous Plasma version's Breeze GTK package
rather than backporting the upcoming release. If it's related to GTK 3.18,
however, there may be more we can do about it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 388018] Breeze-GTK+ changes from Dec 16th 2017 cause visual regressions

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=388018

Fabian Vogt  changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 388018] Breeze-GTK+ changes from Dec 16th 2017 cause visual regressions

[Luca Beltrame]

https://bugs.kde.org/show_bug.cgi?id=388018

--- Comment #1 from Luca Beltrame  ---
Created attachment 109443
  --> https://bugs.kde.org/attachment.cgi?id=109443=edit
Issue as shown in openQA

OpenQA also caught this issue: as you can see from the image, the button
borders are missing and so is the checkbox.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 388018] Breeze-GTK+ changes from Dec 16th 2017 cause visual regressions

[Luca Beltrame]

https://bugs.kde.org/show_bug.cgi?id=388018

Luca Beltrame  changed:

   What|Removed |Added

Summary|Breeze-GTK+ changes from|Breeze-GTK+ changes from
   |Dec 16th 2017 cause visual  |Dec 16th 2017 cause visual
   |regresiosn  |regressions

-- 
You are receiving this mail because:
You are watching all bug changes.