[Breeze] [Bug 397145] libbreezecommon does not install the export header

2018-08-04 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=397145

Fabian Vogt  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Fabian Vogt  ---
Fixed with
https://cgit.kde.org/breeze.git/commit/?id=763ec6d335417df7985fbbd4ef456287915b4d1d

(I added a BUG: in the commit, but arc land reverted that, grmbl)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 397145] libbreezecommon does not install the export header

2018-08-04 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=397145

--- Comment #2 from Fabian Vogt  ---
(In reply to Vlad Zagorodniy from comment #1)
> (In reply to Fabian Vogt from comment #0)
> > A header is generated, but never installed.
> > 
> > If this is intentional and libbreezecommon is not meant to be used by
> > something other than breeze, it should not install a .so link.
> 
> Yes, it's used only by Breeze. (We need to share some code between kstyle
> and kdecoration)
> 
> In my defense: libbreezecommon is based on liboxygen, so that's why it is a
> shared library.
> 
> I suppose it would be better to turn libbreezecommon into a static library
> and use it only during build, right?

That means the shared parts are contained in the binaries twice, so that would
be a steps backwards IMO. If it's not too much, it certainly makes sense
though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 397145] libbreezecommon does not install the export header

2018-08-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=397145

--- Comment #1 from Vlad Zagorodniy  ---
(In reply to Fabian Vogt from comment #0)
> A header is generated, but never installed.
> 
> If this is intentional and libbreezecommon is not meant to be used by
> something other than breeze, it should not install a .so link.

Yes, it's used only by Breeze. (We need to share some code between kstyle and
kdecoration)

In my defense: libbreezecommon is based on liboxygen, so that's why it is a
shared library.

I suppose it would be better to turn libbreezecommon into a static library and
use it only during build, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 397145] libbreezecommon does not install the export header

2018-08-04 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=397145

Fabian Vogt  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.