[Breeze] [Bug 407273] With Small icon size, the height of an icons-only button is slightly shorter than an icons-and-text button

2021-02-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407273

Nate Graham  changed:

   What|Removed |Added

 CC||i...@guoyunhe.me

--- Comment #10 from Nate Graham  ---
*** Bug 411811 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 407273] With Small icon size, the height of an icons-only button is slightly shorter than an icons-and-text button

2019-06-15 Thread Mikhail Zolotukhin
https://bugs.kde.org/show_bug.cgi?id=407273

--- Comment #9 from Mikhail Zolotukhin  ---
Created attachment 120890
  --> https://bugs.kde.org/attachment.cgi?id=120890=edit
Okular combobox with caption

Agreed, the tall combobox is odd. Instead we could just use a caption "Scale"
in "Text under icons" mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 407273] With Small icon size, the height of an icons-only button is slightly shorter than an icons-and-text button

2019-06-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407273

--- Comment #8 from Nate Graham  ---
If there's way to make the heights identical only when they would otherwise be
off by a pixel or two, that would probably be ideal.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 407273] With Small icon size, the height of an icons-only button is slightly shorter than an icons-and-text button

2019-06-14 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=407273

--- Comment #7 from Christoph Feck  ---
I don't agree, the tall comboboxes really look out-of-place.

In Skulpture I forced SmallIcons size to the same size as the font size, so
that buttons with icons and text get the same height. They got blurry, though,
but that shouldn't be an issue now that we have scalable icons, so we could
revisit that idea.

But this won't work for the toolbar case, because toolbar icons can have any
size. What you show here is "text is smaller than icon+text", which is of
course always the case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 407273] With Small icon size, the height of an icons-only button is slightly shorter than an icons-and-text button

2019-05-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407273

--- Comment #6 from Nate Graham  ---
Agreed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 407273] With Small icon size, the height of an icons-only button is slightly shorter than an icons-and-text button

2019-05-21 Thread Mikhail Zolotukhin
https://bugs.kde.org/show_bug.cgi?id=407273

--- Comment #5 from Mikhail Zolotukhin  ---
Created attachment 120235
  --> https://bugs.kde.org/attachment.cgi?id=120235=edit
Okular possible tall combobox

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 407273] With Small icon size, the height of an icons-only button is slightly shorter than an icons-and-text button

2019-05-21 Thread Mikhail Zolotukhin
https://bugs.kde.org/show_bug.cgi?id=407273

--- Comment #4 from Mikhail Zolotukhin  ---
Created attachment 120234
  --> https://bugs.kde.org/attachment.cgi?id=120234=edit
Okular short in height combox

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 407273] With Small icon size, the height of an icons-only button is slightly shorter than an icons-and-text button

2019-05-21 Thread Mikhail Zolotukhin
https://bugs.kde.org/show_bug.cgi?id=407273

--- Comment #3 from Mikhail Zolotukhin  ---
Created attachment 120233
  --> https://bugs.kde.org/attachment.cgi?id=120233=edit
Dropdown button height mismatch in Gwenview

Well 40px font is a bit extreme, but if I understand correctly, button heights
mismatch because font height is greater, than the icon's one, and buttons
define their heights according to content. So,  I think it's a more fundamental
problem, than fonts and icons - take a look at "Open With" dropdown button in
Gwenview, it's height is way smaller, than rest of items on left. It also
applies to other widgets, for example, page size combobox in Okular.

The heights of toolbar items should be equal to toolbar height, I think. In
case of extreme scenarios (like on dropdown menu button on a screenshot) it
won't only look nice - this will increase click area too. However, in case of
comboboxes (like in Okular) I'm not sure about the look, the combo looks
strange in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 407273] With Small icon size, the height of an icons-only button is slightly shorter than an icons-and-text button

2019-05-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407273

Nate Graham  changed:

   What|Removed |Added

   Assignee|gwenview-bugs-n...@kde.org  |unassigned-b...@kde.org
 CC||n...@kde.org
   Severity|normal  |minor
  Component|general |QStyle
Product|gwenview|Breeze
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
Summary|The height of the button|With Small icon size, the
   |with a small icon and no|height of an icons-only
   |text is less, than the  |button is slightly shorter
   |one's with a text   |than an icons-and-text
   ||button

--- Comment #2 from Nate Graham  ---
It's worth mentioning that with the default toolbar icon size settings (22px
icons), the heights do match up.

Not sure this makes sense to change in only Gwenview. If there's anywhere it
does make sense to change, it would be in Breeze. If a user does something
crazy like set 40pt font, nothing else is going to work right, so I'm not sure
it makes sense to optimize around that.

-- 
You are receiving this mail because:
You are watching all bug changes.