[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2023-06-24 Thread Philip Murray
https://bugs.kde.org/show_bug.cgi?id=445809

Philip Murray  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #14 from Philip Murray  ---
Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2023-06-24 Thread Philip Murray
https://bugs.kde.org/show_bug.cgi?id=445809

--- Comment #13 from Philip Murray  ---
Created attachment 159878
  --> https://bugs.kde.org/attachment.cgi?id=159878&action=edit
5.25.7

The spacing in v5.27.5 in Debian 12 looks much nicer now, thanks.
Pic attached shows:
1. Dolphin right-click menu with a more pleasant left margin than before.
2. Dolphin pull-down menu text is now aligned 1 or 2 pixels to the right of the
'Tools' word, and there's a decent margin.
When checkboxes exist in the menu the text all aligns to a larger margin
(compared to Double Commander, which leaves a big margin in the fist place, see
pics above), but that's basically fine.
Hence, I'll close this bug now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2022-11-24 Thread Philip Murray
https://bugs.kde.org/show_bug.cgi?id=445809

Philip Murray  changed:

   What|Removed |Added

 CC||philipihmur...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2022-06-07 Thread Philip Murray
https://bugs.kde.org/show_bug.cgi?id=445809

--- Comment #12 from Philip Murray  ---
General note: the menu's list of text should always be aligned more to the
right than the text at the top, e.g. File, Edit, View etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2022-04-29 Thread Philip Murray
https://bugs.kde.org/show_bug.cgi?id=445809

--- Comment #11 from Philip Murray  ---
Created attachment 148464
  --> https://bugs.kde.org/attachment.cgi?id=148464&action=edit
Double Commander file manager with menu icons off/on, as an example of where
the text doesn't change position when icons are off. I think this is the ideal
method.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2022-02-23 Thread Philip Murray
https://bugs.kde.org/show_bug.cgi?id=445809

--- Comment #10 from Philip Murray  ---
Created attachment 147079
  --> https://bugs.kde.org/attachment.cgi?id=147079&action=edit
Debian 11 (left half) v Fedora 35 (right)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2022-02-23 Thread Philip Murray
https://bugs.kde.org/show_bug.cgi?id=445809

Philip Murray  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|NEEDSINFO   |REOPENED

--- Comment #9 from Philip Murray  ---
I've just loaded Fedora35 in a VM & the left gap pixel width has increased from
5 to 8, so that's 3 pixels in the right direction. :) It doesn't look much
different though & could do with some more I think. Screenshot attached shortly
(left: Debian 11 Plasma 5.20.5, right: Fedora 25 Plasma 5.22.5). Moving them a
bit further to the right would be OK. Two more pixels beyond what's in Plasma
5.22.5 would bring it in line with the menu word, e.g. Go & Up to be
aligned-left to the same imaginary line, which might be OK-ish. Ideally the
menu-items would be indented to the right slightly like they are when icons are
enabled (and like you would have for a bullet-pointed list in a word document
under a heading). 

The way the text alignment jumps around in 5.22.5 as I move through the
File>Edit>View is still quite unpleasant though. This jumping alignment is
caused by the square radio buttons being on the left of the text though because
if a menu includes a radio button it will push all the entries to the right
significantly - it might be better to put radio buttons on the right side?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2022-02-23 Thread Jan Blackquill
https://bugs.kde.org/show_bug.cgi?id=445809

Jan Blackquill  changed:

   What|Removed |Added

 CC||uhh...@gmail.com
 Resolution|--- |FIXED
 Status|CONFIRMED   |NEEDSINFO

--- Comment #8 from Jan Blackquill  ---
FWIW, we added extra left spacing in the case of no icons/check/radiobuttons in
menus some time ago, as to not have this "kissing the left edge" affair going
on. Do you think the current look fixes the issue for you?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2021-11-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=445809

--- Comment #7 from Nate Graham  ---
OMG LOL

Maybe we can do it for all other cases at least, since that is quite a rare use
case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2021-11-24 Thread Philip Murray
https://bugs.kde.org/show_bug.cgi?id=445809

--- Comment #6 from Philip Murray  ---
Created attachment 143914
  --> https://bugs.kde.org/attachment.cgi?id=143914&action=edit
Dolphin - Edit View Go menus

The Dolphin Go menu also has both shortcuts + submenus.
Screenshot attached showing Dolphin's View, Edit & Go menus. My initial issue
was the left side spacing, it seems lot less than that given elsewhere & note
the closeness of the View menu's items to the favourites list beneath it. The
Go menu looks similarly too close to the left side of the menu, but doesn't
isn't quite as bad as there's not a favourites list under it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2021-11-24 Thread Jonathan Marten
https://bugs.kde.org/show_bug.cgi?id=445809

Jonathan Marten  changed:

   What|Removed |Added

 CC||j...@keelhaul.me.uk

--- Comment #5 from Jonathan Marten  ---
> because no menu item with a shortcut can have a submenu

Is this true?  Konqueror's "Go" menu has Up = Alt+Up, Back = Alt+Left and
Forward = Alt+Right all with submenus.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 445809] Menu styling: right-aligned shortcut text has unnecessary spacing

2021-11-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=445809

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |minor
Product|dolphin |Breeze
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
   Assignee|dolphin-bugs-n...@kde.org   |plasma-b...@kde.org
Summary|Add left margin space to|Menu styling: right-aligned
   |Menus without icons |shortcut text has
   ||unnecessary spacing
  Component|general |QStyle
 CC||n...@kde.org,
   ||noaha...@gmail.com
Version|20.12.2 |unspecified

--- Comment #4 from Nate Graham  ---
The issue here, really, is that the shortcut text leaves room on the right for
the submenu arrow--which is unnecessary because no menu item with a shortcut
can have a submenu, and no submenu has a shortcut.

-- 
You are receiving this mail because:
You are watching all bug changes.