[Breeze] [Bug 448122] [Regression] Unchecking "Draw a circle around close button" does not set it to false in breezerc
https://bugs.kde.org/show_bug.cgi?id=448122 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/breeze/commit/f2d33bd33e |ma/breeze/commit/eb73e004f3 |3b823cbb485a03d656226ae0575 |29aa6d76f1ededfe964836ac364 |a6a |960 --- Comment #4 from Nate Graham --- Git commit eb73e004f329aa6d76f1ededfe964836ac364960 by Nate Graham, on behalf of Luke Horwell. Committed on 13/01/2022 at 18:02. Pushed by ngraham into branch 'Plasma/5.24'. Fix OutlineCloseButton default for close tab buttons Under Window Decorations, the option "Draw a circle around close button" is unchecked by default. This normally applies to both window and tab close buttons, but tab buttons permanently had the circle visible because this boolean was incorrect. This made it impossible for the user to disable this style via GUI. `OutlineCloseButton=false` had to be explicitly added to `~/.config/breezerc`. Fixes a regression that started in the 5.23 cycle. FIXED-IN: 5.24 (cherry picked from commit f2d33bd33e3b823cbb485a03d656226ae0575a6a) M +1-1kstyle/breeze.kcfg https://invent.kde.org/plasma/breeze/commit/eb73e004f329aa6d76f1ededfe964836ac364960 -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 448122] [Regression] Unchecking "Draw a circle around close button" does not set it to false in breezerc
https://bugs.kde.org/show_bug.cgi?id=448122 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/breeze/commit/f2d33bd33e ||3b823cbb485a03d656226ae0575 ||a6a Version Fixed In||5.24 Status|CONFIRMED |RESOLVED --- Comment #3 from Nate Graham --- Git commit f2d33bd33e3b823cbb485a03d656226ae0575a6a by Nate Graham, on behalf of Luke Horwell. Committed on 13/01/2022 at 18:02. Pushed by ngraham into branch 'master'. Fix OutlineCloseButton default for close tab buttons Under Window Decorations, the option "Draw a circle around close button" is unchecked by default. This normally applies to both window and tab close buttons, but tab buttons permanently had the circle visible because this boolean was incorrect. This made it impossible for the user to disable this style via GUI. `OutlineCloseButton=false` had to be explicitly added to `~/.config/breezerc`. Fixes a regression that started in the 5.23 cycle. FIXED-IN: 5.24 M +1-1kstyle/breeze.kcfg https://invent.kde.org/plasma/breeze/commit/f2d33bd33e3b823cbb485a03d656226ae0575a6a -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 448122] [Regression] Unchecking "Draw a circle around close button" does not set it to false in breezerc
https://bugs.kde.org/show_bug.cgi?id=448122 Luke Horwell changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Ever confirmed|0 |1 Resolution|WAITINGFORINFO |--- --- Comment #2 from Luke Horwell --- > If you click on the "Defaults" button in the dialog window that contains this > checkbox, what happens? It's unchecked, my bad. Sorry! I think my confusion came from seeing this in the code: https://invent.kde.org/plasma/breeze/-/blob/d3490373c2988c4c062351874dae4a2bf3981174/kstyle/breeze.kcfg#L34-37 I checked on KDE Neon, the problem happens there too. Thanks for clarifying how defaults should work in configuration files, that makes sense. I've created a merge request to fix this: https://invent.kde.org/plasma/breeze/-/merge_requests/167 Glad it's a simple negation and nothing complex. Can confirm recompiling Breeze with this correction fixes the issue. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 448122] [Regression] Unchecking "Draw a circle around close button" does not set it to false in breezerc
https://bugs.kde.org/show_bug.cgi?id=448122 Nate Graham changed: What|Removed |Added Status|REPORTED|NEEDSINFO CC||n...@kde.org Resolution|--- |WAITINGFORINFO --- Comment #1 from Nate Graham --- > By default, this is checked In fact it is not checked by default. Therefore the lack of a setting is interpreted as "false". For better or worse, this is the way all defaults work throughout KDE software; only when a setting it using a non-default value does there need to be a setting written to the config file, and when it returns to its default value, the config file entry is deleted. Perhaps your distro is patching the default to be true but changed the code incorrectly? If you click on the "Defaults" button in the dialog window that contains this checkbox, what happens? -- You are receiving this mail because: You are watching all bug changes.
