[Discover] [Bug 385973] Top 1/4 of app window is wasted space on Home, Browse, and Search Results screens

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=385973

--- Comment #14 from Aleix Pol  ---
Git commit d435e886d56d1c95ce4b3ac0b0f0a153f94ae021 by Aleix Pol.
Committed on 15/02/2018 at 00:10.
Pushed by apol into branch 'master'.

Use Kirgami.ToolBarApplicationHeader instead of the view headers

Summary:
Use the standard Kirigami component as header for Discover. Will need
some polishing on the kirigami component but will pay off in the long
run.
Supports {T7958}

Reviewers: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10471

M  +13   -50   discover/qml/ApplicationPage.qml
M  +1-8discover/qml/ApplicationsListPage.qml
M  +0-5discover/qml/BrowsingPage.qml
M  +7-2discover/qml/DiscoverWindow.qml
M  +1-1discover/qml/InstallApplicationButton.qml
M  +0-9discover/qml/InstalledPage.qml
C  +15   -28   discover/qml/KirigamiActionBridge.qml [from:
discover/qml/SearchPage.qml - 067% similarity]
M  +4-1discover/qml/SearchPage.qml
M  +6-33   discover/qml/SourcesPage.qml
M  +1-0discover/resources.qrc

https://commits.kde.org/discover/d435e886d56d1c95ce4b3ac0b0f0a153f94ae021

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space on Home, Browse, and Search Results screens

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |MOVED

--- Comment #13 from Nate Graham  ---
We are proceeding with this work! It involves adopting the upstream Kirigami
toolbar header, which is more compact and looks more appropriate on the desktop
in particular. As a part of this work, we are submitting patches and changing
the Kirigami toolbar header to better suit users' and developers' needs.
Because that is a large effort, we are now tracking this work in
https://phabricator.kde.org/T7958

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space on Home, Browse, and Search Results screens

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

Nate Graham  changed:

   What|Removed |Added

 CC||funkyna...@gmail.com

--- Comment #12 from Nate Graham  ---
*** Bug 389798 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space on Home, Browse, and Search Results screens

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385973

ria...@yahoo.com changed:

   What|Removed |Added

 CC||ria...@yahoo.com

--- Comment #11 from ria...@yahoo.com ---
I agree that the top header seems unnecessary, considering its size. However,
it does collapse to a more reasonable size once you start scrolling down (which
can be seen in the screenshots from andreas). This seems pretty much the same
size as in the mockup of the proposed new design. 

It seems to me that the problem here is caused by the initial size of the
header. But this is only considered a problem because the header seems to serve
no purpose that requires this large size. For identifying the category, the
smaller header (as shown when scrolling down) might suffice. 

So a solution here might be to make this large header more useful. I am not a
UX designer but from what I understand these headers/banners are usually
considered useful for promoting content, as it's the first thing that users
see. In this case, we could promote the content of the category being visited.

My main point is that we could consider making this header more useful, given
how visible it is to each user, instead of removing or resizing it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space on Home, Browse, and Search Results screens

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385973

matheus4...@hotmail.com changed:

   What|Removed |Added

 CC||matheus4...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space on Home, Browse, and Search Results screens

[andreas]

https://bugs.kde.org/show_bug.cgi?id=385973

andreas  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #10 from andreas  ---
Created attachment 109752
  --> https://bugs.kde.org/attachment.cgi?id=109752=edit
Discover Overview page with two column

In general I suggest to don't change any style decission from the existing
style cause it's clean, clear and well discussed.

you can use discover on small laptop screens quite good but on desktop 24''
screens it wouldn't be bad to use the page size better. So my suggestion is
that the ui switch from 1 to 2 (3) columns depanding on the window wide. The
minimum wide I would choose the wide when you have the default discover window
size.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space on Home, Browse, and Search Results screens

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385973

f.alexander.wi...@gmail.com changed:

   What|Removed |Added

 CC||f.alexander.wi...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space on Home, Browse, and Search Results screens

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

Nate Graham  changed:

   What|Removed |Added

Summary|Top 1/4 of app window is|Top 1/4 of app window is
   |wasted space|wasted space on Home,
   ||Browse, and Search Results
   ||screens

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

--- Comment #9 from Nate Graham  ---
Created attachment 108597
  --> https://bugs.kde.org/attachment.cgi?id=108597=edit
Apple Mac app store Categories page

The usefulness of the banners came up in the Telegram room recently, so I
wanted to attach some screenshots from the Mac app store as that was brought up
as an example.

In fact there is only a banner on the main page, and 90% of it is just an ad
for Apple's own software! None of the other pages have banners; they just have
just lists of apps. GNOME Software is similar, with a banner only on the main
page. And Linux Mint's mintinstall app store, which targets the same user
group, doesn't have banners at all. Discover is the only major App Store type
program I know of that maintains banners on the category page.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

--- Comment #8 from Nate Graham  ---
Created attachment 108596
  --> https://bugs.kde.org/attachment.cgi?id=108596=edit
Apple Mac app store Top Charts page

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

--- Comment #7 from Nate Graham  ---
Created attachment 108595
  --> https://bugs.kde.org/attachment.cgi?id=108595=edit
Apple App store main page

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[Diego Garcia]

https://bugs.kde.org/show_bug.cgi?id=385973

Diego Garcia  changed:

   What|Removed |Added

 CC||dnico...@gmail.com

--- Comment #6 from Diego Garcia  ---
+1 The image and the large search header don't add anything relevant and could
be removed. Also, the large space around the search box is incosistent with the
small search box in system settings.

The only thing I'd change in your mockup is aligning the title "Home" to the
left, and making it a breadcrumb when entering a subcategory. Font size might
have to adjusted for deep subcategories though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

--- Comment #5 from Nate Graham  ---
Heh, *please try to AVOID simply insulting people's work. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=385973

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

--- Comment #4 from Nate Graham  ---
Fire F, this is a volunteer community making software for free. We always
accept constructive criticism and patches that improve things, but please try
to simply insulting people's work. It can be discouraging.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[fire f .]

https://bugs.kde.org/show_bug.cgi?id=385973

--- Comment #3 from fire f.  ---
Comment on attachment 108467
  --> https://bugs.kde.org/attachment.cgi?id=108467
Mockup of proposed new design

This still is a terrible waste of screen space?

Why is that? It is indicative of very low software quality.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 385973] Top 1/4 of app window is wasted space

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385973

--- Comment #1 from Nate Graham  ---
Created attachment 108467
  --> https://bugs.kde.org/attachment.cgi?id=108467=edit
Mockup of proposed new design

-- 
You are receiving this mail because:
You are watching all bug changes.