[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-09-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=411034

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Nate Graham  ---
Ah, I didn't realize you were using Discover from git master, because the
version number on those bug reports said "KDE Plasma Version: 5.16.4". The fix
is in Plasma 5.16.5, si if you're really using 5.16.4, you would be hitting the
original issue because you didn't yet have the fix.

If those issues are hitting you when using either git master or Plasma 5.16.5
(since it was just released today), please re-open the bugs in question with a
comment indicating as such. Thanks, and sorry for the confusion!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-09-03 Thread Karl Ove Hufthammer
https://bugs.kde.org/show_bug.cgi?id=411034

Karl Ove Hufthammer  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #9 from Karl Ove Hufthammer  ---
(In reply to Nate Graham from comment #6)
> #1 is a separate semi-known-ish issue. Please file a new bug to track that.
> 
> I am not able to reproduce #2. Please file a new but for it, and attach a
> screen recording.

I don’t understand. First I reopened this bug because the original reported
issue (including ‘subissues’ #1 and #2) was *not* really fixed. Then you
reclose this bug as ‘fixed’ and tell me to instead file new, *separate* bugs
for #1 and #2. Then I do that exactly that. And then you close these new bug
reports as duplicates of this (‘fixed’) issue. This is really demotivating!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-09-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=411034

--- Comment #7 from Nate Graham  ---
*** Bug 411397 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-09-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=411034

--- Comment #8 from Nate Graham  ---
*** Bug 411396 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-08-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=411034

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Nate Graham  ---
#1 is a separate semi-known-ish issue. Please file a new bug to track that.

I am not able to reproduce #2. Please file a new but for it, and attach a
screen recording.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-08-28 Thread Karl Ove Hufthammer
https://bugs.kde.org/show_bug.cgi?id=411034

Karl Ove Hufthammer  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #5 from Karl Ove Hufthammer  ---
Reopening. I still don’t get any reviews (Git master version). There are two
cases:

1. If I click on an (installed) application *before* the ‘Fetching Updates...’
process is finished (which can easily take a minute or so), I get the
(translated version) of:

   Install this app and be the first to write a review!

And the log on the console says:

   org.kde.plasma.libdiscover: error fetching reviews: "Error transferring
https://odrs.gnome.org/1.0/reviews/api/fetch - server replied: BAD REQUEST"
"{\n\"msg\": \"missing data, expected version\",\n\"success\":
false\n}"


2. If I click on an application *after* the ‘Fetching Updates...’ process is
finished, I get (translated version) of:

Be the first to write a review!

And the log on the console says:

:7: TypeError: Type error
QFSFileEngine::open: No file name specified
file:///usr/lib64/qt5/qml/org/kde/kirigami.2/ItemViewHeader.qml:65:9:
Unable to assign QQuickPopupItem to Page_QMLTYPE_63

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-08-27 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=411034

Aleix Pol  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/dis
   ||cover/5e994dca11f4f877489ca
   ||f6e8c57ede89e416d14
 Resolution|--- |FIXED

--- Comment #4 from Aleix Pol  ---
Git commit 5e994dca11f4f877489caf6e8c57ede89e416d14 by Aleix Pol.
Committed on 27/08/2019 at 14:02.
Pushed by apol into branch 'Plasma/5.16'.

odrs: fix fetching reviews

M  +1-1libdiscover/appstream/OdrsReviewsBackend.cpp

https://commits.kde.org/discover/5e994dca11f4f877489caf6e8c57ede89e416d14

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-08-20 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=411034

--- Comment #3 from Aleix Pol  ---
Hey, thanks for reporting.
Yes, something seems to have changed on the server side, because it even breaks
on older versions.

I'm getting a BAD REQUEST reply from any fetch query, here's an example one:
{ "app_id": "org.kde.gcompris.desktop", "distro": "KDE neon", "limit": 0,
"locale": "ca_ES", "user_hash": "db2ad139150c10fe35391e9dc540602fe9657d27",
"version": "stable"}

Will reach out to ODRS maintainers to see if they know what could be going on.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-08-19 Thread Dan Jensen
https://bugs.kde.org/show_bug.cgi?id=411034

Dan Jensen  changed:

   What|Removed |Added

 CC||ad...@leinir.dk

--- Comment #2 from Dan Jensen  ---
Just for completion, these reviews are ODRS content, not OCS... But yes, still
not great they've gone missing somehow.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-08-19 Thread Ilya Bizyaev
https://bugs.kde.org/show_bug.cgi?id=411034

Ilya Bizyaev  changed:

   What|Removed |Added

 CC||bizy...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 411034] REGRESSION: Discover doesn’t show user reviews anymore

2019-08-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=411034

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |VHI
Summary|Discover doesn’t show user  |REGRESSION: Discover
   |reviews |doesn’t show user reviews
   ||anymore
   Severity|normal  |grave
 CC||n...@kde.org
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Nate Graham  ---
Can reproduce on Neon and Manjaro too. :/ If it's so widespread, it's probably
a real bug in Discover rather than all the distros providing bad OCS data.

-- 
You are receiving this mail because:
You are watching all bug changes.