[Discover] [Bug 438704] Move Settings and About actions to a Hamburger menu next to the Search field

2023-01-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438704

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 438704] Move Settings and About actions to a Hamburger menu next to the Search field

2021-07-06 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438704

--- Comment #5 from Nate Graham  ---
Yes but that's a view-specific overflow menu, and this bug report was asking to
put the "Settings" and "About" items that currently live in the sidebar into a
hamburger menu instead. The "Report Bug" action should probably be there too.
It should be more like in System Monitor, essentially.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 438704] Move Settings and About actions to a Hamburger menu next to the Search field

2021-07-06 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=438704

--- Comment #4 from Aleix Pol  ---
Created attachment 139901
  --> https://bugs.kde.org/attachment.cgi?id=139901=edit
What it looks like right now

By setting:
displayHint: Kirigami.DisplayHint.AlwaysHide

The icons are placed in the overflow menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 438704] Move Settings and About actions to a Hamburger menu next to the Search field

2021-07-06 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438704

Nate Graham  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Ever confirmed|1   |0
 Status|RESOLVED|REPORTED

--- Comment #3 from Nate Graham  ---
I cannot see any UI changes resulting from this commit, either in mobile or
desktop view. Also, by code inspection alone, it does not seem to implement the
requested change; no hamburger menu button on the toolbar has been created to
hold these actions. Re-opening.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 438704] Move Settings and About actions to a Hamburger menu next to the Search field

2021-07-06 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=438704

Aleix Pol  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/discover/commit/37bb1d85
   ||8344c6aa4316353c02bd76a454f
   ||5bcb8

--- Comment #2 from Aleix Pol  ---
Git commit 37bb1d858344c6aa4316353c02bd76a454f5bcb8 by Aleix Pol.
Committed on 06/07/2021 at 14:06.
Pushed by apol into branch 'master'.

Move Settings and About actions into hidden contextual menu

M  +13   -10   discover/qml/AboutPage.qml
M  +2-0discover/qml/Feedback.qml

https://invent.kde.org/plasma/discover/commit/37bb1d858344c6aa4316353c02bd76a454f5bcb8

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 438704] Move Settings and About actions to a Hamburger menu next to the Search field

2021-06-16 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=438704

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 438704] Move Settings and About actions to a Hamburger menu next to the Search field

2021-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438704

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|CONFIRMED
Summary|Discover is using an|Move Settings and About
   |inconsistent placement of   |actions to a Hamburger menu
   |some options|next to the Search field
 Ever confirmed|0   |1

--- Comment #1 from Nate Graham  ---
Yeah, it probably should.

-- 
You are receiving this mail because:
You are watching all bug changes.