[Discover] [Bug 460504] Cannot create review - stuck at "Insert a name"
https://bugs.kde.org/show_bug.cgi?id=460504 --- Comment #7 from Nate Graham --- You're very welcome! -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 460504] Cannot create review - stuck at "Insert a name"
https://bugs.kde.org/show_bug.cgi?id=460504 --- Comment #6 from hamsda.christ...@gmail.com --- Wow, thank you very much for the fast fix! You're all doing great work on KDE, love it :) -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 460504] Cannot create review - stuck at "Insert a name"
https://bugs.kde.org/show_bug.cgi?id=460504 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/discover/commit/8577309c |ma/discover/commit/ec06b73d |afbc9a07eff1cf7a5bdb25c0ac4 |f69edc21f0bab60cd331b776460 |056b8 |1af48 --- Comment #5 from Nate Graham --- Git commit ec06b73df69edc21f0bab60cd331b7764601af48 by Nate Graham. Committed on 18/10/2022 at 00:56. Pushed by ngraham into branch 'Plasma/5.26'. Reviews: Don't check for name field being empty when it's not visible Now, under certain circumstances, the name field will not be shown. But the logic for ensuring all review data has been filled out was not taking that into account, so it become impossible to submit a review when the field was invisible because technically it was empty, so it triggered the "Insert a name" condition. This commit fixes that by disabling the name check when the name field is invisible. FIXED-IN: 5.26.1 (cherry picked from commit 8577309cafbc9a07eff1cf7a5bdb25c0ac4056b8) M +1-1discover/qml/ReviewDialog.qml https://invent.kde.org/plasma/discover/commit/ec06b73df69edc21f0bab60cd331b7764601af48 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 460504] Cannot create review - stuck at "Insert a name"
https://bugs.kde.org/show_bug.cgi?id=460504 Aleix Pol changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/discover/commit/8577309c ||afbc9a07eff1cf7a5bdb25c0ac4 ||056b8 Version Fixed In||5.26.1 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #4 from Aleix Pol --- Git commit 8577309cafbc9a07eff1cf7a5bdb25c0ac4056b8 by Aleix Pol Gonzalez, on behalf of Nate Graham. Committed on 18/10/2022 at 00:46. Pushed by ngraham into branch 'master'. Reviews: Don't check for name field being empty when it's not visible Now, under certain circumstances, the name field will not be shown. But the logic for ensuring all review data has been filled out was not taking that into account, so it become impossible to submit a review when the field was invisible because technically it was empty, so it triggered the "Insert a name" condition. This commit fixes that by disabling the name check when the name field is invisible. FIXED-IN: 5.26.1 M +1-1discover/qml/ReviewDialog.qml https://invent.kde.org/plasma/discover/commit/8577309cafbc9a07eff1cf7a5bdb25c0ac4056b8 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 460504] Cannot create review - stuck at "Insert a name"
https://bugs.kde.org/show_bug.cgi?id=460504 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/393 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 460504] Cannot create review - stuck at "Insert a name"
https://bugs.kde.org/show_bug.cgi?id=460504 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from Nate Graham --- Yup, I was right. Fix incoming. -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 460504] Cannot create review - stuck at "Insert a name"
https://bugs.kde.org/show_bug.cgi?id=460504 Nate Graham changed: What|Removed |Added Keywords||regression CC||n...@kde.org --- Comment #1 from Nate Graham --- I have a feeling I know what this is. We now allow the user so set their own name, but not all backends support this, so the text field for it is only conditionally visible. I bet we're requiring that it has text in it even when it's not visible. I'll investigate and fix it. -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 460504] Cannot create review - stuck at "Insert a name"
https://bugs.kde.org/show_bug.cgi?id=460504 hamsda.christ...@gmail.com changed: What|Removed |Added CC||hamsda.christ...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
