[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 --- Comment #11 from Nate Graham --- Git commit b18ebb137e49ccde3be49239bfaa8d88ace6a0c4 by Nate Graham. Committed on 11/04/2023 at 20:56. Pushed by ngraham into branch 'Plasma/5.27'. Always clear offline updates file after a repair operation No matter what the results of the repair operation were, there's nothing of any value that anyone can do with the file anymore, and if it sticks around, it can annoy the user on every subsequent login for no good reason. So let's just remove it. Related: bug 451753, bug 450973 FIXED-IN: 5.27.5 (cherry picked from commit e87a50f455619dea5c51dea9c290556739112fc7) M +7-0libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp https://invent.kde.org/plasma/discover/commit/b18ebb137e49ccde3be49239bfaa8d88ace6a0c4 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 --- Comment #10 from Nate Graham --- Git commit e87a50f455619dea5c51dea9c290556739112fc7 by Nate Graham. Committed on 11/04/2023 at 20:53. Pushed by ngraham into branch 'master'. Always clear offline updates file after a repair operation No matter what the results of the repair operation were, there's nothing of any value that anyone can do with the file anymore, and if it sticks around, it can annoy the user on every subsequent login for no good reason. So let's just remove it. Related: bug 451753, bug 450973 FIXED-IN: 5.27.5 M +7-0libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp https://invent.kde.org/plasma/discover/commit/e87a50f455619dea5c51dea9c290556739112fc7 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 --- Comment #9 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/527 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 --- Comment #8 from Nate Graham --- Can we also clear it after the user clicks the "repair" button in the notification? We have some bug reports about this not working. -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 Nate Graham changed: What|Removed |Added Version Fixed In||5.27.4 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 Aleix Pol changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/discover/commit/cbecc135 |ma/discover/commit/18a85033 |d99b535a67f9a0d9a1b8b484e4c |c4f79157693b45247c7a19a6a64 |47e9a |8ec32 --- Comment #7 from Aleix Pol --- Git commit 18a85033c4f79157693b45247c7a19a6a648ec32 by Aleix Pol Gonzalez, on behalf of Aleix Pol. Committed on 31/03/2023 at 15:46. Pushed by apol into branch 'Plasma/5.27'. pk: Clear the offline state before starting a new one If there's results left-over from the past, just clear them and hope for better luck next time. (cherry picked from commit cbecc135d99b535a67f9a0d9a1b8b484e4c47e9a) M +6-0libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp https://invent.kde.org/plasma/discover/commit/18a85033c4f79157693b45247c7a19a6a648ec32 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 Aleix Pol changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/discover/commit/cbecc135 ||d99b535a67f9a0d9a1b8b484e4c ||47e9a Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Aleix Pol --- Git commit cbecc135d99b535a67f9a0d9a1b8b484e4c47e9a by Aleix Pol. Committed on 31/03/2023 at 14:53. Pushed by apol into branch 'master'. pk: Clear the offline state before starting a new one If there's results left-over from the past, just clear them and hope for better luck next time. M +6-0libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp https://invent.kde.org/plasma/discover/commit/cbecc135d99b535a67f9a0d9a1b8b484e4c47e9a -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 Martin Tlustos changed: What|Removed |Added CC||martin.tlus...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 --- Comment #5 from Martin Tlustos --- (In reply to Aleix Pol from comment #3) > It would have needed to remove the > "/var/lib/PackageKit/offline-update-competed" file. > > This is something that should be done by PackageKit so at least it's a bug > there upstream (on two counts: failing to cancel properly and then not > clearing the state as requested). > > Do you remember if you pressed "Repair System" or you closed the > notification? Yes, I clicked both "repair system" and "open discover" and closed the notification after several startups. -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/518 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 --- Comment #3 from Aleix Pol --- It would have needed to remove the "/var/lib/PackageKit/offline-update-competed" file. This is something that should be done by PackageKit so at least it's a bug there upstream (on two counts: failing to cancel properly and then not clearing the state as requested). Do you remember if you pressed "Repair System" or you closed the notification? -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 --- Comment #2 from Martin Tlustos --- It works for me now, but I don't mark it as fixed so someone can have a look at whether this behavior should be improved. -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 467638] discover doesn't recognize a fixed broken package problem
https://bugs.kde.org/show_bug.cgi?id=467638 --- Comment #1 from Martin Tlustos --- Additional info: I had disabled offline updates. After re-enabling them, applying the next available updates and restarting, the error message did not show up again. So it seems like there was some error log left behind that only gets cleared in offline mode, but when you switch to the old way of doing updates, it will keep on popping up. -- You are receiving this mail because: You are watching all bug changes.
