[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 Nate Graham changed: What|Removed |Added Version Fixed In||6.0.2 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 Aleix Pol changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/discover/-/commit/9272fe |ma/discover/-/commit/6e6477 |b88bf1e29e4d05097637c21f081 |8eb517ed3fbd0ec440f4ed28144 |cf7775a |3fe268e --- Comment #11 from Aleix Pol --- Git commit 6e64778eb517ed3fbd0ec440f4ed281443fe268e by Aleix Pol Gonzalez, on behalf of Aleix Pol. Committed on 06/03/2024 at 23:58. Pushed by ngraham into branch 'Plasma/6.0'. kns: Make sure we don't emit twice the same resource It breaks assumptions in the front-end. (cherry picked from commit 9272feb88bf1e29e4d05097637c21f081cf7775a) M +9-1libdiscover/backends/KNSBackend/KNSBackend.cpp https://invent.kde.org/plasma/discover/-/commit/6e64778eb517ed3fbd0ec440f4ed281443fe268e -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 Aleix Pol changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/discover/-/commit/9272fe ||b88bf1e29e4d05097637c21f081 ||cf7775a Resolution|--- |FIXED --- Comment #10 from Aleix Pol --- Git commit 9272feb88bf1e29e4d05097637c21f081cf7775a by Aleix Pol. Committed on 06/03/2024 at 22:01. Pushed by apol into branch 'master'. kns: Make sure we don't emit twice the same resource It breaks assumptions in the front-end. M +9-1libdiscover/backends/KNSBackend/KNSBackend.cpp https://invent.kde.org/plasma/discover/-/commit/9272feb88bf1e29e4d05097637c21f081cf7775a -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095
Harald Sitter changed:
What|Removed |Added
CC||sit...@kde.org
--- Comment #9 from Harald Sitter ---
(In reply to Aleix Pol from comment #7)
> @Harald, I'm not sure why you reached the conclusion that it's because of
> the nameSortKey. The deduplication happens when removing duplicates of the
> StreamResults and this is identified by their resource pointer address:
>
> Q_ASSERT(results.size() == QSet(results.constBegin(),
> results.constEnd()).size());
>
> inline size_t qHash(const StreamResult , size_t seed = 0)
> {
> return qHash(quintptr(key.resource), seed);
> }
>
> I did a small test and it seems that we are emitting the same resource
> several times for the same stream. I'll make a patch for that. I have been
> able to reproduce the issue although not reliably so double-checking would
> be appreciated.
Mh, you are right. I should have put on my glasses ;)
--
You are receiving this mail because:
You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #8 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/768 -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095
--- Comment #7 from Aleix Pol ---
@Harald, I'm not sure why you reached the conclusion that it's because of the
nameSortKey. The deduplication happens when removing duplicates of the
StreamResults and this is identified by their resource pointer address:
Q_ASSERT(results.size() == QSet(results.constBegin(),
results.constEnd()).size());
inline size_t qHash(const StreamResult , size_t seed = 0)
{
return qHash(quintptr(key.resource), seed);
}
I did a small test and it seems that we are emitting the same resource several
times for the same stream. I'll make a patch for that. I have been able to
reproduce the issue although not reliably so double-checking would be
appreciated.
--
You are receiving this mail because:
You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 Nate Graham changed: What|Removed |Added Priority|NOR |HI -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 Nate Graham changed: What|Removed |Added CC||danterpania...@gmail.com --- Comment #6 from Nate Graham --- *** Bug 482391 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 --- Comment #5 from Harald Sitter --- https://invent.kde.org/plasma/discover/-/blob/318739412171e08c60d13832a1584ebbfdd4bb9d/libdiscover/resources/ResourcesProxyModel.cpp#L636 The assert trips up on KNS resources that have the same user facing name. For example here's `name packageName` when searching for 'libreoffice': discover(67140)/(default) ResourcesProxyModel::sortedInsertion: "FS Icons Ubuntu" "1002489" discover(67140)/(default) ResourcesProxyModel::sortedInsertion: "FS Icons Ubuntu" "1012533" This happens because AbstractResource implements a nameSortKey() that is based on name. Indeed it must be because we want to sort the visual results by... name. To pass the assertion I suppose the KNS backend should deduplicate names somehow? -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 Harald Sitter changed: What|Removed |Added CC||bugsefor...@gmx.com --- Comment #4 from Harald Sitter --- *** Bug 477202 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 Nicolas Fella changed: What|Removed |Added Version|unspecified |6.0.0 CC||nicolas.fe...@gmx.de -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 --- Comment #3 from guimarcalsi...@gmail.com --- I managed to get a backtrace: Application: Discover (plasma-discover), signal: Aborted [KCrash Handler] #4 __pthread_kill_implementation (no_tid=0, signo=6, threadid=140347001359552) at ./nptl/pthread_kill.c:44 #5 __pthread_kill_internal (signo=6, threadid=140347001359552) at ./nptl/pthread_kill.c:78 #6 __GI___pthread_kill (threadid=140347001359552, signo=signo@entry=6) at ./nptl/pthread_kill.c:89 #7 0x7fa519242476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 #8 0x7fa5192287f3 in __GI_abort () at ./stdlib/abort.c:79 #9 0x7fa519edb017 in qAbort () at ./src/corelib/global/qglobal.cpp:161 #10 0x7fa519ed64e5 in qt_message_fatal (message=..., context=...) at ./src/corelib/global/qlogging.cpp:2003 #11 qt_message(QtMsgType, const QMessageLogContext &, const char *, typedef __va_list_tag __va_list_tag *) (msgType=msgType@entry=QtFatalMsg, context=..., msg=, ap=ap@entry=0x7ffc095f6460) at ./src/corelib/global/qlogging.cpp:378 #12 0x7fa519edba43 in QMessageLogger::fatal (this=, msg=) at ./src/corelib/global/qlogging.cpp:901 #13 0x7fa519ea9c94 in qt_assert (assertion=assertion@entry=0x7fa51c3a7cf0 "_res.size() == QSet(_res.constBegin(), _res.constEnd()).size()", file=file@entry=0x7fa51c3a76c8 "./libdiscover/resources/ResourcesProxyModel.cpp", line=line@entry=636) at ./src/corelib/global/qassert.cpp:68 #14 0x7fa51c3347dc in ResourcesProxyModel::sortedInsertion (this=0x55f733261510, _res=...) at ./libdiscover/resources/ResourcesProxyModel.cpp:636 #15 0x7fa51c375254 in ResourcesProxyModel::addResources (this=0x55f733261510, _res=...) at ./libdiscover/resources/ResourcesProxyModel.cpp:275 #16 0x7fa519e2b7ce in QtPrivate::QSlotObjectBase::call (a=, r=, this=, this=, r=, a=) at ./src/corelib/kernel/qobjectdefs_impl.h:433 #17 doActivate (sender=0x55f7337c9f20, signal_index=3, argv=0x7ffc095f6780) at ./src/corelib/kernel/qobject.cpp:4039 #18 0x7fa51c339776 in ResultsStream::resourcesFound (this=, _t1=...) at ./obj-x86_64-linux-gnu/libdiscover/DiscoverCommon_autogen/3YJK5W5UP7/moc_AbstractResourcesBackend.cpp:187 #19 0x7fa51c367e09 in AggregatedResultsStream::emitResults (this=0x55f7337c9f20) at ./libdiscover/resources/ResourcesModel.cpp:343 #20 0x7fa519e2b7ce in QtPrivate::QSlotObjectBase::call (a=, r=, this=, this=, r=, a=) at ./src/corelib/kernel/qobjectdefs_impl.h:433 #21 doActivate (sender=0x55f7337c9f50, signal_index=3, argv=0x7ffc095f68d0) at ./src/corelib/kernel/qobject.cpp:4039 #22 0x7fa519dde14e in QTimer::timeout (this=, _t1=...) at ./obj-x86_64-linux-gnu/src/corelib/Core_autogen/include/moc_qtimer.cpp:272 #23 0x7fa519dc94ce in QObject::event (this=0x55f7337c9f50, e=0x7ffc095f6a40) at ./src/corelib/kernel/qobject.cpp:1414 #24 0x7fa51bff40eb in QApplicationPrivate::notify_helper (this=, receiver=0x55f7337c9f50, e=0x7ffc095f6a40) at ./src/widgets/kernel/qapplication.cpp:3296 #25 0x7fa519e63e18 in QCoreApplication::notifyInternal2 (receiver=0x55f7337c9f50, event=0x7ffc095f6a40) at ./src/corelib/kernel/qcoreapplication.cpp:1121 #26 0x7fa519d5f121 in QTimerInfoList::activateTimers (this=0x55f732c70940) at ./src/corelib/kernel/qtimerinfo_unix.cpp:507 #27 0x7fa519c630fc in timerSourceDispatch (source=) at ./src/corelib/kernel/qeventdispatcher_glib.cpp:149 #28 0x7fa518c79d3b in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #29 0x7fa518ccf258 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #30 0x7fa518c773e3 in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #31 0x7fa519c5e1f0 in QEventDispatcherGlib::processEvents (this=0x55f732b73390, flags=...) at ./src/corelib/kernel/qeventdispatcher_glib.cpp:393 #32 0x7fa519e6604b in QEventLoop::exec (this=this@entry=0x7ffc095f6ca0, flags=..., flags@entry=...) at ./src/corelib/global/qflags.h:34 #33 0x7fa519e67c7c in QCoreApplication::exec () at ./src/corelib/global/qflags.h:74 #34 0x7fa51a2e9a20 in QGuiApplication::exec () at ./src/gui/kernel/qguiapplication.cpp:1925 #35 0x7fa51bff1689 in QApplication::exec () at ./src/widgets/kernel/qapplication.cpp:2574 #36 0x55f732439f3c in main (argc=, argv=) at ./discover/main.cpp:218 [Inferior 1 (process 7680) detached] -- You are receiving this mail because: You are watching all bug changes.
[Discover] [Bug 482095] Specific search terms causes discover to assert
https://bugs.kde.org/show_bug.cgi?id=482095 Nate Graham changed: What|Removed |Added Summary|Specific search terms |Specific search terms |causes discover to crash|causes discover to assert CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
