[Elisa] [Bug 441525] playlist crashes in FileBrowserProxyModel::recursiveEnqueue() Elisa if opened in Files window
https://bugs.kde.org/show_bug.cgi?id=441525 Jack Hill changed: What|Removed |Added Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult |imedia/elisa/-/commit/87ef4 |imedia/elisa/-/commit/24617 |2ed7864582c7c9899def66ab56d |8d77c77f89a430829e5113ffd20 |656aa8a3|805acb54 --- Comment #10 from Jack Hill --- Git commit 246178d77c77f89a430829e5113ffd20805acb54 by Jack Hill. Committed on 08/06/2024 at 11:10. Pushed by ngraham into branch 'release/24.05'. Fix potential crash when enqueueing from empty files view If the current folder is empty, then mPendingEntries will be empty. Calling front on an empty queue is undefined behaviour, and can result in a crash. Test-plan: added an autotest Related: bug 484972 (cherry picked from commit 87ef42ed7864582c7c9899def66ab56d656aa8a3) M +11 -0autotests/CMakeLists.txt A +86 -0autotests/filebrowserproxymodeltest.cpp [License: LGPL(v3.0+)] M +6-7src/models/filebrowserproxymodel.cpp https://invent.kde.org/multimedia/elisa/-/commit/246178d77c77f89a430829e5113ffd20805acb54 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 441525] playlist crashes in FileBrowserProxyModel::recursiveEnqueue() Elisa if opened in Files window
https://bugs.kde.org/show_bug.cgi?id=441525 Nate Graham changed: What|Removed |Added Version Fixed In||24.05.1 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 441525] playlist crashes in FileBrowserProxyModel::recursiveEnqueue() Elisa if opened in Files window
https://bugs.kde.org/show_bug.cgi?id=441525 Jack Hill changed: What|Removed |Added Latest Commit||https://invent.kde.org/mult ||imedia/elisa/-/commit/87ef4 ||2ed7864582c7c9899def66ab56d ||656aa8a3 Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #9 from Jack Hill --- Git commit 87ef42ed7864582c7c9899def66ab56d656aa8a3 by Jack Hill. Committed on 07/06/2024 at 19:58. Pushed by jackh into branch 'master'. Fix potential crash when enqueueing from empty files view If the current folder is empty, then mPendingEntries will be empty. Calling front on an empty queue is undefined behaviour, and can result in a crash. Test-plan: added an autotest Related: bug 484972 M +11 -0autotests/CMakeLists.txt A +86 -0autotests/filebrowserproxymodeltest.cpp [License: LGPL(v3.0+)] M +6-7src/models/filebrowserproxymodel.cpp https://invent.kde.org/multimedia/elisa/-/commit/87ef42ed7864582c7c9899def66ab56d656aa8a3 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 441525] playlist crashes in FileBrowserProxyModel::recursiveEnqueue() Elisa if opened in Files window
https://bugs.kde.org/show_bug.cgi?id=441525 Jack Hill changed: What|Removed |Added CC||germano.massu...@gmail.com --- Comment #8 from Jack Hill --- *** Bug 484665 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 441525] playlist crashes in FileBrowserProxyModel::recursiveEnqueue() Elisa if opened in Files window
https://bugs.kde.org/show_bug.cgi?id=441525 Nate Graham changed: What|Removed |Added Resolution|BACKTRACE |--- Status|NEEDSINFO |REPORTED Summary|playlist crashes Elisa if |playlist crashes in |opened in Files window |FileBrowserProxyModel::recu ||rsiveEnqueue() Elisa if ||opened in Files window --- Comment #7 from Nate Graham --- Thanks. :) Pasting the relevant part inline: 0x766d36e4 in QUrl::isValid() const () from /lib/x86_64-linux-gnu/libQt5Core.so.5 #0 0x766d36e4 in QUrl::isValid() const () at /lib/x86_64-linux-gnu/libQt5Core.so.5 #1 0x75c672d7 in () at /lib/x86_64-linux-gnu/libKF5KIOCore.so.5 #2 0x75c600f5 in KIO::ListJob::ListJob(KIO::ListJobPrivate&) () at /lib/x86_64-linux-gnu/libKF5KIOCore.so.5 #3 0x75c61c05 in () at /lib/x86_64-linux-gnu/libKF5KIOCore.so.5 #4 0x75c6051d in KIO::listRecursive(QUrl const&, QFlags, bool) () at /lib/x86_64-linux-gnu/libKF5KIOCore.so.5 #5 0x77efd9f1 in FileBrowserProxyModel::recursiveEnqueue() () at /usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0 #6 0x77efcb7d in FileBrowserProxyModel::listRecursiveResult(KJob*) () at /usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0 #7 0x77f03ed3 in QtPrivate::FunctorCall, QtPrivate::List, void, void (FileBrowserProxyModel::*)(KJob*)>::call(void (FileBrowserProxyModel::*)(KJob*), FileBrowserProxyModel*, void**) () at /usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0 #8 0x77f03627 in void QtPrivate::FunctionPointer::call, void>(void (FileBrowserProxyModel::*)(KJob*), FileBrowserProxyModel*, void**) () at /usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0 #9 0x77f029ff in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) () at /usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0 #10 0x767c75c7 in () at /lib/x86_64-linux-gnu/libQt5Core.so.5 #11 0x775bdfa0 in KJob::result(KJob*, KJob::QPrivateSignal) () at /lib/x86_64-linux-gnu/libKF5CoreAddons.so.5 #12 0x775bed1b in KJob::finishJob(bool) () at /lib/x86_64-linux-gnu/libKF5CoreAddons.so.5 -- You are receiving this mail because: You are watching all bug changes.
