[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult |imedia/elisa/commit/9c8ab40 |imedia/elisa/commit/3b32d3f |946685adf2c64a4e75fb60b103b |d6b8ec4a6ec032939edf76474e3 |5c5a8b |1e0606 Version Fixed In||23.04 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #13 from Nate Graham --- Git commit 3b32d3fd6b8ec4a6ec032939edf76474e31e0606 by Nate Graham. Committed on 12/01/2023 at 21:00. Pushed by ngraham into branch 'master'. Make menu buttons open on return/enter again Partially broken with be5d35bf932235f010bff61c021ec17fe6a0ac69. FIXED-IN: 23.04 M +11 -7src/qml/MediaPlayerControl.qml M +13 -8src/qml/NavigationActionBar.qml https://invent.kde.org/multimedia/elisa/commit/3b32d3fd6b8ec4a6ec032939edf76474e31e0606 -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #12 from Nate Graham --- Broken by me recently in https://invent.kde.org/multimedia/elisa/-/commit/be5d35bf932235f010bff61c021ec17fe6a0ac69, because I switched those menu buttons' onClicked: handlers with onPressed:, but they inherit from a base control that sends the clicked() signal when triggered with return/enter. Need to fix that other one too. -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 Nate Graham changed: What|Removed |Added Resolution|FIXED |--- Version Fixed In|22.08 | Status|RESOLVED|REPORTED Ever confirmed|1 |0 --- Comment #11 from Nate Graham --- Can confirm that the hamburger menu is still broken. -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 --- Comment #10 from Jack Hill --- I can't open the hamburger menu or the 3-dot menus listed in bug 464160. The PlayListEntry 3-dot menu works fine. -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 --- Comment #9 from Nate Graham --- Hamburger menu or 30-dot menu or both? Either way, those are different things and we need a different bug report for an issue with the hamburger menu vs the 3-dot menu. -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 --- Comment #8 from Jack Hill --- (In reply to Nate Graham from comment #7) > Can confirm that, but it's a separate issue. Can you file it? I suspect > it''s related to using Kirigami.ActionToolBar for those buttons, which > inherits the Qt default of activating buttons on space, not enter/return. Will do, but I still can't open the hamburger menu -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #7 from Nate Graham --- Can confirm that, but it's a separate issue. Can you file it? I suspect it''s related to using Kirigami.ActionToolBar for those buttons, which inherits the Qt default of activating buttons on space, not enter/return. -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 --- Comment #6 from Jack Hill --- Actually I just realised that the PlayListEntry works, but the other menus don't (footer of Now Playing; footer of playlist; application menu). -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 --- Comment #5 from Jack Hill --- Doesn't work in 22.12.01 or git master for me. Other buttons work though -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 --- Comment #4 from Nate Graham --- Works for me. Note that you have to hit the return or enter key, since the spacebar is globally bound to "Play/Pause" irrespective of keyboard focus. Is this not working for you? -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 Jack Hill changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #3 from Jack Hill --- Seems broken again -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In||22.08 Latest Commit||https://invent.kde.org/mult ||imedia/elisa/commit/9c8ab40 ||946685adf2c64a4e75fb60b103b ||5c5a8b Resolution|--- |FIXED --- Comment #2 from Nate Graham --- Git commit 9c8ab40946685adf2c64a4e75fb60b103b5c5a8b by Nate Graham, on behalf of Tranter Madi. Committed on 18/05/2022 at 19:57. Pushed by ngraham into branch 'master'. Fix playList's key navigation This fixes a recent regression and adds the ability to navigate between buttons with the arrow keys. FIXED-IN: 22.08 M +2-2src/qml/FlatButtonWithToolTip.qml M +40 -9src/qml/MediaPlayListView.qml M +107 -85 src/qml/PlayListEntry.qml https://invent.kde.org/multimedia/elisa/commit/9c8ab40946685adf2c64a4e75fb60b103b5c5a8b -- You are receiving this mail because: You are watching all bug changes.
[Elisa] [Bug 453591] Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard
https://bugs.kde.org/show_bug.cgi?id=453591 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Keywords||regression, usability Status|REPORTED|CONFIRMED CC||n...@kde.org, ||tr...@yandex.com --- Comment #1 from Nate Graham --- For that matter, the inline buttons lost keyboard-selectability too. Seems like a regression with the new UI. -- You are receiving this mail because: You are watching all bug changes.
