[Elisa] [Bug 470721] Elisa does not play .m3u8 playlists that contain embedded #EXTM3U and #EXTINF: tags

2024-04-26 Thread Jack Hill
https://bugs.kde.org/show_bug.cgi?id=470721

Jack Hill  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/-/commit/558be
   ||f47e298b6bb132fe3c58570a355
   ||75ecea6e
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Jack Hill  ---
Git commit 558bef47e298b6bb132fe3c58570a35575ecea6e by Jack Hill.
Committed on 26/04/2024 at 16:00.
Pushed by jackh into branch 'master'.

Fix loading playlists encoded with CRLF

CRLF files end with \r\n. We were not accounting for the extra \r, so
were looking for music files like "myfile.flac\r"

Test-plan:
1. Create a sample playlist file
2. Convert to crlf with `unix2dos -n input.m3u output.m3u`
3. Confirm crlf endings with `cat -A output.m3u` (lines should end with
   ^M$)
4. Import playlist into Elisa

Before: error. Now: works fine

Also added a unit test.

M  +37   -0autotests/mediaplaylistproxymodeltest.cpp
M  +4-0autotests/mediaplaylistproxymodeltest.h
M  +1-1src/mediaplaylistproxymodel.cpp

https://invent.kde.org/multimedia/elisa/-/commit/558bef47e298b6bb132fe3c58570a35575ecea6e

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 470721] Elisa does not play .m3u8 playlists that contain embedded #EXTM3U and #EXTINF: tags

2024-04-16 Thread Jack Hill
https://bugs.kde.org/show_bug.cgi?id=470721

Jack Hill  changed:

   What|Removed |Added

 CC||jackhill3...@gmail.com

--- Comment #5 from Jack Hill  ---
I don't think this is an issue with the # tags.

The file you provided is encoded using CRLF line terminators, i.e. lines end
with '\r\n' instead of just '\n'. This meant that the file paths were being
read like "01 OP.flac\r" which does not correspond to the correct file. Please
can you test the above merge request, if you are able to?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 470721] Elisa does not play .m3u8 playlists that contain embedded #EXTM3U and #EXTINF: tags

2024-04-16 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=470721

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/multimedia/elisa/-/merge_requests/572

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 470721] Elisa does not play .m3u8 playlists that contain embedded #EXTM3U and #EXTINF: tags

2024-04-13 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=470721

lubimov.maxim+...@gmail.com changed:

   What|Removed |Added

 CC||lubimov.maxim+...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 470721] Elisa does not play .m3u8 playlists that contain embedded #EXTM3U and #EXTINF: tags

2023-06-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=470721

--- Comment #3 from c948...@gmail.com ---
(In reply to Nate Graham from comment #2)

Thanks for the reply!
I guess I'll have to annoy the Manjaro package maintainers until they remove
VLC as a dependency for Elisa haha
For now, I'm going to try to compile Elisa against Qt6 myself as you suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 470721] Elisa does not play .m3u8 playlists that contain embedded #EXTM3U and #EXTINF: tags

2023-06-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=470721

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 470721] Elisa does not play .m3u8 playlists that contain embedded #EXTM3U and #EXTINF: tags

2023-06-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=470721

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
Summary|Elisa does not play .m3u8   |Elisa does not play .m3u8
   |playlists nor recognizes|playlists that contain
   |music files in the same |embedded #EXTM3U and
   |folder  |#EXTINF: tags
 Ever confirmed|0   |1
 CC||n...@kde.org

--- Comment #2 from Nate Graham  ---
Can reproduce.

FWIW with Qt6, it's feasible to only use the QtMultiMedia backend and ditch
VLC.

-- 
You are receiving this mail because:
You are watching all bug changes.