[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #16 from Volker Krause --- As I said 6 is only fixed in 24.05, so seeing that still if you are testing with 24.02.2 is expected. The new samples you sent me work here on initial testing, I have yet to find out why some of those are broken for you. -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #15 from cqu...@arcor.de --- I have installed KDE neon and now I see that there is a difference. Maybe for some reason the F-droid version has not libraries updated? There is still an issue with a ticket showing issue 6). The most weird thing is that for a connection I have 4 tickets. 2 behave OK (except for issue 6) and the other 2 show all issues as before. That's quite strange since they are part of the same reservation. I will send all 4 by email. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #14 from cqu...@arcor.de --- I have re-imported the PDFs but the issues are still there. I have even uninstalled completely the application and import everything from scratch but there is no change, at least in android from the f-droid repo. -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #13 from Volker Krause --- 1, 2, 3, 4, 8 and 9 should be fixed in 24.02.2, but it will require a re-import of the tickets. 6 and 7 are only fixed in 24.05, but should work without re-importing. 5 is hopefully fixed in 24.05 as well, but I have no way to verify that in a Finnish network unfortunately. -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #12 from cqu...@arcor.de --- Hi, than you for taking care of these issues. I see that a new version for KDE Itinerary Android is out: 24.02.02. I have seen from the release notes (https://apps.kde.org/es/itinerary/) that the support for VR has been improved, so I guess that the issues have been fixed. I installed it from F-droid but I see that the issues are still there. Is that the release that would fix the issues, or is it still on-going work? Thanks! -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #11 from Volker Krause --- Git commit 22a9a3e7e238fd73dbf9ae604f6565b18413aae5 by Volker Krause. Committed on 06/04/2024 at 08:24. Pushed by vkrause into branch 'release/24.02'. Add extractor script for VR mobile PDF tickets (cherry picked from commit c24a119bb2ad1367d2b3cfd66b1cb22d9015a0f2) M +17 -1src/lib/scripts/vr.fi.js https://invent.kde.org/pim/kitinerary/-/commit/22a9a3e7e238fd73dbf9ae604f6565b18413aae5 -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #10 from Volker Krause --- Git commit 1f9a20976859f6528f8729c947448f3645cc3376 by Volker Krause. Committed on 05/04/2024 at 15:55. Pushed by vkrause into branch 'master'. Regenerate the train station database Among generally new data this now includes Finish train statations with VR station codes containing umlauts. M +3-0autotests/knowledgedbtest.cpp M +---src/lib/knowledgedb/trainstationdb_data.cpp https://invent.kde.org/pim/kitinerary/-/commit/1f9a20976859f6528f8729c947448f3645cc3376 -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #8 from Volker Krause --- Git commit c24a119bb2ad1367d2b3cfd66b1cb22d9015a0f2 by Volker Krause. Committed on 05/04/2024 at 15:51. Pushed by vkrause into branch 'master'. Add extractor script for VR mobile PDF tickets M +17 -1src/lib/scripts/vr.fi.js https://invent.kde.org/pim/kitinerary/-/commit/c24a119bb2ad1367d2b3cfd66b1cb22d9015a0f2 -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #9 from Volker Krause --- Git commit d1c8044fa6649eeaefcfc542b7a50246ea21e02f by Volker Krause. Committed on 05/04/2024 at 15:54. Pushed by vkrause into branch 'master'. Support VR station code umlauts That's outside of the ERA SSB spec, and needs some hacks to work with our compile-time generated train station index. M +24 -0autotests/knowledgedbtest.cpp M +4-2src/knowledgedb-generator/trainstationdbgenerator.cpp M +17 -5src/lib/knowledgedb/stationidentifier.cpp M +10 -6src/lib/knowledgedb/stationidentifier.h https://invent.kde.org/pim/kitinerary/-/commit/d1c8044fa6649eeaefcfc542b7a50246ea21e02f -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #7 from cqu...@arcor.de --- Hi, thank you very much for taking care of this! Yesterday I tried again from Germany before writing the ticket, but I have tried also from Finland while being there. I am no longer there, so I really cannot test it again :( -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #6 from Volker Krause --- Git commit 47a04a30d8c0e27566f891dd73efe78d5ecebaa9 by Volker Krause. Committed on 04/04/2024 at 16:03. Pushed by vkrause into branch 'release/24.02'. Consider berth number in VR ERA SSB ticket barcodes Also, validate the classOfTransport value to deal with class-less tickets. (cherry picked from commit 2075fe69babf17ffd257e3f66a5f5184ba64b951) M +3-2src/lib/scripts/vr.fi.js https://invent.kde.org/pim/kitinerary/-/commit/47a04a30d8c0e27566f891dd73efe78d5ecebaa9 -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #5 from Volker Krause --- Git commit fe8edfa3feaa77fdecc42a07e73f19004b95c065 by Volker Krause. Committed on 04/04/2024 at 16:03. Pushed by vkrause into branch 'release/24.02'. Fix ERA SSB date conversion There's two issues here: - for SSBv1 we missed the end-of-year wrap around logic. - for SSBv2 the end-of-year wrap around was computed correctly but the result ended up being discarded. (cherry picked from commit 60181caf311d11fe0afbbf150e1f359a861728ae) M +16 -0src/lib/era/ssbticketbase.cpp M +8-2src/lib/era/ssbticketbase.h M +2-3src/lib/era/ssbv1ticket.cpp M +4-18 src/lib/era/ssbv2ticket.cpp https://invent.kde.org/pim/kitinerary/-/commit/fe8edfa3feaa77fdecc42a07e73f19004b95c065 -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #4 from Volker Krause --- Git commit 60181caf311d11fe0afbbf150e1f359a861728ae by Volker Krause. Committed on 04/04/2024 at 15:52. Pushed by vkrause into branch 'master'. Fix ERA SSB date conversion There's two issues here: - for SSBv1 we missed the end-of-year wrap around logic. - for SSBv2 the end-of-year wrap around was computed correctly but the result ended up being discarded. M +16 -0src/lib/era/ssbticketbase.cpp M +8-2src/lib/era/ssbticketbase.h M +2-3src/lib/era/ssbv1ticket.cpp M +4-18 src/lib/era/ssbv2ticket.cpp https://invent.kde.org/pim/kitinerary/-/commit/60181caf311d11fe0afbbf150e1f359a861728ae -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #2 from Volker Krause --- Git commit 2075fe69babf17ffd257e3f66a5f5184ba64b951 by Volker Krause. Committed on 04/04/2024 at 15:52. Pushed by vkrause into branch 'master'. Consider berth number in VR ERA SSB ticket barcodes Also, validate the classOfTransport value to deal with class-less tickets. M +3-2src/lib/scripts/vr.fi.js https://invent.kde.org/pim/kitinerary/-/commit/2075fe69babf17ffd257e3f66a5f5184ba64b951 -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #3 from Volker Krause --- Git commit e909a3c153930b5c76a17242b937e1abb9009f5a by Volker Krause. Committed on 04/04/2024 at 15:53. Pushed by vkrause into branch 'master'. Decode Finish ERA SSB alphanumeric station codes correctly A few of those use an 'Ä' as part of the code, which isn't really part of the ERA specification as far as I can tell. In itself this doesn't help yet, we still need the train station database side of this. M +5-2src/lib/era/ssbticketbase.cpp https://invent.kde.org/pim/kitinerary/-/commit/e909a3c153930b5c76a17242b937e1abb9009f5a -- You are receiving this mail because: You are watching all bug changes.
[KDE Itinerary] [Bug 485004] Several issues with VR (Finish operator) imported train tickets
https://bugs.kde.org/show_bug.cgi?id=485004 --- Comment #1 from Volker Krause --- VR seems to have changed their PDF layout, so what you are seeing there is the fallback to just the barcode content (which e.g. doesn't have the full station names or exact times), that explains most of 2, 3, 4, 8 and 9. With the samples you provided this should be fixable though. For 5: when and more importantly in which country (from a network point of view) did you test 5? The Finish public transport API we use has had various counter-measures for a DDoS attack in place, including geo-blocking IPs. -- You are receiving this mail because: You are watching all bug changes.
