[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 --- Comment #3 from Jarosław Staniek --- Git commit 26203c294764c5a388d61836e9baf2fd3b68876f by Jaroslaw Staniek. Committed on 26/03/2018 at 22:22. Pushed by staniek into branch 'master'. Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables This change is backward compatible since metadata without physical table is not usable anyway. FIXED-IN:3.2.0 M +44 -2src/KDbConnection.cpp M +20 -1src/KDbConnection.h M +5-0src/KDbConnectionProxy.cpp M +5-0src/KDbConnectionProxy.h M +10 -1src/KDbDriverBehavior.h M +4-3src/drivers/mysql/MysqlDriver.cpp M +3-0src/drivers/postgresql/PostgresqlDriver.cpp M +2-0src/drivers/sqlite/SqliteDriver.cpp https://commits.kde.org/kdb/26203c294764c5a388d61836e9baf2fd3b68876f --- Comment #4 from Jarosław Staniek --- Git commit 219c02d1bb58fde744e9150c35914cc594ad3138 by Jaroslaw Staniek. Committed on 26/03/2018 at 22:22. Pushed by staniek into branch 'master'. Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables Summary: - KDbTestUtils: add convenience APIs for connecting and using db, support connection options, use it in parser test - Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables - This change is backward compatible since metadata without physical table is not usable anyway. FIXED-IN:3.2.0 + Add autotest for handling missing physical tables Test Plan: Run ctest Reviewers: piggz Tags: #kdb Differential Revision: https://phabricator.kde.org/D11547 M +3-0autotests/CMakeLists.txt A +84 -0autotests/MissingTableTest.cpp [License: LGPL (v2+)] A +---autotests/data/missingTableTest.kexi https://commits.kde.org/kdb/219c02d1bb58fde744e9150c35914cc594ad3138 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Version Fixed In|3.2. Alpha |3.2 Alpha Resolution|--- |FIXED Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Version Fixed In||3.2. Alpha Latest Commit||https://commits.kde.org/kdb ||/219c02d1bb58fde744e9150c35 ||914cc594ad3138 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Target Milestone|--- |3.1.1 --- Comment #1 from Jarosław Staniek --- Possible solution at KDb level: on first call to KDbConnection::tableNames() obtain list of physical tables and compare with tables from kexi__objects metadata. -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Target Milestone|3.1.1 |3.2 Assignee|kexi-b...@kde.org |stan...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 --- Comment #2 from Jarosław Staniek --- Update: additional fix is needed in KEXI itself in the code loading part items because it's for some reasons separate from KDb. -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Version Fixed In|3.2 Alpha |3.2.0 Status|CLOSED |RESOLVED Latest Commit|https://commits.kde.org/kdb |https://commits.kde.org/kex |/219c02d1bb58fde744e9150c35 |i/83a672c348ca9d263e9739bb3 |914cc594ad3138 |ee5566ca8d5d702 --- Comment #5 from Jarosław Staniek --- Git commit 83a672c348ca9d263e9739bb3ee5566ca8d5d702 by Jaroslaw Staniek. Committed on 05/06/2018 at 22:32. Pushed by staniek into branch 'master'. Skip table name if physical table is non-existing, use the new tableNames API in migration Summary: FIXED-IN:3.2.0 Note: functionality of migration is not affected, it's just the code cleanup thanks to the new API. Test Plan: Open kdb.git/autotests/data/missingTableTest.kexi, it should not list persons table anymore. Reviewers: piggz Tags: #kexi Differential Revision: https://phabricator.kde.org/D11549 M +1-1CMakeLists.txt M +37 -11 src/core/kexiproject.cpp M +3-15 src/migration/KexiSqlMigrate.cpp M +0-3src/migration/KexiSqlMigrate.h M +0-1src/migration/mysql/mysqlmigrate.cpp M +0-1src/migration/postgresql/PostgresqlMigrate.cpp https://commits.kde.org/kexi/83a672c348ca9d263e9739bb3ee5566ca8d5d702 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 --- Comment #6 from Jarosław Staniek --- Git commit 9978d76a494ca4dc6760158ef742660e2b4989cb by Jaroslaw Staniek. Committed on 06/01/2019 at 21:14. Pushed by staniek into branch '3.2'. Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables Summary: - KDbTestUtils: add convenience APIs for connecting and using db, support connection options, use it in parser test - Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables - This change is backward compatible since metadata without physical table is not usable anyway. FIXED-IN:3.2.0 + Add autotest for handling missing physical tables Test Plan: Run ctest Reviewers: piggz Tags: #kdb Differential Revision: https://phabricator.kde.org/D11547 M +3-0autotests/CMakeLists.txt A +84 -0autotests/MissingTableTest.cpp [License: LGPL (v2+)] A +---autotests/data/missingTableTest.kexi https://commits.kde.org/kdb/9978d76a494ca4dc6760158ef742660e2b4989cb --- Comment #7 from Jarosław Staniek --- Git commit e5c3a99d939e9176da8a3d8809a6f48c8186bed8 by Jaroslaw Staniek. Committed on 06/01/2019 at 21:14. Pushed by staniek into branch '3.2'. Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables This change is backward compatible since metadata without physical table is not usable anyway. FIXED-IN:3.2.0 M +44 -2src/KDbConnection.cpp M +20 -1src/KDbConnection.h M +5-0src/KDbConnectionProxy.cpp M +5-0src/KDbConnectionProxy.h M +10 -1src/KDbDriverBehavior.h M +4-3src/drivers/mysql/MysqlDriver.cpp M +3-0src/drivers/postgresql/PostgresqlDriver.cpp M +2-0src/drivers/sqlite/SqliteDriver.cpp https://commits.kde.org/kdb/e5c3a99d939e9176da8a3d8809a6f48c8186bed8 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Latest Commit|https://commits.kde.org/kex |https://commits.kde.org/kex |i/83a672c348ca9d263e9739bb3 |i/bcebf0787f0e75de019ba92e7 |ee5566ca8d5d702 |730fc57c2b23a30 --- Comment #8 from Jarosław Staniek --- Git commit bcebf0787f0e75de019ba92e7730fc57c2b23a30 by Jaroslaw Staniek. Committed on 06/01/2019 at 21:41. Pushed by staniek into branch '3.2'. Skip table name if physical table is non-existing, use the new tableNames API in migration Summary: FIXED-IN:3.2.0 Note: functionality of migration is not affected, it's just the code cleanup thanks to the new API. Test Plan: Open kdb.git/autotests/data/missingTableTest.kexi, it should not list persons table anymore. Reviewers: piggz Tags: #kexi Differential Revision: https://phabricator.kde.org/D11549 # Conflicts: # CMakeLists.txt M +37 -11 src/core/kexiproject.cpp M +3-15 src/migration/KexiSqlMigrate.cpp M +0-3src/migration/KexiSqlMigrate.h M +0-1src/migration/mysql/mysqlmigrate.cpp M +0-1src/migration/postgresql/PostgresqlMigrate.cpp https://commits.kde.org/kexi/bcebf0787f0e75de019ba92e7730fc57c2b23a30 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 --- Comment #3 from Jarosław Staniek --- Git commit 26203c294764c5a388d61836e9baf2fd3b68876f by Jaroslaw Staniek. Committed on 26/03/2018 at 22:22. Pushed by staniek into branch 'master'. Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables This change is backward compatible since metadata without physical table is not usable anyway. FIXED-IN:3.2.0 M +44 -2src/KDbConnection.cpp M +20 -1src/KDbConnection.h M +5-0src/KDbConnectionProxy.cpp M +5-0src/KDbConnectionProxy.h M +10 -1src/KDbDriverBehavior.h M +4-3src/drivers/mysql/MysqlDriver.cpp M +3-0src/drivers/postgresql/PostgresqlDriver.cpp M +2-0src/drivers/sqlite/SqliteDriver.cpp https://commits.kde.org/kdb/26203c294764c5a388d61836e9baf2fd3b68876f --- Comment #4 from Jarosław Staniek --- Git commit 219c02d1bb58fde744e9150c35914cc594ad3138 by Jaroslaw Staniek. Committed on 26/03/2018 at 22:22. Pushed by staniek into branch 'master'. Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables Summary: - KDbTestUtils: add convenience APIs for connecting and using db, support connection options, use it in parser test - Add KDbConnection::drv_getTableNames for low level list of table names, make tableNames() skip names with non-existing physical tables - This change is backward compatible since metadata without physical table is not usable anyway. FIXED-IN:3.2.0 + Add autotest for handling missing physical tables Test Plan: Run ctest Reviewers: piggz Tags: #kdb Differential Revision: https://phabricator.kde.org/D11547 M +3-0autotests/CMakeLists.txt A +84 -0autotests/MissingTableTest.cpp [License: LGPL (v2+)] A +---autotests/data/missingTableTest.kexi https://commits.kde.org/kdb/219c02d1bb58fde744e9150c35914cc594ad3138 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Version Fixed In|3.2. Alpha |3.2 Alpha Resolution|--- |FIXED Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Version Fixed In||3.2. Alpha Latest Commit||https://commits.kde.org/kdb ||/219c02d1bb58fde744e9150c35 ||914cc594ad3138 -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Target Milestone|--- |3.1.1 --- Comment #1 from Jarosław Staniek --- Possible solution at KDb level: on first call to KDbConnection::tableNames() obtain list of physical tables and compare with tables from kexi__objects metadata. -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Target Milestone|3.1.1 |3.2 Assignee|kexi-b...@kde.org |stan...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 --- Comment #2 from Jarosław Staniek --- Update: additional fix is needed in KEXI itself in the code loading part items because it's for some reasons separate from KDb. -- You are receiving this mail because: You are watching all bug changes.
[KEXI] [Bug 392112] Deleted physical tables still visible in project navigator
https://bugs.kde.org/show_bug.cgi?id=392112 Jarosław Staniek changed: What|Removed |Added Version Fixed In|3.2 Alpha |3.2.0 Status|CLOSED |RESOLVED Latest Commit|https://commits.kde.org/kdb |https://commits.kde.org/kex |/219c02d1bb58fde744e9150c35 |i/83a672c348ca9d263e9739bb3 |914cc594ad3138 |ee5566ca8d5d702 --- Comment #5 from Jarosław Staniek --- Git commit 83a672c348ca9d263e9739bb3ee5566ca8d5d702 by Jaroslaw Staniek. Committed on 05/06/2018 at 22:32. Pushed by staniek into branch 'master'. Skip table name if physical table is non-existing, use the new tableNames API in migration Summary: FIXED-IN:3.2.0 Note: functionality of migration is not affected, it's just the code cleanup thanks to the new API. Test Plan: Open kdb.git/autotests/data/missingTableTest.kexi, it should not list persons table anymore. Reviewers: piggz Tags: #kexi Differential Revision: https://phabricator.kde.org/D11549 M +1-1CMakeLists.txt M +37 -11 src/core/kexiproject.cpp M +3-15 src/migration/KexiSqlMigrate.cpp M +0-3src/migration/KexiSqlMigrate.h M +0-1src/migration/mysql/mysqlmigrate.cpp M +0-1src/migration/postgresql/PostgresqlMigrate.cpp https://commits.kde.org/kexi/83a672c348ca9d263e9739bb3ee5566ca8d5d702 -- You are receiving this mail because: You are watching all bug changes.
