[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 David Edmundson changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/ksc ||reen/5c45d27f00b4207d5db347 ||350a81e8ecb6bdb108 --- Comment #10 from David Edmundson --- Git commit 5c45d27f00b4207d5db347350a81e8ecb6bdb108 by David Edmundson. Committed on 24/07/2018 at 19:13. Pushed by davidedmundson into branch 'Plasma/5.12'. Fix preview widget appearing to scale twice Summary: It worked when I wrote it against integer scaling, it got broken when fractional support was added, resulting in it rendering at the wrong size when the host scaling is non integer. Test Plan: Ran with QT_SCALE_FACTOR=1.5 to simulate the host being at that scale Opened preview and moved slider At 1.0 buttons were smaller than the main KCM At 1.5 buttons looked the same At 2.0 looked bigger Reviewers: broulik Reviewed By: broulik Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D14338 M +1-1kcm/src/previewwidget.cpp https://commits.kde.org/kscreen/5c45d27f00b4207d5db347350a81e8ecb6bdb108 -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Christoph Feck changed: What|Removed |Added Product|systemsettings |KScreen Component|general |kcm -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org --- Comment #4 from Sebastian Kügler --- I can't reproduce this on my system. Could you post the info as outlined in https://community.kde.org/Solid/Projects/ScreenManagement#Debugging_Information here, so I can have a look at what's specific to your setup? -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 --- Comment #5 from Christoph Feck --- If you can provide the information requested in comment #4, please add it. -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Lastique changed: What|Removed |Added Attachment #109513|0 |1 is obsolete|| --- Comment #6 from Lastique --- Created attachment 110064 --> https://bugs.kde.org/attachment.cgi?id=110064&action=edit Logs collected for scale ratio 1.0 and 1.7 Here are the collected logs. After I enabled the logs I first booted the system with 1.0 scale ratio. You can find the collected logs and settings for this boot time in the 1.0 subfolder. I started the kcm_shell and changed the scale ratio to 1.7 and then rebooted. Logs and settings from after that reboot are in the 1.7 subfolder. While booted with 1.7 scale ratio, I started kcm_shell again (the bug was apparent) and changed the scale ratio back to 1.0. -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 --- Comment #7 from Lastique --- Created attachment 110065 --> https://bugs.kde.org/attachment.cgi?id=110065&action=edit Scaling dialog when system is booted with ratio 1.7 and the ratio is 1.7 Here is a screenshot taken from the system booted with scale ratio 1.7 and the scale ratio in the dialog is 1.7 too (i.e. unchanged since boot). You can see that the preview elements are noticeably larger than the rest of the interface. -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Lastique changed: What|Removed |Added Attachment #110065|0 |1 is obsolete|| --- Comment #8 from Lastique --- Created attachment 110066 --> https://bugs.kde.org/attachment.cgi?id=110066&action=edit Scaling dialog when system is booted with ratio 1.7 and the ratio is 1.7 -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 --- Comment #9 from Lastique --- Created attachment 110067 --> https://bugs.kde.org/attachment.cgi?id=110067&action=edit Scaling dialog when system is booted with ratio 1.7 and the ratio is 1.0 And here is a screenshot from the system that is still booted with scale ratio 1.7 but the slider in the dialog have been moved to 1.0. Notice that the preview elements are roughly the same size as the rest of the UI (i.e. are actually 1.7 times larger than they would normally be with scale ratio 1.0). -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 David Edmundson changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/ksc ||reen/5c45d27f00b4207d5db347 ||350a81e8ecb6bdb108 --- Comment #10 from David Edmundson --- Git commit 5c45d27f00b4207d5db347350a81e8ecb6bdb108 by David Edmundson. Committed on 24/07/2018 at 19:13. Pushed by davidedmundson into branch 'Plasma/5.12'. Fix preview widget appearing to scale twice Summary: It worked when I wrote it against integer scaling, it got broken when fractional support was added, resulting in it rendering at the wrong size when the host scaling is non integer. Test Plan: Ran with QT_SCALE_FACTOR=1.5 to simulate the host being at that scale Opened preview and moved slider At 1.0 buttons were smaller than the main KCM At 1.5 buttons looked the same At 2.0 looked bigger Reviewers: broulik Reviewed By: broulik Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D14338 M +1-1kcm/src/previewwidget.cpp https://commits.kde.org/kscreen/5c45d27f00b4207d5db347350a81e8ecb6bdb108 -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org --- Comment #4 from Sebastian Kügler --- I can't reproduce this on my system. Could you post the info as outlined in https://community.kde.org/Solid/Projects/ScreenManagement#Debugging_Information here, so I can have a look at what's specific to your setup? -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 --- Comment #5 from Christoph Feck --- If you can provide the information requested in comment #4, please add it. -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Lastique changed: What|Removed |Added Attachment #109513|0 |1 is obsolete|| --- Comment #6 from Lastique --- Created attachment 110064 --> https://bugs.kde.org/attachment.cgi?id=110064&action=edit Logs collected for scale ratio 1.0 and 1.7 Here are the collected logs. After I enabled the logs I first booted the system with 1.0 scale ratio. You can find the collected logs and settings for this boot time in the 1.0 subfolder. I started the kcm_shell and changed the scale ratio to 1.7 and then rebooted. Logs and settings from after that reboot are in the 1.7 subfolder. While booted with 1.7 scale ratio, I started kcm_shell again (the bug was apparent) and changed the scale ratio back to 1.0. -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 --- Comment #7 from Lastique --- Created attachment 110065 --> https://bugs.kde.org/attachment.cgi?id=110065&action=edit Scaling dialog when system is booted with ratio 1.7 and the ratio is 1.7 Here is a screenshot taken from the system booted with scale ratio 1.7 and the scale ratio in the dialog is 1.7 too (i.e. unchanged since boot). You can see that the preview elements are noticeably larger than the rest of the interface. -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Lastique changed: What|Removed |Added Attachment #110065|0 |1 is obsolete|| --- Comment #8 from Lastique --- Created attachment 110066 --> https://bugs.kde.org/attachment.cgi?id=110066&action=edit Scaling dialog when system is booted with ratio 1.7 and the ratio is 1.7 -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 --- Comment #9 from Lastique --- Created attachment 110067 --> https://bugs.kde.org/attachment.cgi?id=110067&action=edit Scaling dialog when system is booted with ratio 1.7 and the ratio is 1.0 And here is a screenshot from the system that is still booted with scale ratio 1.7 but the slider in the dialog have been moved to 1.0. Notice that the preview elements are roughly the same size as the rest of the UI (i.e. are actually 1.7 times larger than they would normally be with scale ratio 1.0). -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 388218] Desktop scaling is applied twice in Scale Display preview
https://bugs.kde.org/show_bug.cgi?id=388218 Christoph Feck changed: What|Removed |Added Product|systemsettings |KScreen Component|general |kcm -- You are receiving this mail because: You are watching all bug changes.
