[KScreen] [Bug 390638] Wayland - cannot change primary screen

[Sebastian Kügler]

https://bugs.kde.org/show_bug.cgi?id=390638

Sebastian Kügler  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit||https://commits.kde.org/ksc
   ||reen/cd3b350e0225a3a1616804
   ||924420f86e39db50a1

--- Comment #4 from Sebastian Kügler  ---
Git commit cd3b350e0225a3a1616804924420f86e39db50a1 by Sebastian Kügler.
Committed on 23/02/2018 at 08:57.
Pushed by sebas into branch 'master'.

hide primary display combo when not supported

Summary:
Some backends, for example the kwayland backend, do not support
setting the primary display. The backends already make their
feature set known so we can just hide it from the UI.

It's enough to hide it from the UI since setting it doesn't make
any difference, the libkscreen backend will simply ignore it
internally, so it's just honest to not show it.

Test Plan:
ran kscreen kcm on both, X11 and wayland platforms, combo
and label are shown and hidden as expected

Reviewers: #plasma, dvratil, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kpiwowarski, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10723

M  +4-2kcm/src/widget.cpp
M  +2-0kcm/src/widget.h

https://commits.kde.org/kscreen/cd3b350e0225a3a1616804924420f86e39db50a1

-- 
You are receiving this mail because:
You are watching all bug changes.

[KScreen] [Bug 390638] Wayland - cannot change primary screen

[Sebastian Kügler]

https://bugs.kde.org/show_bug.cgi?id=390638

Sebastian Kügler  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|INVALID |---
 Status|RESOLVED|REOPENED

--- Comment #3 from Sebastian Kügler  ---
I agree, we should hide the respective UI in this case:

https://phabricator.kde.org/D10723

-- 
You are receiving this mail because:
You are watching all bug changes.

[KScreen] [Bug 390638] Wayland - cannot change primary screen

[Kamil Piwowarski]

https://bugs.kde.org/show_bug.cgi?id=390638

--- Comment #2 from Kamil Piwowarski <9luty1...@gmail.com> ---
It would be good to remove this select box on Wayland session :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[KScreen] [Bug 390638] Wayland - cannot change primary screen

[Sebastian Kügler]

https://bugs.kde.org/show_bug.cgi?id=390638

Sebastian Kügler  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Sebastian Kügler  ---
The panel and primary screen have nothing to do with each other. You can move
the panel using the panel controller.

Note: Primary screen is not a concept in Wayland, it's not even well defined in
X11-based Plasma, so we're moving away from it.

-- 
You are receiving this mail because:
You are watching all bug changes.