[NeoChat] [Bug 469733] Can no longer use the up arrow to edit the last message

2023-05-27 Thread James Graham 
https://bugs.kde.org/show_bug.cgi?id=469733

James Graham  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/netw
   ||ork/neochat/-/commit/ee5379
   ||3a6daeb8bc2bc2f9a5918ca3604
   ||ae49c3d

--- Comment #2 from James Graham  ---
Git commit ee53793a6daeb8bc2bc2f9a5918ca3604ae49c3d by James Graham.
Committed on 27/05/2023 at 16:36.
Pushed by nvrwhere into branch 'master'.

Fix replying and editing from chatbox

Restore the functionality to edit or reply to the last message in the
`chatbar`.

This is achieved be moving the functions `getLastLocalUserMessageEventId` and
`getLatestMessageFromRow` to `NeoChatRoom` as `editLastMessage` and
`replyLastMessage` as `chatbar` no longer has access to `messageEventModel`.

The functions are also simplified as they only need to find the `eventId` and
always from row 0 as this was the only use of the functions.

M  +0-81   src/models/messageeventmodel.cpp
M  +0-25   src/models/messageeventmodel.h
M  +67   -0src/neochatroom.cpp
M  +15   -0src/neochatroom.h
M  +2-8src/qml/Component/ChatBox/ChatBar.qml

https://invent.kde.org/network/neochat/-/commit/ee53793a6daeb8bc2bc2f9a5918ca3604ae49c3d

-- 
You are receiving this mail because:
You are watching all bug changes.

[NeoChat] [Bug 469733] Can no longer use the up arrow to edit the last message

2023-05-26 Thread Bug Janitor Service 
https://bugs.kde.org/show_bug.cgi?id=469733

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #1 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/network/neochat/-/merge_requests/1016

-- 
You are receiving this mail because:
You are watching all bug changes.