[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 --- Comment #11 from Austin Huang --- Yes; see attachment 162962, comment 1. -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 James Graham changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #10 from James Graham --- (In reply to Austin Huang from comment #8) > But I also mentioned that putting some unicode characters also affect the > height of the last author field in room previews. Element seems to just cut > off the extra height for this. I don’t know if it’s my issue (sorry I’m new > to Linux lol) of not installing a font, but fixing the height of the field > could be considered. Do you have any examples of the other unicode characters as we just need to sanitize them as well? -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 James Graham changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/netw ||ork/neochat/-/commit/61ad89 ||27325c8c994145c8611e7c26a8c ||4207f95 Status|ASSIGNED|RESOLVED --- Comment #9 from James Graham --- Git commit 61ad8927325c8c994145c8611e7c26a8c4207f95 by James Graham. Committed on 12/11/2023 at 19:46. Pushed by nvrwhere into branch 'master'. Handle multiple line names Add function to get the display name for an author on a single line as nothing stops there being linebreaks. M +29 -0autotests/data/test-eventhandler-sync.json M +19 -0autotests/eventhandlertest.cpp M +22 -0src/eventhandler.cpp M +11 -0src/eventhandler.h M +1-1src/neochatroom.cpp https://invent.kde.org/network/neochat/-/commit/61ad8927325c8c994145c8611e7c26a8c4207f95 -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 --- Comment #8 from Austin Huang --- But I also mentioned that putting some unicode characters also affect the height of the last author field in room previews. Element seems to just cut off the extra height for this. I don’t know if it’s my issue (sorry I’m new to Linux lol) of not installing a font, but fixing the height of the field could be considered. -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/1438 -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 James Graham changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Ever confirmed|0 |1 Resolution|WAITINGFORINFO |--- --- Comment #6 from James Graham --- (In reply to Austin Huang from comment #5) > It’s a user display name, not a room topic/name. Oh then that makes sense we don't sanitise those. But it looks like we need to and yes that would cause the issue seen. -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 --- Comment #5 from Austin Huang --- It’s a user display name, not a room topic/name. -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 James Graham changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO CC||james.h.graham@protonmail.c ||om --- Comment #4 from James Graham --- OK so this is super weird I put the string you copied in as a test and as expected the newlines are successfully stripped from the topic so I have no idea why this is happening. Since you seem to know how to get to the underlying event data are you able to copy me the entire JSON for the m.room.name and m.room.topic events for this room? -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 Austin Huang changed: What|Removed |Added Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO |--- -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 --- Comment #3 from Austin Huang --- Extracted from membership state events: "Access forbidden!\n\nYou don't have permission to access the requested directory. There is either no index document or the directory is read-protected.\n\nIf you think this is a server error, please contact the webmaster.\nError 403\nlocalhost\nApache” So it’s literally \n > On Nov 11, 2023, at 18:55, Tobias Fella wrote: > > https://bugs.kde.org/show_bug.cgi?id=476731 > > Tobias Fella changed: > > What|Removed |Added > > Status|REPORTED|NEEDSINFO > Resolution|--- |WAITINGFORINFO > > --- Comment #2 from Tobias Fella --- > do you know which character exactly is used as a linebreak here? for the usual > candidates, this is already filtered out, so it's probably something more > exotic, maybe unicode > > -- > You are receiving this mail because: > You reported the bug. -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 Tobias Fella changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #2 from Tobias Fella --- do you know which character exactly is used as a linebreak here? for the usual candidates, this is already filtered out, so it's probably something more exotic, maybe unicode -- You are receiving this mail because: You are watching all bug changes.
[NeoChat] [Bug 476731] Room preview: username height affects room avatar height, breaking layout
https://bugs.kde.org/show_bug.cgi?id=476731 --- Comment #1 from Austin Huang --- Created attachment 162962 --> https://bugs.kde.org/attachment.cgi?id=162962&action=edit The usual scenario where one has emojis in display name -- You are receiving this mail because: You are watching all bug changes.
