[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa 
https://bugs.kde.org/show_bug.cgi?id=380452

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/oxy
   ||gen/cbc5fdbd4654118c6ec3777
   ||6b060420e520c216b

--- Comment #4 from Hugo Pereira Da Costa  ---
Git commit 8a4e31bc99ed5ada95f2ebf1eb8151c52a1d5420 by Hugo Pereira Da Costa.
Committed on 02/06/2017 at 08:08.
Pushed by hpereiradacosta into branch 'master'.

Q_DECL_OVERRIDE -> override
Rationale is that oxygen decoration depends on libkdecoration, which uses
override directly already.

M  +3-3kdecoration/config/oxygenanimationconfigwidget.h
M  +1-1kdecoration/config/oxygendetectwidget.h
M  +4-4kdecoration/config/oxygenexceptionmodel.h
M  +1-1kdecoration/config/oxygenitemmodel.h
M  +1-1kdecoration/oxygenbutton.h
M  +1-1kdecoration/oxygendecohelper.h

https://commits.kde.org/oxygen/8a4e31bc99ed5ada95f2ebf1eb8151c52a1d5420

--- Comment #5 from Hugo Pereira Da Costa  ---
Git commit cbc5fdbd4654118c6ec37776b060420e520c216b by Hugo Pereira Da Costa.
Committed on 02/06/2017 at 08:12.
Pushed by hpereiradacosta into branch 'master'.

Partially revert "Use Q_DECL_OVERRIDE"

The style code can be built with Qt4/kdelibs4 as well, and there is no
Q_DECL_OVERRIDE in that case.

This partially reverts commit 1bf982f43470c9441287f3fd6a8a3dee834e1483

M  +2-2kstyle/animations/oxygenbusyindicatorengine.h
M  +1-1kstyle/animations/oxygendockseparatordata.h
M  +3-3kstyle/animations/oxygendockseparatorengine.h
M  +1-1kstyle/animations/oxygenenabledata.h
M  +1-1kstyle/animations/oxygengenericdata.h
M  +2-2kstyle/animations/oxygenheaderviewdata.h
M  +3-3kstyle/animations/oxygenheaderviewengine.h
M  +1-1kstyle/animations/oxygenmdiwindowdata.h
M  +3-3kstyle/animations/oxygenmdiwindowengine.h
M  +5-5kstyle/animations/oxygenmenubardata.h
M  +21   -21   kstyle/animations/oxygenmenubarengine.h
M  +7-7kstyle/animations/oxygenmenudata.h
M  +21   -21   kstyle/animations/oxygenmenuengine.h
M  +1-1kstyle/animations/oxygenprogressbardata.h
M  +3-3kstyle/animations/oxygenprogressbarengine.h
M  +2-2kstyle/animations/oxygenscrollbardata.h
M  +3-3kstyle/animations/oxygenscrollbarengine.h
M  +1-1kstyle/animations/oxygenspinboxdata.h
M  +3-3kstyle/animations/oxygenspinboxengine.h
M  +3-3kstyle/animations/oxygensplitterengine.h
M  +1-1kstyle/animations/oxygentabbardata.h
M  +3-3kstyle/animations/oxygentabbarengine.h
M  +3-3kstyle/animations/oxygentoolbardata.h
M  +4-4kstyle/animations/oxygentoolbarengine.h
M  +3-3kstyle/animations/oxygentoolboxengine.h
M  +3-3kstyle/animations/oxygenwidgetstateengine.h
M  +3-3kstyle/config/oxygenanimationconfigwidget.h
M  +2-2kstyle/config/oxygenfollowmouseanimationconfigitem.h
M  +1-1kstyle/config/oxygenstyleconfig.h
M  +1-1kstyle/debug/oxygenwidgetexplorer.h
M  +2-2kstyle/demo/oxygendemodialog.h
M  +1-1kstyle/demo/oxygensimulator.h
M  +1-1kstyle/oxygenaddeventfilter.h
M  +2-2kstyle/oxygenblurhelper.h
M  +8-8kstyle/oxygenframeshadow.h
M  +2-2kstyle/oxygenmdiwindowshadow.h
M  +1-1kstyle/oxygenmnemonics.h
M  +1-1kstyle/oxygenshadowhelper.h
M  +2-2kstyle/oxygensplitterproxy.h
M  +3-3kstyle/oxygenstyle.cpp
M  +14   -14   kstyle/oxygenstyle.h
M  +4-4kstyle/oxygenstylehelper.h
M  +1-1kstyle/oxygenstyleplugin.h
M  +1-1kstyle/oxygenwindowmanager.cpp
M  +2-2kstyle/oxygenwindowmanager.h
M  +4-4kstyle/transitions/oxygencomboboxdata.h
M  +3-3kstyle/transitions/oxygencomboboxengine.h
M  +4-4kstyle/transitions/oxygenlabeldata.h
M  +3-3kstyle/transitions/oxygenlabelengine.h
M  +4-4kstyle/transitions/oxygenlineeditdata.h
M  +3-3kstyle/transitions/oxygenlineeditengine.h
M  +2-2kstyle/transitions/oxygenstackedwidgetdata.h
M  +3-3kstyle/transitions/oxygenstackedwidgetengine.h
M  +2-2kstyle/transitions/oxygentransitionwidget.h
M  +2-2liboxygen/oxygengenericanimationconfigitem.h
M  +26   -26   liboxygen/oxygenitemmodel.h
M  +4-4liboxygen/oxygenlistmodel.h

https://commits.kde.org/oxygen/cbc5fdbd4654118c6ec37776b060420e520c216b

-- 
You are receiving this mail because:
You are watching all bug changes.

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa 
https://bugs.kde.org/show_bug.cgi?id=380452

Hugo Pereira Da Costa  changed:

   What|Removed |Added

   Assignee|mon...@kde.org  |hugo.pereira.da.costa@gmail
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa 
https://bugs.kde.org/show_bug.cgi?id=380452

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/oxy
   ||gen/cbc5fdbd4654118c6ec3777
   ||6b060420e520c216b

--- Comment #4 from Hugo Pereira Da Costa  ---
Git commit 8a4e31bc99ed5ada95f2ebf1eb8151c52a1d5420 by Hugo Pereira Da Costa.
Committed on 02/06/2017 at 08:08.
Pushed by hpereiradacosta into branch 'master'.

Q_DECL_OVERRIDE -> override
Rationale is that oxygen decoration depends on libkdecoration, which uses
override directly already.

M  +3-3kdecoration/config/oxygenanimationconfigwidget.h
M  +1-1kdecoration/config/oxygendetectwidget.h
M  +4-4kdecoration/config/oxygenexceptionmodel.h
M  +1-1kdecoration/config/oxygenitemmodel.h
M  +1-1kdecoration/oxygenbutton.h
M  +1-1kdecoration/oxygendecohelper.h

https://commits.kde.org/oxygen/8a4e31bc99ed5ada95f2ebf1eb8151c52a1d5420

--- Comment #5 from Hugo Pereira Da Costa  ---
Git commit cbc5fdbd4654118c6ec37776b060420e520c216b by Hugo Pereira Da Costa.
Committed on 02/06/2017 at 08:12.
Pushed by hpereiradacosta into branch 'master'.

Partially revert "Use Q_DECL_OVERRIDE"

The style code can be built with Qt4/kdelibs4 as well, and there is no
Q_DECL_OVERRIDE in that case.

This partially reverts commit 1bf982f43470c9441287f3fd6a8a3dee834e1483

M  +2-2kstyle/animations/oxygenbusyindicatorengine.h
M  +1-1kstyle/animations/oxygendockseparatordata.h
M  +3-3kstyle/animations/oxygendockseparatorengine.h
M  +1-1kstyle/animations/oxygenenabledata.h
M  +1-1kstyle/animations/oxygengenericdata.h
M  +2-2kstyle/animations/oxygenheaderviewdata.h
M  +3-3kstyle/animations/oxygenheaderviewengine.h
M  +1-1kstyle/animations/oxygenmdiwindowdata.h
M  +3-3kstyle/animations/oxygenmdiwindowengine.h
M  +5-5kstyle/animations/oxygenmenubardata.h
M  +21   -21   kstyle/animations/oxygenmenubarengine.h
M  +7-7kstyle/animations/oxygenmenudata.h
M  +21   -21   kstyle/animations/oxygenmenuengine.h
M  +1-1kstyle/animations/oxygenprogressbardata.h
M  +3-3kstyle/animations/oxygenprogressbarengine.h
M  +2-2kstyle/animations/oxygenscrollbardata.h
M  +3-3kstyle/animations/oxygenscrollbarengine.h
M  +1-1kstyle/animations/oxygenspinboxdata.h
M  +3-3kstyle/animations/oxygenspinboxengine.h
M  +3-3kstyle/animations/oxygensplitterengine.h
M  +1-1kstyle/animations/oxygentabbardata.h
M  +3-3kstyle/animations/oxygentabbarengine.h
M  +3-3kstyle/animations/oxygentoolbardata.h
M  +4-4kstyle/animations/oxygentoolbarengine.h
M  +3-3kstyle/animations/oxygentoolboxengine.h
M  +3-3kstyle/animations/oxygenwidgetstateengine.h
M  +3-3kstyle/config/oxygenanimationconfigwidget.h
M  +2-2kstyle/config/oxygenfollowmouseanimationconfigitem.h
M  +1-1kstyle/config/oxygenstyleconfig.h
M  +1-1kstyle/debug/oxygenwidgetexplorer.h
M  +2-2kstyle/demo/oxygendemodialog.h
M  +1-1kstyle/demo/oxygensimulator.h
M  +1-1kstyle/oxygenaddeventfilter.h
M  +2-2kstyle/oxygenblurhelper.h
M  +8-8kstyle/oxygenframeshadow.h
M  +2-2kstyle/oxygenmdiwindowshadow.h
M  +1-1kstyle/oxygenmnemonics.h
M  +1-1kstyle/oxygenshadowhelper.h
M  +2-2kstyle/oxygensplitterproxy.h
M  +3-3kstyle/oxygenstyle.cpp
M  +14   -14   kstyle/oxygenstyle.h
M  +4-4kstyle/oxygenstylehelper.h
M  +1-1kstyle/oxygenstyleplugin.h
M  +1-1kstyle/oxygenwindowmanager.cpp
M  +2-2kstyle/oxygenwindowmanager.h
M  +4-4kstyle/transitions/oxygencomboboxdata.h
M  +3-3kstyle/transitions/oxygencomboboxengine.h
M  +4-4kstyle/transitions/oxygenlabeldata.h
M  +3-3kstyle/transitions/oxygenlabelengine.h
M  +4-4kstyle/transitions/oxygenlineeditdata.h
M  +3-3kstyle/transitions/oxygenlineeditengine.h
M  +2-2kstyle/transitions/oxygenstackedwidgetdata.h
M  +3-3kstyle/transitions/oxygenstackedwidgetengine.h
M  +2-2kstyle/transitions/oxygentransitionwidget.h
M  +2-2liboxygen/oxygengenericanimationconfigitem.h
M  +26   -26   liboxygen/oxygenitemmodel.h
M  +4-4liboxygen/oxygenlistmodel.h

https://commits.kde.org/oxygen/cbc5fdbd4654118c6ec37776b060420e520c216b

-- 
You are receiving this mail because:
You are watching all bug changes.

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa 
https://bugs.kde.org/show_bug.cgi?id=380452

--- Comment #3 from Hugo Pereira Da Costa  ---
Also, I remember a discussion on kcd about how using Q_DECL_OVERRIDE was a
pita, and that one should simply use "override". Just checked, that's what kwin
and kdecoration does. 

Since at least the decoration part of breeze and oxygen rely on kdecoration,
(and thus have the same compiler requirements), I would change Q_DECL_OVERRIDE
into override there. 
This also would have prevented the crash (override is defined disregarding the
Qt version).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa 
https://bugs.kde.org/show_bug.cgi?id=380452

--- Comment #2 from Hugo Pereira Da Costa  ---
Note that a proper code review would have prevent this
(idem in breeze).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Oxygen] [Bug 380452] latest commit in master (Use Q_DECL_OVERRIDE) causes failed builds

2017-06-02 Thread Hugo Pereira Da Costa 
https://bugs.kde.org/show_bug.cgi?id=380452

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 CC||hugo.pereira.da.costa@gmail
   ||.com
   Assignee|hugo.pereira.da.costa@gmail |mon...@kde.org
   |.com|

--- Comment #1 from Hugo Pereira Da Costa  ---
Yes. I guess it breaks with kde4/qt4 compilation, for which Q_DECL_OVERRIDE
does not exist.
Please revert, Laurent, at least partially, to make sure KDE4 build works

(the option for kde4 build  is to add -DUSE_KDE4=1 at cmake stage)

-- 
You are receiving this mail because:
You are watching all bug changes.