[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

--- Comment #14 from Kai Uwe Broulik  ---
This patch will be part of the upcoming Plasma 5.7.4 release (due 23 August)
and since we also improved KScreen's output detection in the 5.7 cycle to
include your DisplayPort monitor, both issues (suspend when closing the first
time and when switching activities) should be fixed then \o/

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

Kai Uwe Broulik  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/powe
   ||rdevil/48c3dca61d7cb808c904
   ||a3a3659b2cd36fba1866
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.7.4

--- Comment #13 from Kai Uwe Broulik  ---
Git commit 48c3dca61d7cb808c904a3a3659b2cd36fba1866 by Kai Uwe Broulik.
Committed on 10/08/2016 at 07:32.
Pushed by broulik into branch 'Plasma/5.7'.

Don't unconditionally emit buttonPressed on profile load

A button press (technically the "lid closed" event is also a button press)
should
always be some consicious action triggered by the user. By emitting this signal
unconditionally on profile load (ie. whenever changing an activity or
(un)plugging AC)
the session might always lock or suspend when this happens.

If and only if a profile would really like to take some action or set some
state
depending on the lid state on profile load - which none do, the handle button
press action should only react on explicit button presses anyway - it can still
ask the backend for isLidClosed in its onProfileLoad method.
FIXED-IN: 5.7.4

Differential Revision: https://phabricator.kde.org/D2325

M  +0-5daemon/powerdevilcore.cpp

http://commits.kde.org/powerdevil/48c3dca61d7cb808c904a3a3659b2cd36fba1866

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Erik Quaeghebeur via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

--- Comment #12 from Erik Quaeghebeur  ---
(In reply to Kai Uwe Broulik from comment #10)
> Can you try this patch https://phabricator.kde.org/D2325 please?

I tried it (after changing some stuff in the patch to make it apply), and it
works! So, I'd consider this bug fixed once that patch is committed. (Can you
report back about the release version in which it will first appear?
Backported?)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Erik Quaeghebeur via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

--- Comment #11 from Erik Quaeghebeur  ---
(In reply to Kai Uwe Broulik from comment #9)
> Thanks a lot. Can you try if this [1] fixes it for you?
> 
> [1]
> https://quickgit.kde.org/?p=libkscreen.
> git=commit=54ec74901a0fea1601f76278d6e04af4fbd4b74d

(In reply to Kai Uwe Broulik from comment #10)
> Can you try this patch https://phabricator.kde.org/D2325 please?

I can try this (tomorrow, otherwise it will have to wait until late august),
but only if those patches apply against 5.6.5.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

--- Comment #10 from Kai Uwe Broulik  ---
Can you try this patch https://phabricator.kde.org/D2325 please?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

--- Comment #9 from Kai Uwe Broulik  ---
Thanks a lot. Can you try if this [1] fixes it for you? The heuristic was
recently changed to detect outputs that start with DP (DP2 in your case) as
DisplayPort which should fix this problem. This commit should have landed in
Plasma 5.7.0.

[1]
https://quickgit.kde.org/?p=libkscreen.git=commit=54ec74901a0fea1601f76278d6e04af4fbd4b74d

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Erik Quaeghebeur via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

--- Comment #8 from Erik Quaeghebeur  ---
Created attachment 100405
  --> https://bugs.kde.org/attachment.cgi?id=100405=edit
kscreen-console output

DP1 is laptop-DP and DP2 is dock-DP

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

--- Comment #7 from Kai Uwe Broulik  ---
Can you run kscreen-console and attach its output here? It should have eg.
"Type: "Panel (Laptop)"" and some other information we could use to figure out
why (if it does) it detects it as Unknown. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Erik Quaeghebeur via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

--- Comment #6 from Erik Quaeghebeur  ---
(In reply to Kai Uwe Broulik from comment #5)
>
> https://quickgit.kde.org/?p=powerdevil.
> git=blobdiff=1c3a06d9bb1bf1abade1cc02024e4bbccbf12781=7e1d16e4123d1ac2
> 80ad71807f265b0859e347b9=d3162725cfffb79da7bb8f276a31a915e3349dab=daemon
> %2Factions%2Fbundled%2Fhandlebuttonevents.cpp

Maybe it would be helpful for me to check what KScreen thinks output->type() is
for me. Is there a way I could find this out?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

--- Comment #5 from Kai Uwe Broulik  ---
This doesn't change the fact that the handle button events plugin eventually
discards the event when an external monitor is present, at least that's what it
should do, so we have two bugs here:

1. Closing the lid triggering a screen lock although an external monitor is
present which might have been caused by [1]
2. The lid closed signal being emitted unconditionally on profile load if the
lid is currently closed

[1]
https://quickgit.kde.org/?p=powerdevil.git=blobdiff=1c3a06d9bb1bf1abade1cc02024e4bbccbf12781=7e1d16e4123d1ac280ad71807f265b0859e347b9=d3162725cfffb79da7bb8f276a31a915e3349dab=daemon%2Factions%2Fbundled%2Fhandlebuttonevents.cpp

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

Kai Uwe Broulik  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||k...@privat.broulik.de

--- Comment #4 from Kai Uwe Broulik  ---
I think I found the reason. When activities change PowerDevil reloads its
profile (as you might have per-activity settings) and in the profile loader it
has the following code:

// If the lid is closed, retrigger the lid close signal
if (m_backend->isLidClosed()) {
Q_EMIT
m_backend->buttonPressed(PowerDevil::BackendInterface::LidClose);
}

and then it locks the screen, it also doesn't even check whether the lid is
already closed, so it does that everytime you change activities.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Powerdevil] [Bug 366125] screen is locked when changing activities after closing lid while docked

[Erik Quaeghebeur via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366125

Erik Quaeghebeur  changed:

   What|Removed |Added

Version|unspecified |5.6.5
  Component|general |general
Product|kscreenlocker   |Powerdevil

--- Comment #3 from Erik Quaeghebeur  ---
(In reply to Martin Gräßlin from comment #2)
> > The screen should not be locked when closing the lid,
> 
> This is a configuration option in powerdevil

Well, this is when attached to mains, and I don't have “Even when external
monitor is attached” enabled.

> > but it should certainly not be locked when switching activities.
> 
> No idea what's going on there. KScreenlocker doesn't integrate with
> activities AFAIK.

While looking at the power saving config, I noticed there is a tab for
activities configuration. So I assume it may be there, I'll reassign to
powerdevil (if I can't, please do it for me).

-- 
You are receiving this mail because:
You are watching all bug changes.