[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 Iyán Méndez Veiga changed: What|Removed |Added Version|git-stable-Plasma/6.1 |6.1.2 -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #14 from Fushan Wen --- Git commit 14f4cf0158d8565365dae1c5c55c2fac5801ef08 by Fushan Wen. Committed on 12/06/2024 at 03:58. Pushed by fusionfuture into branch 'master'. applets/brightness: test setting keyboard brightness This adds a test to make sure the keyboard brightness slider works as expected. M +6-0appiumtests/applets/CMakeLists.txt A +153 -0appiumtests/applets/brightnesstest.py M +30 -0appiumtests/utils/OrgFreedesktopUPower.py M +4-2applets/brightness/package/contents/ui/BrightnessItem.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/14f4cf0158d8565365dae1c5c55c2fac5801ef08 -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 Nate Graham changed: What|Removed |Added Keywords||regression CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #13 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/powerdevil/-/merge_requests/377 -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #12 from Iyán Méndez Veiga --- On more thing I just discover. If I run `systemctl --user restart plasma-powerdevil.service`, everything works again. So the problem is that after that commit, and after a system reboot, it doesn´t work. The service has to be manually restarted. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 Iyán Méndez Veiga changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |REPORTED -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #11 from Iyán Méndez Veiga --- And a 1 and a 2 in the two other two brightness modes. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #10 from Iyán Méndez Veiga --- (In reply to Fushan Wen from comment #9) > Does `qdbus6 --system org.freedesktop.UPower > /org/freedesktop/UPower/KbdBacklight > org.freedesktop.UPower.KbdBacklight.GetBrightness` return anything? It returns a 0. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 Jakob Petsovits changed: What|Removed |Added CC||jpe...@petsovits.com -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 Fushan Wen changed: What|Removed |Added CC||qydwhotm...@gmail.com --- Comment #9 from Fushan Wen --- Does `qdbus6 --system org.freedesktop.UPower /org/freedesktop/UPower/KbdBacklight org.freedesktop.UPower.KbdBacklight.GetBrightness` return anything? -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4378 -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #6 from Iyán Méndez Veiga --- Hi David, Regarding point one I already added a comment because I couldn't update the original description. Indeed, when it works, the slides is in the "Brightness and Color" applet. I first noticed the issues with the package provided by Arch Linux in the [kde-unstable] repo, which if I do `pacman -Ql powerdevil | grep plugins` lists the following: powerdevil /usr/lib/qt6/plugins/ powerdevil /usr/lib/qt6/plugins/plasma/ powerdevil /usr/lib/qt6/plugins/plasma/kcms/ powerdevil /usr/lib/qt6/plugins/plasma/kcms/systemsettings/ powerdevil /usr/lib/qt6/plugins/plasma/kcms/systemsettings/kcm_powerdevilprofilesconfig.so powerdevil /usr/lib/qt6/plugins/powerdevil/ powerdevil /usr/lib/qt6/plugins/powerdevil/action/ powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_brightnesscontrolaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_dimdisplayaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_dpmsaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_handlebuttoneventsaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_keyboardbrightnesscontrolaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_powerprofileaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_runscriptaction.so powerdevil /usr/lib/qt6/plugins/powerdevil/action/powerdevil_suspendsessionaction.so For the git bisect I used the exact same PKGBUILD just changing the source to use the git repo and forcing the commit given by git bisect. Each build was done in a clean env using the [kde-unstable] repo (with kde-unstable-x86_64-build). And I was checking for the three issues. -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #5 from David Edmundson --- When you did the bisect which one of the 3 things above are you referring to? -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #4 from David Edmundson --- >1. The slider is missing in the power and battery plasmoid Note that this moved to a new brightness applet -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 David Edmundson changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO CC||k...@davidedmundson.co.uk --- Comment #3 from David Edmundson --- Can you ensure there are no stray old files in ./plugins/powerdevil in wherever you install your software -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 Iyán Méndez Veiga changed: What|Removed |Added Platform|Other |Arch Linux Version|unspecified |git-stable-Plasma/6.1 -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #2 from Iyán Méndez Veiga --- I did a git bisect from tags 6.0.4 to 6.0.90 and this is what I found: fe9e90f51728c8ba16aa5597f909018e213191a8 is the first bad commit commit fe9e90f51728c8ba16aa5597f909018e213191a8 (HEAD) Author: Bogdan Onofriichuk Date: Tue Dec 19 12:02:56 2023 +0200 Extract keyboard brightness into separate class. daemon/CMakeLists.txt| 9 + daemon/actions/bundled/dimdisplay.cpp| 5 +++-- daemon/actions/bundled/dpms.cpp | 5 ++--- daemon/actions/bundled/handlebuttonevents.cpp| 8 daemon/actions/bundled/keyboardbrightnesscontrol.cpp | 27 -- daemon/actions/bundled/keyboardbrightnesscontrol.h | 2 +- daemon/backends/upower/CMakeLists.txt| 5 - daemon/backends/upower/powerdevilupowerbackend.cpp | 101 + daemon/backends/upower/powerdevilupowerbackend.h | 13 - daemon/controllers/keyboardbrightnesscontroller.cpp | 149 +++ daemon/controllers/keyboardbrightnesscontroller.h| 51 + daemon/powerdevilaction.cpp | 2 +- daemon/powerdevilaction.h| 2 +- daemon/powerdevilbackendinterface.cpp| 27 -- daemon/powerdevilbackendinterface.h | 20 daemon/powerdevilcore.cpp| 12 daemon/powerdevilcore.h | 6 ++ 17 files changed, 252 insertions(+), 192 deletions(-) create mode 100644 daemon/controllers/keyboardbrightnesscontroller.cpp create mode 100644 daemon/controllers/keyboardbrightnesscontroller.h -- You are receiving this mail because: You are watching all bug changes.
[Powerdevil] [Bug 487743] No keyboard light control and always on by default
https://bugs.kde.org/show_bug.cgi?id=487743 --- Comment #1 from Iyán Méndez Veiga --- There was a typo in my report: I meant the Brightness and Color plasmoid. -- You are receiving this mail because: You are watching all bug changes.
