[Spectacle] [Bug 415826] Implement FileManager1 dbus interface
https://bugs.kde.org/show_bug.cgi?id=415826 --- Comment #4 from David Redondo --- Hi I just stepped through KIO to what happens and it essentially does the same as your patch. It ends up in KRun::runURL which looks similiar to your code. https://cgit.kde.org/kio.git/tree/src/widgets/krun.cpp#n421 Are you sure this happens in Spectacle 19.12.0? The KRun line that your patch touches is only in master, 19.12.0 has complicated logic here that ends up calling KIO::highlightInFileManager -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 415826] Implement FileManager1 dbus interface
https://bugs.kde.org/show_bug.cgi?id=415826 --- Comment #3 from Denis Lisov --- Hi Davide, Thank you for your attempt, but I don't think that's the correct way. Spectacle is not the one at fault here, or we'll have to fix this at every place separately. Shouldn't KRun be the one to know how to open the user default file manager? For example, your patch does not fix Spectacle's own Open Containing Folder button that appears after saving the screenshot - and that one uses KIO::highlightInFileManager, which will immediately cause you to find bug 397953. There are also other cases such using highlightInFileManager such as "Open Containing Folder" in file context menu in the Open dialog of, for example, Kate. Or Firefox opening the folder containing a downloaded file using the FileManager1 DBus interface. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 415826] Implement FileManager1 dbus interface
https://bugs.kde.org/show_bug.cgi?id=415826 Davide Gianforte changed: What|Removed |Added Product|krusader|Spectacle Component|general |General Version|unspecified |19.12.0 CC||k...@david-redondo.de Assignee|krusader-bugs-n...@kde.org |m...@baloneygeek.com --- Comment #2 from Davide Gianforte --- Proposed patch: https://phabricator.kde.org/D26383 -- You are receiving this mail because: You are watching all bug changes.
