[Spectacle] [Bug 422874] Spectacle does not show notifications as expected (two notifications are shown or there is no screenshot preview) when 'Copy image to clipboard' feature is enabled
https://bugs.kde.org/show_bug.cgi?id=422874 --- Comment #20 from Noah Davis --- Git commit 8e44d9d40a3e13b7197732624e7f566e6712c463 by Noah Davis. Committed on 10/04/2023 at 16:14. Pushed by ndavis into branch 'release/23.04'. Use export action flags instead of several functions and signals This allows us to specify export actions and figure out which kinds of actions have been done simultaneously without having separate functions and signals for all the various combinations of save, save as, copy image and copy path. SpectacleCore: Instead of storing which actions to use in boolean member variables, use a function to calculate which automatic export options can be done. This makes it so we don't need to update the variables every time we want to use them. CaptureWindow, SelectionEditor, SpectacleCore: Don't export directly from CaptureWindows. Instead, pass export actions to the SpectacleCore::grabDone() signal via SelectionEditor::acceptSelection(). Necessary for preventing double saves when clicking the Save button in rectangle capture windows. In order to cherry-pick this to 23.04, we'll need to cherry-pick some of the previous code clean-up and bug fix commits on master: - 35f3eefc2125aadd302519bee629fa380e0d1cce - 0bf9cd3433e418ce15337490cf119e0e30f87ee6 - 6711242f8397417ae05eaf76dc5f81622b691473 - 3a9f5351deb887eeac5d751d44fa55e8c31e63d4 - a95993c25059ab8de85f7128ec87b32f6c7df9b4 - ed981b997cfc0d155db29af4bf7f04659903092e - 28f63cee4fb71de2804994b582b084db77b2cfcc - 211127024a500da6f9ccf27c1131682a5558eec0 - 553eb2cf16ad3ccb8f9177cfd0ec533de5f22fdc - 0fda35cb61b8db8cc50e05e28ee33e7516ca7cd2 - 001877540c54c19ba0a08b34182744d285dac3bc - abf044557f36115c8e1ace0ba86a5c020422288f (cherry picked from commit 84a9d9762e168d1f505736895e326f4546db29c8) M +82 -97 src/ExportManager.cpp M +15 -10 src/ExportManager.h M +4-8src/Gui/CaptureWindow.cpp M +2-2src/Gui/ExportMenu.cpp M +5-5src/Gui/SelectionEditor.cpp M +2-1src/Gui/SelectionEditor.h M +5-23 src/Gui/SpectacleWindow.cpp M +4-2src/Main.cpp M +97 -116 src/SpectacleCore.cpp M +5-5src/SpectacleCore.h https://invent.kde.org/graphics/spectacle/commit/8e44d9d40a3e13b7197732624e7f566e6712c463 -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 422874] Spectacle does not show notifications as expected (two notifications are shown or there is no screenshot preview) when 'Copy image to clipboard' feature is enabled
https://bugs.kde.org/show_bug.cgi?id=422874 --- Comment #19 from Noah Davis --- Git commit 84a9d9762e168d1f505736895e326f4546db29c8 by Noah Davis. Committed on 10/04/2023 at 16:02. Pushed by ndavis into branch 'master'. Use export action flags instead of several functions and signals This allows us to specify export actions and figure out which kinds of actions have been done simultaneously without having separate functions and signals for all the various combinations of save, save as, copy image and copy path. SpectacleCore: Instead of storing which actions to use in boolean member variables, use a function to calculate which automatic export options can be done. This makes it so we don't need to update the variables every time we want to use them. CaptureWindow, SelectionEditor, SpectacleCore: Don't export directly from CaptureWindows. Instead, pass export actions to the SpectacleCore::grabDone() signal via SelectionEditor::acceptSelection(). Necessary for preventing double saves when clicking the Save button in rectangle capture windows. In order to cherry-pick this to 23.04, we'll need to cherry-pick some of the previous code clean-up and bug fix commits on master: - 35f3eefc2125aadd302519bee629fa380e0d1cce - 0bf9cd3433e418ce15337490cf119e0e30f87ee6 - 6711242f8397417ae05eaf76dc5f81622b691473 - 3a9f5351deb887eeac5d751d44fa55e8c31e63d4 - a95993c25059ab8de85f7128ec87b32f6c7df9b4 - ed981b997cfc0d155db29af4bf7f04659903092e - 28f63cee4fb71de2804994b582b084db77b2cfcc - 211127024a500da6f9ccf27c1131682a5558eec0 - 553eb2cf16ad3ccb8f9177cfd0ec533de5f22fdc - 0fda35cb61b8db8cc50e05e28ee33e7516ca7cd2 - 001877540c54c19ba0a08b34182744d285dac3bc - abf044557f36115c8e1ace0ba86a5c020422288f M +82 -97 src/ExportManager.cpp M +15 -10 src/ExportManager.h M +4-8src/Gui/CaptureWindow.cpp M +2-2src/Gui/ExportMenu.cpp M +5-5src/Gui/SelectionEditor.cpp M +2-1src/Gui/SelectionEditor.h M +5-23 src/Gui/SpectacleWindow.cpp M +4-2src/Main.cpp M +97 -116 src/SpectacleCore.cpp M +5-5src/SpectacleCore.h https://invent.kde.org/graphics/spectacle/commit/84a9d9762e168d1f505736895e326f4546db29c8 -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 422874] Spectacle does not show notifications as expected (two notifications are shown or there is no screenshot preview) when 'Copy image to clipboard' feature is enabled
https://bugs.kde.org/show_bug.cgi?id=422874 --- Comment #18 from Akseli Lahtinen --- Created attachment 156765 --> https://bugs.kde.org/attachment.cgi?id=156765=edit Two notifications on Fedora KDE 37 -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 422874] Spectacle does not show notifications as expected (two notifications are shown or there is no screenshot preview) when 'Copy image to clipboard' feature is enabled
https://bugs.kde.org/show_bug.cgi?id=422874 Akseli Lahtinen changed: What|Removed |Added CC||akse...@akselmo.dev --- Comment #17 from Akseli Lahtinen --- I get two notifications on Fedora KDE. This began to happen when i set a sound effect for the screenshot notification in spectacles notification settings. Spectacle 22.12.2 Operating System: Fedora Linux 37 KDE Plasma Version: 5.27.1 KDE Frameworks Version: 5.103.0 Qt Version: 5.15.8 Kernel Version: 6.1.13-200.fc37.x86_64 (64-bit) Graphics Platform: Wayland Processors: 12 × AMD Ryzen 5 3600 6-Core Processor Memory: 15,5 GiB of RAM Graphics Processor: AMD Radeon RX 6600 -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 422874] Spectacle does not show notifications as expected (two notifications are shown or there is no screenshot preview) when 'Copy image to clipboard' feature is enabled
https://bugs.kde.org/show_bug.cgi?id=422874 Lê Hoàng Phương changed: What|Removed |Added CC||lehoangphuon...@gmail.com --- Comment #16 from Lê Hoàng Phương --- Currently, the "Copy to Clipboard" notification doesn't allow "Annotate". If "Annotate" feature needs the screenshot to be saved somewhere (my assumption only, I didn't read the code), having Spectacle to also save the screenshot to /tmp should allow "Copy to Clipboard" notification to both show preview, and "Annotate"-able. I currently have to bear the duplicate notifications. I use the "rectangular region capture" shortcut day-to-day in my work. Most of the time I simply need to paste the shortcut to other document, chat screen, etc, for other times I also need annotate the screenshot before pasting it. Since the notification that have "Annotate" only appear with option "Save to default folder", there are now two notifications every time I make a screenshot. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 422874] Spectacle does not show notifications as expected (two notifications are shown or there is no screenshot preview) when 'Copy image to clipboard' feature is enabled
https://bugs.kde.org/show_bug.cgi?id=422874 Bacteria changed: What|Removed |Added CC||dev.bacterios...@aleeas.com --- Comment #15 from Bacteria --- I followed the instructions in comment 14 but I am not able to get the notification. I am not able to get notification with any possible setting. Operating System: Arch Linux KDE Plasma Version: 5.24.90 KDE Frameworks Version: 5.94.0 Qt Version: 5.15.4 Spectacle Version: 22.04.1 Graphics Platform: Wayland -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 422874] Spectacle does not show notifications as expected (two notifications are shown or there is no screenshot preview) when 'Copy image to clipboard' feature is enabled
https://bugs.kde.org/show_bug.cgi?id=422874 Patrick Silva changed: What|Removed |Added Summary|Spectacle doesn’t show |Spectacle does not show |notifications correctly:|notifications as expected |Notification doesn't show |(two notifications are |screenshot preview when |shown or there is no |"Copy image to clipboard" |screenshot preview) when |feature is enabled and |'Copy image to clipboard' |duplicate notifications |feature is enabled |show when this is not | |enabled.| -- You are receiving this mail because: You are watching all bug changes.
