[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2022-12-07 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=437495

Noah Davis  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||23.04
  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/commit/9d4ff
   ||df70e5a29fa9105cbf8c4f7e1dd
   ||ca9e377a

--- Comment #7 from Noah Davis  ---
Git commit 9d4ffdf70e5a29fa9105cbf8c4f7e1ddca9e377a by Noah Davis.
Committed on 07/12/2022 at 11:46.
Pushed by ndavis into branch 'master'.

Port and rework UI for Qt Quick/QML

There are still some parts that use Qt Widgets, such as the settings dialog,
font dialog, color dialog, print dialog and popup menus. The Qt Quick port is
needed for a future patch where screen recording will be added and it also
allows more animations to be used. The UI was redesigned, partly because the
old UI couldn't be ported nicely to QML and partly to improve the appearance of
the UI.

There are 2 window classes for the main UIs. CaptureWindow is used for the
rectangle capture mode and ViewerWindow is used for the other modes and viewing
accepted regions from the rectangle capture mode. Both UIs support adding
annotations.

Fullscreen Capture UI:

The UI is a lot like the old UI, but there are floating toolbars that expose
more functionality.

- Annotations, saving, copying and taking a new snapshot can be done directly.
- Export, Options and Help menus can be accessed directly.
- Info box no longer covers or overlaps with selection handles.
- Antialiasing for selection handles is fixed.
- Each screen now has its own fullscreen window, which fixes some issues on
Wayland and X11.

Image Viewer UI (appears after a screenshot has been taken):

- Main controls are consolidated into a single top toolbar: Save, Save As,
Copy, Export (opens popup menu), Show Annotation Tools, Configure (opens
settings dialog), Help (opens popup menu)
- There is a right sidebar for selecting capture modes and related options that
were in the old UI.
- The whole UI doesn't completely transform when annotation controls are shown
anymore. Instead, a vertical left side toolbar (tools) and a bottom toolbar
(tool options) are added and the right sidebar slides away. Undo and Redo are
added to the top toolbar.
- It should be easier to understand the annotation UI now.
- Annotations done in the Fullscreen Capture UI can still be undone/redone in
the Image Viewer UI.

No screenshot taken UI (appears when configured to start without taking a
screenshot):

- Has buttons for each capture mode on the left
- Has all the other options that were in the Image Viewer UI sidebar and the
old UI on the right
- Has buttons for opening the settings dialog and showing the help menu below
the options.
- The heading can be used to drag the window just to make moving the dialog
around a bit more convenient.

The kImageAnnotator library was replaced by a custom annotation system because
kImageAnnotator only worked with Qt Widgets and can't work in the rectangle
capture mode since it has its own UI.

There is some unused code in this patch that is meant for the upcoming video
recording feature.
Related: bug 407843, bug 425311, bug 425853, bug 427117, bug 429141, bug
431278, bug 451838, bug 456399, bug 458956, bug 460689, bug 462521
FIXED-IN: 23.04

---

| Fullscreen Capture UI |
|---|
|
![Screenshot_20221207_052432](/uploads/0a1a94987c80f831ef8ce65e29258797/Screenshot_20221207_052432.png)
|

| Image Viewer UI |
|-|
|
![Screenshot_20221207_052647](/uploads/05b9e19702c030228c21fb816af08ee4/Screenshot_20221207_052647.png)
|

| No Screenshot UI |
|-|
|
![Screenshot_20221207_053432](/uploads/9d97d6642d050ad84a14bf39f5a914db/Screenshot_20221207_053432.png)
|

| Image Viewer Annotations |
|--|
|
![Screenshot_20221207_052825](/uploads/a8a7ffb4844fa0556e4a979e85dd/Screenshot_20221207_052825.png)
|

| Export Menu |
|-|
|
![Screenshot_20220823_141330](/uploads/3117057d424b66ae84f84648030912a8/Screenshot_20220823_141330.png)
|

| Options Menu |
|--|
|
![Screenshot_20220823_141058](/uploads/05f0589b01ae61a90540d1dd6ba154ae/Screenshot_20220823_141058.png)
|

| Help Menu |
|---|
|
![Screenshot_20220823_141353](/uploads/2f8173dd31cc0ef5c6c598ae6f5bb088/Screenshot_20220823_141353.png)
|

| Annotation Options (sections are hidden based on what the active tool can
use) |
||
|
![Screenshot_20221207_053046](/uploads/ded7a02e8f68d659377abb5d9dc43b11/Screenshot_20221207_053046.png)![Screenshot_20221207_053136](/uploads/c11b21ce6762a7d287ae3e421762bb10/Screenshot_20221207_053136.png)
|

M  +5

[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2022-10-29 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=437495

--- Comment #6 from Patrick Silva  ---
*** Bug 452174 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2022-06-21 Thread postix
https://bugs.kde.org/show_bug.cgi?id=437495

postix  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

--- Comment #5 from postix  ---
*** Bug 455742 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2022-05-04 Thread Onuralp SEZER
https://bugs.kde.org/show_bug.cgi?id=437495

Onuralp SEZER  changed:

   What|Removed |Added

 CC||thunderbirdtr@fedoraproject
   ||.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2021-10-30 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=437495

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2021-09-28 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=437495

Vlad Zahorodnii  changed:

   What|Removed |Added

   Keywords||wayland

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2021-09-28 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=437495

--- Comment #4 from Vlad Zahorodnii  ---
(In reply to Nate Graham from comment #3)
> Can confirm.
> 
> Not sure if this is a KWin issue or a Spectacle issue.

The overlay window is placed in the layer where normal windows are. This issue
can be fixed by porting spectacle to the layer-shell protocol.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2021-05-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437495

Nate Graham  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1
 CC||vlad.zahorod...@kde.org
 Status|NEEDSINFO   |CONFIRMED

--- Comment #3 from Nate Graham  ---
Can confirm.

Not sure if this is a KWin issue or a Spectacle issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2021-05-26 Thread Alex
https://bugs.kde.org/show_bug.cgi?id=437495

--- Comment #2 from Alex  ---
Yes, this is on wayland. Forgot to mention that, sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 437495] Rectangle selection overlay appears below windows that are set to "keep above others"

2021-05-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437495

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||n...@kde.org

--- Comment #1 from Nate Graham  ---
Is this on Wayland? Cannot reproduce on X11.

-- 
You are receiving this mail because:
You are watching all bug changes.