[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-26 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=478155

--- Comment #9 from Noah Davis  ---
It seems that Qt Designer (the Qt Widgets one) also has this problem with modal
font dialogs.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-11 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=478155

--- Comment #8 from Noah Davis  ---
I get the bug with QFontDialog under the following conditions:

```
// Calling QDialog::open().
// This sets the modality to Qt::WindowModal via QWidget::setWindowModality()
and then calls QWidget::show().
// QWidget::setWindowModality() sets the specific type of modality and also
sets the Qt::WA_ShowModal attribute.
// When Qt::WA_ShowModal is set, the modality is set to Qt::ApplicationModal if
it is currently set to Qt::NonModal
// and otherwise keeps the current modality.
// If the widget has the attribute Qt::WA_WState_Created, the current modality
is applied to the widget's windowHandle.
dialog->open();

// Setting Qt::ApplicationModal and calling QWidget::show().
dialog->setWindowModality(Qt::ApplicationModal);
dialog->show();

// Setting the dialog as modal via QDialog::setModal() and calling
QWidget::show().
// This has the same behavior as setting the modality to Qt::ApplicationModal.
dialog->setModal(true);
dialog->show();
```

If I only call QWidget::show(), the QFontDialog can be used, but the dialog is
non-modal.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-10 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=478155

--- Comment #7 from Nicolas Fella  ---
it has something to do with the modality of the dialog

in
https://invent.kde.org/plasma/plasma-integration/-/blob/master/qt6/src/platformtheme/kdeplatformfontdialoghelper.cpp?ref_type=heads#L43
we get Qt::WindowModal and set that on the QFontDialog. When I change that to
ApplicationModal it works.

Or if I in
https://invent.kde.org/graphics/spectacle/-/blob/master/src/Gui/SpectacleWindow.cpp#L345
replace open() with show() it also works.

I don't fully understand it though

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-10 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=478155

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #6 from Nicolas Fella  ---
https://invent.kde.org/plasma/plasma-integration/-/merge_requests/115 broke it

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-08 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=478155

--- Comment #5 from Noah Davis  ---
Also, this is a recent change even if you were already using the Qt6-only
version of spectacle.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-08 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=478155

--- Comment #4 from Noah Davis  ---
(In reply to Nate Graham from comment #3)
> The way font strings are serialized in config files changes between Qt5 and
> Qt6, which may be related.

The bug still happens even if there are no font settings in the config file.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=478155

--- Comment #3 from Nate Graham  ---
The way font strings are serialized in config files changes between Qt5 and
Qt6, which may be related.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=478155

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-06 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=478155

--- Comment #2 from Noah Davis  ---
Apparently the dialog is usable while Spectacle is being inspected with
GammaRay, but not otherwise. The code involving the font dialog has not been
touched in a while, so I'm inclined to believe that the bug comes from
somewhere outside of Spectacle, but I'm not sure where.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-06 Thread Eric Armbruster
https://bugs.kde.org/show_bug.cgi?id=478155

Eric Armbruster  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||er...@armbruster-online.de

--- Comment #1 from Eric Armbruster  ---
Can reproduce.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 478155] You cannot change the font in the annotation tools

2023-12-06 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=478155

Bug Janitor Service  changed:

   What|Removed |Added

   Keywords||qt6

-- 
You are receiving this mail because:
You are watching all bug changes.