[Spectacle] [Bug 481435] Annotations made while in Rectangular Region overlay end up in the wrong place

2024-04-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=481435

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||24.05

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 481435] Annotations made while in Rectangular Region overlay end up in the wrong place

2024-04-05 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=481435

Noah Davis  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/spectacle/-/commit/f30
   ||9049a7dab26cfd673bb399480d3
   ||ed5825ec9c
 Status|CONFIRMED   |RESOLVED

--- Comment #8 from Noah Davis  ---
Git commit f309049a7dab26cfd673bb399480d3ed5825ec9c by Noah Davis.
Committed on 05/04/2024 at 18:55.
Pushed by ndavis into branch 'master'.

Add backend logic for undoable cropping

Also separate mousePath (interactive path) and visualRect from Traits::Geometry
into Traits::Interactive and Traits::Visual. Needed to be able to have geometry
without visibility or interactivity in a history item.

M  +99   -40   src/Gui/Annotations/AnnotationDocument.cpp
M  +7-3src/Gui/Annotations/AnnotationDocument.h
M  +10   -5src/Gui/Annotations/AnnotationViewport.cpp
M  +6-5src/Gui/Annotations/EffectUtils.cpp
M  +143  -29   src/Gui/Annotations/Traits.cpp
M  +41   -13   src/Gui/Annotations/Traits.h

https://invent.kde.org/graphics/spectacle/-/commit/f309049a7dab26cfd673bb399480d3ed5825ec9c

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 481435] Annotations made while in Rectangular Region overlay end up in the wrong place

2024-02-17 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=481435

--- Comment #7 from Noah Davis  ---
(In reply to Nate Graham from comment #6)
> Greaṫ! But now I have to wonder: in what universe do you do a Rectangular
> Region screenshot and not drag a box around something? :D Isn't that the use
> case of Rectangular Region instead of Full Screen?

You can also capture all screens just by pressing enter with no selection.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 481435] Annotations made while in Rectangular Region overlay end up in the wrong place

2024-02-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=481435

--- Comment #6 from Nate Graham  ---
Greaṫ! But now I have to wonder: in what universe do you do a Rectangular
Region screenshot and not drag a box around something? :D Isn't that the use
case of Rectangular Region instead of Full Screen?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 481435] Annotations made while in Rectangular Region overlay end up in the wrong place

2024-02-16 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=481435

Noah Davis  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #5 from Noah Davis  ---
Ok, so I did not test actually cropping the rectangle screenshot. The problem
occurs when I actually set a rectangular area to capture. Curiously, the
problem only applies to the last annotation. Previous annotations are fine and
the problem goes away if I undo and redo the last annotation.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 481435] Annotations made while in Rectangular Region overlay end up in the wrong place

2024-02-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=481435

--- Comment #4 from Nate Graham  ---
I just tried it with my dual-screen setup (4k@225% on the left, 1080p@110% on
the right) and got the same result. Here's a video that shows it happening, in
case my description was not clear enough. I couldn't attach it as I was unable
to compress it enough to  get it under the 4 MB size limit on Bugzilla.

https://imgur.com/zr2utzN

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 481435] Annotations made while in Rectangular Region overlay end up in the wrong place

2024-02-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=481435

Nate Graham  changed:

   What|Removed |Added

Version|23.04.1 |git-master

--- Comment #3 from Nate Graham  ---
That is a mistake, it's current git master.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 481435] Annotations made while in Rectangular Region overlay end up in the wrong place

2024-02-16 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=481435

--- Comment #2 from Noah Davis  ---
When I tried reproducing this, I tried a few different screen configurations,
always with two screens horizontally next to each other.

1. 1x, 2x
2. 1x, 1.75x
3. 1x, 2.25x
4. 1.25x, 2x.

I tried drawing rectangles on both screens and they were always in the correct
locations.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Spectacle] [Bug 481435] Annotations made while in Rectangular Region overlay end up in the wrong place

2024-02-16 Thread Noah Davis
https://bugs.kde.org/show_bug.cgi?id=481435

--- Comment #1 from Noah Davis  ---
Unfortunately, I cannot reproduce this. I see you put the version as 23.04.1,
but that's a mistake, right?

-- 
You are receiving this mail because:
You are watching all bug changes.