[Tokodon] [Bug 463892] Enhancement request: scale, rather than crop images in timeline view
https://bugs.kde.org/show_bug.cgi?id=463892 Joshua Goins changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/netw ||ork/tokodon/commit/7fcd1f2e ||c2d160ab54e65b609277eebf1d6 ||c797b --- Comment #4 from Joshua Goins --- Git commit 7fcd1f2ec2d160ab54e65b609277eebf1d6c797b by Joshua Goins. Committed on 14/01/2023 at 16:51. Pushed by redstrate into branch 'master'. Improve layouts of media attachments This improves the layouts of attachments in several ways: * Multiple attachments are always 16:9 * Single attachments can either be cropped to 16:9 or full height * Removes the extra margins which should've been on the attachment grid itself, not on individual items Signed-off-by: Joshua Goins M +4-0src/config.kcfg M +26 -6src/content/ui/PostDelegate.qml M +13 -1src/content/ui/Settings/GeneralCard.qml M +1-0src/content/ui/TimelinePage.qml https://invent.kde.org/network/tokodon/commit/7fcd1f2ec2d160ab54e65b609277eebf1d6c797b -- You are receiving this mail because: You are watching all bug changes.
[Tokodon] [Bug 463892] Enhancement request: scale, rather than crop images in timeline view
https://bugs.kde.org/show_bug.cgi?id=463892 --- Comment #3 from Joshua Goins --- (In reply to Zak from comment #2) > Tokodon's behavior does not match Mastodon's; Mastodon crops to 16:9 by > default while Tokodon crops to a specific height, but the full width of the > window, which results in a tiny sliver of the image being shown when the > window is set large. Tokodon is also not honoring my preference to never > crop images set in Mastodon. I don't like either cropping behavior, but if > the thinking is to match what Mastodon does, Tokodon currently doesn't. I'll fix that as well, I didn't realize Tokodon didn't properly crop stuff to 16:9 (I've only been using Tokodon in small windows, oops) > Simply showing the image scaled to the width of the screen when the crop > preference is eventually supported isn't ideal either, as that will lead to > images taller than the viewport. Scaling based on the larger of window width > and a percentage of hegiht would allow viewing the whole image in-line. I think that's what I'll eventually go with, because scaling up images on my 4K UHD desktop would look crazy too :v -- You are receiving this mail because: You are watching all bug changes.
[Tokodon] [Bug 463892] Enhancement request: scale, rather than crop images in timeline view
https://bugs.kde.org/show_bug.cgi?id=463892 --- Comment #2 from Zak --- Tokodon's behavior does not match Mastodon's; Mastodon crops to 16:9 by default while Tokodon crops to a specific height, but the full width of the window, which results in a tiny sliver of the image being shown when the window is set large. Tokodon is also not honoring my preference to never crop images set in Mastodon. I don't like either cropping behavior, but if the thinking is to match what Mastodon does, Tokodon currently doesn't. Simply showing the image scaled to the width of the screen when the crop preference is eventually supported isn't ideal either, as that will lead to images taller than the viewport. Scaling based on the larger of window width and a percentage of hegiht would allow viewing the whole image in-line. -- You are receiving this mail because: You are watching all bug changes.
[Tokodon] [Bug 463892] Enhancement request: scale, rather than crop images in timeline view
https://bugs.kde.org/show_bug.cgi?id=463892 Joshua Goins changed: What|Removed |Added CC||j...@redstrate.com Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Joshua Goins --- This is intentional, as it matches Mastodon behavior whenever it is requested to crop images (this is controlled via user preference) - however I don't think focus point is taken into account. You're right that there should be an option to not crop it. I'm actually implementing this feature, but I don't have a MR up yet - the related issue is https://invent.kde.org/network/tokodon/-/issues/50 though -- You are receiving this mail because: You are watching all bug changes.
