[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 Pedro de Carvalho Gomes changed: What|Removed |Added Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult |imedia/amarok/commit/80b2b9 |imedia/amarok/commit/df34fd |aa9b8267c184dacb38cd38c5d4e |789a8cd14bea5482c88c85216b2 |a03e336 |ef791c9 --- Comment #16 from Pedro de Carvalho Gomes --- Git commit df34fd789a8cd14bea5482c88c85216b2ef791c9 by Pedro Gomes. Committed on 30/07/2020 at 20:42. Pushed by pgomes into branch 'master'. Summary: Fix crash when closing dialog to edit filter M +6-6src/dialogs/EditFilterDialog.cpp M +1-1src/dialogs/EditFilterDialog.h M +4-5src/widgets/Token.cpp M +1-0src/widgets/Token.h M +2-2src/widgets/TokenDropTarget.cpp https://invent.kde.org/multimedia/amarok/commit/df34fd789a8cd14bea5482c88c85216b2ef791c9 -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 Pedro de Carvalho Gomes changed: What|Removed |Added Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult |imedia/amarok/commit/4de6bb |imedia/amarok/commit/80b2b9 |675a3e4dbffa46dae87d08549b4 |aa9b8267c184dacb38cd38c5d4e |f728a33 |a03e336 --- Comment #15 from Pedro de Carvalho Gomes --- Git commit 80b2b9aa9b8267c184dacb38cd38c5d4ea03e336 by Pedro de Carvalho Gomes. Committed on 30/07/2020 at 20:36. Pushed by pgomes into branch 'bug_421456-crash_when_exiting_edit_filter_dialog'. Summary: Fix crash when closing dialog to edit filter M +6-6src/dialogs/EditFilterDialog.cpp M +1-1src/dialogs/EditFilterDialog.h M +4-5src/widgets/Token.cpp M +1-0src/widgets/Token.h M +2-2src/widgets/TokenDropTarget.cpp https://invent.kde.org/multimedia/amarok/commit/80b2b9aa9b8267c184dacb38cd38c5d4ea03e336 -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 Pedro de Carvalho Gomes changed: What|Removed |Added Latest Commit||https://invent.kde.org/mult ||imedia/amarok/commit/4de6bb ||675a3e4dbffa46dae87d08549b4 ||f728a33 --- Comment #14 from Pedro de Carvalho Gomes --- Git commit 4de6bb675a3e4dbffa46dae87d08549b4f728a33 by Pedro de Carvalho Gomes. Committed on 27/06/2020 at 12:03. Pushed by pgomes into branch 'bug_421456-crash_when_exiting_edit_filter_dialog'. Summary: Fix crash when closing dialog to edit filter M +6-6src/dialogs/EditFilterDialog.cpp M +1-1src/dialogs/EditFilterDialog.h M +4-5src/widgets/Token.cpp M +1-0src/widgets/Token.h M +2-2src/widgets/TokenDropTarget.cpp https://invent.kde.org/multimedia/amarok/commit/4de6bb675a3e4dbffa46dae87d08549b4f728a33 -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 Pedro de Carvalho Gomes changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #13 from Pedro de Carvalho Gomes --- The problem was at the package and the source it used to be built. Basically I made some confusion between branches. I have recreated packages for 19.10 and 20.04, and all should be back to track -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 robert marshall changed: What|Removed |Added Status|RESOLVED|REPORTED Resolution|FIXED |--- Ever confirmed|1 |0 --- Comment #12 from robert marshall --- I'm marking this as reported - I've just updated amarok to the latest version from Pedro's ppa and this bug is back! If you'd prefer a separate report feel free to close and I'll make a separate report. -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 --- Comment #11 from Pedro de Carvalho Gomes --- (In reply to robert marshall from comment #9) > This looks fixed to me - though maybe there's more of this - looking at > https://bugs.kde.org/show_bug.cgi?id=422132 which seems similar - a crash > when trying to return to displaying Local Collection. But this instance can > be closed - thanks! Thanks Robert for pointing out those. I will take a look at the other bug -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 Pedro de Carvalho Gomes changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #10 from Pedro de Carvalho Gomes --- The reported confirmed that the bug was fixed. -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 --- Comment #9 from robert marshall --- This looks fixed to me - though maybe there's more of this - looking at https://bugs.kde.org/show_bug.cgi?id=422132 which seems similar - a crash when trying to return to displaying Local Collection. But this instance can be closed - thanks! -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 --- Comment #8 from Pedro de Carvalho Gomes --- I fixed the bug. It was caused by a bad habit that I see all across the code: widgets that capture QObject::destroyed signal from its descendants. This is bad because such are signaled either when the code deletes the descendant, or when it was deleted in the deletion chain of the ascendant widget when it was deleted. This leads to slots of "half-dead" widgets being called, which in turn accesss a deleted member, thus leading to the crash I have already published a new version with the fix in my launchpad. I have also created the Merge request to the main repository, but I am waiting revision. -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 --- Comment #7 from Pedro de Carvalho Gomes --- I confirm the crash. As stated above, it required at least one item at the filter. -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]
https://bugs.kde.org/show_bug.cgi?id=421456 Myriam Schweingruber changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED Summary|Crash when exiting Edit |Crash when exiting Edit |filter dialog |filter dialog ||[TokenDropTarget::tokensAtR ||ow ] -- You are receiving this mail because: You are watching all bug changes.
