[amarok] [Bug 485415] Login to last.fm doesn't work if amarok is run with --debug

2024-04-12 Thread Tuomas Nurmi 
https://bugs.kde.org/show_bug.cgi?id=485415

Tuomas Nurmi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/-/commit/4533
   ||d9c8f60457a0e4f70a6c0d3bd97
   ||ca689514b
 Resolution|--- |FIXED

--- Comment #3 from Tuomas Nurmi  ---
Git commit 4533d9c8f60457a0e4f70a6c0d3bd97ca689514b by Tuomas Nurmi.
Committed on 12/04/2024 at 11:45.
Pushed by nurmi into branch 'master'.

Add workaround to enable last.fm debugging.

liblastfm checks QCoreApplication::arguments() for "--debug". That's not
easy to avoid, so add a synonym debug flag "--debug-last-fm" which has
identical
functionality in Amarok, but doesn't trigger the non-functional last.fm debug
mode.

This is not pretty, but it is pretty contained and makes reasonable last.fm
bughunting possible. Should https://github.com/lastfm/liblastfm/pull/37 ever
get merged, this commit can be reverted, but that might not happen anytime soon
as the PR has been pending for 4 years and latest liblastfm release was almost
10 years ago.

M  +2-0src/App.cpp
M  +1-1src/main.cpp

https://invent.kde.org/multimedia/amarok/-/commit/4533d9c8f60457a0e4f70a6c0d3bd97ca689514b

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 485415] Login to last.fm doesn't work if amarok is run with --debug

2024-04-12 Thread robert marshall 
https://bugs.kde.org/show_bug.cgi?id=485415

--- Comment #2 from robert marshall  ---
Yes, I see there's an open PR https://github.com/lastfm/liblastfm/pull/37

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 485415] Login to last.fm doesn't work if amarok is run with --debug

2024-04-12 Thread Tuomas Nurmi 
https://bugs.kde.org/show_bug.cgi?id=485415

Tuomas Nurmi  changed:

   What|Removed |Added

   Assignee|amarok-bugs-d...@kde.org|tuo...@norsumanageri.org
 CC||tuo...@norsumanageri.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Tuomas Nurmi  ---
Ok, found the reason. The normal hostname for last.fm API calls is
ws.audioscrobbler.com, but in liblastfm, src/ws.cpp, lastfm::ws::host():
QStringList const args = QCoreApplication::arguments();
if (args.contains( "--debug"))
return "ws.staging.audioscrobbler.com";

which is apparently not functional (anymore?).

-- 
You are receiving this mail because:
You are watching all bug changes.